Commits · 7b06874ef56522693759e256c687e013bfaeb574 · abdullh.alsoleman / Front-End

08 Sep, 2023 14 commits

Roll Flutter Engine from c38feb382e96 to f09a139101c3 (1 revision) (#134299) · 7b06874e

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/c38feb382e96...f09a139101c3

2023-09-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 33DToYd0jNpWX1jNv... to KvtLknmg3f23uqWVm... (flutter/engine#45573)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 33DToYd0jNpW to KvtLknmg3f23

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b06874e

Roll Flutter Engine from f146d4bf244b to c38feb382e96 (1 revision) (#134293) · 2681e873

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/f146d4bf244b...c38feb382e96

2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from e60556f75b68 to 65ec697f4183 (1 revision) (flutter/engine#45572)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2681e873

Roll Flutter Engine from a140ab4a4ec6 to f146d4bf244b (1 revision) (#134290) · 2d9680ba

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/a140ab4a4ec6...f146d4bf244b

2023-09-08 whesse@google.com Add dart2wasm dependency to flutter_frontend_server (flutter/engine#45570)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2d9680ba

Roll Flutter Engine from ea1d0d28e26f to a140ab4a4ec6 (5 revisions) (#134288) · 0ddfe909

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/ea1d0d28e26f...a140ab4a4ec6

2023-09-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from EuBfOtm5TZIdgNaQe... to h_bQLstuirD8blCZW... (flutter/engine#45571)
2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from 99d39241ad4d to e60556f75b68 (1 revision) (flutter/engine#45569)
2023-09-08 bdero@google.com [Impeller] Aiks image filters; allow setting effect transforms after FilterContents instantiation. (flutter/engine#45530)
2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from ce3ec572ae77 to ece9f3a15b08 (1 revision) (flutter/engine#45568)
2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from fb4faa8646f8 to ce3ec572ae77 (1 revision) (flutter/engine#45567)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from EuBfOtm5TZId to h_bQLstuirD8

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0ddfe909

fix a Scrollbar example crash (#127925) · f4707c2b

xubaolin authored Sep 08, 2023

Fix a scrollbar example crash.
https://api.flutter.dev/flutter/material/Scrollbar-class.html#material.Scrollbar.1

f4707c2b

Fix `Drawer` examples are missing `dartpad` tag (#134219) · bb8de216

Taha Tesser authored Sep 08, 2023

fixes [`Drawer` examples are misssing `dartpad` tag]( https://github.com/flutter/flutter/issues/134217)

these examples were updated in https://github.com/flutter/flutter/pull/130523

bb8de216

Roll Flutter Engine from 4ac4429a206b to ea1d0d28e26f (1 revision) (#134270) · fa113358

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/4ac4429a206b...ea1d0d28e26f

2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 658025e9efdd to fb4faa8646f8 (1 revision) (flutter/engine#45564)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fa113358

Roll Flutter Engine from df3965a55fd8 to 4ac4429a206b (1 revision) (#134267) · 1c3c0f8a

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/df3965a55fd8...4ac4429a206b

2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 1b8a25d05c45 to 658025e9efdd (1 revision) (flutter/engine#45563)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1c3c0f8a

Roll Flutter Engine from 505ef3c33102 to df3965a55fd8 (1 revision) (#134263) · 7cbaa2a4

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/505ef3c33102...df3965a55fd8

2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from a412b149d5b1 to 99d39241ad4d (1 revision) (flutter/engine#45562)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7cbaa2a4

_TabBarViewState should dispose created instances of PageController. (#134091) · 3ff0beb5
Polina Cherkasova authored Sep 08, 2023

3ff0beb5
Remove non needed controllers in SegmentedButton. (#134064) · 237ddcc3
Polina Cherkasova authored Sep 08, 2023

237ddcc3
EditableTextState should dispose cursorVisibilityNotifier. (#133858) · 161c7090
Polina Cherkasova authored Sep 08, 2023

161c7090
TestWidgetsFlutterBinding should dispose old RestorationManager on reset. (#133999) · 0d30546c
Polina Cherkasova authored Sep 08, 2023

0d30546c

Roll Flutter Engine from 65f6fb841c7a to 505ef3c33102 (4 revisions) (#134260) · e08173e7

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/65f6fb841c7a...505ef3c33102

2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 17f36a6a101e to 1b8a25d05c45 (2 revisions) (flutter/engine#45560)
2023-09-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from N915IZbyx6MSrwwS-... to 33DToYd0jNpWX1jNv... (flutter/engine#45559)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from efd438ed1c06 to 17f36a6a101e (2 revisions) (flutter/engine#45557)
2023-09-07 skia-flutter-autoroll@skia.org Roll ANGLE from cdbc45a9f37e to a412b149d5b1 (2 revisions) (flutter/engine#45556)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from N915IZbyx6MS to 33DToYd0jNpW

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e08173e7

07 Sep, 2023 26 commits

CupertinoAlertDialog should not create ScrollController on every build, if... · cc95ace3

Polina Cherkasova authored Sep 07, 2023

CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor. (#134075)

Relanding of https://github.com/flutter/flutter/pull/134071

Verified failed tests succeeded now:

cc95ace3

Roll Flutter Engine from a828c26e7e97 to 65f6fb841c7a (1 revision) (#134254) · a863ad6e

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/a828c26e7e97...65f6fb841c7a

2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from ce2c94883cb5 to efd438ed1c06 (2 revisions) (flutter/engine#45554)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a863ad6e

_SearchBarState should dispose FocusNode, if it created it. (#134076) · 1c0b4ad5
Polina Cherkasova authored Sep 07, 2023
```
Relanding of revert: https://github.com/flutter/flutter/pull/134072

Verified failed tests succeeded now:
```
1c0b4ad5

Roll Flutter Engine from 2dba8ceca824 to a828c26e7e97 (8 revisions) (#134249) · 5a8a20c6

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/2dba8ceca824...a828c26e7e97

2023-09-07 skia-flutter-autoroll@skia.org Roll ANGLE from 204c07a56b64 to cdbc45a9f37e (1 revision) (flutter/engine#45551)
2023-09-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WbB3tmMXnuwJBAHoi... to EuBfOtm5TZIdgNaQe... (flutter/engine#45550)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from ee741e5e8cf3 to ce2c94883cb5 (1 revision) (flutter/engine#45552)
2023-09-07 30870216+gaaclarke@users.noreply.github.com [Impeller] Started tracking the pool with the command buffer. (flutter/engine#45298)
2023-09-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.6.0 to 4.0.0 (flutter/engine#45439)
2023-09-07 41930132+hellohuanlin@users.noreply.github.com Reverts part of "fix auto-correction highlight on top left corner (Again)" (flutter/engine#45523)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 59a2610cd83d to ee741e5e8cf3 (4 revisions) (flutter/engine#45548)
2023-09-07 skia-flutter-autoroll@skia.org Roll ANGLE from 60b56591dee5 to 204c07a56b64 (7 revisions) (flutter/engine#45546)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from WbB3tmMXnuwJ to EuBfOtm5TZId

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5a8a20c6

[integration_test] Allow capture of screenshots for `FlutterFragmentActivity`s (#132406) · 827b5dff

Gray Mackall authored Sep 07, 2023

Fixes https://github.com/flutter/flutter/issues/89683.

The changes to `getFlutterView` in `FlutterDeviceScreenshot` are the fix that was required, everything else was done to get tests running (such as re-generating some lockfiles and modifying the android manifest).

The code was all currently not unit tested, and there were no other easy examples to base these java unit tests off in flutter/flutter, so let me know if this approach to testing is wrong.

827b5dff

Roll Flutter Engine from 8d07c2947e60 to 2dba8ceca824 (2 revisions) (#134243) · c79868b0

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/8d07c2947e60...2dba8ceca824

2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from c3d6534b0ac3 to 59a2610cd83d (1 revision) (flutter/engine#45545)
2023-09-07 bdero@google.com Update impeller-cmake-example (flutter/engine#45526)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c79868b0

Fix `ExpansionTile` properties cannot be updated with `setState` (#134218) · 30234a00

Taha Tesser authored Sep 07, 2023

fixes [`ExpansionTile` properties aren't updated with `setState`](https://github.com/flutter/flutter/issues/24493)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  ShapeBorder collapsedShape = const RoundedRectangleBorder(
    borderRadius: BorderRadius.all(Radius.circular(4)),
  );
  Color collapsedTextColor = const Color(0xffffffff);
  Color collapsedBackgroundColor = const Color(0xffff0000);
  Color collapsedIconColor = const Color(0xffffffff);
  ShapeBorder shape = const RoundedRectangleBorder(
    borderRadius: BorderRadius.all(Radius.circular(16)),
  );
  Color backgroundColor = const Color(0xffff0000);
  Color textColor = const Color(0xffffffff);
  Color iconColor = const Color(0xffffffff);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Padding(
          padding: const EdgeInsets.symmetric(horizontal: 16.0),
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: [
              ExpansionTile(
                shape: shape,
                backgroundColor: backgroundColor,
                textColor: textColor,
                iconColor: iconColor,
                collapsedShape: collapsedShape,
                collapsedTextColor: collapsedTextColor,
                collapsedBackgroundColor: collapsedBackgroundColor,
                collapsedIconColor: collapsedIconColor,
                title: const Text('Collapsed ExpansionTile'),
                children: const [
                  ListTile(
                    title: Text('Revealed!'),
                  ),
                ],
              ),
              const SizedBox(height: 16),
              ExpansionTile(
                shape: shape,
                backgroundColor: backgroundColor,
                textColor: textColor,
                iconColor: iconColor,
                initiallyExpanded: true,
                title: const Text('Expanded ExpansionTile'),
                children: const [
                  ListTile(
                    title: Text('Revealed!'),
                  ),
                ],
              ),
              const SizedBox(height: 16),
              FilledButton(
                onPressed: () {
                  setState(() {
                    collapsedShape = const RoundedRectangleBorder(
                      borderRadius: BorderRadius.all(Radius.circular(50)),
                    );
                    collapsedTextColor = const Color(0xfff00000);
                    collapsedBackgroundColor = const Color(0xffffff00);
                    collapsedIconColor = const Color(0xfff00000);

                    shape = const RoundedRectangleBorder();
                    backgroundColor = const Color(0xfffff000);
                    textColor = const Color(0xfff00000);
                    iconColor = const Color(0xfff00000);
                  });
                },
                child: const Text('Update properties'),
              ),
            ],
          ),
        ),
      ),
    );
  }
}
```

</details> 

### Before

https://github.com/flutter/flutter/assets/48603081/b29aed98-38ff-40a3-9ed3-c4342ada35b6

### After

https://github.com/flutter/flutter/assets/48603081/5e0b6a34-c577-40ed-8456-7ef55caa277b

30234a00

[Windows Arm64] Remove device_type property (#134181) · 2032fcc5

Loïc Sharma authored Sep 07, 2023

The Windows Arm64 tests are failing to start as no machines match
desired properties. This removes the `device_type: none` property as no
Windows Arm64 machines match this ([with
`device_type`](https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=cpu%3Aarm64&f=os%3AWindows&f=pool%3Aluci.flutter.staging&f=device_type%3Anone&s=id),
[without
`device_type`](https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=cpu%3Aarm64&f=os%3AWindows&f=pool%3Aluci.flutter.staging&s=id)).

This allows the tests to run on the Windows Arm64 machine pool. [I
tested this manually using
`led`](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/d96efacb0ccd274798d5c18c9822903543bb1513d620ba9e50240e3ee2375905/+/build.proto?server=chromium-swarm.appspot.com).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

2032fcc5

Roll Flutter Engine from f0b718e28779 to 8d07c2947e60 (3 revisions) (#134240) · e308722e

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/f0b718e28779...8d07c2947e60

2023-09-07 matanlurey@users.noreply.github.com [Impeller] Document and slightly refactor `ResourceManagerVK` & friends. (flutter/engine#45474)
2023-09-07 uysalere@gmail.com [fuchsia] Restructure Flatland vsync loop (flutter/engine#45531)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 16df0c27bc0e to c3d6534b0ac3 (3 revisions) (flutter/engine#45543)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e308722e

add --exit flag to dev/devicelab/bin/test_runner.dart (#134165) · aea4552a

Andrew Kolos authored Sep 07, 2023

Resolves #134070

Adds a flag to the `test_runner.dart test` script that will cause the test runner to exit upon first failure (or, said another way, exit without retrying).

This is in parity with the `--exit` flag of `dev/devicelab/bin/run.dart`.

aea4552a

fix `--exit` flag in dev/devicelab/bin/run.dart (#134162) · 445e02dd

Andrew Kolos authored Sep 07, 2023

Fixes #134154 

This PR also changes the default value of the `--exit` flag from `true` to `false`. Effectively, this is not a change in behavior since `--exit` didn't previously work.

445e02dd

Roll Packages from e7d812cefce0 to 22d475491502 (9 revisions) (#134232) · ea351694

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/packages/compare/e7d812cefce0...22d475491502

2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from ff5b5b5fa6f3 to 2524052335ec (6 revisions) (flutter/packages#4866)
2023-09-07 maurits@vnbskm.nl [webview_flutter_platform_interface] Adds option to override console log (flutter/packages#4701)
2023-09-01 stuartmorgan@google.com [tools,pigeon] Update tooling to handle Windows build output changes (flutter/packages#4826)
2023-08-31 amuramoto@users.noreply.github.com [google_maps_flutter] Cloud-based map styling support (flutter/packages#3682)
2023-08-31 stuartmorgan@google.com [ci] Convert version presubmit check to LUCI (flutter/packages#4822)
2023-08-31 rajveer0malviya@gmail.com [url_launcher_android] Add support for Custom Tabs (flutter/packages#4739)
2023-08-31 tarrinneal@gmail.com [webview_flutter] update pigeon to 11 (flutter/packages#4821)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter (stable) from e1e47221e862 to ff5b5b5fa6f3 (1 revision) (flutter/packages#4823)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter from 1fe24956 to c175cf87 (30 revisions) (flutter/packages#4825)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea351694

Roll Flutter Engine from 71bea01d3abe to f0b718e28779 (2 revisions) (#134231) · 11ad759a

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/71bea01d3abe...f0b718e28779

2023-09-07 kjlubick@users.noreply.github.com Explicitly encode SkImages in SkPictures as PNG (flutter/engine#45511)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 9a41a83f96d7 to 16df0c27bc0e (3 revisions) (flutter/engine#45537)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

11ad759a

DropdownRoutePage should dispose the created ScrollController. (#133941) · 12e6ff2c
Polina Cherkasova authored Sep 07, 2023

12e6ff2c
Cover some test/widgets tests with leak tracking (#133803) · aca91df6
Kostia Sokolovskyi authored Sep 07, 2023

aca91df6
SearchDelegate should dispose resources. (#133948) · 0d198c7b
Polina Cherkasova authored Sep 07, 2023

0d198c7b

Fixed [NavigationRailDestination]'s label opacity while disabled not being... · 2867b31f

Matheus Kirchesch authored Sep 07, 2023

Fixed [NavigationRailDestination]'s label opacity while disabled not being coherent with the icon (#132345)

Fixing the opacity of the NavigationRailDestination widget label while
it is disabled, right now it doesn't get affected by the disabled
attribute, which doesn't match the icon that gets affected

* https://github.com/flutter/flutter/issues/132344

I believe this PR should be marked as [test-exempt]

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

2867b31f

Roll Flutter Engine from 558136a1ccbf to 71bea01d3abe (2 revisions) (#134216) · 6ddb3b04

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/558136a1ccbf...71bea01d3abe

2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 826f9f5d20b6 to 9a41a83f96d7 (2 revisions) (flutter/engine#45534)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from c99601816d84 to 826f9f5d20b6 (1 revision) (flutter/engine#45533)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6ddb3b04

Roll Flutter Engine from 5a45ecd24aa3 to 558136a1ccbf (1 revision) (#134206) · bbf5d11a

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/5a45ecd24aa3...558136a1ccbf

2023-09-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SCoDb2m_zQDLrMhwT... to N915IZbyx6MSrwwS-... (flutter/engine#45532)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SCoDb2m_zQDL to N915IZbyx6MS

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bbf5d11a

Roll Flutter Engine from d864ae68db3c to 5a45ecd24aa3 (1 revision) (#134201) · 3744050b

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/d864ae68db3c...5a45ecd24aa3

2023-09-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from hHwU6r12A0sy5Bq-0... to WbB3tmMXnuwJBAHoi... (flutter/engine#45529)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from hHwU6r12A0sy to WbB3tmMXnuwJ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3744050b

Fix `TabBar` doesn't use `labelStyle` & `unselectedLabelStyle` color (#133989) · f5355af4

Taha Tesser authored Sep 07, 2023

Fixes [TabBar labelStyle.color and unselectedLabelStyle.color does not take effect](https://github.com/flutter/flutter/issues/109484)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [TabBar].

const Color labelColor = Color(0xFFFF0000);
const Color unselectedLabelColor = Color(0x95FF0000);
const TextStyle labelStyle = TextStyle(
  color: Color(0xff0000ff),
  fontWeight: FontWeight.bold,
);
const TextStyle unselectedLabelStyle = TextStyle(
  color: Color(0x950000ff),
  fontStyle: FontStyle.italic,
);

void main() => runApp(const TabBarApp());

class TabBarApp extends StatelessWidget {
  const TabBarApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(useMaterial3: true),
      home: const TabBarExample(),
    );
  }
}

class TabBarExample extends StatelessWidget {
  const TabBarExample({super.key});

  @override
  Widget build(BuildContext context) {
    return DefaultTabController(
      initialIndex: 1,
      length: 3,
      child: Scaffold(
        appBar: AppBar(
          title: const Text('TabBar Sample'),
          bottom: const TabBar(
            // labelColor: labelColor,
            // unselectedLabelColor: unselectedLabelColor,
            labelStyle: labelStyle,
            unselectedLabelStyle: unselectedLabelStyle,
            tabs: <Widget>[
              Tab(
                icon: Icon(Icons.cloud_outlined),
                text: 'Cloudy',
              ),
              Tab(
                icon: Icon(Icons.beach_access_sharp),
                text: 'Sunny',
              ),
              Tab(
                icon: Icon(Icons.brightness_5_sharp),
                text: 'Rainy',
              ),
            ],
          ),
        ),
        body: const TabBarView(
          children: <Widget>[
            Center(
              child: Text("It's cloudy here"),
            ),
            Center(
              child: Text("It's rainy here"),
            ),
            Center(
              child: Text("It's sunny here"),
            ),
          ],
        ),
      ),
    );
  }
}
```

</details>

#### When `labelStyle` and `unselectedLabelStyle` are specified with a color.

### Before
![image](https://github.com/flutter/flutter/assets/48603081/4138f928-aa63-40bc-9d4e-4d2aeefe72c1)

### After

![image](https://github.com/flutter/flutter/assets/48603081/2ce552c5-3972-4b5d-9492-eb487764e58f)

f5355af4

Fix `DataTable`'s `headingTextStyle` & `dataTextStyle` are not merged with... · 75797a8a

Taha Tesser authored Sep 07, 2023

Fix `DataTable`'s `headingTextStyle` & `dataTextStyle` are not merged with default text style (#134138)

fixes [Inconsistent text color on DataTable in different platforms](https://github.com/flutter/flutter/issues/114470)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [DataTable].

void main() => runApp(const DataTableExampleApp());

class DataTableExampleApp extends StatelessWidget {
  const DataTableExampleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      themeMode: ThemeMode.dark,
      theme: ThemeData(),
      darkTheme: ThemeData.dark(),
      home: Scaffold(
        appBar: AppBar(title: const Text('DataTable Sample')),
        body: const DataTableExample(),
      ),
    );
  }
}

class DataTableExample extends StatelessWidget {
  const DataTableExample({super.key});

  @override
  Widget build(BuildContext context) {
    return DataTable(
      headingTextStyle: const TextStyle(),
      dataTextStyle: const TextStyle(),
      columns: const <DataColumn>[
        DataColumn(
          label: Expanded(
            child: Text(
              'Name',
              style: TextStyle(fontStyle: FontStyle.italic),
            ),
          ),
        ),
        DataColumn(
          label: Expanded(
            child: Text(
              'Age',
              style: TextStyle(fontStyle: FontStyle.italic),
            ),
          ),
        ),
        DataColumn(
          label: Expanded(
            child: Text(
              'Role',
              style: TextStyle(fontStyle: FontStyle.italic),
            ),
          ),
        ),
      ],
      rows: const <DataRow>[
        DataRow(
          cells: <DataCell>[
            DataCell(Text('Sarah')),
            DataCell(Text('19')),
            DataCell(Text('Student')),
          ],
        ),
        DataRow(
          cells: <DataCell>[
            DataCell(Text('Janine')),
            DataCell(Text('43')),
            DataCell(Text('Professor')),
          ],
        ),
        DataRow(
          cells: <DataCell>[
            DataCell(Text('William')),
            DataCell(Text('27')),
            DataCell(Text('Associate Professor')),
          ],
        ),
      ],
    );
  }
}

```

</details>

### Before

| Desktop | Mobile |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/19c3908d-6b6a-4408-9c6b-da83c8efaa4a"  /> | <img src="https://github.com/flutter/flutter/assets/48603081/efda08fb-05f9-437e-be5c-6b6861babe19" width="350"  /> |

### After

| Desktop | Mobile |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/6bd3433f-d61f-4f35-8a2a-f7539a74f93e" /> | <img src="https://github.com/flutter/flutter/assets/48603081/5123a79b-6c2a-4bea-9fbc-64ed3e599826" width="350" /> |

75797a8a

Roll Flutter Engine from 187c5b3c5f71 to d864ae68db3c (2 revisions) (#134199) · 3b0359a0

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/187c5b3c5f71...d864ae68db3c

2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 5b7a07a6356f to c99601816d84 (1 revision) (flutter/engine#45528)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 9e86d3f6239a to 5b7a07a6356f (1 revision) (flutter/engine#45527)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3b0359a0

Reland "Fix `Chip.shape`'s side is not used when provided in Material 3" (#133856) · ded8b8e3

Taha Tesser authored Sep 07, 2023

fixes [Chip border side color not working in Material3](https://github.com/flutter/flutter/issues/132922)
Relands https://github.com/flutter/flutter/pull/132941 with an updated fix and a regression test.

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Chips'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            const RawChip(
              shape: RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: BorderSide(color: Colors.red),
              label: Text('RawChip'),
            ),
            const Chip(
              shape: RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: BorderSide(color: Colors.red),
              label: Text('Chip'),
            ),
            ActionChip(
              shape: const RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: const BorderSide(color: Colors.red),
              label: const Text('ActionChip'),
              onPressed: () {},
            ),
            FilterChip(
              shape: const RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: const BorderSide(color: Colors.red),
              label: const Text('FilterChip'),
              onSelected: (value) {},
            ),
            ChoiceChip(
              shape: const RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: const BorderSide(color: Colors.red),
              label: const Text('ChoiceChip'),
              selected: false,
              onSelected: (value) {},
            ),
            InputChip(
              shape: const RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: const BorderSide(color: Colors.red),
              label: const Text('InputChip'),
              onSelected: (value) {},
            ),
          ],
        ),
      ),
    );
  }
}
```

</details>

<img src="https://github.com/flutter/flutter/assets/48603081/f713fd84-cf9a-4e52-8cdb-5faba63d8e91" height="450" /> <img src="https://github.com/flutter/flutter/assets/48603081/a142efc7-041e-4e6e-87cf-e6c4ebe735f3" height="450" />

<img src="https://github.com/flutter/flutter/assets/48603081/377df55b-499f-403f-96c5-0be0334795dc" height="450" /> <img src="https://github.com/flutter/flutter/assets/48603081/731a2752-7822-4605-8e9c-db0a71dd6f08" height="450" />

ded8b8e3

Roll Flutter Engine from 75437a3bd002 to 187c5b3c5f71 (1 revision) (#134193) · 83c24274

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/75437a3bd002...187c5b3c5f71

2023-09-07 bdero@google.com [Impeller] Gaussian blur: Remove lingering BlurStyle vertex data/uniforms. (flutter/engine#45524)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

83c24274

Manual roll Flutter Engine from 2c69d05dfafb to 75437a3bd002 (15 revisions) (#134188) · 14ced759

engine-flutter-autoroll authored Sep 07, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/2c69d05dfafb...75437a3bd002

2023-09-07 zanderso@users.noreply.github.com Revert "Enforce the rule of calling `FlutterView.Render`" (flutter/engine#45525)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 2b76d1113497 to 9e86d3f6239a (1 revision) (flutter/engine#45521)
2023-09-07 bdero@google.com [Impeller] Gaussian blur: Remove the current blur style implementation. (flutter/engine#45520)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 9c9757c5d17d to 2b76d1113497 (2 revisions) (flutter/engine#45518)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 0039caadd635 to 9c9757c5d17d (1 revision) (flutter/engine#45516)
2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 00daa451320c to 60b56591dee5 (1 revision) (flutter/engine#45517)
2023-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8dgICHnG28wNHzoz3... to SCoDb2m_zQDLrMhwT... (flutter/engine#45514)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from a274609c442c to 0039caadd635 (2 revisions) (flutter/engine#45513)
2023-09-06 stuartmorgan@google.com Add macOS support for plugin value publishing (flutter/engine#45502)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from e5ed4ffaaaa4 to a274609c442c (2 revisions) (flutter/engine#45510)
2023-09-06 zanderso@users.noreply.github.com Roll Fuchsia with license script fix (flutter/engine#45498)
2023-09-06 dkwingsmt@users.noreply.github.com Enforce the rule of calling `FlutterView.Render` (flutter/engine#45300)
2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 7b0bb0f6e785 to 00daa451320c (1 revision) (flutter/engine#45507)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 59e54ccf25a4 to e5ed4ffaaaa4 (4 revisions) (flutter/engine#45506)
2023-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from dFe-t1SosqZwU5lZR... to hHwU6r12A0sy5Bq-0... (flutter/engine#45505)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from z9uQ0mXwjKFQ to SCoDb2m_zQDL
fuchsia/sdk/core/mac-amd64 from dFe-t1SosqZw to hHwU6r12A0sy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14ced759