- 26 Sep, 2016 1 commit
-
-
Ian Hickson authored
This silences an assertion that fired when reparenting a widget with a global key inside a LayoutBuilder callback when that callback also happened to call setState (directly or indirectly) on that widget. Normally such setStates are considered ok since we know we haven't cleaned that subtree yet, but we were not correctly handling the case where the list needed resorting in that situation.
-
- 24 Sep, 2016 1 commit
-
-
Ian Hickson authored
The debugging logic was lagging behind the recent actual logic changes, especially around buildScope.
-
- 22 Sep, 2016 1 commit
-
-
Ian Hickson authored
Previously in some rather esoteric cases involving global keys reversing relative positions we would forget to build everyone.
-
- 21 Sep, 2016 1 commit
-
-
Adam Barth authored
-
- 20 Sep, 2016 3 commits
-
-
Adam Barth authored
-
Adam Barth authored
-
Adam Barth authored
There are still more to go, but this patch completes the widget section.
-
- 16 Sep, 2016 1 commit
-
-
Ian Hickson authored
See #4434.
-
- 15 Sep, 2016 2 commits
-
-
Adam Barth authored
Also, make ProxyWidget and ProxyElement public. Fixes #4505
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/5840
-
- 12 Sep, 2016 1 commit
-
-
Ian Hickson authored
This allows us to simplify the logic around inherited widgets e.g. in the Image widget.
-
- 09 Sep, 2016 2 commits
-
-
Ian Hickson authored
I forgot that it was possible for the root view to get marked dirty without getting a new widget. This fixes that case to work.
-
Ian Hickson authored
I did a pass through some of the code cleaning minor things up.
-
- 08 Sep, 2016 1 commit
-
-
Ian Hickson authored
Previously, pumpWidget() would do a partial pump (it didn't trigger Ticker callbacks or post-frame callbacks), and pump() would do a full pump. This patch brings them closer together. It also makes runApp run a full actual frame, rather than skipping the transient callback part of the frame logic. Having "half-frames" in the system was confusing and could lead to bugs where code expecting to run before the next layout pass didn't because a "half-frame" ran first. Also, make Tickers start ticking in the frame that they were started in, if they were started during a frame. This means we no longer spin a frame for t=0, we jump straight to the first actual frame. Other changes in this patch: * rename WidgetsBinding._runApp to WidgetsBinding.attachRootWidget, so that tests can use it to more accurately mock out runApp. * allow loadStructuredData to return synchronously. * make handleBeginFrame handle not being given a time stamp. * make DataPipeImageProvider.loadAsync protected (rather than private), and document it. There wasn't really a reason for it to be private. * fix ImageConfiguration.toString. * introduce debugPrintBuildScope and debugPrintScheduleBuildForStacks, which can help debug problems with widgets getting marked as dirty but not cleaned. * make debugPrintRebuildDirtyWidgets say "Building" the first time and "Rebuilding" the second, to make it clearer when a widget is first created. This makes debugging widget lifecycle issues much easier. * make debugDumpApp more resilient. * debugPrintStack now takes a label that is printed before the stack. * improve the banner shown for debugPrintBeginFrameBanner. * various and sundry documentation fixes
-
- 07 Sep, 2016 1 commit
-
-
Ian Hickson authored
Previously, if a StatefulWidget was marked dirty, then removed from the build, then reinserted using the exact same widget under a widget under a LayoutBuilder, it wouldn't rebuild. This fixes that. It also introduces an assert that's supposed to catch SizeObserver-like behaviour. Rather than make this patch even bigger, I papered over two pre-existing bugs which this assert uncovered (and fixed the other problems it found): https://github.com/flutter/flutter/issues/5751 https://github.com/flutter/flutter/issues/5749 We should fix those before 1.0 though.
-
- 29 Aug, 2016 1 commit
-
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/5283 Other changes in this patch: Rename OffStage to Offstage. Fixes https://github.com/flutter/flutter/issues/5378 Add a lot of docs. Some minor punctuation and whitespace fixes.
-
- 26 Aug, 2016 3 commits
-
-
Hans Muller authored
-
Ian Hickson authored
Somehow we missed this before. Fixes https://github.com/flutter/flutter/issues/5615
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/5588
-
- 23 Aug, 2016 1 commit
-
-
Ian Hickson authored
-
- 09 Aug, 2016 1 commit
-
-
Ian Hickson authored
...so that you can use hot reload mode to update assets.
-
- 29 Jul, 2016 1 commit
-
-
Ian Hickson authored
And make Scrollbar work with LazyBlock. And an about box to the Stocks sample app.
-
- 28 Jul, 2016 1 commit
-
-
Ian Hickson authored
- show the next error fully after a hot reload - hide _AssertionError in stacks - immediately rebuild after a reassemble, so that hit tests work - catch errors when notifying global key listeners
-
- 27 Jul, 2016 1 commit
-
-
Adam Barth authored
Also, add a few more debugging flags.
-
- 07 Jul, 2016 1 commit
-
-
Adam Barth authored
Fixes #4761
-
- 01 Jul, 2016 1 commit
-
-
Adam Barth authored
Now that protected can be accessed from inside the same library, we can use protected in a number of new places and we can remove some trampolines we were using to work around its previous semantics.
-
- 30 Jun, 2016 2 commits
- 26 Jun, 2016 1 commit
-
-
Adam Barth authored
This patch documents State in detail because it's a very common class for developers to work with and it has a number of subtles.
-
- 25 Jun, 2016 1 commit
-
-
Adam Barth authored
-
- 22 Jun, 2016 3 commits
-
-
pq authored
-
pq authored
-
pq authored
* brings in analyzer version (`0.27.4-alpha.14`) corresponding to current Dart SDK (`1.18.0-dev.2.0`). * updates analysis to use prefered API for embedder URI resolution * adds trampolines to `State` and `StatelessWidget` to allow for warning-free within-library @protected access (needed since we closed off access to @protected closures from outside subclasses). * turns off cache dependency tracking for analysis (in DDC this amounted to a 10% speed improvement).
-
- 07 Jun, 2016 2 commits
-
-
Ian Hickson authored
Also: * Make PaginatedDataTable able to scroll itself horizontally. * Make drop down buttons support having an explicit text style and icon size given. * Fix a bug with drop-down buttons asserting when opened partly off-screen. * Make sure to pop the drop-down button's route if the drop-down button is discarded while the route is up. * Remove extraneous padding on drop-down buttons. (Couldn't figure out why it was there, and it breaks alignment when a drop-down is mixed with other text.) * Some docs improvements. * Add Route.isActive * Add a setState() method to ModalRoutes.
-
Adam Barth authored
-
- 02 Jun, 2016 1 commit
-
-
Adam Barth authored
This required refactoring some cases where we weren't following the rules for the protected annotation.
-
- 01 Jun, 2016 2 commits
-
-
Adam Barth authored
-
Adam Barth authored
This patch starts using the mustCallSuper annotation for several of the key lifecycle callbacks in the framework. I haven't added it to didUpdateConfig because there are a large number of non-compliant overrides. We should discuss whether we want to use it there.
-
- 25 May, 2016 1 commit
-
-
Adam Barth authored
For consistency. Fixes #4142
-
- 24 May, 2016 1 commit
-
-
Adam Barth authored
Fixes #4114
-