1. 01 Mar, 2019 2 commits
    • Greg Spencer's avatar
      Be more strict about finding version number attached to a revision. (#28527) · 7ab3bc71
      Greg Spencer authored
      When we package Flutter, we used to find the "current" tag (which is the version number) by starting at the revision we are building on and looking backwards in time to find the most recent tag. This causes problems on release builds when we failed to tag properly.
      
      This PR makes the packaging script be more strict by requiring the given revision to itself have a tag, but only when we're publishing the result. When we're not publishing the result, it's more lenient, since otherwise we couldn't test packaging on non-release commits.
      
      I also renamed ProcessRunnerException to PreparePackageException, since we were using that exception more generally than just for processes.
      7ab3bc71
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  2. 26 Feb, 2019 1 commit
  3. 15 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Remove remaining "## Sample code" segments, and fix the snippet generator. (#27793) · 262f12b4
      Greg Spencer authored
      This converts all remaining "## Sample code" segments into snippets, and fixes
      the snippet generator to handle multiple snippets in the same dartdoc block
      properly.
      
      I also generated, compiled, and ran each of the existing application samples,
      and fixed them up to be more useful and/or just run without errors.
      
      This PR fixes these problems with examples:
      
      1. Switching tabs in a snippet now works if there is more than one snippet in
         a single dartdoc block.
      2. Generation of snippet code now works if there is more than one snippet.
      3. Contrast of text and links in the code sample block has been improved to
         recommended levels.
      4. Added five new snippet templates, including a "freeform" template to make
         it possible to show examples that need to change the app instantiation.
      5. Fixed several examples to run properly, a couple by adding the "Scaffold"
         widget to the template, a couple by just fixing their code.
      6. Fixed visual look of some of the samples when they run by placing many
         samples inside of a Scaffold.
      7. In order to make it easier to run locally, changed the sample analyzer to
         remove the contents of the supplied temp directory before running, since
         having files that hang around is problematic (only a problem when running
         locally with the `--temp` argument).
      8. Added a `SampleCheckerException` class, and handle sample checking
         exceptions more gracefully.
      9. Deprecated the old "## Sample code" designation, and added enforcement for
         the deprecation.
      10. Removed unnecessary `new` from templates (although they never appeared in
         the samples thanks to dartfmt, but still).
      
      Fixes #26398
      Fixes #27411
      262f12b4
  4. 26 Jan, 2019 1 commit
  5. 11 Jan, 2019 1 commit
  6. 07 Jan, 2019 1 commit
  7. 06 Nov, 2018 2 commits
  8. 05 Nov, 2018 1 commit
    • Greg Spencer's avatar
      Rewrite the analyze-sample-code script to also analyze snippets (#23893) · 202b045b
      Greg Spencer authored
      This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well.
      
      It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions.
      
      I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error.
      
      For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
      202b045b
  9. 30 Oct, 2018 1 commit
  10. 01 Oct, 2018 1 commit
  11. 22 Sep, 2018 1 commit
    • Ian Hickson's avatar
      [H] Cleanup (#21542) · 989cf18b
      Ian Hickson authored
      * Improve documentation and clean up code.
      
      * Remove "Note that".
      
      The phrase "note that" is basically meaningless as a prefix to an
      otherwise fine sentence.
      989cf18b
  12. 18 Sep, 2018 1 commit
  13. 14 Sep, 2018 1 commit
  14. 12 Sep, 2018 1 commit
  15. 07 Sep, 2018 1 commit
  16. 20 Aug, 2018 1 commit
    • Ian Hickson's avatar
      `flutter analyze` cleanup (#20490) · ad1eaff4
      Ian Hickson authored
      * `flutter analyze` cleanup
      
      * Make `--dartdocs` work in all modes.
      * Make `analyze-sample-code.dart` more resilient.
      * Add a test for `analyze-sample-code.dart`.
      * Minor cleanup in related code and files.
      
      * Apply review comments
      
      * Fix tests
      ad1eaff4
  17. 17 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Clean up usage of temporary directories (#20682) · 3dec6a69
      Ian Hickson authored
      All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`.
      
      I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests.
      
      While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others.
      
      Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
      3dec6a69
  18. 15 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Shim package:test to avoid matcher issues (#20602) · 686d8f8a
      Ian Hickson authored
      * Upgrade everything except matcher.
      * Roll matcher (and test)
      * Adjust tests that depend on flutter:test directly to depend on a shim
      * Require use of package:test shim and remove other references to package:test
      686d8f8a
  19. 02 Aug, 2018 1 commit
  20. 27 Jul, 2018 1 commit
  21. 23 Jul, 2018 1 commit
  22. 16 Jul, 2018 2 commits
  23. 21 Jun, 2018 1 commit
  24. 20 Jun, 2018 1 commit
  25. 19 Jun, 2018 1 commit
  26. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  27. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  28. 30 May, 2018 2 commits
  29. 22 Mar, 2018 1 commit
  30. 20 Mar, 2018 1 commit
  31. 14 Mar, 2018 2 commits
    • Greg Spencer's avatar
      Fix the remote setup to only change the URL. (#15528) · c345c1bb
      Greg Spencer authored
      This changes the packaging tool to only set the remote URL instead of recreating the remote.
      
      Recreating it was removing some metadata that identified the repo as having been cloned from the "real" repo, so flutter --version would report an unknown channel and source. This just sets the URL so that it looks like it came from GitHub.
      
      I also fixed some incorrect comments, and made unzip work on platforms other than Windows (even though we don't really need it there yet).
      
      Fixes #15518
      c345c1bb
    • Alexandre Ardhuin's avatar
      7667db63
  32. 10 Mar, 2018 1 commit
  33. 27 Feb, 2018 1 commit
    • Greg Spencer's avatar
      Switch Mac packaging to use .zip files. (#14894) · 29d59e3c
      Greg Spencer authored
      We can't use .tar.xz on Mac because although it can unpack them on the command line (with tar), the "Archive Utility" that runs when you double-click on them just does some crazy behavior (it
      converts it to a compressed cpio archive, and when you double-click on that, it converts it back to .tar.xz, without ever unpacking it!)
      
      So, this changes the script to use .zip for Mac, and the files are about 220MB larger than they need to be. 
      29d59e3c
  34. 22 Feb, 2018 1 commit
  35. 09 Feb, 2018 1 commit