- 31 May, 2023 1 commit
-
-
Tae Hyung Kim authored
-
- 26 May, 2023 1 commit
-
-
Phil Quitslund authored
The newly updated lint will soon flag for-each in collections. See discussion: https://github.com/dart-lang/linter/pull/4383 /cc @goderbauer
-
- 03 May, 2023 1 commit
-
-
Kevin Moore authored
-
- 26 Apr, 2023 1 commit
-
-
Tae Hyung Kim authored
Refactor "gen-l10n" command to use same code path when "l10n.yaml" is present or not present (#125429) I think this is a long needed change to the `gen-l10n` command. Essentially, the arguments to `flutter gen-l10n` can be provided by two different methods: via command line arguments or via the `l10n.yaml` file. The existence of a `l10n.yaml` file causes the latter approach to take precedence. However, currently, there's several differences in how the two approaches are handled, and most of the default arguments are all over the place, causing unexpected issues such as #120457 or #120023. This PR refactors the command so that * `LocalizationOptions` are more consistent with the actual argument names/yaml options. * All default values are determined in `LocalizationOptions`'s constructor (or in `argParser.addOption(...)` in the case a boolean value needs to be explicitly true). * New `parseLocalizationsOptionsFromCommand` function to parse arguments. * Parse `LocalizationOptions` at the beginning of `runCommand()` and pass it to `generateLocalizations`. Fixes #120023.
-
- 09 Aug, 2022 1 commit
-
-
Dillon Nys authored
-
- 27 Apr, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 17 Aug, 2021 1 commit
-
-
Jonah Williams authored
-
- 25 May, 2021 1 commit
-
-
Jenn Magder authored
-
- 20 Apr, 2021 1 commit
-
-
Jenn Magder authored
-
- 31 Mar, 2021 1 commit
-
-
Jenn Magder authored
-
- 27 Jan, 2021 1 commit
-
-
Jonah Williams authored
* opt out the flutter tool * oops EOF * fix import * Update tool_backend.dart * Update daemon_client.dart * fix more
-
- 05 Jan, 2021 1 commit
-
-
Shi-Hao Hong authored
* Reorganize files * Use l10n.yaml instead of command line args
-
- 04 Jan, 2021 1 commit
-
-
Shi-Hao Hong authored
-
- 04 Dec, 2020 1 commit
-
-
Shi-Hao Hong authored
-
- 06 Nov, 2020 1 commit
-
-
Shi-Hao Hong authored
-
- 05 Nov, 2020 1 commit
-
-
Shi-Hao Hong authored
-
- 16 Oct, 2020 1 commit
-
-
Shi-Hao Hong authored
* Generate pubspec.yaml for synthetic package if it did not exist prior
-
- 12 Oct, 2020 1 commit
-
-
Jonah Williams authored
HACKTOBERFEST
-
- 09 Sep, 2020 1 commit
-
-
Herbert Poul authored
* [gen_l10n] Support string list as preferred-supported-locales, as documented. * [gen_l10n] Convert preferredSupportedLocale to a list of strings. * [gen_l10n] Accept a multi option instead of a json string in the command line.
-
- 03 Sep, 2020 1 commit
-
-
Shi-Hao Hong authored
-
- 31 Aug, 2020 1 commit
-
-
Shi-Hao Hong authored
* synthetic packages by default in gen_l10n tool * Refactor default path for synthetic package * Remove unused import * Code cleanup * Further improvements to help text * Refactor synthetic package path * Remove newlines * Test cleanup * clean up logic in inputs and outputs list function * Update l10n.yaml usage * only add option if value is non-null * Update stocks app as proof of concept for synthetic package usage * Address nits * print pubspec contents * add print statements * Do not allow null value for useSyntheticPackage * + * + * + * + * Cleanup * Add test * Fix text * Dont parse pubspec directly * Test using context * WIP: generate synthetic packages on pub get -- needs tests * Allow null value * Update null handling * Refactor to properly handle null case * Fix yamlMap condition * Fix yaml node for real * WIP: struggling to write tests * WIP - take absolute path as an option * Add tests * Use environment project directory for synthetic package generation pathway * Fix typo * Improve help text * Update defaults * Remove unauthorized path import * Fix pathing issues at synthetic package generation * Fix typo in test * Use path.join so projectDir matches up based on OS * Fix Windows pathing in test * Remove unnecessary replaceApp code for projectDir.path * Use globals.fs.currentDirectory.path in resident_runner_test.dart * Fix merge conflict * Add test to ensure that synthetic package is generated on pub get * Fix resident_runner_test.dart tests * Fix tests * Use package:file instead of dart:io * WIP - exploration * Remove synthetic package use from stocks example * Update integration test to not use synthetic packages * Remove trailing whitespace * flutter pub get runs synth package generation * Remove more print statements * Add license header * WIP - minimally working pub.get * Use own MockBuildSystem * Modify test and implementation to be a little cleaner * Fix flutter pub get invocation * Use synthetic packages in stocks app * Revert "Use synthetic packages in stocks app" This reverts commit 45bf24903c3d4a2a5fd5481d7d6bc36c4a348703. * Add environment and buildSystem params to flutter test * Address code review feedback * + * Isolate codegen into its own API * Fix imports * Slight refactor * Add one more test for no l10n.yaml file * Remove unneeded mock class and import in pub_get_test.dart * More code review feedback * Remove unnecessary imports * Remove `return await`s that I missed * use arrow functions instead
-
- 13 Aug, 2020 1 commit
-
-
Shi-Hao Hong authored
-
- 06 Aug, 2020 1 commit
-
-
Nolan Scobie authored
* Add punctuation for unterminated sentences in doc comments * Addressing review nit
-
- 06 Jun, 2020 1 commit
-
-
Jonah Williams authored
-
- 18 May, 2020 1 commit
-
-
Jonah Williams authored
Reland: #56167
-
- 10 May, 2020 1 commit
-
-
Jonah Williams authored
This reverts commit f865ac7e.
-
- 08 May, 2020 1 commit
-
-
Jonah Williams authored
* [flutter_tools] integration l10n tool * add runtime skip to build system * Update build_system.dart * add links to issues, comments * Update packages/flutter_tools/test/general.shard/build_system/build_system_test.dart Co-authored-by: Shi-Hao Hong <shihaohong@google.com> * Update packages/flutter_tools/lib/src/build_system/targets/localizations.dart Co-authored-by: Shi-Hao Hong <shihaohong@google.com> * Update localizations.dart * switch to gen_l10n localizations * fix tests Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
-