- 19 Nov, 2019 3 commits
-
-
Greg Spencer authored
This adds a FocusableActionDetector, a widget which combines the functionality of Actions, Shortcuts, MouseRegion and a Focus widget to create a detector that defines actions and key bindings, and will notify that the focus or hover highlights should be shown or not. This widget can be used to give a control the required detection modes for focus and hover handling on desktop and web platforms. I replaced a bunch of similar code in many of our widgets with this widget, and found that pretty much any control that wants to be focusable wants all of these features as well: focus highlights, hover highlights, and actions to activate it. Also eliminated an extra _hasFocus variable in FocusState that wasn't being used.
-
Shi-Hao Hong authored
-
Amir Hardon authored
While building the iOS platform views support we only enabled it when the app developer explicitly specified it with a flag, the main reasons were using an untested thread configuration, and taking a performance hit (even when no platform view is used due to disabled raster cache). Now that we are using the same dynamic thread configuration whether platform views is used or not, and that raster cache works with platform views in the tree as well, we are almost ready to enabled the platform views support by default. As a first step, I'm enabling it for the Flutter Gallery app on which we run benchmarks. After monitoring the benchmarks and making sure the gallery takes no hit we should be more confident to enabled platform views by default. This change is expected to have no performance effect on the Gallery app at all.
-
- 18 Nov, 2019 13 commits
-
-
Jonah Williams authored
* add depfile slot to Target class * Update source.dart * Update source.dart
-
Greg Spencer authored
GLFW key events set modifier flags based on what the modifier state was before the event, unlike every other platform. This modifies the GLFW key support to take that into account. As a small cleanup, I fixed a documentation macro reference for the modifier flags that was duplicate
-
Greg Spencer authored
This adds support for the command key for text selection/editing on macOS. I had ported the text editing code (in #42879), but forgot to add support for the command key itself. This also adds a test that tests the text editing on multiple platforms instead of just testing Android. There appears to still be a bug (filed #44135) where we're losing key events sometimes on macOS, leaving some keys "stuck" on, but this PR at least allows the right key combinations to be used.
-
Jonah Williams authored
-
Christopher Fujino authored
-
engine-flutter-autoroll authored
9832bc8f2 Roll src/third_party/skia 78fa08b279c5..c9d263c1213e (1 commits) (flutter/engine#13893) (#45108) git@github.com:flutter/engine.git/compare/5fb7eb753b28...9832bc8f2eb2 git log 5fb7eb753b28..9832bc8f2eb2 --no-merges --oneline 2019-11-18 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78fa08b279c5..c9d263c1213e (1 commits) (flutter/engine#13893) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
chunhtai authored
-
chunhtai authored
-
Danny Tuppeny authored
* Switch from using app.progress to app.url for passing web launch urls * Update daemon.md * Change app.url -> app.webLaunchUrl * Add tests for app.webLaunchUrl event * Update tests with recent changes after rebasing
-
-
Bartosz Wiśniewski authored
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/3261324fab79...5fb7eb753b28 git log 3261324fab79..5fb7eb753b28 --no-merges --oneline 2019-11-18 bkonyi@google.com Roll src/third_party/dart 8617da2bf0..7b67303318 (3 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/4da0645df1aa...3261324fab79 git log 4da0645df1aa..3261324fab79 --no-merges --oneline 2019-11-18 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from pVwSb... to 6ZRA_... (flutter/engine#13891) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
- 17 Nov, 2019 3 commits
-
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/54be2d5fd8ea...4da0645df1aa git log 54be2d5fd8ea..4da0645df1aa --no-merges --oneline 2019-11-17 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Ass60... to pVwSb... (flutter/engine#13890) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
54be2d5fd Roll src/third_party/skia 541f310b3482..78fa08b279c5 (9 commits) (flutter/engine#13884) (#45060) git@github.com:flutter/engine.git/compare/fb9b91428b44...54be2d5fd8ea git log fb9b91428b44..54be2d5fd8ea --no-merges --oneline 2019-11-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia 541f310b3482..78fa08b279c5 (9 commits) (flutter/engine#13884) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/7ef587220aca...fb9b91428b44 git log 7ef587220aca..fb9b91428b44 --no-merges --oneline 2019-11-17 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from rX-Bh... to Ass60... (flutter/engine#13888) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
- 16 Nov, 2019 7 commits
-
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/f0371e2f8f97...7ef587220aca git log f0371e2f8f97..7ef587220aca --no-merges --oneline 2019-11-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from s9Vl7... to rX-Bh... (flutter/engine#13887) 2019-11-16 bkonyi@google.com Roll src/third_party/dart d6b0a27665..8617da2bf0 (1 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/59b5a0cf7676...f0371e2f8f97 git log 59b5a0cf7676..f0371e2f8f97 --no-merges --oneline 2019-11-16 ianloic@google.com Work around Fuchsia a11y / ICU name conflict (flutter/engine#13885) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/7892c69445d4...59b5a0cf7676 git log 7892c69445d4..59b5a0cf7676 --no-merges --oneline 2019-11-16 bkonyi@google.com Roll src/third_party/dart fdb9d19826..d6b0a27665 (19 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/486e62d02a2a...7892c69445d4 git log 486e62d02a2a..7892c69445d4 --no-merges --oneline 2019-11-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from RI85D... to s9Vl7... (flutter/engine#13882) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
Ian Hickson authored
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/b3463e3580bc...486e62d02a2a git log b3463e3580bc..486e62d02a2a --no-merges --oneline 2019-11-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1496758da42e..541f310b3482 (12 commits) (flutter/engine#13880) 2019-11-16 bkonyi@google.com Roll src/third_party/dart 8e176998b4..fdb9d19826 (5 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/b2640d97e7e8...b3463e3580bc git log b2640d97e7e8..b3463e3580bc --no-merges --oneline 2019-11-15 garyq@google.com getLineBoundary edge condition use <= instead of < (flutter/engine#13881) 2019-11-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia b3d3551577a3..1496758da42e (5 commits) (flutter/engine#13876) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
- 15 Nov, 2019 14 commits
-
-
Jonah Williams authored
-
Kate Lovett authored
* Init * Added error message to assert * Removing unrelated changes
-
Kate Lovett authored
-
Ben Konyi authored
Fixes failures in some tests which used regular expressions to compare stack traces which had instances of "<asynchronous suspension>".
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/cc2fe6be9e42...096ba6892a43 git log cc2fe6be9e42..096ba6892a43 --no-merges --oneline 2019-11-15 aam@google.com Reland children isolates sharing isolate group change. (flutter/engine#13758) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
Kate Lovett authored
-
Greg Spencer authored
This fixes the snippet code output so that it includes the name of the element that it is a snippet for in the first line.
-
Zachary Anderson authored
* [flutter_tool] Don't crash when failing to delete downloaded artifacts * Add space * Add more spaces.
-
engine-flutter-autoroll authored
cc2fe6be9 Roll src/third_party/skia f7281db422b7..b3d3551577a3 (1 commits) (flutter/engine#13874) (#44994) git@github.com:flutter/engine.git/compare/a8218a901ec8...cc2fe6be9e42 git log a8218a901ec8..cc2fe6be9e42 --no-merges --oneline 2019-11-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia f7281db422b7..b3d3551577a3 (1 commits) (flutter/engine#13874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/be139a5b94b3...a8218a901ec8 git log be139a5b94b3..a8218a901ec8 --no-merges --oneline 2019-11-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from VMTIz... to RI85D... (flutter/engine#13873) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
be139a5b9 Roll src/third_party/skia 3fafc831bc15..f7281db422b7 (4 commits) (flutter/engine#13871) (#44978) git@github.com:flutter/engine.git/compare/cd1b25a09e69...be139a5b94b3 git log cd1b25a09e69..be139a5b94b3 --no-merges --oneline 2019-11-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3fafc831bc15..f7281db422b7 (4 commits) (flutter/engine#13871) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
cd1b25a09 Roll src/third_party/skia c1c4634dcb07..3fafc831bc15 (1 commits) (flutter/engine#13870) (#44969) git@github.com:flutter/engine.git/compare/cb8d7bc569b5...cd1b25a09e69 git log cb8d7bc569b5..cd1b25a09e69 --no-merges --oneline 2019-11-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia c1c4634dcb07..3fafc831bc15 (1 commits) (flutter/engine#13870) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
cb8d7bc56 Allow passing hot reload debugging flags through dart-flags (flutter/engine#13780) (#44968) git@github.com:flutter/engine.git/compare/90a6054a878d...cb8d7bc569b5 git log 90a6054a878d..cb8d7bc569b5 --no-merges --oneline 2019-11-15 jonahwilliams@google.com Allow passing hot reload debugging flags through dart-flags (flutter/engine#13780) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
* 174e0e915 Roll src/third_party/dart dc35290111..dc808f3fcb (5 commits) (flutter/engine#13859) * 33d997ce1 Roll fuchsia/sdk/core/mac-amd64 from 7XOyl... to VMTIz... (flutter/engine#13861) * b4899d911 Roll src/third_party/skia d860a78fd60c..e57ca4931952 (44 commits) (flutter/engine#13862) * f456423cf RendererContextSwitch guard flutter's gl context rework. (flutter/engine#13812) * 6bab64e6d Fix test to account for pixel ratio transformations being framework responsibility. (flutter/engine#13850) * 5b10fa35b Guard against orphaned semantic objects from referencing dead accessibility bridge on iOS (flutter/engine#13857) * 97df087ee [fuchsia] Package flutter_frontend_server snapshot for fuchsia (flutter/engine#13865) * 0832dfde5 [flow][fuchsia] Add more tracing to layers and Fuchsia surface pool (flutter/engine#13864) * 141dc785d Roll src/third_party/skia e57ca4931952..c1c4634dcb07 (15 commits) (flutter/engine#13866) * 90a6054a8 Revert "Roll src/third_party/dart dc35290111..dc808f3fcb (5 commits) (#13859)" (flutter/engine#13867)
-
