- 16 Nov, 2016 1 commit
-
-
Ian Hickson authored
More idiomatic use of constraints in performResize. Trivial fixes to comments. Make ProxyBox not use BoxParentData since it ignores the field. Make applyPaintTransform more helpful if you use a different ParentData subclass than RenderBox expects. Make debugAssertIsValid actually fulfill its contract in RenderObject as documented. Add a childBefore for symmetry (we already had childAfter). Fix the way we dump the child list when there's no children in a multichild render object. More asserts in the rendering test library.
-
- 14 Nov, 2016 1 commit
-
-
Ian Hickson authored
Also fixes https://github.com/flutter/flutter/issues/6510
-
- 10 Nov, 2016 2 commits
-
-
Ian Hickson authored
-
Ian Hickson authored
-
- 17 Oct, 2016 1 commit
-
-
Adam Barth authored
Fixes #773
-
- 14 Oct, 2016 1 commit
-
-
Adam Barth authored
When not dismissing, the Dismissable widget should cull its background. When a dismiss is in progress, it should clip the background to just the part that is revealed. Fixes #6127
-
- 13 Oct, 2016 1 commit
-
-
Adam Barth authored
We weren't computing the bounds for composited transforms correctly. We need to conjugate the transform by the offset in order to get the correct paint bounds for the composited layer. We now also use the same math in the non-composited case for consistency. Also, don't scale the z-coordinate in RenderFittedBox. Fixes #6293
-
- 07 Oct, 2016 1 commit
-
-
Adam Barth authored
This patch adds `@checked` everywhere is needed to remove the `strong_mode_invalid_method_override` strong mode error.
-
- 06 Oct, 2016 1 commit
-
-
Adam Barth authored
This change might make our grammar less perfect, but it will increase our sanity.
-
- 28 Sep, 2016 1 commit
-
-
Ian Hickson authored
* globalToLocal was just broken when there was a rotation and a translation at the same time. This fixes that and adds a test. * update graphic used by spinning_mixed since the old one went 404. * simplify some of the code in the demo. * fix MatrixUtils.transformPoint to be consistent with how we transform points elsewhere. * stop transforming points elsewhere, just use MatrixUtils.transformPoint. * make the Widget binding handle not having a root element. * make the spinning_mixed demo update its widget tree.
-
- 27 Sep, 2016 1 commit
-
-
Adam Barth authored
The code previously assumed that paint would be called before hitTest, but that assumption isn't valid because RenderOpacity hit tests its children without painting them. Fixes #6089
-
- 24 Sep, 2016 1 commit
-
-
Adam Barth authored
This widget lets you apply an ImageFit to a child widget. Fixes #5830
-
- 15 Sep, 2016 1 commit
-
-
Adam Barth authored
Having this base class lets classes like CustomPainter and DataTableSource be more agnostic as to what's generating the repaints.
-
- 29 Aug, 2016 1 commit
-
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/5283 Other changes in this patch: Rename OffStage to Offstage. Fixes https://github.com/flutter/flutter/issues/5378 Add a lot of docs. Some minor punctuation and whitespace fixes.
-
- 16 Aug, 2016 2 commits
-
-
Ian Hickson authored
Turns out that previously we weren't updating the clip if the layout didn't change, even if the delegate was different.
-
Ian Hickson authored
We have so many render objects going on these days that showing every box that gets an event just makes the screen blue. This limits it down to only the ones that are actually doing something with the events.
-
- 15 Aug, 2016 2 commits
-
-
Ian Hickson authored
Instead of a PNG, the Flutter gallery widget is now drawn in code. There's now a FlutterLogoDecoration class that paints the flutter logo anywhere you can use a Decoration (e.g. AnimatedContainer). There's now a FlutterLogo class that honors the IconTheme. The About dialog box API now takes a Widget for the applicationIcon, instead of an ImageProvider. It uses IconTheme to make the icon the right size instead of using an Image widget. Add padding, duration, and curve properties to the DrawerHeader. Make the child of a DrawerHeader optional. Clean up UserAccuntsDrawerHeader a bit. Add some useful properties and methods to EdgeInsets. Add some debug logic to RenderDecoratedBox to catch unpaired save/restore calls when possible. Make GestureDetector fill its parent if it has no children. Fixes https://github.com/flutter/flutter/issues/5380
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/5380
-
- 29 Jul, 2016 1 commit
-
-
Dragoș Tiselice authored
* Added custom radii to RRect. This is the first commit towads an implementation of MergeableMaterial. It adds custom radii to RRect. * Renamed RRect constructors and added BorderRadius. BorderRadius is a class similar to EdgeInsets that lets you define all rounded corners of a rounded rectangle easily.
-
- 27 Jul, 2016 2 commits
-
-
Adam Barth authored
Also, add a few more debugging flags.
-
Ian Hickson authored
Fundamentally the core problem was that we were not saying how wide a date picker should be. It should be 330 pixels, if I'm measuring the spec's mocks correctly.
-
- 22 Jul, 2016 1 commit
-
-
Adam Barth authored
Previously, we considered them one operation in the compositor, which didn't trigger caching. Now we have a way to explicitly hint that the compositor should cache a layer.
-
- 04 Jul, 2016 1 commit
-
-
Adam Barth authored
-
- 01 Jul, 2016 1 commit
-
-
Adam Barth authored
This patch updates the framework to use the new SemanticAction in semantics.mojom.
-
- 30 Jun, 2016 1 commit
-
-
Matt Perry authored
navigating away. Details are in the bug, but when we navigate away, the overscroll indicator around the Scrollable would change the widget hierarchy. This would trigger the Scrollable to rebuild, which would cause its scrollOffset to be clamped to 0 for a frame. BUG=https://github.com/flutter/flutter/issues/4597
-
- 27 Jun, 2016 1 commit
-
-
Adam Barth authored
* Change how navigator prevents redundant operations Instead of requiring transactions, we now cancel all active pointers that are interacting with the navigator and absorb future pointers until we get a chance to build. This approach isn't perfect (e.g., events that trigger off the cancelled pointers could still interact with the navigator), but it should be better than the current transaction-based approach. Fixes #4716 * Remove openTransaction * test * fixup
-
- 16 Jun, 2016 1 commit
-
-
Ian Hickson authored
Overview ======== This patch refactors images to achieve the following goals: * it allows references to unresolved assets to be passed around (previously, almost every layer of the system had to know about whether an image came from an asset bundle or the network or elsewhere, and had to manually interact with the image cache). * it allows decorations to use the same API for declaring images as the widget tree. It requires some minor changes to call sites that use images, as discussed below. Widgets ------- Change this: ```dart child: new AssetImage( name: 'my_asset.png', ... ) ``` ...to this: ```dart child: new Image( image: new AssetImage('my_asset.png'), ... ) ``` Decorations ----------- Change this: ```dart child: new DecoratedBox( decoration: new BoxDecoration( backgroundImage: new BackgroundImage( image: DefaultAssetBundle.of(context).loadImage('my_asset.png'), ... ), ... ), child: ... ) ``` ...to this: ```dart child: new DecoratedBox( decoration: new BoxDecoration( backgroundImage: new BackgroundImage( image: new AssetImage('my_asset.png'), ... ), ... ), child: ... ) ``` DETAILED CHANGE LOG =================== The following APIs have been replaced in this patch: * The `AssetImage` and `NetworkImage` widgets have been split in two, with identically-named `ImageProvider` subclasses providing the image-loading logic, and a single `Image` widget providing all the widget tree logic. * `ImageResource` is now `ImageStream`. Rather than configuring it with a `Future<ImageInfo>`, you complete it with an `ImageStreamCompleter`. * `ImageCache.load` and `ImageCache.loadProvider` are replaced by `ImageCache.putIfAbsent`. The following APIs have changed in this patch: * `ImageCache` works in terms of arbitrary keys and caches `ImageStreamCompleter` objects using those keys. With the new model, you should never need to interact with the cache directly. * `Decoration` can now be `const`. The state has moved to the `BoxPainter` class. Instead of a list of listeners, there's now just a single callback and a `dispose()` method on the painter. The callback is passed in to the `createBoxPainter()` method. When invoked, you should repaint the painter. The following new APIs are introduced: * `AssetBundle.loadStructuredData`. * `SynchronousFuture`, a variant of `Future` that calls the `then` callback synchronously. This enables the asynchronous and synchronous (in-the-cache) code paths to look identical yet for the latter to avoid returning to the event loop mid-paint. * `ExactAssetImage`, a variant of `AssetImage` that doesn't do anything clever. * `ImageConfiguration`, a class that describes parameters that configure the `AssetImage` resolver. The following APIs are entirely removed by this patch: * `AssetBundle.loadImage` is gone. Use an `AssetImage` instead. * `AssetVendor` is gone. `AssetImage` handles everything `AssetVendor` used to handle. * `RawImageResource` and `AsyncImage` are gone. The following code-level changes are performed: * `Image`, which replaces `AsyncImage`, `NetworkImage`, `AssetImage`, and `RawResourceImage`, lives in `image.dart`. * `DecoratedBox` and `Container` live in their own file now, `container.dart` (they reference `image.dart`). DIRECTIONS FOR FUTURE RESEARCH ============================== * The `ImageConfiguration` fields are mostly aspirational. Right now only `devicePixelRatio` and `bundle` are implemented. `locale` isn't even plumbed through, it will require work on the localisation logic. * We should go through and make `BoxDecoration`, `AssetImage`, and `NetworkImage` objects `const` where possible. * This patch makes supporting animated GIFs much easier. * This patch makes it possible to create an abstract concept of an "Icon" that could be either an image or a font-based glyph (using `IconData` or similar). (see https://github.com/flutter/flutter/issues/4494) RELATED ISSUES ============== Fixes https://github.com/flutter/flutter/issues/4500 Fixes https://github.com/flutter/flutter/issues/4495 Obsoletes https://github.com/flutter/flutter/issues/4496
-
- 08 Jun, 2016 1 commit
-
-
Ian Hickson authored
Also, make sure that the parent is notified when they change. Fixes #2298
-
- 03 Jun, 2016 3 commits
-
-
Adam Barth authored
This patch starts working through the missing dartdocs in widgets.dart.
-
Adam Barth authored
Previously we supplied individual parameters to the various drag and pan callbacks. However, that approach isn't extensible because each new parameter is a breaking change to the API. This patch makes a one-time breaking change to the API to provide a "details" object that we can extend over time as we need to expose more information. The first planned extension is adding enough information to accurately produce an overscroll glow on Android.
-
Ian Hickson authored
The old code had gotten crufty with all the refactors. This simplifies it down to what it really means. Also, add a bunch of tests.
-
- 02 Jun, 2016 1 commit
-
-
Adam Barth authored
All of the public APIs in rendering.dart now have dartdocs.
-
- 01 Jun, 2016 2 commits
-
-
Ian Hickson authored
This introduces the key parts of a paginated data table, not including the built-in pagination features. * Provide more data for the data table demo, so there's data to page. * Introduce a ChangeNotifier class which abstracts out addListener/removeListener/notifyListeners. We might be able to use this to simplify existing classes as well, though this patch doesn't do that. * Introduce DataTableSource, a delegate for getting data for data tables. This will also be used by ScrollingDataTable in due course. * Introduce PaginatedDataTable, a widget that wraps DataTable and only shows N rows at a time, fed by a DataTableSource.
-
Ian Hickson authored
* Fix fallout from intrinsics changes * Move away from isInfinite in favor of isFinite
-
- 31 May, 2016 1 commit
-
-
Ian Hickson authored
-
- 30 May, 2016 2 commits
-
-
Adam Barth authored
I pulled the trigger to land the previous patch too quickly and missed a number of comments.
-
Adam Barth authored
-
- 27 May, 2016 1 commit
-
-
Adam Barth authored
There are still many more left before rendering.dart is complete.
-
- 25 May, 2016 1 commit
-
-
Adam Barth authored
For consistency. Fixes #4142
-
- 12 May, 2016 1 commit
-
-
pq authored
It's safe to remove the unneeded `void`s from setters since the blocking issues in the `always_declare_return_types` lint have been fixed (https://github.com/dart-lang/linter/). We can also safely flip the bit on `avoid_return_types_on_setters`.
-