Commits · 6d22a11b62d3448df10ce18f2262c2b9ecc660c1 · abdullh.alsoleman / Front-End

27 Aug, 2023 4 commits

Roll Flutter Engine from fc592728a7d0 to 0593c0455fd6 (4 revisions) (#133419) · 6d22a11b

engine-flutter-autoroll authored Aug 27, 2023

https://github.com/flutter/engine/compare/fc592728a7d0...0593c0455fd6

2023-08-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from N-A8agqDgvTKiT2Wc... to jnDJLdEAx34diOWFx... (flutter/engine#45159)
2023-08-27 jonahwilliams@google.com [Impeller] SuboptimalKHR is not an exit condition. (flutter/engine#45157)
2023-08-27 matanlurey@users.noreply.github.com Use YAML >- to avoid strange formatting. (flutter/engine#45158)
2023-08-27 matanlurey@users.noreply.github.com [Impeller] Implement TextDecoration (i.e. dashed lines) (flutter/engine#45041)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from N-A8agqDgvTK to jnDJLdEAx34d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6d22a11b

Roll Flutter Engine from b4e2758d6d43 to fc592728a7d0 (1 revision) (#133410) · 3f5583c8

engine-flutter-autoroll authored Aug 27, 2023

https://github.com/flutter/engine/compare/b4e2758d6d43...fc592728a7d0

2023-08-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from jZgLG9jWLutILTtsL... to 8nJB1-rSpC5L4digu... (flutter/engine#45156)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from jZgLG9jWLutI to 8nJB1-rSpC5L

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3f5583c8

Roll Flutter Engine from b5f18218969b to b4e2758d6d43 (1 revision) (#133405) · cd3aeef3

engine-flutter-autoroll authored Aug 27, 2023

https://github.com/flutter/engine/compare/b5f18218969b...b4e2758d6d43

2023-08-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xYHxghcipvy5XZAK6... to N-A8agqDgvTKiT2Wc... (flutter/engine#45155)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from xYHxghcipvy5 to N-A8agqDgvTK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cd3aeef3

Roll Flutter Engine from 683d7dc38928 to b5f18218969b (1 revision) (#133401) · f11430cd

engine-flutter-autoroll authored Aug 27, 2023

https://github.com/flutter/engine/compare/683d7dc38928...b5f18218969b

2023-08-27 matanlurey@users.noreply.github.com Use `SkTextBlob::bounds` instead of `TextFrame::getBounds()`. (flutter/engine#45148)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f11430cd

26 Aug, 2023 5 commits

Roll Flutter Engine from 4aaf77e33de6 to 683d7dc38928 (3 revisions) (#133393) · dbf87fc8

engine-flutter-autoroll authored Aug 26, 2023

https://github.com/flutter/engine/compare/4aaf77e33de6...683d7dc38928

2023-08-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Qj4BGsKtF7EJssKIK... to jZgLG9jWLutILTtsL... (flutter/engine#45153)
2023-08-26 skia-flutter-autoroll@skia.org Roll Skia from e64e8f4094b2 to 0f9e50daa879 (2 revisions) (flutter/engine#45152)
2023-08-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IYiIm4zYdKPYfpOIG... to xYHxghcipvy5XZAK6... (flutter/engine#45151)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from IYiIm4zYdKPY to xYHxghcipvy5
fuchsia/sdk/core/mac-amd64 from Qj4BGsKtF7EJ to jZgLG9jWLutI

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dbf87fc8

Roll Flutter Engine from c9b584d59219 to 4aaf77e33de6 (2 revisions) (#133389) · 26972de9

engine-flutter-autoroll authored Aug 26, 2023

https://github.com/flutter/engine/compare/c9b584d59219...4aaf77e33de6

2023-08-26 jonahwilliams@google.com Revert "[Impeller] DlAiksCanvas as a DlCanvas wrapper for impeller::Canvas" (flutter/engine#45149)
2023-08-26 dnfield@google.com [Impeller] DlAiksCanvas as a DlCanvas wrapper for impeller::Canvas (flutter/engine#45131)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

26972de9

Roll Flutter Engine from e280ed21f923 to c9b584d59219 (1 revision) (#133380) · 229b74d9

engine-flutter-autoroll authored Aug 26, 2023

https://github.com/flutter/engine/compare/e280ed21f923...c9b584d59219

2023-08-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from u8ovJYTk3nN78xF4X... to IYiIm4zYdKPYfpOIG... (flutter/engine#45138)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from u8ovJYTk3nN7 to IYiIm4zYdKPY

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

229b74d9

Roll Flutter Engine from 63fdf8a6701c to e280ed21f923 (3 revisions) (#133378) · 95161d86

engine-flutter-autoroll authored Aug 26, 2023

https://github.com/flutter/engine/compare/63fdf8a6701c...e280ed21f923

2023-08-26 skia-flutter-autoroll@skia.org Roll Skia from ac39b12fd835 to e64e8f4094b2 (1 revision) (flutter/engine#45136)
2023-08-26 skia-flutter-autoroll@skia.org Roll Skia from e67d9439a8c4 to ac39b12fd835 (1 revision) (flutter/engine#45133)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 40f4e01fca40 to e67d9439a8c4 (4 revisions) (flutter/engine#45132)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

95161d86

_SelectableFragment should dispatch creation in constructor. (#133351) · 343000b6
Polina Cherkasova authored Aug 26, 2023

343000b6

25 Aug, 2023 23 commits

Roll Flutter Engine from 53595c937df1 to 63fdf8a6701c (1 revision) (#133366) · 305c4db6

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/53595c937df1...63fdf8a6701c

2023-08-25 bdero@google.com [Impeller] Reland debug captures and inspector. (flutter/engine#45094)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

305c4db6

Roll Flutter Engine from 1ec7b89f3a6b to 53595c937df1 (4 revisions) (#133362) · 1b40f05a

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/1ec7b89f3a6b...53595c937df1

2023-08-25 bdero@google.com [Impeller] Fix mask blurs and the Gaussian blur coverage hint. (flutter/engine#45079)
2023-08-25 ychris@google.com ios: remove shared_application and support app extension build (flutter/engine#44732)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 76672468e8d7 to 40f4e01fca40 (3 revisions) (flutter/engine#45126)
2023-08-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 4LHUJjNlDT21v_pdT... to Qj4BGsKtF7EJssKIK... (flutter/engine#45127)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 4LHUJjNlDT21 to Qj4BGsKtF7EJ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1b40f05a

Roll Flutter Engine from 1471967afb9b to 1ec7b89f3a6b (6 revisions) (#133355) · d966f11f

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/1471967afb9b...1ec7b89f3a6b

2023-08-25 zanderso@users.noreply.github.com Remove --enable-software-rendering from iOS scenario tests (flutter/engine#45093)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 56bb647a49ac to 76672468e8d7 (3 revisions) (flutter/engine#45121)
2023-08-25 yatendraroria2001@gmail.com Fix: Complete Documentation for RasterStatus::kSkipAndRetry (flutter/engine#44880)
2023-08-25 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated TextureSourceVK docs and deleted unused ivars (flutter/engine#45123)
2023-08-25 zanderso@users.noreply.github.com Revert "Fix global tests doing nothing." (flutter/engine#45125)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from ba7c5258d2b4 to 56bb647a49ac (3 revisions) (flutter/engine#45118)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d966f11f

Fix locking to work with flutter and dart running simultaneously (#133350) · c4e1a1b3
Ian Hickson authored Aug 25, 2023

c4e1a1b3

Adds callback onWillAcceptWithDetails in DragTarget. (#131545) · 347f7bac

Chinmoy authored Aug 25, 2023

This PR adds onWillAcceptWithDetails callback to DragTarget to get information about offset.

Fixes: #131378 

This PR is subject to changes based on #131542

347f7bac

Remove deprecated onPlatformMessage from TestWindow and TestPlatformDispatcher (#133183) · 72bd3602
Kate Lovett authored Aug 25, 2023

72bd3602
Remove deprecated androidOverscrollIndicator from ScrollBehaviors (#133181) · 721016c1
Kate Lovett authored Aug 25, 2023

721016c1
Add an example showing how to use a MatrixTransition. (#132874) · 40af7db6
gmilou authored Aug 25, 2023

40af7db6

Roll Flutter Engine from 3dcd2179336d to 1471967afb9b (3 revisions) (#133342) · cd03eabd

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/3dcd2179336d...1471967afb9b

2023-08-25 reidbaker@google.com Update gradle to 7.5.1 (flutter/engine#45113)
2023-08-25 ychris@google.com Ignore unguarded-availability for unit test (flutter/engine#44852)
2023-08-25 jonahwilliams@google.com [Impeller] avoid hashing and std::vector growth when binding descriptor sets. (flutter/engine#45070)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cd03eabd

Roll Flutter Engine from 33fca02451ef to 3dcd2179336d (3 revisions) (#133340) · 284dfce7

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/33fca02451ef...3dcd2179336d

2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 4b30261160a2 to ba7c5258d2b4 (5 revisions) (flutter/engine#45116)
2023-08-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from R_deCnScH70FbSeii... to u8ovJYTk3nN78xF4X... (flutter/engine#45115)
2023-08-25 gspencergoog@users.noreply.github.com Add quotes around Doxygen configuration values (flutter/engine#45087)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from R_deCnScH70F to u8ovJYTk3nN7

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

284dfce7

Update flutter packages to pick up latest vm_service (#133335) · 61d9f556
Kenzie Davisson authored Aug 25, 2023
```
Generated by running `flutter update-packages --force-upgrade`
```
61d9f556

Roll Flutter Engine from 00f532dcaef4 to 33fca02451ef (1 revision) (#133337) · b66fb2a4

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/00f532dcaef4...33fca02451ef

2023-08-25 jonahwilliams@google.com [Impeller] fix validation warning on iOS/macOS when compiling external texture shader. (flutter/engine#45080)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b66fb2a4

Roll Flutter Engine from cb58abd77326 to 00f532dcaef4 (3 revisions) (#133333) · db22617b

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/cb58abd77326...00f532dcaef4

2023-08-25 godofredoc@google.com Remove cirrus build badge (flutter/engine#45103)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 8a26fe31389d to 4b30261160a2 (1 revision) (flutter/engine#45109)
2023-08-25 godofredoc@google.com Fix global tests doing nothing. (flutter/engine#45097)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

db22617b

Fix `PopupMenuItem` with a `ListTile` doesn't use the correct style. (#133141) · ea005219

Taha Tesser authored Aug 25, 2023

fixes [`PopupMenuItem` with a `ListTile`  doesn't use the correct text style.](https://github.com/flutter/flutter/issues/133138)

### Description

This fixes an issue text style issue for `PopupMenuItem` with a `ListTile` (for an elaborate popup menu) 

https://api.flutter.dev/flutter/material/PopupMenuItem-class.html

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [PopupMenuButton].

// This is the type used by the popup menu below.
enum SampleItem { itemOne, itemTwo, itemThree }

void main() => runApp(const PopupMenuApp());

class PopupMenuApp extends StatelessWidget {
  const PopupMenuApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        useMaterial3: true,
        textTheme: const TextTheme(
          labelLarge: TextStyle(
            fontStyle: FontStyle.italic,
            fontWeight: FontWeight.bold,
          ),
        ),
      ),
      home: const PopupMenuExample(),
    );
  }
}

class PopupMenuExample extends StatefulWidget {
  const PopupMenuExample({super.key});

  @override
  State<PopupMenuExample> createState() => _PopupMenuExampleState();
}

class _PopupMenuExampleState extends State<PopupMenuExample> {
  SampleItem? selectedMenu;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: SizedBox(
          width: 300,
          height: 130,
          child: Align(
            alignment: Alignment.topLeft,
            child: PopupMenuButton<SampleItem>(
              initialValue: selectedMenu,
              // Callback that sets the selected popup menu item.
              onSelected: (SampleItem item) {
                setState(() {
                  selectedMenu = item;
                });
              },
              itemBuilder: (BuildContext context) =>
                  <PopupMenuEntry<SampleItem>>[
                const PopupMenuItem<SampleItem>(
                  value: SampleItem.itemOne,
                  child: Text('PopupMenuItem'),
                ),
                const CheckedPopupMenuItem<SampleItem>(
                  checked: true,
                  value: SampleItem.itemTwo,
                  child: Text('CheckedPopupMenuItem'),
                ),
                const PopupMenuItem<SampleItem>(
                  value: SampleItem.itemOne,
                  child: ListTile(
                    leading: Icon(Icons.cloud),
                    title: Text('ListTile'),
                    contentPadding: EdgeInsets.zero,
                    trailing: Icon(Icons.arrow_right_rounded),
                  ),
                ),
              ],
            ),
          ),
        ),
      ),
    );
  }
}
``` 

</details>

### Before

![Screenshot 2023-08-23 at 14 08 48](https://github.com/flutter/flutter/assets/48603081/434ac95e-2981-4ab5-9843-939b39d771a2)

### After

![Screenshot 2023-08-23 at 14 08 32](https://github.com/flutter/flutter/assets/48603081/f6aba7e0-3d03-454f-8e0b-c031492f3f2d)

ea005219

Fix `Chip.shape`'s side is not used when provided in Material 3 (#132941) · 612117a6

Taha Tesser authored Aug 25, 2023

fixes [Chip border side color not working in Material3](https://github.com/flutter/flutter/issues/132922)

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        useMaterial3: true,
        chipTheme: const ChipThemeData(
            // shape: RoundedRectangleBorder(
            //   side: BorderSide(color: Colors.amber),
            //   borderRadius: BorderRadius.all(Radius.circular(12)),
            // ),
            // side: BorderSide(color: Colors.red),
            ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return const Scaffold(
      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          // side: BorderSide(color: Colors.red),
          label: Text('Chip'),
        ),
      ),
    );
  }
}

``` 

</details>

---

### Before

When `RawChip.shape` is provided with a `BorderSide`.

```dart
      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          label: Text('Chip'),
        ),
      ),
```

![Screenshot 2023-08-24 at 17 54 54](https://github.com/flutter/flutter/assets/48603081/89e2c9b5-44c2-432e-97ff-8bb95b0d0fb1)

When `RawChip.shape` is provided with a `BorderSide` and also `RawChip.side` is provided. The  `RawChip.side` overrides the shape's side.

```dart
      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          side: BorderSide(color: Colors.red),
          label: Text('Chip'),
        ),
      ),
```

![Screenshot 2023-08-24 at 17 55 37](https://github.com/flutter/flutter/assets/48603081/938803cc-d514-464b-b06b-e4841b9ad040)

---

### After

When `RawChip.shape` is provided with a `BorderSide`.

```dart
      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          label: Text('Chip'),
        ),
      ),
```

![Screenshot 2023-08-24 at 17 51 29](https://github.com/flutter/flutter/assets/48603081/d6fcaaa9-8f5d-4180-ad14-062dd459ec45)

When `RawChip.shape` is provided with a `BorderSide` and also `RawChip.side` is provided. The  `RawChip.side` overrides the shape's side.

```dart
      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          side: BorderSide(color: Colors.red),
          label: Text('Chip'),
        ),
      ),
```

![Screenshot 2023-08-24 at 17 52 31](https://github.com/flutter/flutter/assets/48603081/3fa46341-43f0-4fe7-a922-f1d8ba34028c)

---

612117a6

Dispose overlay entries (#132826) · 5c17a37b
Tomasz Gucio authored Aug 25, 2023

5c17a37b

Roll Flutter Engine from 0f8962208a44 to cb58abd77326 (3 revisions) (#133320) · 901a392a

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/0f8962208a44...cb58abd77326

2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from f867f82cc758 to 8a26fe31389d (1 revision) (flutter/engine#45104)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 5a1b6567544c to f867f82cc758 (2 revisions) (flutter/engine#45102)
2023-08-25 ian@hixie.ch FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#45030)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

901a392a

Roll Flutter Engine from 09e620d26834 to 0f8962208a44 (2 revisions) (#133309) · 3c1dd2f9

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/09e620d26834...0f8962208a44

2023-08-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from jkVyhV_xfb8Mv43xj... to 4LHUJjNlDT21v_pdT... (flutter/engine#45100)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 1428f16fc0de to 5a1b6567544c (1 revision) (flutter/engine#45099)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from jkVyhV_xfb8M to 4LHUJjNlDT21

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3c1dd2f9

Roll Flutter Engine from 9bcefc74b772 to 09e620d26834 (1 revision) (#133307) · 9ab8d27a

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/9bcefc74b772...09e620d26834

2023-08-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0kEa4JczTMD0Xus08... to R_deCnScH70FbSeii... (flutter/engine#45096)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 0kEa4JczTMD0 to R_deCnScH70F

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9ab8d27a

Roll Flutter Engine from 1382d6d79408 to 9bcefc74b772 (2 revisions) (#133305) · 3aca26ed

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/1382d6d79408...9bcefc74b772

2023-08-25 zanderso@users.noreply.github.com Revert ios cpu changes (flutter/engine#45095)
2023-08-25 30870216+gaaclarke@users.noreply.github.com [Impeller] Refactor: Create attachment descriptions without setting layouts (flutter/engine#45088)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3aca26ed

Allow passing verbose log from flutter daemon. (#132828) · 22a61b94
Lau Ching Jun authored Aug 25, 2023
```
It would be helpful for debugging if we can choose to also receive remote verbose logs.
```
22a61b94

Roll Flutter Engine from b8ec4da8866c to 1382d6d79408 (1 revision) (#133298) · 865b5b48

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/b8ec4da8866c...1382d6d79408

2023-08-25 flar@google.com Reland "Split DisplayListBuilder into
DlCanvas optimizer and DlOp recorder classes #44718"
(flutter/engine#45085)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

865b5b48

Roll Flutter Engine from 965501a25d92 to b8ec4da8866c (11 revisions) (#133296) · c8b9ae50

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/965501a25d92...b8ec4da8866c

2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 99a76ea8e1b2 to 1428f16fc0de (1 revision) (flutter/engine#45086)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 25fafff5b32c to 99a76ea8e1b2 (2 revisions) (flutter/engine#45083)
2023-08-24 jacksongardner@google.com Revert "Turn on the `skia_enable_optimize_size` flag to save a bit of binary size" (flutter/engine#45082)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from d7d56885a49b to 25fafff5b32c (1 revision) (flutter/engine#45081)
2023-08-24 dnfield@google.com [Impeller] Do not build scene unless 3d define is true (flutter/engine#45028)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 177e8477faf9 to d7d56885a49b (1 revision) (flutter/engine#45078)
2023-08-24 dkwingsmt@users.noreply.github.com Reland: [Rasterizer] Make resubmit information temporary (flutter/engine#45037)
2023-08-24 34871572+gmackall@users.noreply.github.com Add case checking to android sdk cipd upload script (flutter/engine#45063)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 007386294889 to 177e8477faf9 (1 revision) (flutter/engine#45076)
2023-08-24 jacksongardner@google.com Turn on the `skia_enable_optimize_size` flag to save a bit of binary size (flutter/engine#45029)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from b17ee34f3378 to 007386294889 (1 revision) (flutter/engine#45075)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c8b9ae50

24 Aug, 2023 8 commits

Bump actions/checkout from 3.5.3 to 3.6.0 (#133281) · d387f551

dependabot[bot] authored Aug 24, 2023

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v3.6.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Mark test scripts with Bash'isms to be run via Bash by <a href="https://github.com/dscho"><code>@âdscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1377">actions/checkout#1377</a></li>
<li>Add option to fetch tags even if fetch-depth &gt; 0 by <a href="https://github.com/RobertWieczoreck"><code>@âRobertWieczoreck</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/579">actions/checkout#579</a></li>
<li>Release 3.6.0 by <a href="https://github.com/luketomlinson"><code>@âluketomlinson</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1437">actions/checkout#1437</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/RobertWieczoreck"><code>@âRobertWieczoreck</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/579">actions/checkout#579</a></li>
<li><a href="https://github.com/luketomlinson"><code>@âluketomlinson</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1437">actions/checkout#1437</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3.5.3...v3.6.0">https://github.com/actions/checkout/compare/v3.5.3...v3.6.0</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/579">Add option to fetch tags even if fetch-depth &gt; 0</a></li>
</ul>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade <code>@âactions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1045">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942">Add GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967">Fix status badge</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1002">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1029">Update <code>@âactions/io</code> to 1.1.2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1039">Upgrading version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/939">Use <code>@âactions/core</code> <code>saveState</code> and <code>getState</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/922">Add <code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/770">Add input <code>set-safe-directory</code></a></li>
</ul>
<h2>v3.0.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/762">Fixed an issue where checkout failed to run in container jobs due to the new git setting <code>safe.directory</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/744">Bumped various npm package versions</a></li>
</ul>
<h2>v3.0.0</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/checkout/commit/f43a0e5ff2bd294095638e18286ca9a3d1956744"><code>f43a0e5</code></a> Release 3.6.0 (<a href="https://redirect.github.com/actions/checkout/issues/1437">#1437</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/7739b9ba2efcda9dde65ad1e3c2dbe65b41dfba7"><code>7739b9b</code></a> Add option to fetch tags even if fetch-depth &gt; 0 (<a href="https://redirect.github.com/actions/checkout/issues/579">#579</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/96f53100ba2a5449eb71d2e6604bbcd94b9449b5"><code>96f5310</code></a> Mark test scripts with Bash'isms to be run via Bash (<a href="https://redirect.github.com/actions/checkout/issues/1377">#1377</a>)</li>
<li>See full diff in <a href="https://github.com/actions/checkout/compare/c85c95e3d7251135ab7dc9ce3241c5835cc595a9...f43a0e5ff2bd294095638e18286ca9a3d1956744">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=3.5.3&new-version=3.6.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

d387f551

Update the tool to know about all our new platforms (#132423) · d6bf1447
Ian Hickson authored Aug 24, 2023
```
...and add a test so we remember to keep it in sync.
```
d6bf1447
l10n-related documentation improvements (#133114) · 5fa8de05
Ian Hickson authored Aug 24, 2023

5fa8de05

Add hover duration for `Inkwell` widget (#132176) · b2118918

Henry Riehl authored Aug 24, 2023

Adds a `hoverDuration` property to the `Inkwell` widget. This allows the user to customise how long the change in colour animates between the default colour and the hovered colour.

https://github.com/flutter/flutter/assets/73116038/2e7c5ccb-8651-4e08-8c7b-225cc005d594

Fixes #132170

b2118918

[web] benchmark the benchmark harness overhead (#132999) · cb72164a

Yegor authored Aug 24, 2023

Add benchmarks that measure the overhead of the benchmark harness itself. We want the overhead to be minimal. Also, these numbers are useful to judge the quality of real benchmarks. If a real benchmark's result is too close to the harness overhead, then it's likely not measuring enough of useful work.

cb72164a

Users of ChangeNotifier should dispatch event of object creation in constructor. (#133210) · afa37891
Polina Cherkasova authored Aug 24, 2023

afa37891

Bump activesupport from 6.1.7.3 to 6.1.7.6 in /dev/ci/mac (#133225) · 8175d693

dependabot[bot] authored Aug 24, 2023

Bumps [activesupport](https://github.com/rails/rails) from 6.1.7.3 to 6.1.7.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/rails/rails/releases">activesupport's releases</a>.</em></p>
<blockquote>
<h2>v6.1.7.6</h2>
<p>No changes between this and 6.1.7.5.  This release was just to fix file permissions in the previous release.</p>
<h2>6.1.7.5 Release</h2>
<h2>Active Support</h2>
<ul>
<li>
<p>Use a temporary file for storing unencrypted files while editing</p>
<p>[CVE-2023-38037]</p>
</li>
</ul>
<h2>Active Model</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Active Record</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Action View</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Action Pack</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Active Job</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Action Mailer</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Action Cable</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/rails/rails/commit/56bcc0abd3c9a6b09469e9428f6eea0dd77c2294"><code>56bcc0a</code></a> Preparing for 6.1.7.6 release</li>
<li><a href="https://github.com/rails/rails/commit/1f03e9dcbf75bf2a18f2b9a2212eff32d1a70612"><code>1f03e9d</code></a> Bumping version for new release</li>
<li><a href="https://github.com/rails/rails/commit/3a1b6150a9b7619fb6d020b61c3b8f8d493142b0"><code>3a1b615</code></a> Preparing for 6.1.7.5 release</li>
<li><a href="https://github.com/rails/rails/commit/c2af5781a972fcc5f39ef0a2915fca480f1aa186"><code>c2af578</code></a> bumping version / changelog</li>
<li><a href="https://github.com/rails/rails/commit/c85cc667ebfd3c270df37c7575d580ea6462e12f"><code>c85cc66</code></a> Use a temporary file for storing unencrypted files while editing</li>
<li><a href="https://github.com/rails/rails/commit/7d949d7c81d2ec3c6d21525ebb08c85f3f174b74"><code>7d949d7</code></a> Preparing for 6.1.7.4 release</li>
<li>See full diff in <a href="https://github.com/rails/rails/compare/v6.1.7.3...v6.1.7.6">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=activesupport&package-manager=bundler&previous-version=6.1.7.3&new-version=6.1.7.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/flutter/flutter/network/alerts).

</details>

8175d693

Remove `ImageProvider.load`, `DecoderCallback` and... · b4f4ece4

LongCatIsLooong authored Aug 24, 2023

Remove `ImageProvider.load`, `DecoderCallback` and `PaintingBinding.instantiateImageCodec` (#132679)

~The failing plugin tests should pass once
https://github.com/flutter/packages/pull/4725 lands and rolls into
flutter/flutter~

google tests are migrated.

Part of https://github.com/flutter/flutter/issues/133171

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

b4f4ece4