- 21 Apr, 2016 6 commits
-
-
Matt Perry authored
Also simplify handle drawing. All 3 cases are the same, just rotated. Also fix selection changes on iOS.
-
Eric Seidel authored
This only works for apps which use WidgetsApp. Apps which don't (like the game) could presumably read the static themselves off of WidgetsApp. @devoncarew @hixie
-
Ian Hickson authored
* Refactor the Gesturer's interfaces This makes them more coherent. It also makes it easier for the tests to override each specific part of hit-testing, should that be necessary. * Update binding.dart
-
Matt Perry authored
Only partially works. Editing the selected text doesn't work very well, which probably will require engine changes. Currently only draws the selected text and allows you to manipulate the selection with draggable selection handles.
-
Hans Muller authored
* Gallery Smoke Test
-
Adam Barth authored
Prior to this patch, we were pushing two frames each time the cursor blinked. In turning the cursor on or off, the markNeedsPaint call was triggering another frame to be scheduled because we cleared a bit in the scheduler at the beginning of the frame instead of at the end of the frame. To implement scheduling correctly, we actually need two bits: one for ensureVisualUpdate, which just promises to get to the end of the pipeline soon, and scheduleFrame, which promises to get to the beginning of the pipeline soon.
-
- 20 Apr, 2016 8 commits
-
-
Matt Perry authored
-
Ian Hickson authored
Also a bit of code cleanup. The key part of this patch is the addition in `_endScroll` to reset `_simulation`. It seems like this was the one place where it's possible for us to end the animation but not reset our state. Since we assert that are state is coherent, we were hitting asserts when a fling finished and then you interacted with the widget again.
-
Hans Muller authored
* Make IconButtons as big as possible
-
Ian Hickson authored
The 'routes' table is a point of confusion with new developers. By providing a 'home' argument that sets the '/' route, we can delay the point at which we teach developers about 'routes' until the point where they want to have a second route.
-
Viktor Lidholt authored
* Gallery code snippets now analyzed
-
Ian Hickson authored
-
Ian Hickson authored
...so that people don't think it's for Row.
-
Devon Carew authored
-
- 19 Apr, 2016 6 commits
-
-
Hans Muller authored
* Remove Scaffold scrollable_key demo usage
-
Ian Hickson authored
This makes it easier to use e.g. AssetImage in simple test applications. Also, dartdoc improvements. Also, use @required in one place, to see if it causes any trouble. If it doesn't, I'll start using it in more places.
-
Devon Carew authored
* add a service extension for repaint rainbow * review comments
-
Ian Hickson authored
The defaulting logic for bundles really belongs in the services layer, not the widgets layer. This way we can tell non-widget code just to use rootBundle if it just wants to read a JSON file or some such.
-
Ian Hickson authored
Bindings now have a debugRegisterServiceExtensions() method that is invoked in debug mode (only). (Once we have a profile mode, there'll be a registerProfileServiceExtensions() method that gets called in that mode only to register extensions that apply then.) The BindingBase class provides convenience methods for registering service extensions that do the equivalent of: ```dart void extension() { ... } bool extension([bool enabled]) { ... } double extension([double extension]) { ... } Map<String, String> extension([Map<String, String> parameters]) { ... } ``` The BindingBase class also itself registers ext.flutter.reassemble, which it has call a function on the binding called reassembleApplication(). The Scheduler binding now exposes the preexisting ext.flutter.timeDilation. The Renderer binding now exposes the preexisting ext.flutter.debugPaint. The Renderer binding hooks reassembleApplication to trigger the rendering tree to be reprocessed (in particular, to fix up the optimisation closures). All the logic from rendering/debug.dart about service extensions is replaced by the above. I moved basic_types to foundation. The FlutterWidgets binding hooks reassembleApplication to trigger the widget tree to be entirely rebuilt. Flutter Driver now uses ext.flutter.driver instead of ext.flutter_driver, and is hooked using the same binding mechanism. Eventually we'll probably move the logic into the Flutter library so that you just get it without having to invoke a special method first.
-
Ian Hickson authored
To be more consistent with other parts of the platform: * put the binding in a binding.dart file. * rearrange some members of the Scheduler class to be more close to execution order. * factor out Priority class into its own file. * add more dart docs.
-
- 16 Apr, 2016 1 commit
-
-
Hans Muller authored
-
- 15 Apr, 2016 6 commits
-
-
Ian Hickson authored
+ Add new demo to gallery to show data tables. (This currently doesn't use a Card; I'll create a Card version in a subsequent patch.) + Fix checkbox alignment. It now centers in its box regardless. + Add Colors.black54. + Some minor fixes to dartdocs. + DataTable, DataColumn, DataRow, DataCell + RowInkWell + Augment dartdocs of materia/debug.dart. + DropDownButtonHideUnderline to hide the underline in a drop-down when used in a DataTable. + Add new capabilities to InkResponse to support RowInkWell. + Augment dartdocs of materia/material.dart. + Add an assert to catch nested Blocks. + Fix a crash in RenderBox when you remove an object and an ancestor used its baseline. (https://github.com/flutter/flutter/issues/2874) + Fix (and redocument) RenderBaseline/Baseline. + Add flex support to IntrinsicColumnWidth. + Document more stuff on the RenderTable side. + Fix a bug with parentData handling on RenderTable children. + Completely rewrite the column width computations. The old logic made no sense at all. + Add dartdocs to widgets/debug.dart. + Add a toString for TableRow.
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/3363
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/3352
-
Ian Hickson authored
If two repaint boundaries mark themselves dirty, but the second one is a child of the first, then the second one will get repainted by the first and then when we come to paint it directly, we get confused because it isn't dirty any more. We ran into this in layout before. Apply the same fix. Also, apply the same fix to composition while we're at it.
-
Ian Hickson authored
Exception stack variable was shadowing the function argument stack.
-
Ian Hickson authored
We're getting back to the point where we have a bunch of foundation APIs and it's getting confusing having them mixed with services/.
-
- 14 Apr, 2016 3 commits
-
-
pq authored
With the new dev build we've got the updated linter and so can use the `@optionalTypeArgs` annotation (in `meta 0.12.0`). Bonus: this lets us clean up one more Regexp in the `analyze` command! :)
-
Ian Hickson authored
-
Alhaad Gokhale authored
-
- 13 Apr, 2016 4 commits
-
-
Ian Hickson authored
-
Ian Hickson authored
...by adding tests to our examples that don't import flutter_test, which pins the relevant dependencies. Also, provide more information when complaining about leaked transient callbacks in tests. Also, make tests display full information when they have an exception, by bypassing the throttling we have for Android logging in tests. Also, make the word wrapping not wrap stack traces if they happen to be included in exception output. Also, fix a leaked transient callback in the checkbox code.
-
Devon Carew authored
-
Ian Hickson authored
* Fix Block intrinsic functions * Update block_test.dart Fix the test per travis
-
- 12 Apr, 2016 6 commits
-
-
Ian Hickson authored
This also shrinks the width of the error messages a bit because now that we use 'package:' URLs the stacks are a bit narrower.
-
Adam Barth authored
-
Devon Carew authored
* styles updates for the api docs * update library docs * use the new --favion and --use-categories options for dartdoc
-
Adam Barth authored
Also fill in some related dartdocs.
-
Adam Barth authored
Now past halfway though material.dart by files.
-
Jason Simmons authored
-