- 28 Jul, 2019 1 commit
-
-
Kate Lovett authored
-
- 27 Jul, 2019 1 commit
-
- 24 Jul, 2019 1 commit
-
-
Jim Graham authored
Primarily these methods no longer allocate any objects other than their return values. Additionally, the math in the methods is reduced compared to the general case math based on known input conditions.
-
- 17 Jul, 2019 1 commit
-
-
Matan Shukry authored
Using custom exception class for network loading error
-
- 12 Jul, 2019 2 commits
-
-
Kate Lovett authored
This reverts commit eb0b1790. Skia Gold post-submit test were failing due to the service account not being found on Cirrus.
-
Kate Lovett authored
* Fresh PR for Gold integration. * Nits * WIP * Artifacts from merge * Changed some platform dependencies for web, added library prefix notation for Skia Gold test names. * Updating for CI implementation * Write out service account * Writing to skip out * WIP * ++ * Fixing depot tools deps * Windows depot_tools * Fixing setup scripts * ++ * depot tools * ++ * WIP * Tracing depot_tools clone * WIP * ++ * analyzer * WIP * chrome typo * copy artifact * Working on tests * Code cleanup * ++ * Code cleanup, updated tests * ++ review feedback * Review * Analyzer * Review feedback * Nits from review * PRogress * ++ * Fixing tests * ++ * Testing repo route * Just needing documention around new structures. * cleanup * Analyzer * Documentation updates * Documentation updates * Cirrus updates * cirrus nit * Review feedback * Review feedback * Fixing skip comparator * Fix base directory for Skia Gold case * ++ * Feedback * ++ * Fixed uri assertion * Made GoldensClient abstract, altered SkiaGoldClient constructor * Analyzer
-
- 11 Jul, 2019 1 commit
-
-
Dan Field authored
-
- 28 Jun, 2019 1 commit
-
-
- 25 Jun, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 18 Jun, 2019 1 commit
-
-
Kate Lovett authored
* Splitting golden file versioning out as an argument of matchesGoldenFile * Fixing description implementation. * Removing unused imports * Removing unused import * Review feedback
-
- 15 Jun, 2019 1 commit
-
-
Jonah Williams authored
* add web and io implemenations of network and asset image * fix foundation import * update to remove extra asset image indirection * skip chunk test * address comments * disable non-functional test * disable all golden tests * address comments
-
- 13 Jun, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 10 Jun, 2019 1 commit
-
-
Jonah Williams authored
-
- 07 Jun, 2019 2 commits
-
-
Gary Qian authored
Reland "Text inline widgets, TextSpan rework (#30069)" with improved backwards compatibility (#34051)
-
- 06 Jun, 2019 1 commit
-
-
Gary Qian authored
-
- 05 Jun, 2019 1 commit
-
- 04 Jun, 2019 1 commit
-
-
Gary Qian authored
* Merge in changes for inline widgets * Make analyzer happy, fix tests * Fix analyzer * Add missing doc * Docs on RichText * Fix analyzer some more * Remove whitespace at end of line * Update goldens * Text fixes * Analyzer
-
- 03 Jun, 2019 3 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
This reverts commit d92b3b40.
-
Jonah Williams authored
-
- 31 May, 2019 1 commit
-
-
Todd Volkert authored
This updates FadeInImage to use the new Image.frameBuilder API (added in #33369), to greatly simplify the implementation of FadeInImage. This also removes the FadeInImage.placeholderSemanticLabel property. This property was added in #28799 for the sake of completeness (the bug it fixed was the lack of any semantic label support in FadeInImage), but a placeholder is a transient visual artifact, not something that affects the underlying semantic meaning of the image.
-
- 30 May, 2019 1 commit
-
-
Gary Qian authored
-
- 23 May, 2019 2 commits
-
-
Paul Berry authored
The dart analyzer fails to warn about missing returns in function expressions due to a bug that has been fixed but not yet rolled into Flutter (see https://dart-review.googlesource.com/c/sdk/+/100301). So it failed to catch that https://github.com/flutter/flutter/pull/33217 accidentally introduced a call to `testWidgets` that passed it a synchronous callback.
-
Todd Volkert authored
I forgot to add `onChunk` to them in #33092
-
- 22 May, 2019 1 commit
-
-
Jason Simmons authored
-
- 21 May, 2019 2 commits
-
-
Todd Volkert authored
This is another step towards supporting image loading progress notification at the widgets layer. This adds an `ImageChunkEvent` class along with associated `ImageChunkListener` callback signature and an `onChunk` property to `ImageStreamListener`. The events serve to notify registered listeners when byte chunks are received while loading an image. https://github.com/flutter/flutter/issues/32374
-
Todd Volkert authored
The current API was broken in that you registered multiple callbacks at once, but when you removed listeners, only the primary listener was used to determine what was removed. This led to unintuitive cases where the caller could get unexpected behavior. This updates the API to add and remove listeners using a newly introduced [ImageStreamListener] object, a value object that has references to the individual callbacks that may fire. flutter/flutter#24722 flutter/flutter#32374 flutter/flutter#32935
-
- 20 May, 2019 1 commit
-
-
Todd Volkert authored
Currently, the fact that NetworkImage uses a static HttpClient makes it impossible to properly test, as a mock in one test will be reused in another test. This change fixes that. https://github.com/flutter/flutter/issues/32374
-
- 10 May, 2019 1 commit
-
-
Kate Lovett authored
Revert "Merge branch 'master' into master" This reverts commit e3a03c04, reversing changes made to 64749826.
-
- 09 May, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 06 May, 2019 1 commit
-
-
Michael Klimushyn authored
-
- 29 Apr, 2019 1 commit
-
-
Dan Field authored
* Re-enable const
-
- 25 Apr, 2019 1 commit
-
-
Kate Lovett authored
-
- 24 Apr, 2019 1 commit
-
-
Kate Lovett authored
Commented out skips in golden framework tests and transitioned from matchesGoldenFile to matchesSkiaGoldFile.
-
- 17 Apr, 2019 1 commit
-
-
Todd Volkert authored
-
- 11 Apr, 2019 1 commit
-
-
Siva authored
* Use identical instead of '==' in a constant expression. * Fix analyzer warnings. * Fix analyzer warnings.
-
- 10 Apr, 2019 3 commits
-
-
Sam Rawlins authored
-
Jonah Williams authored
-
Justin McCandless authored
* Disallow cursor from appearing beyond the width of the input. * Test that verifies the cursor can't exceed the width of the input * Use constant from editable.dart to explain 1 pixel difference in test * Fix failing test that tested the case of overflowing spaces
-