- 23 Sep, 2015 3 commits
-
-
Hixie authored
In the old world, we had two ways to bind a Widget tree to a RenderObject node, one way for RenderView and one mostly untested way for other cases (it's only tested by the spinning_mixed.dart demo). For fn3, I made these the same code path. This patch also introduces GlobalKey, though the GlobalKey logic isn't hooked in yet. This is Hello World in the new world: ```dart import 'package:sky/src/fn3.dart'; void main() { runApp(new Text('Hello World!')); } ```
-
Adam Barth authored
-
Adam Barth authored
-
- 22 Sep, 2015 20 commits
-
-
Adam Barth authored
Add TagWidget to fn3
-
Adam Barth authored
-
Hans Muller authored
-
Hans Muller authored
Currently, fling scrolls animate far too long after the display has effectively stopped moving. Use the ScrollSimulation's tolerance property to stop the scrolling roughly when the display stops changing.
-
Hixie authored
Fixes errors from #1285 and #1281.
-
Hans Muller authored
-
Hans Muller authored
-
Hans Muller authored
-
Hixie authored
- I extracted the BuildScheduler into a separate binding.dart file. - Various changes to expose private members that are needed by binding.dart. - Registering the render objects for event dispatch. - Convert the tests to use the new binding mechanism. This doesn't yet have a RenderView or event handling.
-
Adam Barth authored
We'll need tag nodes before finishing Flex and Stack.
-
Ian Hickson authored
Fix scrolling of Block.
-
Hixie authored
Since our build function depends on scrollBehavior.isScrollable, any time we update scrollBehavior we are implicitly updating our state. As such, we must do so during a setState() call, or else we won't rebuild and might not bother to listen to the scroll gestures. This probably broke when we made Block not listen to gestures if it wasn't overflowing.
-
Adam Barth authored
There are some TODOs in this file that I'll address in the next patch.
-
Adam Barth authored
More dartdocs for fn3, refactor buildDirtyElements
-
Jason Simmons authored
Ensure that EditableText always shows a cursor
-
Jason Simmons authored
Some cleanup of the Sky analyzer script
-
Hixie authored
The buildDirtyElements() method now enforces that we only build deeper nodes and never go back to build higher nodes during a frame.
-
Adam Barth authored
-
Hixie authored
- move _uniqueChild earlier since a comment now mentions it earlier. - reorder methods in Element to more closely reflect call order. - change mount to be the place that sets the parent pointer, for consistency. - make the lifecycleState a purely debug-time thing for consistency. - make BuildableElement.unmount set dirty to false so that we won't build unmounted objects. - rename "updated" to "newWidget" for clarity. - change how we unmount things so that the slot is reset up to a RenderObjectElement, but not further, and don't reset the depth.
-
Adam Barth authored
-
- 21 Sep, 2015 13 commits
-
-
Adam Barth authored
All the use cases for EventDisposition are now addressed by the gesture detection system.
-
Adam Barth authored
We no longer have gesture events.
-
Hixie authored
Add a LeafRenderObjectElement, fix a test to use the new contract.
-
Hixie authored
- adds dartdocs - replaces config setter with didUpdateConfig() so that you can't replace the config outside of the system - renames didUnmount() with destroy(). - rename Component to StatelessComponent, ComponentConfiguration to StatefulComponent - move debug dump to end of file - renamed _holder to _element
-
Adam Barth authored
fn3 shouldn't rebuild components that don't change identity
-
Collin Jackson authored
add a test for scale gestures
-
Jason Simmons authored
* If no source path is provided, then run the analyzer on the Sky unit tests * Fix the filter for errors found in pub cache packages * Generalize the filter for the analyzer's "xx errors/warnings/hints found" status message Also fix a test that caused a warning in the analyzer.
-
Jason Simmons authored
Previously EditableText would render a text widget with no cursor if the text value was empty. Also adjust the height of the cursor widget to reflect the style's line height, and update the cursor painting to match.
-
Adam Barth authored
-
Adam Barth authored
-
Adam Barth authored
Previously --stage-two would error out because the LICENSE was git ignored. This patch includes the LICENSE file in the repo to avoid the error. Also, refactor the big_red_button.py to be clearer about what's shared between stage one and stage two of the release process.
-
Adam Barth authored
-
Ian Hickson authored
Prototype of fn3
-
- 20 Sep, 2015 1 commit
-
-
Adam Barth authored
We were just missing a few type casts in tests to make the analyzer happy.
-
- 19 Sep, 2015 2 commits
-
-
Adam Barth authored
-
Adam Barth authored
This patch contains a prototype of a new widget framework. In this framework, Components can be reused in the tree as many times as the author desires. Also, StatefulComponent is split into two pieces, a ComponentConfiguration and a ComponentState. The ComponentConfiguration is created by the author and can be reused as many times as desired. When mounted into the tree, the ComponentConfiguration creates a ComponentState to hold the state for the component. The state remains in the tree and cannot be reused.
-
- 18 Sep, 2015 1 commit
-
-
Hixie authored
Instead of having to manage the popup menu from your app's build function, you now just call showPopupMenu() with the menu's position and it takes care of everything for you. This solves the problem that the popup menu was trying to mutate the state of the navigator from within its own initState() function. Also, remove the "route" argument to RouteBase.build() since it equals "this" by definition... Also, remove ModalOverlay, and instead put that logic in the navigator.
-