1. 23 May, 2023 1 commit
    • Ian Hickson's avatar
      Give channel descriptions in `flutter channel`, use branch instead of upstream... · 9c7a9e77
      Ian Hickson authored
      Give channel descriptions in `flutter channel`, use branch instead of upstream for channel name (#126936)
      
      ## How we determine the channel name
      
      Historically, we used the current branch's upstream to figure out the current channel name. I have no idea why. I traced it back to https://github.com/flutter/flutter/pull/446/files where @abarth implement this and I reviewed that PR and left no comment on it at the time.
      
      I think this is confusing. You can be on a branch and it tells you that your channel is different. That seems weird.
      
      This PR changes the logic to uses the current branch as the channel name.
      
      ## How we display channels
      
      The main reason this PR exists is to add channel descriptions to the `flutter channel` list:
      
      ```
      ianh@burmese:~/dev/flutter/packages/flutter_tools$ flutter channel
      Flutter channels:
        master (tip of tree, for contributors)
        main (tip of tree, follows master channel)
        beta (updated monthly, recommended for experienced users)
        stable (updated quarterly, for new users and for production app releases)
      * foo_bar
      
      Currently not on an official channel.
      ianh@burmese:~/dev/flutter/packages/flutter_tools$
      ```
      
      ## Other changes
      
      I made a few other changes while I was at it:
      
      * If you're not on an official channel, we used to imply `--show-all`, but now we don't, we just show the official channels plus yours. This avoids flooding the screen in the case the user is on a weird channel and just wants to know what channel they're on.
      * I made the tool more consistent about how it handles unofficial branches. Now it's always `[user branch]`.
      * I slightly adjusted how unknown versions are rendered so it's clearer the version is unknown rather than just having the word "Unknown" floating in the output without context.
      * Simplified some of the code.
      * Made some of the tests more strict (checking all output rather than just some aspects of it).
      * Changed the MockFlutterVersion to implement the FlutterVersion API more strictly.
      * I made sure we escape the output to `.metadata` to avoid potential injection bugs (previously we just inlined the version and channel name verbatim with no escaping, which is super sketchy).
      * Tweaked the help text for the `downgrade` command to be clearer.
      * Removed some misleading text in some error messages.
      * Made the `.metadata` generator consistent with the template file.
      * Removed some obsolete code to do with the `dev` branch.
      
      ## Reviewer notes
      
      I'm worried that there are implications to some of these changes that I am not aware of, so please don't assume I know what I'm doing when reviewing this code. :-)
      9c7a9e77
  2. 21 Apr, 2023 1 commit
  3. 02 Mar, 2023 1 commit
  4. 21 Aug, 2022 1 commit
  5. 02 May, 2022 1 commit
  6. 28 Apr, 2022 1 commit
  7. 26 Apr, 2022 1 commit
  8. 31 Mar, 2022 1 commit
  9. 28 Mar, 2022 2 commits
  10. 19 Feb, 2022 1 commit
  11. 18 Feb, 2022 1 commit
  12. 29 Jan, 2022 1 commit
  13. 19 May, 2021 1 commit
  14. 12 Apr, 2021 1 commit
  15. 02 Apr, 2021 1 commit
  16. 10 Mar, 2021 1 commit
  17. 08 Mar, 2021 1 commit
  18. 02 Feb, 2021 1 commit
  19. 27 Jan, 2021 1 commit
  20. 22 Jan, 2021 1 commit
  21. 21 Jan, 2021 1 commit
  22. 16 Nov, 2020 1 commit
  23. 17 Sep, 2020 1 commit
  24. 16 Jul, 2020 1 commit
    • Jonah Williams's avatar
      [flutter_tools] add feature for iOS, android, and fuchsia (#61481) · 859fce90
      Jonah Williams authored
      Add feature flags for android, ios, and fuchsia (on by default). After updating the g3 rollers, the fuchsia feature will be turned off by default. Creates a simpler base type of feature flags for g3 to extend.
      
      Updates android, ios, fuchsia workflows to use feature flags check.
      Removes concept of stable artifacts and checks on flutter version.
      
      Fixes #58999
      #52859
      #12768
      859fce90
  25. 11 Jul, 2020 1 commit
  26. 23 Jun, 2020 1 commit
  27. 06 May, 2020 1 commit
  28. 06 Jan, 2020 1 commit
  29. 04 Dec, 2019 1 commit
  30. 03 Dec, 2019 4 commits
  31. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  32. 24 Nov, 2019 1 commit
  33. 30 Oct, 2019 1 commit
    • stuartmorgan's avatar
      Split desktop config fallback variable by platform (#43758) · f6f6e86e
      stuartmorgan authored
      The environment variable for all desktop platforms is currently
      ENABLE_FLUTTER_DESKTOP to allow backward compatibility with existing
      workflows. However, this is actually causing issues since 'flutter
      config' provides a better experience (most importantly, IDEs will work
      correctly, which is generally not the case with the environemnt
      variable). Currently people following old (third-patry) instructions
      don't realize that they are missing available functionality, so aren't
      looking for the current instructions.
      
      In adddition, this will be confusing as different platform graduate to
      channels other than master at different times.
      
      To resolve both issues, the environment variable fallback is now
      separate for each desktop platform, and follows a naming scheme
      consistent with the web environment variable.
      f6f6e86e
  34. 24 Sep, 2019 1 commit
  35. 23 Sep, 2019 1 commit
  36. 20 Sep, 2019 1 commit