Unverified Commit da88baff authored by Christopher Fujino's avatar Christopher Fujino Committed by GitHub

[flutter_tools] remove dummy implementation from abstract class .isEnabled() (#96888)

parent ad69dbd7
......@@ -53,7 +53,7 @@ abstract class FeatureFlags {
/// Whether a particular feature is enabled for the current channel.
///
/// Prefer using one of the specific getters above instead of this API.
bool isEnabled(Feature feature) => false;
bool isEnabled(Feature feature);
}
/// All current Flutter feature flags.
......@@ -138,18 +138,21 @@ const Feature flutterWindowsDesktopFeature = Feature(
name: 'beta-quality support for desktop on Windows',
configSetting: 'enable-windows-desktop',
environmentOverride: 'FLUTTER_WINDOWS',
extraHelpText: 'Newer beta versions are available on the beta channel.',
master: FeatureChannelSetting(
available: true,
enabledByDefault: true,
),
dev: FeatureChannelSetting(
available: true,
enabledByDefault: true,
),
beta: FeatureChannelSetting(
available: true,
enabledByDefault: true,
),
stable: FeatureChannelSetting(
available: true,
enabledByDefault: true,
),
);
......
......@@ -107,8 +107,7 @@ void main() {
testWithoutContext('Flutter Windows desktop help string', () {
expect(flutterWindowsDesktopFeature.generateHelpMessage(),
'Enable or disable beta-quality support for desktop on Windows. '
'This setting will take effect on the master, dev, beta, and stable channels. '
'Newer beta versions are available on the beta channel.');
'This setting will take effect on the master, dev, beta, and stable channels.');
});
testWithoutContext('help string on multiple channels', () {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment