Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
da88baff
Unverified
Commit
da88baff
authored
Jan 29, 2022
by
Christopher Fujino
Committed by
GitHub
Jan 29, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] remove dummy implementation from abstract class .isEnabled() (#96888)
parent
ad69dbd7
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
4 deletions
+6
-4
features.dart
packages/flutter_tools/lib/src/features.dart
+5
-2
features_test.dart
packages/flutter_tools/test/general.shard/features_test.dart
+1
-2
No files found.
packages/flutter_tools/lib/src/features.dart
View file @
da88baff
...
...
@@ -53,7 +53,7 @@ abstract class FeatureFlags {
/// Whether a particular feature is enabled for the current channel.
///
/// Prefer using one of the specific getters above instead of this API.
bool
isEnabled
(
Feature
feature
)
=>
false
;
bool
isEnabled
(
Feature
feature
);
}
/// All current Flutter feature flags.
...
...
@@ -138,18 +138,21 @@ const Feature flutterWindowsDesktopFeature = Feature(
name:
'beta-quality support for desktop on Windows'
,
configSetting:
'enable-windows-desktop'
,
environmentOverride:
'FLUTTER_WINDOWS'
,
extraHelpText:
'Newer beta versions are available on the beta channel.'
,
master:
FeatureChannelSetting
(
available:
true
,
enabledByDefault:
true
,
),
dev:
FeatureChannelSetting
(
available:
true
,
enabledByDefault:
true
,
),
beta:
FeatureChannelSetting
(
available:
true
,
enabledByDefault:
true
,
),
stable:
FeatureChannelSetting
(
available:
true
,
enabledByDefault:
true
,
),
);
...
...
packages/flutter_tools/test/general.shard/features_test.dart
View file @
da88baff
...
...
@@ -107,8 +107,7 @@ void main() {
testWithoutContext
(
'Flutter Windows desktop help string'
,
()
{
expect
(
flutterWindowsDesktopFeature
.
generateHelpMessage
(),
'Enable or disable beta-quality support for desktop on Windows. '
'This setting will take effect on the master, dev, beta, and stable channels. '
'Newer beta versions are available on the beta channel.'
);
'This setting will take effect on the master, dev, beta, and stable channels.'
);
});
testWithoutContext
(
'help string on multiple channels'
,
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment