Unverified Commit da88baff authored by Christopher Fujino's avatar Christopher Fujino Committed by GitHub

[flutter_tools] remove dummy implementation from abstract class .isEnabled() (#96888)

parent ad69dbd7
...@@ -53,7 +53,7 @@ abstract class FeatureFlags { ...@@ -53,7 +53,7 @@ abstract class FeatureFlags {
/// Whether a particular feature is enabled for the current channel. /// Whether a particular feature is enabled for the current channel.
/// ///
/// Prefer using one of the specific getters above instead of this API. /// Prefer using one of the specific getters above instead of this API.
bool isEnabled(Feature feature) => false; bool isEnabled(Feature feature);
} }
/// All current Flutter feature flags. /// All current Flutter feature flags.
...@@ -138,18 +138,21 @@ const Feature flutterWindowsDesktopFeature = Feature( ...@@ -138,18 +138,21 @@ const Feature flutterWindowsDesktopFeature = Feature(
name: 'beta-quality support for desktop on Windows', name: 'beta-quality support for desktop on Windows',
configSetting: 'enable-windows-desktop', configSetting: 'enable-windows-desktop',
environmentOverride: 'FLUTTER_WINDOWS', environmentOverride: 'FLUTTER_WINDOWS',
extraHelpText: 'Newer beta versions are available on the beta channel.',
master: FeatureChannelSetting( master: FeatureChannelSetting(
available: true, available: true,
enabledByDefault: true,
), ),
dev: FeatureChannelSetting( dev: FeatureChannelSetting(
available: true, available: true,
enabledByDefault: true,
), ),
beta: FeatureChannelSetting( beta: FeatureChannelSetting(
available: true, available: true,
enabledByDefault: true,
), ),
stable: FeatureChannelSetting( stable: FeatureChannelSetting(
available: true, available: true,
enabledByDefault: true,
), ),
); );
......
...@@ -107,8 +107,7 @@ void main() { ...@@ -107,8 +107,7 @@ void main() {
testWithoutContext('Flutter Windows desktop help string', () { testWithoutContext('Flutter Windows desktop help string', () {
expect(flutterWindowsDesktopFeature.generateHelpMessage(), expect(flutterWindowsDesktopFeature.generateHelpMessage(),
'Enable or disable beta-quality support for desktop on Windows. ' 'Enable or disable beta-quality support for desktop on Windows. '
'This setting will take effect on the master, dev, beta, and stable channels. ' 'This setting will take effect on the master, dev, beta, and stable channels.');
'Newer beta versions are available on the beta channel.');
}); });
testWithoutContext('help string on multiple channels', () { testWithoutContext('help string on multiple channels', () {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment