Commits · 53cba8fd49309e7b6189677d67d4e29061ba2db6 · abdullh.alsoleman / Front-End

26 Apr, 2023 2 commits

Add hostonly web compile size benchmarks (#125518) · 53cba8fd
Zachary Anderson authored Apr 26, 2023
```
First part of https://github.com/flutter/flutter/issues/125492
```
53cba8fd

Roll Flutter Engine from 34ece7a4abac to b3cbf0678487 (6 revisions) (#125529) · 062f6c1d

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/34ece7a4abac...b3cbf0678487

2023-04-25 godofredoc@google.com Migrate windows host engine to engine v2. (flutter/engine#41487)
2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from f6f0c4b5ee98 to 809bf518d4ab (3 revisions) (flutter/engine#41494)
2023-04-25 30870216+gaaclarke@users.noreply.github.com Made sure not to turn on wide gamut support without impeller. (flutter/engine#41460)
2023-04-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 5bc9_eyVcLoMrWvdO... to JKHSUjf-qEr0ZMdEi... (flutter/engine#41493)
2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 1bed4228ea3b to f6f0c4b5ee98 (7 revisions) (flutter/engine#41492)
2023-04-25 30870216+gaaclarke@users.noreply.github.com [Impeller] Fixed blit command missing tracking and added mock vulkan for tests (flutter/engine#41408)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 5bc9_eyVcLoM to JKHSUjf-qEr0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

062f6c1d

25 Apr, 2023 19 commits

Handle dollar signs properly when generating localizations (#125514) · 8be335f2

Tae Hyung Kim authored Apr 25, 2023

Currently, the code doesn't properly handle strings which contain dollar signs. The return expression for the generated localization function is computed by `generateReturnExpr` which concatenates several strings, which are either interpolated placeholders, interpolated function calls, or normal strings, but we didn't properly escape dollar signs before sending normal strings to `generateReturnExpr`.

Fixes #125461.

8be335f2

Roll Flutter Engine from 6d798393a15a to 34ece7a4abac (1 revision) (#125516) · 9a28f56e

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/6d798393a15a...34ece7a4abac

2023-04-25 godofredoc@google.com Double zip FlutterMacOS.dSYM.zip. (flutter/engine#41425)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9a28f56e

Roll Flutter Engine from 469e5b409686 to 6d798393a15a (2 revisions) (#125513) · 426e32fa

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/469e5b409686...6d798393a15a

2023-04-25 flar@google.com hide DisplayList::DisposeOps and other lint suggestions (flutter/engine#41464)
2023-04-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 170137fc759b to f9d4d255c6e7 (1 revision) (flutter/engine#41486)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

426e32fa

Adds selected semantics flag to radio button for Apple devices (#125499) · ef82f97f

chunhtai authored Apr 25, 2023

fixes https://github.com/flutter/flutter/issues/125495

The iOS will announce 'Selected, \<label\>, button' for selected radio button after this change

ef82f97f

Roll Flutter Engine from 0e236982086b to 469e5b409686 (1 revision) (#125510) · 9bf2cd3c

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/0e236982086b...469e5b409686

2023-04-25 58529443+srujzs@users.noreply.github.com Remove package:js references and move to dart:js_interop (flutter/engine#41212)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9bf2cd3c

Relabel JSFunction as JSExportedDartFunction (#125453) · 829a2d07

Srujan Gaddam authored Apr 25, 2023

toDart exists on the latter, not the former.

Fixing https://github.com/flutter/flutter/pull/125220.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

829a2d07

Roll Flutter Engine from 60c4e61416cd to 0e236982086b (2 revisions) (#125504) · 4dddac97

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/60c4e61416cd...0e236982086b

2023-04-25 linxunfeng@yeah.net [ios] Fix hold and drag spacebar does not move cursor when obscureText is true. (flutter/engine#40216)
2023-04-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 337365e42613 to 170137fc759b (2 revisions) (flutter/engine#41483)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4dddac97

iOS TextField spell check style (#125432) · 85ec8742

Justin McCandless authored Apr 25, 2023

When using a Material TextField on iOS, the spell check selection style now defaults to the red iOS-style, not Android's blue.

85ec8742

Roll Flutter Engine from 308bce499087 to 60c4e61416cd (1 revision) (#125490) · 8cd11e91

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/308bce499087...60c4e61416cd

2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from c44f06399619 to 1bed4228ea3b (1 revision) (flutter/engine#41482)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8cd11e91

Roll Flutter Engine from 54ddef68b124 to 308bce499087 (1 revision) (#125485) · 932faedc

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/54ddef68b124...308bce499087

2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 7a0879961df5 to c44f06399619 (1 revision) (flutter/engine#41479)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

932faedc

Roll Flutter Engine from 307416f43b5a to 54ddef68b124 (1 revision) (#125481) · aad9fd2d

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/307416f43b5a...54ddef68b124

2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 571074c14049 to 7a0879961df5 (1 revision) (flutter/engine#41478)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

aad9fd2d

Roll Flutter Engine from 232810b36671 to 307416f43b5a (1 revision) (#125475) · 160ecade

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/232810b36671...307416f43b5a

2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 9b1b2a5dd899 to 571074c14049 (1 revision) (flutter/engine#41476)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

160ecade

Roll Flutter Engine from 1c4b6c0cb862 to 232810b36671 (2 revisions) (#125472) · 2afa98ed

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/1c4b6c0cb862...232810b36671

2023-04-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c3afc3507b4f to 337365e42613 (1 revision) (flutter/engine#41475)
2023-04-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8TJtGsJTpIHk5-Ss5... to xfKYQ2vkoLvxhBHIf... (flutter/engine#41474)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 8TJtGsJTpIHk to xfKYQ2vkoLvx

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2afa98ed

Roll Flutter Engine from a26a479e86b3 to 1c4b6c0cb862 (1 revision) (#125463) · 5903a8cf

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/a26a479e86b3...1c4b6c0cb862

2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 2c0f33c7ec04 to 9b1b2a5dd899 (2 revisions) (flutter/engine#41473)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5903a8cf

Fix `SliverAppBar.medium` & `SliverAppBar.large` text scale (#125038) · 6e1d4f9f

Taha Tesser authored Apr 25, 2023

fixes https://github.com/flutter/flutter/issues/114340

<details> 
<summary>code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [SliverAppBar.medium].

void main() {
  runApp(const AppBarMediumApp());
}

class AppBarMediumApp extends StatelessWidget {
  const AppBarMediumApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        useMaterial3: true,
      ),
      home: MediaQuery(
        data: MediaQuery.of(context).copyWith(textScaleFactor: 3.0),
        child: Material(
          child: CustomScrollView(
            slivers: <Widget>[
              SliverAppBar.medium(
                leading:
                    IconButton(icon: const Icon(Icons.menu), onPressed: () {}),
                title: const Text('Medium App Bar'),
                actions: <Widget>[
                  IconButton(icon: const Icon(Icons.more_vert), onPressed: () {}),
                ],
              ),
              // SliverAppBar.large(
              //   leading:
              //       IconButton(icon: const Icon(Icons.menu), onPressed: () {}),
              //   title: const Text('Large App Bar'),
              //   actions: <Widget>[
              //     IconButton(
              //         icon: const Icon(Icons.more_vert), onPressed: () {}),
              //   ],
              // ),
              // Just some content big enough to have something to scroll.
              SliverToBoxAdapter(
                child: Card(
                  child: SizedBox(
                    height: 1200,
                    child: Padding(
                      padding: const EdgeInsets.fromLTRB(8, 100, 8, 100),
                      child: Text(
                        'Here be scrolling content...',
                        style: Theme.of(context).textTheme.headlineSmall,
                      ),
                    ),
                  ),
                ),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

``` 
	
</details>

### Before
|  Medium App Bar - `textScaleFactor: 3.0` |   Large App Bar - `textScaleFactor.30` |
| --------------- | --------------- |
| <img src="https://user-images.githubusercontent.com/48603081/232815191-ab42523b-d710-4c93-a889-e9c92ca472c8.png" height="450" /> | <img src="https://user-images.githubusercontent.com/48603081/232815232-104c208d-f1dd-404e-9218-5dfb61244d56.png" height="450" /> |

### After
|  Medium App Bar - `textScaleFactor: 3.0` |   Large App Bar - `textScaleFactor.30` |
| --------------- | --------------- |
| <img src="https://user-images.githubusercontent.com/48603081/232815733-8b8af94f-197f-427a-bbb9-bc6cd0173658.png" height="450" /> | <img src="https://user-images.githubusercontent.com/48603081/232815758-2c336d14-085b-4e91-8b93-748a40822ea6.png" height="450" /> |

6e1d4f9f

Roll Flutter Engine from 3f4116c225e8 to a26a479e86b3 (1 revision) (#125459) · 8395a2b2

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/3f4116c225e8...a26a479e86b3

2023-04-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gxpKJcSBfY7AuR_Ur... to 5bc9_eyVcLoMrWvdO... (flutter/engine#41471)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from gxpKJcSBfY7A to 5bc9_eyVcLoM

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8395a2b2

Roll Flutter Engine from 64882f4b7371 to 3f4116c225e8 (2 revisions) (#125458) · 597cc8f9

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/64882f4b7371...3f4116c225e8

2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 8822608fcb4d to 2c0f33c7ec04 (1 revision) (flutter/engine#41470)
2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 5f4dd36a69f9 to 8822608fcb4d (2 revisions) (flutter/engine#41469)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

597cc8f9

Roll Flutter Engine from 8fe8e94c02fc to 64882f4b7371 (1 revision) (#125454) · 5817ed47

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/8fe8e94c02fc...64882f4b7371

2023-04-25 godofredoc@google.com [Cleanup] remove type=local from local test/generators. (flutter/engine#41465)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5817ed47

Roll Flutter Engine from 5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (#125452) · d23dba22

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/5fbde6c0fc57...8fe8e94c02fc

2023-04-25 jonahwilliams@google.com Revert "[impeller] convert src over to src for solid color" (flutter/engine#41466)
2023-04-24 godofredoc@google.com Remove empty tests properties. (flutter/engine#41461)
2023-04-24 skia-flutter-autoroll@skia.org Roll Skia from 0ec4c84abd0b to 5f4dd36a69f9 (21 revisions) (flutter/engine#41462)
2023-04-24 godofredoc@google.com Reland "Upload windows arm artifacts to production bucket." (flutter/engine#41409)
2023-04-24 skia-flutter-autoroll@skia.org Roll Dart SDK from c7042dc03f43 to c3afc3507b4f (1 revision) (flutter/engine#41458)
2023-04-24 54558023+keyonghan@users.noreply.github.com Add 16.2 runtime to Mac unopt (flutter/engine#41456)
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from EEdHfWcEn3fHwQj46... to gxpKJcSBfY7AuR_Ur... (flutter/engine#41453)
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fJ7ysM-O4VYAGeBDc... to 8TJtGsJTpIHk5-Ss5... (flutter/engine#41451)
2023-04-24 skia-flutter-autoroll@skia.org Roll Dart SDK from a1c1e0d3bb18 to c7042dc03f43 (2 revisions) (flutter/engine#41452)
2023-04-24 skia-flutter-autoroll@skia.org Roll Skia from 1f84e5060646 to 0ec4c84abd0b (6 revisions) (flutter/engine#41449)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fJ7ysM-O4VYA to 8TJtGsJTpIHk
fuchsia/sdk/core/mac-amd64 from EEdHfWcEn3fH to gxpKJcSBfY7A

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d23dba22

24 Apr, 2023 17 commits

Add Sliders to `macrobenchmarks` (#125296) · 457e98a1

Taha Tesser authored Apr 24, 2023

This adds a performance test for `Slider` and `RangeSlider` to run on Android.
This is to measure upcoming changes to these widgets and compare their performance.

https://user-images.githubusercontent.com/48603081/233633349-0bcad3c3-04a9-42dd-acd0-46b76ce51178.mp4

457e98a1

[date_picker] [date_range_picker] add properties to change switch-to icons (#124881) · 9525934e
Tirth authored Apr 24, 2023

9525934e
Sliver Constrained Cross Axis (#125239) · 482d1aaf
Tae Hyung Kim authored Apr 24, 2023
```
Reimplements what we reverted here: #125233.
```
482d1aaf
tool: Move cdKey to CustomDimensionsEnum (#125335) · 7d9f2082
Kevin Moore authored Apr 24, 2023

7d9f2082

Add `borderRadius` to LinearProgressIndicator (#123517) · 9e9ac77d

Bernardo Ferrari authored Apr 24, 2023

Split from https://github.com/flutter/flutter/pull/122664 so it gets easier to review, as this is now unrelated to the `preferRound`. I'm one step from adding a width attribute, lol.

<img width="474" alt="image" src="https://user-images.githubusercontent.com/351125/226083798-71e529e9-4ae9-41de-a500-0412b989a273.png">

cc @Piinks

9e9ac77d

Fix JS types in _test_http_request.dart (#125220) · aa5bb7d9

Srujan Gaddam authored Apr 24, 2023

Types are being reified in the JS backends, so these need to be
addressed. Fixes two issues:

- @staticInterop types need to be casted to JS types
- JS functions need to be cast to JSFunction before conversion

Enables landing of https://dart-review.googlesource.com/c/sdk/+/295105.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

aa5bb7d9

Fix `OutlinedButton`, `TextButton`, and `IconButton` throw exception when... · 38c7c2fe

Taha Tesser authored Apr 24, 2023

Fix `OutlinedButton`, `TextButton`, and `IconButton`  throw exception when passing only one cursor to `styleFrom` (#125204)

fixes https://github.com/flutter/flutter/issues/118071

38c7c2fe

Swap some iOS TESTOWNERS (#125340) · b7332ef1

Jenn Magder authored Apr 24, 2023

Temporarily remove myself from `TESTOWNER` and reassign to others. Please let me know if you'd rather not "own" these and I'll find someone else ð. I intend to take these back later.

Plugins -> @stuartmorgan
iOS-specific tooling -> @vashworth
Benchmark and app extension test -> @cyanglaz
iOS artifact checking -> @christopherfujino

b7332ef1

Fix iOS touch drag behavior (#125169) · 1a51dc21

Renzo Olivares authored Apr 24, 2023

Before this change on a quick touch drag the cursor, where the touch is not on the previous collapsed selection, the cursor would move to the tapped position.

After this change on a quick touch drag the cursor does not move unless the touch is on the previously collapsed selection. This is inline with native behavior.

Before|After|Native
--|--|--
<video src="https://user-images.githubusercontent.com/948037/233224775-f33b42b5-5638-416c-9278-39ecd964e3bb.mov" />|<video src="https://user-images.githubusercontent.com/948037/233224760-2d1af657-8d99-45fc-8499-9567f17d533e.mov" />|<video src="https://user-images.githubusercontent.com/948037/233224790-f5997cfa-7370-4891-8952-11ef8057a729.mov" />

1a51dc21

Mark module_test_ios flaky (#125426) · 624bdd38
keyonghan authored Apr 24, 2023
```
https://github.com/flutter/flutter/issues/125425
```
624bdd38

Implement url support for RouteInformation and didPushRouteInformation (#119968) · 3b4ac4d5

chunhtai authored Apr 24, 2023

Related https://github.com/flutter/flutter/issues/100624

The goal is to make sure the engine can send a location string in either the existing format or a complete uri string to the framework, and the framework will still work as usual.

3b4ac4d5

[tool,web] Include more info URI on Wasm init failure (#125312) · 034adb66
Kevin Moore authored Apr 24, 2023

034adb66
Do not run `windows_home_scroll_perf__timeline_summary` benchmark in presubmit (#125343) · 9e2e64c7
Jenn Magder authored Apr 24, 2023
```
Introduced in https://github.com/flutter/flutter/pull/99564.  Checked with @jonahwilliams and this should not be running in presubmit.
```
9e2e64c7

Tiny fix doc pointing to incorrect widget confusing the readers (#125394) · c1e41b43

fzyzcjy authored Apr 24, 2023

Just a one-word super tiny change, which I encounter today when playing with RawGestureDetector :)

The original doc says:

> For common gestures, use a [GestureRecognizer](https://api.flutter.dev/flutter/gestures/GestureRecognizer-class.html). [RawGestureDetector](https://api.flutter.dev/flutter/widgets/RawGestureDetector-class.html) is useful primarily when developing your own gesture recognizers.

However, for "common gestures", IMHO the doc wants to say `GestureDetector` (because that one has easy-to-use onTap, onLongPress etc). On the other hand, GestureRecognizer should be used together with RawGestureDetector and is a quite low-level thing, and for common gestures people seldom use it. So I guess here it is a typo.

c1e41b43

Fix the position of the Android-style spell check toolbar (#124897) · 98aaf00a
Justin McCandless authored Apr 24, 2023
```
The spell check menu now appears directly below the misspelled word on Android.
```
98aaf00a

Roll Flutter Engine from fcf46af2d38c to 5fbde6c0fc57 (4 revisions) (#125410) · 3ab8cd26

engine-flutter-autoroll authored Apr 24, 2023

https://github.com/flutter/engine/compare/fcf46af2d38c...5fbde6c0fc57

2023-04-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-python from 4.5.0 to 4.6.0 (flutter/engine#41444)
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kZQW1hC63MessR4gl... to EEdHfWcEn3fHwQj46... (flutter/engine#41441)
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1RnHwa4NRXqe4iS6H... to fJ7ysM-O4VYAGeBDc... (flutter/engine#41440)
2023-04-23 skia-flutter-autoroll@skia.org Roll Skia from b9c90858cdd8 to 1f84e5060646 (1 revision) (flutter/engine#41432)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 1RnHwa4NRXqe to fJ7ysM-O4VYA
fuchsia/sdk/core/mac-amd64 from kZQW1hC63Mes to EEdHfWcEn3fH

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3ab8cd26

[Process] Update cherry-pick template assignees (#125402) · a00babf4

Kevin Chisholm authored Apr 24, 2023

Updates the cherry-pick template to add @itsjustkevin as primary and
@CaseyHillers as secondary assignees to all cherry-pick requests.

a00babf4

23 Apr, 2023 2 commits

Roll Flutter Engine from 0e329d5e2196 to fcf46af2d38c (1 revision) (#125384) · 60077ff9

engine-flutter-autoroll authored Apr 23, 2023

https://github.com/flutter/engine/compare/0e329d5e2196...fcf46af2d38c

2023-04-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from KWUhrqWF9DaVpikxZ... to kZQW1hC63MessR4gl... (flutter/engine#41430)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from KWUhrqWF9DaV to kZQW1hC63Mes

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

60077ff9

Roll Flutter Engine from f364492e2010 to 0e329d5e2196 (1 revision) (#125381) · e4b2a5ab

engine-flutter-autoroll authored Apr 23, 2023

https://github.com/flutter/engine/compare/f364492e2010...0e329d5e2196

2023-04-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from I9z-K7N5PdhXN-5SG... to 1RnHwa4NRXqe4iS6H... (flutter/engine#41428)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from I9z-K7N5PdhX to 1RnHwa4NRXqe

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e4b2a5ab