- 12 Dec, 2023 1 commit
-
-
Christopher Fujino authored
Fixes https://github.com/flutter/flutter/issues/139709 This adds a static helper method `ProcessUtils.writelnToStdinGuarded()`, which will asynchronously write to a sub-process's STDIN `IOSink` and catch errors. In talking with Brian, it sounds like this is the best and most reliable way to catch `SocketException`s during these writes *to sub-process file descriptors* specifically (with a "real" hard drive file, the future returned by `.flush()` should complete with the write error). Also, as I note in the dartdoc to `writelnToStdinGuarded()`, the behavior seems to be different between macOS and linux. Moving forward, in any place where we want to catch exceptions writing to STDIN, we will want to use this new helper.
-
- 05 Sep, 2023 1 commit
-
-
Victoria Ashworth authored
Sometimes `ios-deploy` loses connection to the device after installing, starting debugserver, and launching. This is shown with an error message like: ``` Process 579 exited with status = -1 (0xffffffff) lost connection ``` This happens frequently in our CI system: https://github.com/flutter/flutter/issues/120808 Usually in CI, on retry it'll work and pass - so this is an attempt to retry without failing the test first. It's not guaranteed to fix since we're unable to recreate this error locally.
-
- 07 Jul, 2023 1 commit
-
-
Victoria Ashworth authored
Adding debugging for https://github.com/flutter/flutter/issues/129836. Takes a screenshot when startup test takes too long (10 minutes). Also, removes some old debugging and add new debugging message.
-
- 26 May, 2023 1 commit
-
-
Victoria Ashworth authored
This reverts commit a19b3436. We added this logging to try and determine if the reason for Dart VM errors (https://github.com/flutter/flutter/issues/121231) was caused by some issue with the streams. A recent test proves that is not the case: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20platform_view_ios__start_up/11046/overview The test shows the Dart VM url in the device log. However, the test log does NOT show a log for the Dart VM url but does show the stack trace, which all come from the main stream, which means it's not an issue with the secondary streams not receiving the log. So reverting the debugging we added.
-
- 24 May, 2023 1 commit
-
-
Victoria Ashworth authored
Reland https://github.com/flutter/flutter/pull/127222 that was reverted in https://github.com/flutter/flutter/pull/127405. Fixed `Mac_ios microbenchmarks_ios` test failure by not echoing logs twice.
-
- 23 May, 2023 2 commits
-
-
Victoria Ashworth authored
Reverts flutter/flutter#127222
-
Victoria Ashworth authored
Log all output of `ios-deploy` to try and determine if the issue of https://github.com/flutter/flutter/issues/121231 is with stream or with `ios-deploy`. Note: This will cause some duplicate logs like example below but only in verbose mode ``` (lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend. (lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend. 2023-05-19 13:48:19.156866-0500 Runner[2521:390612] flutter: The Dart VM service is listening on http://127.0.0.1:63508/IsFnhXJykCM=/ VM Service URL on device: http://127.0.0.1:63508/IsFnhXJykCM=/ ```
-
- 19 May, 2023 1 commit
-
-
Victoria Ashworth authored
When tests run in our CI using `flutter drive`, if there is a failure it will loop and try again. https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/drive/drive_service.dart#L177-L186 However, it's using the same `device` instance for each iteration. So what was happening was when it would fail to launch, it would tell its listeners that it was cancelled. https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/ios/ios_deploy.dart#L486-L489 Then when the next iteration started, the `vmServiceDiscovery` would immediately return with null because the `deviceLogReader` would be cached from the previous iteration and would already be cancelled. Therefore, bypassing and cancelling the timer. https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/ios/devices.dart#L585-L591 https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/ios/devices.dart#L627 In addition, it seems like sometimes the stop would fail and therefore the the drain would never get the signal that it was done and therefore would hang forever. There was no indication that the stop had failed though because the logs were going to the stream that had no listeners since `deviceLogReader` was already cancelled. https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/ios/ios_deploy.dart#L563-L576 Fixes https://github.com/flutter/flutter/issues/127141
-
- 15 May, 2023 1 commit
-
-
Victoria Ashworth authored
Check what is available in the device's iOS DeviceSupport folder to check if symbols were properly fetched. Also, add some logging to track what status the debugger is in. Debugging for https://github.com/flutter/flutter/issues/121231.
-
- 15 Mar, 2023 1 commit
-
-
Victoria Ashworth authored
Separate attached and wireless devices
-
- 06 Feb, 2023 1 commit
-
-
林洵锋 authored
* Fix flutter_tools stuck when using custom LLDB prompt * Remove trailing space character * Fix local variable name * Add comment * Remove trailing space character * Update packages/flutter_tools/lib/src/ios/ios_deploy.dart Co-authored-by: Jenn Magder <magder@google.com> * Update packages/flutter_tools/lib/src/ios/ios_deploy.dart Co-authored-by: Jenn Magder <magder@google.com> * Remove trailing space character --------- Co-authored-by: Jenn Magder <magder@google.com>
-
- 26 Jul, 2022 1 commit
-
-
Jenn Magder authored
-
- 07 May, 2022 2 commits
-
-
Christopher Fujino authored
-
Jenn Magder authored
-
- 12 Apr, 2022 3 commits
-
-
Christopher Fujino authored
-
Christopher Fujino authored
This reverts commit 2978b59b.
-
Christopher Fujino authored
-
- 17 Mar, 2022 1 commit
-
-
Christopher Fujino authored
-
- 25 Feb, 2022 1 commit
-
-
Jenn Magder authored
-
- 16 Feb, 2022 1 commit
-
-
Jenn Magder authored
-
- 15 Feb, 2022 1 commit
-
-
Ben Konyi authored
* Update flutter_tools to look for new VM service message The Dart SDK will soon move away from the current Observatory message: "Observatory listening on ..." To a new message that no longer references Observatory: "Dart VM Service listening on ..." This change updates all tests with mocks to check for the new message and also adds support for the new message in ProtocolDiscovery. See https://github.com/dart-lang/sdk/issues/46756 * Fix some parsing locations * Fix analysis failures * Update message * Remove extra comment * Update message * Add globals prefix
-
- 10 Sep, 2021 1 commit
-
-
Jenn Magder authored
-
- 16 Aug, 2021 1 commit
-
-
Jenn Magder authored
-
- 23 Apr, 2021 1 commit
-
-
Jonah Williams authored
-
- 10 Mar, 2021 1 commit
-
-
Jenn Magder authored
-
- 08 Feb, 2021 1 commit
-
-
Jonah Williams authored
This reverts commit 8b6baae4.
-
- 04 Feb, 2021 1 commit
-
-
Jonah Williams authored
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
-
- 27 Jan, 2021 1 commit
-
-
Jonah Williams authored
* opt out the flutter tool * oops EOF * fix import * Update tool_backend.dart * Update daemon_client.dart * fix more
-
- 23 Oct, 2020 1 commit
-
-
Jenn Magder authored
-
- 16 Oct, 2020 1 commit
-
-
Jenn Magder authored
-
- 14 Oct, 2020 1 commit
-
-
Jenn Magder authored
-
- 13 Oct, 2020 1 commit
-
-
Jenn Magder authored
-
- 12 Oct, 2020 4 commits
-
-
Jonah Williams authored
Revert "[flutter_tools] reland: fold process resolution logic into the flutter tool (#67957)" (#67968) This reverts commit bd813879.
-
Jonah Williams authored
Reland of #67669 The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. So that we can adjust/modify this logic, fold it into flutter and add some additional logging. caches the resolved executable per target directory, to avoid repeated look ups. Instead of throwing an argument error, attempts to run the executable as given if an exact path can't be found Accept files or symlinks for the executable path. user where/which to resolve path instead of package:process logic.
-
Jonah Williams authored
This reverts commit 10c78c26.
-
Jonah Williams authored
The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. Fold the resolution logic into the tool and use where/which instead of the package:process specific logic.
-
- 23 Sep, 2020 1 commit
-
-
Jenn Magder authored
-
- 22 Sep, 2020 3 commits
-
-
Jenn Magder authored
This reverts commit 2be4570d.
-
Jenn Magder authored
-
Jenn Magder authored
This reverts commit 5c858036.
-