- 19 Jan, 2024 1 commit
-
-
Ian Hickson authored
Revert "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#140101)" (#141814) Reverts https://github.com/flutter/flutter/pull/140101 That PR somehow made non-matching gold tests not fail at HEAD. Fixes https://github.com/flutter/flutter/issues/141880 - Blocked by https://github.com/flutter/flutter/issues/140169 - https://github.com/flutter/flutter/pull/141427
-
- 21 Dec, 2023 1 commit
-
-
Ian Hickson authored
Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#140101) Originally landed in https://github.com/flutter/flutter/pull/139549 Originally reverted in https://github.com/flutter/flutter/pull/140085 - Remove all use of global variables. - Always pass in all dependencies, only create them in main or in tests. - Pass in the "print" primitive. - Make all network traffic retry (except when run locally, when it just auto-passes). - Enable tests to be run in random order. - Better error messages
-
- 13 Dec, 2023 2 commits
-
-
auto-submit[bot] authored
Reverts "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal" (#140085) Reverts flutter/flutter#139549 Initiated by: Piinks This change reverts the following previous change: Original Description: * Remove all use of global variables. * Always pass in all dependencies, only create them in main or in tests. * Pass in the "print" primitive. * Make all network traffic retry (except when run locally, when it just auto-passes). * Enable tests to be run in random order.
-
Ian Hickson authored
Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#139549) * Remove all use of global variables. * Always pass in all dependencies, only create them in main or in tests. * Pass in the "print" primitive. * Make all network traffic retry (except when run locally, when it just auto-passes). * Enable tests to be run in random order.
-
- 07 Dec, 2023 1 commit
-
-
Kate Lovett authored
Part of fixing https://github.com/flutter/flutter/issues/139673, it will need to be cherry picked into the stable branch to fully resolve. Originally I tried to come at this from `ci.yaml`, but the syntax does not exist to either conditionally include a dependency based on the branch we are on, or to disable a shard for a given branch (as opposed to enabling it which is supported). I could double every CI shard that uses Gold to try to serve my purpose, but it is already a very large and cumbersome file to keep up to date. Doubling it does not feel like the best solution. Using a RegEx is not my favorite, but I am using the same one we use in our CI, and left a note there to update it if it should ever change. Since there is already a whole infra built around it, I feel it is pretty safe so we can fix the stable tree. We already had mitigated Gold affecting release branches in the past through flutter/cocoon (https://github.com/flutter/flutter/issues/58814), but https://github.com/flutter/flutter/issues/139673 exposed a rather rare edge case. A change was CP'd into the stable branch that introduced golden file image changes. Typically this would not cause an issue since any change that has landed on the master branch has golden files accounted for. In this case, the CP'd change on master has generated a different image on canvaskit due to another change that was not on stable. So when the CP landed, it generated a new image Gold had never seen before. Gold only tracks the master branch, so we cannot approve the image, and so cannot fix the stable tree. This would disable the failing check on release branches and fix the tree.
-
- 08 Nov, 2022 2 commits
-
-
Zachary Anderson authored
This reverts commit 53e68762.
-
Kate Lovett authored
* allow marking a golden check as flaky * add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib * Pause * ++ * ++ * Analyzer therapy * Once more with feeling * Nits * Review feedback * Silly oops * Test progress * More tests * Finish * Nits * Analyzer * Review feedback Co-authored-by: Yegor Jbanov <yjbanov@google.com>
-
- 04 Aug, 2022 1 commit
-
-
Kate Lovett authored
-
- 08 Jun, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 25 May, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 29 Apr, 2022 1 commit
-
-
Yegor authored
-
- 27 Apr, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Apr, 2022 1 commit
-
-
Kate Lovett authored
-
- 22 Mar, 2022 1 commit
-
-
Kate Lovett authored
-
- 17 Mar, 2022 2 commits
-
-
Kate Lovett authored
-
Kate Lovett authored
-
- 04 Mar, 2022 1 commit
-
-
Viren Khatri authored
-
- 03 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 25 Feb, 2022 1 commit
-
-
Kate Lovett authored
-
- 24 Feb, 2022 2 commits
-
-
Harry Terkelsen authored
This reverts commit ee86e61f.
-
Kate Lovett authored
-
- 11 Dec, 2021 1 commit
-
-
Kate Lovett authored
-
- 01 Dec, 2021 1 commit
-
-
Chris Wong authored
-
- 15 Nov, 2021 1 commit
-
-
Kate Lovett authored
-
- 11 Nov, 2021 1 commit
-
-
Alexander Dahlberg authored
-
- 11 Oct, 2021 1 commit
-
-
Ian Hickson authored
-
- 07 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Mouad Debbar authored
This reverts commit cb378edc.
-
Ian Hickson authored
-
- 16 Sep, 2021 1 commit
-
-
Kate Lovett authored
-
- 14 Sep, 2021 1 commit
-
-
Kate Lovett authored
-
- 27 Jul, 2021 1 commit
-
-
Greg Spencer authored
* Randomize tests, exclude tests that fail with randomization. * Disable some more tool tests
-
- 07 May, 2021 1 commit
-
-
Kate Lovett authored
-
- 02 Apr, 2021 1 commit
-
-
Sam Rawlins authored
-
- 04 Mar, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 16 Feb, 2021 1 commit
-
-
Jonah Williams authored
-
- 28 Jan, 2021 1 commit
-
-
Kate Lovett authored
-
- 27 Jan, 2021 1 commit
-
-
Dan Field authored
-
- 08 Oct, 2020 1 commit
-
-
Kate Lovett authored
-
- 19 Sep, 2020 1 commit
-
-
Kate Lovett authored
-