1. 19 Jan, 2024 1 commit
  2. 21 Dec, 2023 1 commit
  3. 13 Dec, 2023 2 commits
    • auto-submit[bot]'s avatar
      Reverts "Make tests more resilient to Skia gold failures and refactor... · 91877c63
      auto-submit[bot] authored
      Reverts "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal" (#140085)
      
      Reverts flutter/flutter#139549
      Initiated by: Piinks
      This change reverts the following previous change:
      Original Description:
      * Remove all use of global variables.
      * Always pass in all dependencies, only create them in main or in tests.
      * Pass in the "print" primitive.
      * Make all network traffic retry (except when run locally, when it just auto-passes).
      * Enable tests to be run in random order.
      91877c63
    • Ian Hickson's avatar
      Make tests more resilient to Skia gold failures and refactor flutter_goldens... · 11a9cb70
      Ian Hickson authored
      Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#139549)
      
      * Remove all use of global variables.
      * Always pass in all dependencies, only create them in main or in tests.
      * Pass in the "print" primitive.
      * Make all network traffic retry (except when run locally, when it just auto-passes).
      * Enable tests to be run in random order.
      11a9cb70
  4. 07 Dec, 2023 1 commit
    • Kate Lovett's avatar
      Don't send images to Gold on release branches (#139706) · 91ea024c
      Kate Lovett authored
      Part of fixing https://github.com/flutter/flutter/issues/139673, it will need to be cherry picked into the stable branch to fully resolve.
      
      Originally I tried to come at this from `ci.yaml`, but the syntax does not exist to either conditionally include a dependency based on the branch we are on, or to disable a shard for a given branch (as opposed to enabling it which is supported). I could double every CI shard that uses Gold to try to serve my purpose, but it is already a very large and cumbersome file to keep up to date. Doubling it does not feel like the best solution. Using a RegEx is not my favorite, but I am using the same one we use in our CI, and left a note there to update it if it should ever change. Since there is already a whole infra built around it, I feel it is pretty safe so we can fix the stable tree.
      
      We already had mitigated Gold affecting release branches in the past through flutter/cocoon (https://github.com/flutter/flutter/issues/58814), but https://github.com/flutter/flutter/issues/139673 exposed a rather rare edge case. A change was CP'd into the stable branch that introduced golden file image changes. Typically this would not cause an issue since any change that has landed on the master branch has golden files accounted for. In this case, the CP'd change on master has generated a different image on canvaskit due to another change that was not on stable. So when the CP landed, it generated a new image Gold had never seen before. Gold only tracks the master branch, so we cannot approve the image, and so cannot fix the stable tree.
      
      This would disable the failing check on release branches and fix the tree.
      91ea024c
  5. 08 Nov, 2022 2 commits
  6. 04 Aug, 2022 1 commit
  7. 08 Jun, 2022 1 commit
  8. 25 May, 2022 1 commit
  9. 29 Apr, 2022 1 commit
  10. 27 Apr, 2022 1 commit
  11. 07 Apr, 2022 1 commit
  12. 22 Mar, 2022 1 commit
  13. 17 Mar, 2022 2 commits
  14. 04 Mar, 2022 1 commit
  15. 03 Mar, 2022 1 commit
  16. 25 Feb, 2022 1 commit
  17. 24 Feb, 2022 2 commits
  18. 11 Dec, 2021 1 commit
  19. 01 Dec, 2021 1 commit
  20. 15 Nov, 2021 1 commit
  21. 11 Nov, 2021 1 commit
  22. 11 Oct, 2021 1 commit
  23. 07 Oct, 2021 3 commits
  24. 16 Sep, 2021 1 commit
  25. 14 Sep, 2021 1 commit
  26. 27 Jul, 2021 1 commit
  27. 07 May, 2021 1 commit
  28. 02 Apr, 2021 1 commit
  29. 04 Mar, 2021 1 commit
  30. 16 Feb, 2021 1 commit
  31. 28 Jan, 2021 1 commit
  32. 27 Jan, 2021 1 commit
  33. 08 Oct, 2020 1 commit
  34. 19 Sep, 2020 1 commit