Skip to content

F
Front-End
Unverified Commit 2386fd90 authored by Kate Lovett's avatar Kate Lovett Committed by GitHub
Browse files
Options

Disable post-submit Gold failures entirely (#100332)

parent 7f84c550
Hide whitespace changes
Inline Side-by-side
Showing with 52 additions and 43 deletions
packages/flutter_goldens/test/flutter_goldens_test.dart
View file @ 2386fd90
...@@ -181,7 +181,9 @@ void main() { ...@@ -181,7 +181,9 @@ void main() {
'--commit', '1234', '--commit', '1234',
'--keys-file', '/workDirectory/keys.json', '--keys-file', '/workDirectory/keys.json',
'--failure-file', '/workDirectory/failures.json', '--failure-file', '/workDirectory/failures.json',
'--passfail', // TODO(Piinks): Re-enable once https://github.com/flutter/flutter/issues/100304
// is resolved.
//'--passfail',
], ],
null, null,
); );
...@@ -257,46 +259,46 @@ void main() { ...@@ -257,46 +259,46 @@ void main() {
await skiaClient.tryjobInit(); await skiaClient.tryjobInit();
}); });
test('throws for error state from imgtestAdd', () { // TODO(Piinks): Re-enable once https://github.com/flutter/flutter/issues/100304
final File goldenFile = fs.file('/workDirectory/temp/golden_file_test.png') // is resolved.
..createSync(recursive: true); // test('throws for error state from imgtestAdd', () {
platform = FakePlatform( // final File goldenFile = fs.file('/workDirectory/temp/golden_file_test.png')
environment: <String, String>{ // ..createSync(recursive: true);
'FLUTTER_ROOT': _kFlutterRoot, // platform = FakePlatform(
'GOLDCTL' : 'goldctl', // environment: <String, String>{
}, // 'FLUTTER_ROOT': _kFlutterRoot,
operatingSystem: 'macos' // 'GOLDCTL' : 'goldctl',
); // },
// operatingSystem: 'macos'
skiaClient = SkiaGoldClient( // );
workDirectory, //
fs: fs, // skiaClient = SkiaGoldClient(
process: process, // workDirectory,
platform: platform, // fs: fs,
httpClient: fakeHttpClient, // process: process,
); // platform: platform,
// httpClient: fakeHttpClient,
const RunInvocation goldctlInvocation = RunInvocation( // );
<String>[ //
'goldctl', // const RunInvocation goldctlInvocation = RunInvocation(
'imgtest', 'add', // <String>[
'--work-dir', '/workDirectory/temp', // 'goldctl',
'--test-name', 'golden_file_test', // 'imgtest', 'add',
'--png-file', '/workDirectory/temp/golden_file_test.png', // '--work-dir', '/workDirectory/temp',
// TODO(Piinks): Re-enable once https://github.com/flutter/flutter/issues/100304 // '--test-name', 'golden_file_test',
// is resolved. // '--png-file', '/workDirectory/temp/golden_file_test.png',
//'--passfail', // '--passfail',
], // ],
null, // null,
); // );
process.processResults[goldctlInvocation] = ProcessResult(123, 1, 'Expected failure', 'Expected failure'); // process.processResults[goldctlInvocation] = ProcessResult(123, 1, 'Expected failure', 'Expected failure');
process.fallbackProcessResult = ProcessResult(123, 1, 'Fallback failure', 'Fallback failure'); // process.fallbackProcessResult = ProcessResult(123, 1, 'Fallback failure', 'Fallback failure');
//
expect( // expect(
skiaClient.imgtestAdd('golden_file_test', goldenFile), // skiaClient.imgtestAdd('golden_file_test', goldenFile),
throwsException, // throwsException,
); // );
}); // });
test('correctly inits tryjob for luci', () async { test('correctly inits tryjob for luci', () async {
platform = FakePlatform( platform = FakePlatform(
......
packages/flutter_goldens_client/lib/skia_client.dart
View file @ 2386fd90
...@@ -144,7 +144,9 @@ class SkiaGoldClient { ...@@ -144,7 +144,9 @@ class SkiaGoldClient {
'--commit', commitHash, '--commit', commitHash,
'--keys-file', keys.path, '--keys-file', keys.path,
'--failure-file', failures.path, '--failure-file', failures.path,
'--passfail', // TODO(Piinks): Re-enable once https://github.com/flutter/flutter/issues/100304
// is resolved.
//'--passfail',
]; ];
if (imgtestInitCommand.contains(null)) { if (imgtestInitCommand.contains(null)) {
...@@ -214,7 +216,12 @@ class SkiaGoldClient { ...@@ -214,7 +216,12 @@ class SkiaGoldClient {
..writeln('Debug information for Gold:') ..writeln('Debug information for Gold:')
..writeln('stdout: ${result.stdout}') ..writeln('stdout: ${result.stdout}')
..writeln('stderr: ${result.stderr}'); ..writeln('stderr: ${result.stderr}');
throw Exception(buf.toString()); // Temporarily print logs for issue diagnosis
// ignore: avoid_print
print(buf.toString());
// TODO(Piinks): Re-enable once https://github.com/flutter/flutter/issues/100304
// is resolved.
// throw Exception(buf.toString());
} }
return true; return true;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

HIAST - GitLab