1. 26 Sep, 2016 1 commit
    • Ian Hickson's avatar
      Turn off AnimationControllers when not in use (#5902) · 9e673853
      Ian Hickson authored
      This requires all AnimationController objects to be given a
      TickerProvider, a class that can create the Ticker.
      
      It also provides some nice mixins for people who want to have their
      State provide a TickerProvider. And a schedulerTickerProvider for those
      cases where you just want to see your battery burn.
      
      Also, we now enforce destruction order for elements.
      9e673853
  2. 08 Sep, 2016 1 commit
    • Ian Hickson's avatar
      Make tests more realistic (#5762) · 5bc8888e
      Ian Hickson authored
      Previously, pumpWidget() would do a partial pump (it didn't trigger
      Ticker callbacks or post-frame callbacks), and pump() would do a full
      pump. This patch brings them closer together. It also makes runApp run a
      full actual frame, rather than skipping the transient callback part of
      the frame logic. Having "half-frames" in the system was confusing and
      could lead to bugs where code expecting to run before the next layout
      pass didn't because a "half-frame" ran first.
      
      Also, make Tickers start ticking in the frame that they were started in,
      if they were started during a frame. This means we no longer spin a
      frame for t=0, we jump straight to the first actual frame.
      
      Other changes in this patch:
      
      * rename WidgetsBinding._runApp to WidgetsBinding.attachRootWidget, so
        that tests can use it to more accurately mock out runApp.
      
      * allow loadStructuredData to return synchronously.
      
      * make handleBeginFrame handle not being given a time stamp.
      
      * make DataPipeImageProvider.loadAsync protected (rather than private),
        and document it. There wasn't really a reason for it to be private.
      
      * fix ImageConfiguration.toString.
      
      * introduce debugPrintBuildScope and debugPrintScheduleBuildForStacks,
        which can help debug problems with widgets getting marked as dirty but
        not cleaned.
      
      * make debugPrintRebuildDirtyWidgets say "Building" the first time and
        "Rebuilding" the second, to make it clearer when a widget is first
        created. This makes debugging widget lifecycle issues much easier.
      
      * make debugDumpApp more resilient.
      
      * debugPrintStack now takes a label that is printed before the stack.
      
      * improve the banner shown for debugPrintBeginFrameBanner.
      
      * various and sundry documentation fixes
      5bc8888e
  3. 25 May, 2016 1 commit
  4. 22 Apr, 2016 1 commit
  5. 19 Apr, 2016 1 commit
    • Ian Hickson's avatar
      Rearrange scheduling library (#3388) · 61605a9d
      Ian Hickson authored
      To be more consistent with other parts of the platform:
      
      * put the binding in a binding.dart file.
      
      * rearrange some members of the Scheduler class to be more close to
        execution order.
      
      * factor out Priority class into its own file.
      
      * add more dart docs.
      61605a9d
  6. 13 Apr, 2016 1 commit
    • Ian Hickson's avatar
      Fix dependency skew. (#3306) · 7861d029
      Ian Hickson authored
      ...by adding tests to our examples that don't import flutter_test, which
      pins the relevant dependencies.
      
      Also, provide more information when complaining about leaked transient
      callbacks in tests.
      
      Also, make tests display full information when they have an exception,
      by bypassing the throttling we have for Android logging in tests.
      
      Also, make the word wrapping not wrap stack traces if they happen to
      be included in exception output.
      
      Also, fix a leaked transient callback in the checkbox code.
      7861d029
  7. 12 Mar, 2016 3 commits
  8. 04 Mar, 2016 1 commit
  9. 11 Feb, 2016 2 commits
    • Ian Hickson's avatar
      Ticker typedef had no defined return type · 4d90194e
      Ian Hickson authored
      4d90194e
    • Ian Hickson's avatar
      Clean up imports and exports. · a94999ba
      Ian Hickson authored
      Each layer is supposed to reexport the parts of the previous layer
      that are part of its API.
      
      - In painting.dart, export from dart:ui all the Canvas-related APIs
        that make sense to be used at higher levels, e.g. PaintingStyle.
      
      - Delete painting/shadows.dart. It was dead code.
      
      - In rendering/object.dart, export all of painting.dart.
      
      - In widgets/basic.dart, export all of painting.dart and
        animation.dart. Some classes in animation/ are renamed to make this
        less disruptive and confusing to the namespace.
      
      - Split out Stocks back into an import model rather than a part model,
        so that it's easier to manage its dependencies on a per-file basis.
      
      - Move Ticker to scheduler library.
      
      - Remove as many redundant imports as possible now.
      
      - Some minor nit picking cleanup in various files.
      a94999ba
  10. 14 Dec, 2015 1 commit
  11. 10 Dec, 2015 2 commits
  12. 02 Dec, 2015 1 commit
    • Florian Loitsch's avatar
      Rename some of the functions from the scheduler. · 72821152
      Florian Loitsch authored
      The names are probably less familiar, but more consistent:
      - FrameCallback: a callback that is relative to the frame and wants the
        frame offset (a duration) as argument.
      - addXFrameCallback: adds the given callback to the internal lists/maps.
      - scheduleXFrameCallback (currently only X = ""): add the callback, but
        also trigger a new frame.
      - handleX: the method that is invoked when the event-loop or the frame
        calls into the scheduler.
      - ensureXYZ: ensure that the callback happens.
        Unfortunately there is the ambiguity between a "callback": it can be a
        closure, or the action of doing a callback, so we end up with:
        ensureBeginFrameCallback, and ensureEventLoopCallback, where
        "callback" means the action of being called back.
      72821152
  13. 09 Oct, 2015 1 commit
    • Hixie's avatar
      Relative paths in internal flutter libraries · 37bda251
      Hixie authored
      Now that you import a top-level file for each layer of the Flutter
      framework, within the framework we can use relative paths without being
      worried about the copy/pasta problem we used to have.
      37bda251
  14. 05 Oct, 2015 1 commit
  15. 03 Oct, 2015 2 commits
  16. 08 Sep, 2015 2 commits
  17. 17 Aug, 2015 1 commit
  18. 13 Aug, 2015 1 commit
    • Matt Perry's avatar
      Fix common asserts in animation API. · 8a729317
      Matt Perry authored
      1. We would assert if you tried to start an animation from within an
      animation status callback. This is a common pattern, so I fixed this
      assert (in Ticker._tick).
      2. We would assert for animations with duration under a millisecond.
      Fixed.
      
      Also removed the workarounds assocated with #1.
      8a729317
  19. 28 Jul, 2015 2 commits
  20. 16 Jul, 2015 1 commit