- 11 Feb, 2020 4 commits
-
-
LongCatIsLooong authored
-
Alexandre Ardhuin authored
-
Greg Spencer authored
This change adds a way to provide explicit focus order for a part of the widget tree. It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR. It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String. As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior. I was able to do this without breaking the API (AFAICT).
-
Gary Qian authored
-
- 10 Feb, 2020 5 commits
-
-
Mouad Debbar authored
-
Greg Spencer authored
This makes FocusManager a ChangeNotifier that notifies when the primaryFocus changes so that an app can track the current focus. Fixes #50501
-
liyuqian authored
-
Greg Spencer authored
This PR modifies the existing API docs samples to use DartPad so that all of the samples are now interactive apps on the API docs site. It also removes the restriction for the max width of the description area so that the dartpad region can expand horizontally. I updated the first paragraph on the API docs to indicate that Flutter is more than just mobile now (same text as the README.md at the top level). I modified a few of the examples so that they looked nicer, and fit better on the page. I added the sample description text above each DartPad instance, since that often defines the context of the example. I removed animations and images when they were redundant with the sample content. There were a few that made sense to keep, so I did.
-
Jonah Williams authored
-
- 08 Feb, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 07 Feb, 2020 1 commit
-
-
Dan Field authored
-
- 06 Feb, 2020 4 commits
-
-
David Shuckerow authored
-
Dan Field authored
-
creativecreatorormaybenot authored
-
Gary Qian authored
-
- 05 Feb, 2020 3 commits
-
-
creativecreatorormaybenot authored
provide Guidance for MultiChildRenderObjectWidget implementations
-
chunhtai authored
-
creativecreatorormaybenot authored
-
- 04 Feb, 2020 3 commits
-
-
Chris Bracken authored
This change broke some internal tests that set the text editing value to the same thing (the empty string) twice in a row. Note that in that case, the developer had subclassed EditableTextState and overridden the updateEditingValue method, which may or may not be relevant to the failure. This reverts commit 83d4d63a.
-
Jenn Magder authored
This reverts commit a1143d17.
-
- 03 Feb, 2020 1 commit
-
-
Remi Rousselet authored
-
- 01 Feb, 2020 2 commits
- 31 Jan, 2020 7 commits
-
-
Kate Lovett authored
-
Alexandre Ardhuin authored
-
Shi-Hao Hong authored
This reverts commit 46ccd086.
-
Dan Field authored
-
Gary Qian authored
-
Jonah Williams authored
This reverts commit 340b193f.
-
- 30 Jan, 2020 6 commits
-
-
chunhtai authored
-
Greg Spencer authored
This PR fixes #49647 by changing DiagnosticableMixin.toDiagnosticsNode and other things to accept DiagnosticableMixin instead of requiring Diagnosticable.
-
Dan Field authored
-
chunhtai authored
Fixes the focus handling when popping pages so that when multiple pages are popped, the focus doesn't try to focus the interstitial pages.
-
Jonah Williams authored
-
Gary Qian authored
-
- 29 Jan, 2020 2 commits
- 28 Jan, 2020 1 commit
-
-
Tong Mu authored
-