Commits · 464e751a78a933b9538f0fd8ef52552d779e5526 · abdullh.alsoleman / Front-End

20 Oct, 2023 22 commits

Reland "Use Layer.toImage for golden tests on CanvasKit" (#136918) · 464e751a
Harry Terkelsen authored Oct 20, 2023
```
Relands https://github.com/flutter/flutter/pull/135249

A golden test was failing in post submit in the previous PR
```
464e751a

Bump github/codeql-action from 2.22.3 to 2.22.4 (#136985) · 9beb98aa

dependabot[bot] authored Oct 20, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.3 to 2.22.4.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.22.4 - 20 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/1953">#1953</a></li>
<li>Users will begin to see warnings on Node.js 16 deprecation in their Actions logs on code scanning runs starting October 23, 2023.
<ul>
<li>All code scanning workflows should continue to succeed regardless of the warning.</li>
<li>The team at GitHub maintaining the CodeQL Action is aware of the deprecation timeline and actively working on creating another version of the CodeQL Action, v3, that will bump us to Node 20.</li>
<li>For more information, and to communicate with the maintaining team, please use <a href="https://redirect.github.com/github/codeql-action/issues/1959">this issue</a>.</li>
</ul>
</li>
</ul>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
<h2>2.22.2 - 12 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.0. <a href="https://redirect.github.com/github/codeql-action/pull/1938">#1938</a></li>
<li>Improve the log output when an error occurs in an invocation of the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1927">#1927</a></li>
</ul>
<h2>2.22.1 - 09 Oct 2023</h2>
<ul>
<li>Add a workaround for Python 3.12, which is not supported in CodeQL CLI version 2.14.6 or earlier. If you are running an analysis on Windows and using Python 3.12 or later, the CodeQL Action will switch to running Python 3.11. In this case, if Python 3.11 is not found, then the workflow will fail. <a href="https://redirect.github.com/github/codeql-action/pull/1928">#1928</a></li>
</ul>
<h2>2.22.0 - 06 Oct 2023</h2>
<ul>
<li>The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. <a href="https://redirect.github.com/github/codeql-action/pull/1907">#1907</a></li>
<li>The CodeQL Action no longer runs ML-powered queries. For more information, including details on our investment in AI-powered security technology, see <a href="https://github.blog/changelog/2023-09-29-codeql-code-scanning-deprecates-ml-powered-alerts/">&quot;CodeQL code scanning deprecates ML-powered alerts.&quot;</a> <a href="https://redirect.github.com/github/codeql-action/pull/1910">#1910</a></li>
<li>Fix a bug which prevented tracing of projects using Go 1.21 and above on Linux. <a href="https://redirect.github.com/github/codeql-action/pull/1909">#1909</a></li>
</ul>
<h2>2.21.9 - 27 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/1897">#1897</a></li>
<li>We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. <a href="https://redirect.github.com/github/codeql-action/pull/1889">#1889</a></li>
<li>We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. <a href="https://redirect.github.com/github/codeql-action/pull/1903">#1903</a></li>
<li>Add a warning to help customers avoid inadvertently analyzing the same CodeQL language in multiple matrix jobs. <a href="https://redirect.github.com/github/codeql-action/pull/1901">#1901</a></li>
</ul>
<h2>2.21.8 - 19 Sep 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.10.4 and earlier. These versions of CodeQL were discontinued on 12 September 2023 alongside GitHub Enterprise Server 3.6, and will be unsupported by the next minor release of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/1884">#1884</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.10.5 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.9.5 and 2.10.4, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.21.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>Enable the following language aliases when using CodeQL 2.14.4 and later: <code>c-cpp</code> for C/C++ analysis, <code>java-kotlin</code> for Java/Kotlin analysis, and <code>javascript-typescript</code> for JavaScript/TypeScript analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1883">#1883</a></li>
</ul>
<h2>2.21.7 - 14 Sep 2023</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/49abf0ba24d0b7953cb586944e918a0b92074c80"><code>49abf0b</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1961">#1961</a> from github/update-v2.22.4-63470275e</li>
<li><a href="https://github.com/github/codeql-action/commit/907abca61b21ae40b4f5b3a5233638842f1ac8d8"><code>907abca</code></a> Update changelog for v2.22.4</li>
<li><a href="https://github.com/github/codeql-action/commit/63470275e73bbef3ffab4f0bfff5b52e0772baf5"><code>6347027</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1953">#1953</a> from github/update-bundle/codeql-bundle-v2.15.1</li>
<li><a href="https://github.com/github/codeql-action/commit/b98a636a6be5574bf856f048453614bdd05a9a6e"><code>b98a636</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.15.1</li>
<li><a href="https://github.com/github/codeql-action/commit/4a368f64ad12c37745429168fc8de8672d16d5a6"><code>4a368f6</code></a> Add announcement on Node 16 deprecation (<a href="https://redirect.github.com/github/codeql-action/issues/1960">#1960</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/77bbb99abd466b60ab05e710e898ebe72cc5a8a2"><code>77bbb99</code></a> Bump urllib3 in /python-setup/tests/poetry/python-3.8 (<a href="https://redirect.github.com/github/codeql-action/issues/1957">#1957</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/a75a0d5716c40695ffa2977b51b8bd0daff48b87"><code>a75a0d5</code></a> Bump urllib3 in /python-setup/tests/poetry/requests-3 (<a href="https://redirect.github.com/github/codeql-action/issues/1956">#1956</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/aa55b87f8723d3b0ef9a4163d3952d085d692c7e"><code>aa55b87</code></a> Bump urllib3 in /python-setup/tests/pipenv/requests-3 (<a href="https://redirect.github.com/github/codeql-action/issues/1955">#1955</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/b6b0833c3dcbc510e52e232ffa10b394011136f9"><code>b6b0833</code></a> Bump urllib3 in /python-setup/tests/pipenv/python-3.8 (<a href="https://redirect.github.com/github/codeql-action/issues/1954">#1954</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/013244878413b4d09fc10936471c302365ae9548"><code>0132448</code></a> Add changelog note</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/0116bc2df50751f9724a2e35ef1f24d22f90e4e1...49abf0ba24d0b7953cb586944e918a0b92074c80">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.3&new-version=2.22.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

9beb98aa

Add missing call to parent method of GApplication::shutdown, implement... · 849ff0d0

Robert Ancell authored Oct 20, 2023

Add missing call to parent method of GApplication::shutdown, implement GApplication::startup (#136836)

Fixes a warning introduced in https://github.com/flutter/flutter/pull/136780 and adds the other related function.

849ff0d0

Roll Flutter Engine from b27e1b38375b to 4a65910f0ab2 (5 revisions) (#136987) · f47192ff

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/b27e1b38375b...4a65910f0ab2

2023-10-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Multiview pipeline" (flutter/engine#47174)
2023-10-20 dkwingsmt@users.noreply.github.com Multiview pipeline (flutter/engine#44473)
2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 9ffd5ef9a9ed to ca69b04f7dd2 (1 revision) (flutter/engine#47171)
2023-10-20 john@johnmccutchan.com Lower the severity of a log message (flutter/engine#47172)
2023-10-20 mdebbar@google.com [web] Remove workaround for safely removing slots on Safari (flutter/engine#47169)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f47192ff

Bump dartdoc to 7.0.1 and clean-up (#136975) · 997a94fd

Michael Goderbauer authored Oct 20, 2023

These warnings/errors have been removed from dartdoc. Removing them from the flutter config as well.

Also fixes CI to actually test doc generation for all documented packages and on dartdoc config changes.

997a94fd

RenderEditable WidgetSpan intrinsics (#136979) · 5f477642

LongCatIsLooong authored Oct 20, 2023

Update the `RenderEditable` implementation to match `RenderParagraph`. Fixes https://github.com/flutter/flutter/issues/136596

5f477642

Roll Flutter Engine from d46933e6772e to b27e1b38375b (9 revisions) (#136982) · 78b754e5

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/d46933e6772e...b27e1b38375b

2023-10-20 47866232+chunhtai@users.noreply.github.com Add link support in web accessibility (flutter/engine#46117)
2023-10-20 mdebbar@google.com [web] Support `flutterViewId` in platform view messages (flutter/engine#46891)
2023-10-20 jacksongardner@google.com Fix async image loading issues in skwasm. (flutter/engine#47117)
2023-10-20 flar@google.com Add option to save Impeller failure images in rendertests (flutter/engine#47142)
2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from b960e9140f56 to 9ffd5ef9a9ed (3 revisions) (flutter/engine#47167)
2023-10-20 chris@bracken.jp [macOS] Eliminate extraneous loadView calls (flutter/engine#47166)
2023-10-20 skia-flutter-autoroll@skia.org Roll Dart SDK from ba96a157a8eb to 53fee35b299f (1 revision) (flutter/engine#47165)
2023-10-20 jonahwilliams@google.com [Impeller] GPU Tracer for GLES. (flutter/engine#47080)
2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from de628929015d to b960e9140f56 (2 revisions) (flutter/engine#47164)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

78b754e5

Roll pub packages (#136924) · d7c82888
flutter-pub-roller-bot authored Oct 20, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
d7c82888

[docs] Expand categories for automated release notes (#136967) · f68612e7

Kevin Chisholm authored Oct 20, 2023

Updates release.yml to expand categories for automated release notes utilizing updated labels.

For more information on automated release notes see: https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

CC: @MaryaBelanger @atsansone

f68612e7

Roll Flutter Engine from 21b5c3771ee1 to d46933e6772e (3 revisions) (#136973) · 6b78b726

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/21b5c3771ee1...d46933e6772e

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 461218cee44c to de628929015d (1 revision) (flutter/engine#47161)
2023-10-20 mdebbar@google.com [web] Make HotRestartCacheHandler standalone (flutter/engine#46906)
2023-10-20 mdebbar@google.com [web] Attach pointer event listeners in the bubble phase (flutter/engine#47121)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6b78b726

[Impeller] add OpenGL GPU tracing to devicelab tests. (#136974) · 841cc675

Jonah Williams authored Oct 20, 2023

Adds the metadata key required to enable OpenGLES GPU tracing. This is off by default because the API crashes on some GPU models, but it should be safe on the Pixel 7 (others TBD based on testing results).

841cc675

Roll Flutter Engine from f9d1dbc39f4c to 21b5c3771ee1 (1 revision) (#136969) · abd9374f

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/f9d1dbc39f4c...21b5c3771ee1

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 04a9f72abd87 to 461218cee44c (1 revision) (flutter/engine#47160)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

abd9374f

Default `NativeAssets` Darwin and IOS target archs if missing (#136948) · 0a18aa46

Daco Harkes authored Oct 20, 2023

Make the `NativeAssets` target consistent with `build_info.dart`'s
documentation on missing `IosArchs` or `DarwinArchs`.

Bug:

* https://github.com/flutter/flutter/issues/136931

Also, updates the doc to reflect that MacOS is by default built for both
x64 and arm64. The PR making universal binaries the default didn't
update the doc comment.

* https://github.com/flutter/flutter/pull/100271

Please note that these defines are handled inconsistently in
`flutter_tools`. In some places they default to what's specified in the
doc-comment. In other places a `MissingDefineException` is thrown. I
believe the code around `build_info.dart` and the `environment` could
benefit from a wrapping so that defaults or missing definitions are
handled consistently in the code base.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

0a18aa46

Roll Flutter Engine from 6d1e9eec0841 to f9d1dbc39f4c (1 revision) (#136966) · ddbf09c2

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/6d1e9eec0841...f9d1dbc39f4c

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 24abc105675c to 04a9f72abd87 (1 revision) (flutter/engine#47159)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ddbf09c2

Roll Flutter Engine from 9b88ff83fd82 to 6d1e9eec0841 (2 revisions) (#136965) · 6366c1f6

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/9b88ff83fd82...6d1e9eec0841

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from e836c3aa2b98 to 24abc105675c (1 revision) (flutter/engine#47156)
2023-10-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from jkQctnDMmHydahKfZ... to VTlSkkxOaJrlxj_vv... (flutter/engine#47155)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from jkQctnDMmHyd to VTlSkkxOaJrl

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6366c1f6

Roll Packages from 09c6b1152070 to be915be92708 (6 revisions) (#136964) · 0883cb2e

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/packages/compare/09c6b1152070...be915be92708

2023-10-20 737941+loic-sharma@users.noreply.github.com [ci] Finalize migration to x64 specific Windows platform (flutter/packages#5174)
2023-10-19 15619084+vashworth@users.noreply.github.com [image_picker_ios] Update UITests for Xcode 15/iOS 17 (flutter/packages#5176)
2023-10-19 stuartmorgan@google.com [ci] Add emulator tests on older Android version (flutter/packages#4616)
2023-10-19 engine-flutter-autoroll@skia.org Roll Flutter from 189196d1 to c2bd2c11 (11 revisions) (flutter/packages#5183)
2023-10-19 stuartmorgan@google.com [tool] Fix `filter-packages-to` when everything is changed (flutter/packages#5182)
2023-10-19 tarrinneal@gmail.com [pigeon] add flutter api protocol (flutter/packages#5181)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0883cb2e

Roll Flutter Engine from de780872533c to 9b88ff83fd82 (4 revisions) (#136959) · 483ac618

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/de780872533c...9b88ff83fd82

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 17f05db514c3 to e836c3aa2b98 (1 revision) (flutter/engine#47154)
2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 5291f485514f to 17f05db514c3 (4 revisions) (flutter/engine#47151)
2023-10-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from eKYGl_wBcnT-n0J8n... to tcVA-iW-vOHPnwh_P... (flutter/engine#47149)
2023-10-20 skia-flutter-autoroll@skia.org Roll Dart SDK from aadeeb497dbe to ba96a157a8eb (1 revision) (flutter/engine#47147)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from eKYGl_wBcnT- to tcVA-iW-vOHP

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

483ac618

Roll Flutter Engine from 1e107c21328a to de780872533c (1 revision) (#136952) · 72e454d9

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/1e107c21328a...de780872533c

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 1d63da5da8e8 to 5291f485514f (3 revisions) (flutter/engine#47143)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

72e454d9

Roll Flutter Engine from fd33e7e75eac to 1e107c21328a (1 revision) (#136949) · f33b82e5

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/fd33e7e75eac...1e107c21328a

2023-10-20 skia-flutter-autoroll@skia.org Roll Dart SDK from f71ddbe0a500 to aadeeb497dbe (1 revision) (flutter/engine#47141)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f33b82e5

Roll Flutter Engine from 9dd59f7fcff9 to fd33e7e75eac (1 revision) (#136942) · 8b2c643c

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/9dd59f7fcff9...fd33e7e75eac

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 4c1ee6935b7b to 1d63da5da8e8 (1 revision) (flutter/engine#47140)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b2c643c

Roll Flutter Engine from cc3356c0e68f to 9dd59f7fcff9 (1 revision) (#136935) · eefafdac

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/cc3356c0e68f...9dd59f7fcff9

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from e5c37860c792 to 4c1ee6935b7b (1 revision) (flutter/engine#47136)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eefafdac

Roll Flutter Engine from 504a99d93f42 to cc3356c0e68f (2 revisions) (#136934) · 07042fa2

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/504a99d93f42...cc3356c0e68f

2023-10-19 matanlurey@users.noreply.github.com Remove unused `fbo` parameter in GLES `SetAsFramebufferAttachment()`. (flutter/engine#47133)
2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 0hLSNJ_DCTzRvTVJe... to jkQctnDMmHydahKfZ... (flutter/engine#47132)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 0hLSNJ_DCTzR to jkQctnDMmHyd

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

07042fa2

19 Oct, 2023 18 commits

Roll Flutter Engine from 503b84295462 to 504a99d93f42 (3 revisions) (#136930) · 84db74c9

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/503b84295462...504a99d93f42

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from b540ed3ba8e7 to e5c37860c792 (2 revisions) (flutter/engine#47126)
2023-10-19 chris@bracken.jp [macOS] Fail early when no a11y notification (flutter/engine#47129)
2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Z2mOZ5cuPJWvKn22P... to eKYGl_wBcnT-n0J8n... (flutter/engine#47128)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Z2mOZ5cuPJWv to eKYGl_wBcnT-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

84db74c9

Roll Flutter Engine from 3b0469b0c718 to 503b84295462 (1 revision) (#136928) · bfe174bb

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/3b0469b0c718...503b84295462

2023-10-19 dkwingsmt@users.noreply.github.com Reland 2 (part 2): Enforce the rule of calling `FlutterView.Render` (flutter/engine#47095)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bfe174bb

Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match... · 548843b9

Kate Lovett authored Oct 19, 2023

Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match iOS; inadvertent scrolling when user lifts up finger" (#136905)

Reverts flutter/flutter#132291

We have found this introduced flakiness in many of our tests.

Fixes https://github.com/flutter/flutter/issues/135728

548843b9

[flutter_tools] move build_preview_test from commands/permeable to integration shard (#136912) · fd160466
Christopher Fujino authored Oct 19, 2023
```
Fixes https://github.com/flutter/flutter/issues/136907 by moving the test to the tools integration shard, which DOES have VS code installed.
```
fd160466

Roll Flutter Engine from b40042ebb95b to 3b0469b0c718 (2 revisions) (#136922) · 27cf404d

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/b40042ebb95b...3b0469b0c718

2023-10-19 jason-simmons@users.noreply.github.com [Impeller] Use a weak pointer factory in GPUSurfaceGLImpeller that supports the raster thread merger (flutter/engine#47081)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from ea86103e06b1 to f71ddbe0a500 (1 revision) (flutter/engine#47124)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

27cf404d

do not include entries from `--dart-define-from-file` files in the gradle... · 25bed918

Andrew Kolos authored Oct 19, 2023

do not include entries from `--dart-define-from-file` files in the gradle config or environment during build (#136865)

Fixes https://github.com/flutter/flutter/issues/130599 and https://github.com/flutter/flutter/issues/136444

25bed918

Roll Flutter Engine from bfd2ffb9a8bc to b40042ebb95b (2 revisions) (#136915) · b5d8d77e

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/bfd2ffb9a8bc...b40042ebb95b

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 04449cda5a0a to b540ed3ba8e7 (4 revisions) (flutter/engine#47118)
2023-10-19 jiahaog@users.noreply.github.com Fix use of nested designators (flutter/engine#45869)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b5d8d77e

Roll Flutter Engine from 9d49175618f5 to bfd2ffb9a8bc (2 revisions) (#136910) · bbdcaea6

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/9d49175618f5...bfd2ffb9a8bc

2023-10-19 ychris@google.com [iOS] Load additional Cupertino system fonts (flutter/engine#46857)
2023-10-19 jiahaog@users.noreply.github.com Add missing import (flutter/engine#47083)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bbdcaea6

Allow users to customize search algorithm in `DropdownMenu` (#136848) · 40776d01

Qun Cheng authored Oct 19, 2023

Fixes #136735

This PR is to add a searchCallback to allow users to customize the search algorithm. This feature is used to fix b/305662376 which needs an exact match algorithm.

40776d01

Upgrade Flutter deps to pull in latest vm_service and dwds (#136734) · 01eef7ca

Elliott Brooks authored Oct 19, 2023

Generated by running `flutter update-packages --force-upgrade`

Updates vm_service to [12.0.0](https://pub.dev/packages/vm_service/versions/12.0.0) and dwds to [22.0.0](https://pub.dev/packages/dwds/versions/22.0.0)

The changes to `packages/flutter_tools/lib/src/isolated/devfs_web.dart` are for the new interface of DWDS introduced in https://github.com/dart-lang/webdev/pull/2243

FYI @bkonyi

01eef7ca

[Reland] Skip injecting Bonjour settings when port publication is disabled (#136842) · 3c3d414e
Victoria Ashworth authored Oct 19, 2023
```
Reland https://github.com/flutter/flutter/pull/136751 with fixes.
```
3c3d414e
_DefaultTabControllerState should dispose all created TabContoller instances. (#136608) · 9fa9fd36
Kostia Sokolovskyi authored Oct 19, 2023

9fa9fd36
Reland: "Add code for updating `focusedChild` when removing grandchildren from scope" (#136899) · 0abb017c
Greg Spencer authored Oct 19, 2023

0abb017c

Roll Flutter Engine from 418dce4feaf7 to 9d49175618f5 (1 revision) (#136901) · f82299ef

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/418dce4feaf7...9d49175618f5

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from b31b189be018 to 04449cda5a0a (1 revision) (flutter/engine#47105)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f82299ef

Unmark linux_android platform_channels_benchmarks as flaky (#136838) · f8c00983

Gray Mackall authored Oct 19, 2023

Unmarking this test as flaky in favor of a fix for the [underlying issue](https://github.com/flutter/flutter/issues/135035). None of the other impacted tests have been marked as flaky, so I think it is better for this one to not be treated differently.

f8c00983

Roll Packages from 14aa69e2e54c to 09c6b1152070 (4 revisions) (#136896) · ced0e741

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/packages/compare/14aa69e2e54c...09c6b1152070

2023-10-19 engine-flutter-autoroll@skia.org Manual roll Flutter from 6eea6e27 to 189196d1 (44 revisions) (flutter/packages#5178)
2023-10-18 47866232+chunhtai@users.noreply.github.com [go_router] adds ability to dynamically update routing table. (flutter/packages#5079)
2023-10-18 devoncarew@google.com [flutter_lints] rev flutter_lints to 3.0; increase dep on package:lints (flutter/packages#5177)
2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2f708eb8396e to 6c4930c4ac86 (1 revision) (flutter/packages#5173)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ced0e741

Roll Flutter Engine from 28cb2508b8e0 to 418dce4feaf7 (2 revisions) (#136895) · f9bec6cf

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/28cb2508b8e0...418dce4feaf7

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 8cf64b0795af to b31b189be018 (1 revision) (flutter/engine#47103)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b425a25a6dd to ea86103e06b1 (1 revision) (flutter/engine#47101)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f9bec6cf

Reverts "Fixes ability to call nextFocus() on a node to focus its descendant" (#136894) · c2bd2c11

auto-submit[bot] authored Oct 19, 2023

Reverts flutter/flutter#136773
Initiated by: itsjustkevin
This change reverts the following previous change:
Original Description:
fixes https://github.com/flutter/flutter/issues/134854

c2bd2c11