1. 27 Oct, 2023 1 commit
    • Binni Goel's avatar
      Fix. typos (#137325) · 9e04246c
      Binni Goel authored
      ## Description
      
      This PR fixes typos in 
      - `actions.dart`
      - `app_bar.dart`
      - `basic.dart`
      - `button_bar_theme.dart`
      9e04246c
  2. 22 Oct, 2023 1 commit
    • Todd Volkert's avatar
      Add timeline events for post frame callbacks (#136435) · cb9a3f69
      Todd Volkert authored
      Before this change, long-running post-frame callbacks wouldn't show up in the timeline at all.  This adds a timeline event for post-frame callbacks, with a debug flag that will add timeline events for each individual callback.
      
      #testexempt -- we have no way to test calls to the timeline.
      cb9a3f69
  3. 10 Oct, 2023 1 commit
    • Greg Spencer's avatar
      Add key event handlers that happen before or after the focus traversal (#136280) · 7e1d366a
      Greg Spencer authored
      ## Description
      
      This adds a mechanism for listening to key events before or after focus traversal occurs.
      
      It adds four methods to the public `FocusManager` API:
      
      - `addEarlyKeyEventHandler` - Adds a handler that can handle events before they are given to the focus tree for handling.
      - `removeEarlyKeyEventHandler` - Removes an early event handler.
      - `addLateKeyEventHandler` - Adds a handler that can handle events if they have not been handled by anything in the focus tree.
      - `removeLateKeyEventHandler` - Removes a late event handler.
      
      This allows an app to get notified for a key anywhere, and prevent the focus tree from seeing that event if it handles it.
      
      For the menu system, this allows it to eat an escape key press and close all the open menus.
      
      ## Related Issues
       - https://github.com/flutter/flutter/issues/135334
      
      ## Tests
       - Added tests for new functionality.
      7e1d366a
  4. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must be non-null' and 'must not be null' comments in widgets library (#134992) · 6e5134b0
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the widgets library.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134991
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      6e5134b0
  5. 14 Jun, 2023 1 commit
  6. 16 May, 2023 1 commit
  7. 28 Mar, 2023 1 commit
  8. 22 Mar, 2023 2 commits
  9. 24 Jan, 2023 1 commit
  10. 18 Jan, 2023 1 commit
  11. 17 Jan, 2023 1 commit
  12. 10 Jan, 2023 1 commit
    • Yegor's avatar
      add closed/open focus traversal; use open on web (#115961) · 42053575
      Yegor authored
      * allow focus to leave FlutterView
      
      * fix tests and docs
      
      * small doc update
      
      * fix analysis lint
      
      * use closed loop for dialogs
      
      * add tests for new API
      
      * address comments
      
      * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around
      
      * rename actionResult to invokeResult
      
      * address comments
      42053575
  13. 11 Dec, 2022 1 commit
  14. 09 Dec, 2022 1 commit
  15. 03 Dec, 2022 1 commit
  16. 22 Nov, 2022 1 commit
  17. 12 Sep, 2022 1 commit
  18. 02 Sep, 2022 1 commit
  19. 10 Aug, 2022 1 commit
  20. 08 Jul, 2022 1 commit
  21. 15 Jun, 2022 1 commit
  22. 31 May, 2022 1 commit
  23. 26 May, 2022 1 commit
  24. 25 May, 2022 1 commit
    • Greg Spencer's avatar
      Removing Shorcuts.of and Shortctus.maybeOf (#104215) · da24f105
      Greg Spencer authored
      This removes Shorcuts.of and Shortctus.maybeOf because they're not especially useful, since the only thing you can really set on a ShortcutManager is the shortcuts, and the Shortcuts widget that you give it to manages those, so if it rebuilds, it overwrites what you set.
      
      Also, adds a Shortcuts.manager constructor and removes the manager argument to the Shortcuts widget.
      
      Removing these will also eliminate an InheritedWidget for each Shortcuts widget, improving memory usage.
      da24f105
  25. 17 May, 2022 1 commit
    • Greg Spencer's avatar
      Add VoidCallbackAction and VoidCallbackIntent (#103518) · 19940279
      Greg Spencer authored
      This adds a simple VoidCallbackAction and VoidCallbackIntent that allows configuring an intent that will invoke a void callback when the intent is sent to the action subsystem. This allows binding a shortcut directly to a void callback in a Shortcuts widget.
      
      I also added an instance of VoidCallbackAction to the default actions so that simply binding a shortcut to a VoidCallbackIntent works anywhere in the app, and you don't need to add a VoidCallbackAction at the top of your app to make it work.
      19940279
  26. 14 Apr, 2022 1 commit
  27. 03 Feb, 2022 1 commit
  28. 10 Jan, 2022 1 commit
  29. 14 Dec, 2021 1 commit
  30. 12 Dec, 2021 1 commit
  31. 07 Dec, 2021 1 commit
  32. 03 Nov, 2021 1 commit
  33. 15 Oct, 2021 1 commit
  34. 04 Oct, 2021 1 commit
    • Greg Spencer's avatar
      Clean up examples, remove section markers and --template args (#91133) · fd9ce277
      Greg Spencer authored
      This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder.
      
      I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed.
      
      I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
      fd9ce277
  35. 01 Oct, 2021 1 commit
  36. 25 Aug, 2021 1 commit
    • Greg Spencer's avatar
      Extract Sample code into examples/api (#87280) · 33403bd2
      Greg Spencer authored
      This extracts the sample code out from the API doc comments, and places them in separate files on disk, allowing running of the examples locally, testing them, and building of slightly larger examples.
      33403bd2
  37. 10 Aug, 2021 1 commit
  38. 15 Jul, 2021 1 commit
  39. 14 Jul, 2021 1 commit