Commits · 4648f54430f4f65fe787930c9decb769f0ce7bf5 · abdullh.alsoleman / Front-End

29 Nov, 2023 29 commits

Fix chips `onDeleted` callback don't show the delete button when disabled (#137685) · 4648f544

Taha Tesser authored Nov 29, 2023

fixes [Chips with `onDeleted` callback should show the delete button in the `disabled` state](https://github.com/flutter/flutter/issues/136638)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            RawChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('RawChip'),
              onSelected: null,
              isEnabled: false,
              onDeleted: () {},
            ),
            InputChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('InputChip'),
              isEnabled: false,
              onPressed: null,
              onDeleted: () {},
            ),
            FilterChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('FilterChip'),
              onSelected: null,
              onDeleted: () {},
            ),
          ],
        ),
      ),
    );
  }
}
```

</details>

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/8bd458de-cfd2-44f0-a0dd-a8298938c61f" /> | <img src="https://github.com/flutter/flutter/assets/48603081/afca0684-b061-416b-b029-5316588c6888" /> |

4648f544

Roll Flutter Engine from 9a7e49d75411 to 35939ca8534f (5 revisions) (#139259) · 023e5add

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/9a7e49d75411...35939ca8534f

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from eb6fc55a3bc5 to 010883e6572c (1 revision) (flutter/engine#48506)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 830111a2c7d6 to eb6fc55a3bc5 (1 revision) (flutter/engine#48503)
2023-11-29 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Disable createImageBitmap support on Chrome 110 or older on Windows. (flutter/engine#48475)
2023-11-29 jonnywang@google.com [fuchsia] Update Fuchsia API level to 15 (flutter/engine#48233)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 8931060e9ab5 to 830111a2c7d6 (1 revision) (flutter/engine#48501)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

023e5add

Refactor to use Apple system fonts (#137275) · e84f1296

Mitchell Goodwin authored Nov 29, 2023

Addresses #63507, and is a follow up to the engine PR https://github.com/flutter/engine/pull/46857

Changes the font family string when attempting to use Apple system fonts to the new proxies added by the engine. For the "Text" font this will be more secure in the future against possible changes to Apple's API. For the "Display" font, this will now work correctly when it didn't before.

I checked the letter spacing values against a native app for all font sizes between 17-28. I made a few adjustments to better match native, but especially for the "Text" font we were either really close, or close enough to not make a large breaking change to default fonts worth it.

| Before  | After |
| ------------- | ------------- |
| <img width="466" alt="Screenshot 2023-11-02 at 11 45 12â¯AM" src="https://github.com/flutter/flutter/assets/58190796/627ed8ac-d848-4f71-aa62-a467b8aac62d"> | <img width="383" alt="Screenshot 2023-11-02 at 11 46 25â¯AM" src="https://github.com/flutter/flutter/assets/58190796/9a502021-7d2b-4e14-98f1-86971b3830a5"> |

The smaller text in both the before and after should be the same. The large system font that Flutter used before was incorrect, which caused it to look more spread out. Now we use the correct font.

e84f1296

Dynamic view sizing (#138648) · 4f8a9914

Michael Goderbauer authored Nov 29, 2023

Towards https://github.com/flutter/flutter/issues/134501.

This change is based on https://github.com/flutter/engine/pull/48090. It changes the `RenderView` to be dynamically sized based on its content if the `FlutterView` it is configured with allows it (i.e. the `FlutterView` has loose `FlutterView.physicalConstraints`). For that, it uses those `physicalConstraints` as input to the layout algorithm by passing them on to its child (after translating them to logical constraints via the device pixel ratio). The resulting `Size` that the `RenderView` would like to be is then communicated back to the engine by passing it to the `FlutterView.render` call.

Tests will fail until https://github.com/flutter/engine/pull/48090 has rolled into the framework.

4f8a9914

Roll dependencies (#139203) · b4178125
Ian Hickson authored Nov 29, 2023
```
Removes video_player and scoped_model pins, rolls everything else to latest.
```
b4178125

add sourceTimeStamp to ScaleUpdateDetails (#135936) · 443d8617

yakagami authored Nov 29, 2023

This PR adds the ability to get the `sourceTimeStamp` from `ScaleUpdateDetails` in a `GestureScaleUpdateCallback` like so:

```dart
onScaleUpdate: (ScaleUpdateDetails details){
print(details.sourceTimeStamp);
}
```

`sourceTimeStamp` is necessary when tracking velocity eg.

```dart
VelocityTracker tracker = VelocityTracker.withKind(PointerDeviceKind.touch);
///...
onScaleUpdate: (ScaleUpdateDetails details){
tracker.addPosition(details.sourceTimeStamp!, details.focalPoint);
}
```

The docs say:

>Having both a pan gesture recognizer and a scale gesture recognizer is redundant; scale is a superset of pan. Just use the scale gesture recognizer.

Currently this is not entirely accurate, and should be fixed, as noted in https://github.com/flutter/flutter/issues/43833#issuecomment-548133779. This PR does not add `sourceTimeStamp` to `ScaleStartDetails` because it is more involved. Specifically, `ScaleStartDetails` can be created in `acceptGesture` which does not have access to the `PointerEvent` to get the `event.timeStamp` (https://github.com/flutter/flutter/blob/54fa25543243e3bf31af6af0c1fef6adabc1d5c1/packages/flutter/lib/src/gestures/scale.dart#L730C5-L730C5).

fixes https://github.com/flutter/flutter/issues/135873. See also https://github.com/flutter/flutter/issues/43833 which added delta and https://github.com/flutter/flutter/issues/49025 which added `numPointers` to `ScaleUpdateDetails` for the reason given above. `sourceTimeStamp` should probably be added to `ScaleStartDetails` as well because it exists in `DragStartDetails` and therefore in `onPanStart`.

I am not sure how to add tests for this, any input about this PR would be appreciated.

- [] All existing and new tests are passing.

443d8617

Roll Flutter Engine from 222beb28a8eb to 9a7e49d75411 (1 revision) (#139250) · c864a556

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/222beb28a8eb...9a7e49d75411

2023-11-29 jonahwilliams@google.com [Impeller] fix order of operations in SkSL generated texture lookup. (flutter/engine#48488)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c864a556

Remove deprecated `PlatformMenuBar.body` (#138509) · 62952891

Greg Spencer authored Nov 29, 2023

Part of https://github.com/flutter/flutter/issues/139243

## Description

This removes the `PlatformMenuBar.body` attribute and constructor parameter, since its deprecation period has elapsed.

## Tests
 - No tests were using the deprecated attribute, so no tests were removed.

#FlutterDeprecations

62952891

Migration for the `sendTiming` events for `package:unified_analytics` (#138896) · 60d5c8ab

Elias Yishak authored Nov 29, 2023

Related to tracker issue:
- https://github.com/flutter/flutter/issues/128251

<img width="278" alt="image" src="https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de">

The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.

60d5c8ab

Roll Flutter Engine from 60b963930202 to 222beb28a8eb (2 revisions) (#139242) · 5e5b5292

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/60b963930202...222beb28a8eb

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from b9e2514a6fb6 to 8931060e9ab5 (1 revision) (flutter/engine#48498)
2023-11-29 34871572+gmackall@users.noreply.github.com Fix new lint from android 14 upgrade, and remove it from the baseline (flutter/engine#47817)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5e5b5292

Roll Flutter Engine from eebbe7e15c7d to 60b963930202 (2 revisions) (#139237) · f53e68a1

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/eebbe7e15c7d...60b963930202

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from ca84147b3e4e to b9e2514a6fb6 (1 revision) (flutter/engine#48497)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 19fbbf73fa33 to ca84147b3e4e (1 revision) (flutter/engine#48496)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f53e68a1

Roll Packages from 3c054661a3a6 to e4aaba833261 (5 revisions) (#139232) · 85d311d6

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/packages/compare/3c054661a3a6...e4aaba833261

2023-11-28 ian@hixie.ch [rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutter/packages#5471)
2023-11-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.20 to 1.9.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5483)
2023-11-28 70025277+Nitin-Poojary@users.noreply.github.com [flutter image] Changed image link to use image within package (flutter/packages#5326)
2023-11-28 PROGrand@users.noreply.github.com camera_android: Camera.java pausePreview null check (flutter/packages#5265)
2023-11-28 ltv.luongthevinh@gmail.com [webview_flutter] Add listener for content offset (Platform Interface) (flutter/packages#5427)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

85d311d6

Update VelocityTracker (4) (#139166) · 8ba459ce

Kate Lovett authored Nov 29, 2023

This updates the implementation to use the stopwatch from the Clock object and pipes it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands https://github.com/flutter/flutter/pull/138843 attempted to reland https://github.com/flutter/flutter/pull/137381 which attempted to reland #132291
Fixes https://github.com/flutter/flutter/issues/97761

1. The original change was reverted due to flakiness it introduced in tests that use fling gestures.
  * Using a mocked clock through the test binding fixes this now
2. It was reverted a second time because a change at tip of tree broke it, exposing memory leaks, but it was not rebased before landing. 
  * These leaks are now fixed
3. It was reverted a third time, because we were so excellently quick to revert those other times, that we did not notice the broken benchmark that only runs in postsubmit.
  * The benchmark is now fixed

8ba459ce

Analyze against using Stopwatches in the framework (#138507) · 133711ba
Kate Lovett authored Nov 29, 2023

133711ba

Roll Flutter Engine from ecc9c7b6be7d to eebbe7e15c7d (1 revision) (#139225) · 4d8ae570

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/ecc9c7b6be7d...eebbe7e15c7d

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 89e844f3fc87 to 19fbbf73fa33 (1 revision) (flutter/engine#48494)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d8ae570

Roll Flutter Engine from 28aae2d29822 to ecc9c7b6be7d (1 revision) (#139210) · 2c93b999

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/28aae2d29822...ecc9c7b6be7d

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 8489b2c37f73 to 89e844f3fc87 (1 revision) (flutter/engine#48490)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2c93b999

Improve documentation of CardTheme.shape (#139096) · 1d4d0025

Fré Dumazy authored Nov 29, 2023

The previous documentation did not point out the difference between the default corner radius for Material 2 and Material 3.

Fixes: https://github.com/flutter/flutter/issues/139093

1d4d0025

Simplify devicelab logic and fix tests (#139122) · 5e216d44

Ian Hickson authored Nov 29, 2023

- fix https://github.com/flutter/flutter/issues/53707 by having the test not expect a timeout but instead actually look for the retry message
- simplify the `--task` option to only accept task names rather than also accepting paths
- remove some obsolete options that referred to the manifest which no longer seems to exist

5e216d44

implemented leadingWidth and automaticallyImplyLeading options (#136165) · c5328650

Veli Bacik authored Nov 29, 2023

Before:
![Screenshot 2023-10-09 at 01 32 33](https://github.com/flutter/flutter/assets/17102578/cb90423c-8d8d-40d5-afd0-5aab23b9930b)

After:

![Screenshot 2023-10-09 at 01 33 01](https://github.com/flutter/flutter/assets/17102578/3ba84243-42b8-4e02-b064-70618e21a305)

![Screenshot 2023-10-09 at 01 32 49](https://github.com/flutter/flutter/assets/17102578/4f311d74-f6a8-4f32-9974-109bd7f55812)

Fixed #136164

c5328650

TextField and TextFormField can use a MaterialStatesController (#133977) · 178130b1

Renzo Olivares authored Nov 29, 2023

This change adds support for a `MaterialStatesController` in `TextField` and `TextFormField`. With this change a user can listen to `MaterialState` changes in an input field by passing a `MaterialStatesController` to `TextField` or `TextFormField`.

Fixes #133273

178130b1

Provide parameter to Icon and IconThemeData for they to consider the context's... · 49632fc3

Mateus Felipe C. C. Pinto authored Nov 29, 2023

Provide parameter to Icon and IconThemeData for they to consider the context's text scaler (#135708)

Provide a parameter `applyTextScaling` to both `Icon` and `IconDataTheme`. When `true`, the context's `TextScaler` will apply it's `scale` method to the icon size.

Fixes #115466

49632fc3

Roll Flutter Engine from be4d7c8b760c to 28aae2d29822 (1 revision) (#139204) · 44981755

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/be4d7c8b760c...28aae2d29822

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 539aba7d8539 to 8489b2c37f73 (1 revision) (flutter/engine#48489)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

44981755

Update `ButtonStyleButton.scaledPadding` documentation. Migrate callers in... · 075b9f76

LongCatIsLooong authored Nov 29, 2023

Update `ButtonStyleButton.scaledPadding` documentation. Migrate callers in flutter/flutter (#139014)

Fixes https://github.com/flutter/flutter/issues/138547.

It makes more sense to me for the default padding values to use the scaled font sizes instead of the `textScaleFactor`.

075b9f76

Roll Flutter Engine from de99c71c598f to be4d7c8b760c (1 revision) (#139199) · 716b34c5

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/de99c71c598f...be4d7c8b760c

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from fa5d6165e4d8 to 539aba7d8539 (1 revision) (flutter/engine#48486)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

716b34c5

Roll Flutter Engine from 9a840e8dba40 to de99c71c598f (2 revisions) (#139195) · 27f644b5

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/9a840e8dba40...de99c71c598f

2023-11-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Vqcs_2rbtDfbmu3WX... to 8wu5EgBh1yJPNOd5W... (flutter/engine#48485)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 6ad886e9593a to fa5d6165e4d8 (2 revisions) (flutter/engine#48484)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Vqcs_2rbtDfb to 8wu5EgBh1yJP

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

27f644b5

Roll Flutter Engine from fbb2b1e880fa to 9a840e8dba40 (1 revision) (#139192) · 0233e938

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/fbb2b1e880fa...9a840e8dba40

2023-11-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "binary_messenger missing cstdint" (flutter/engine#48483)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0233e938

Roll Flutter Engine from 4beaa1195b74 to fbb2b1e880fa (1 revision) (#139191) · 54ecad9f

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/4beaa1195b74...fbb2b1e880fa

2023-11-29 joel.winarske@gmail.com binary_messenger missing cstdint (flutter/engine#48481)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

54ecad9f

Roll Flutter Engine from 570fec4fa92c to 4beaa1195b74 (3 revisions) (#139190) · 7a0508e5

engine-flutter-autoroll authored Nov 29, 2023

https://github.com/flutter/engine/compare/570fec4fa92c...4beaa1195b74

2023-11-29 jonahwilliams@google.com [Impeller] fix descriptor pool recycler test flake. (flutter/engine#48479)
2023-11-29 robert.ancell@canonical.com Fix the application not disposing by breaking circular references on quit (flutter/engine#47684)
2023-11-28 dnfield@google.com Fix CanonicalizeURL for file schema (flutter/engine#48466)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7a0508e5

Reverts "Reland Add platform view wide gamut test" (#139189) · 20eb3ea1

auto-submit[bot] authored Nov 29, 2023

Reverts flutter/flutter#139101
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
Reland of https://github.com/flutter/flutter/pull/138837

I reverted too many config files, the app needed the pbx project file in order to find the new class I added. Instead, just put the new platform view in the app delegate so it builds.

20eb3ea1

28 Nov, 2023 11 commits

Move analysis test to shard tests. (#139161) · 8b6277e6

godofredoc authored Nov 28, 2023

This is part of the effort to deprecated adhoc tests.

Bug: https://github.com/flutter/flutter/issues/139153

8b6277e6

Write Tests for API Examples of `snack_bar.0`, `elevated_button.0`,... · a49ee534

Tirth authored Nov 28, 2023

Write Tests for API Examples of `snack_bar.0`, `elevated_button.0`, `stepper.0`, `radio.0`, `filled_button.0`, `outlined_button.0` & `card.0` (#138987)

Write Tests for API Examples of `snack_bar.0`, `elevated_button.0`, `stepper.0`, `radio.0`, `filled_button.0`, `outlined_button.0` & `card.0`

Part of #130459

a49ee534

Implement `switch` expressions in `dev/` (#139048) · 3267fbc0

Nate authored Nov 28, 2023

I previously made a PR (#136140) that used `switch` expressions to make some parts of the Flutter codebase easier to understand. It was assigned to the framework team, and @christopherfujino let me know that it was too large to effectively review and recommended breaking it up into smaller pull requests.

Here's a PR that only targets files in the `dev/` directory. Hopefully this will be easier to work with!

(solves issue https://github.com/flutter/flutter/issues/136139)

3267fbc0

Roll Flutter Engine from 01fcec7214db to 570fec4fa92c (2 revisions) (#139178) · 9c4df1f1

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/01fcec7214db...570fec4fa92c

2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from f07025afd712 to 6ad886e9593a (5 revisions) (flutter/engine#48469)
2023-11-28 jason-simmons@users.noreply.github.com Remove use of variable length arrays (flutter/engine#48232)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c4df1f1

Fix comment (#138973) · 352a0601
Gregor Zurowski authored Nov 28, 2023
```
A documentation tiny fix of the comment for `WidgetsBindingObserver`.
```
352a0601
Added some documentation for OverlayPortal (#138934) · f3c84ce2
yim authored Nov 28, 2023
```
Fixes: #138836 

Adds some comments to OverlayPortal to clarify its behavior.
```
f3c84ce2

feature(table-widget): Added intrinsicHeight to TableCellVerticalAlignment enum. (#130264) · 66935a82

Gabriel Tavares authored Nov 28, 2023

**What has been done?**
----------------------
Added new enumeration in `TableCellVerticalAlignment`, which sets the cell size to the same as the topmost cell. There are no noticeable problems in using it in all cells together, as there are in `TableCellVerticalAlignment.fill` which is made not to be used in all cells together because it has another purpose.

**Explanation of the logic**
----------------------
An assignment was made (which already existed in `TableCellVerticalAlignment.top; middle and bottom`) that assigns `rowHeight` the maximum double between the initialized height and the height of its child.

![image](https://github.com/flutter/flutter/assets/69699209/0fc9c168-5638-494b-aa0c-c579d0494c5e)

Basically, defining a minimum cell height based on its child, and letting each table row have its own height stipulated from the largest element, creating an `IntrinsicHeight` for TableCell automatically.

![image](https://github.com/flutter/flutter/assets/69699209/488b258a-3d25-4655-a9a0-381680468dec)

As the `TableCellVerticalAlignment` logic already provides for the use of the height of the largest cell in the row, it was possible to reuse this logic, and just not make the break statement that exists to fill in the calculation for `intrinsicHeight`.

Real example in an Android application after added enumeration
----------------------
![image](https://github.com/flutter/flutter/assets/69699209/51dce88d-f0f5-4644-942a-11ad218ffca0)

Opened issue
----------------------
FIX: #130261

66935a82

Roll Flutter Engine from 97ede154dcd8 to 01fcec7214db (1 revision) (#139172) · ef3c6170

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/97ede154dcd8...01fcec7214db

2023-11-28 15619084+vashworth@users.noreply.github.com Skip unexpected events in MultiPlatformViewBackgroundForegroundScenario (flutter/engine#48456)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ef3c6170

Ensure Icon vertically centers its icon glyph. (#138937) · f2b74725

LongCatIsLooong authored Nov 28, 2023

Fixes https://github.com/flutter/flutter/issues/138592. 

In an `Icon` widget if the icon font's body (ascender + descender) is larger than the font's units per em, the icon height reported by the text layout library will be larger than the specified font size. When that happens the icon glyph gets pushed towards the bottom because the `Icon` widget is wrapped in a fontSize x fontSize SizedBox and thus has a fixed height of fontSize px. This wasn't a problem for material icons because its UPEM == body.

f2b74725

Roll Flutter Engine from fd3a33f8b239 to 97ede154dcd8 (2 revisions) (#139168) · 223f32e0

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/fd3a33f8b239...97ede154dcd8

2023-11-28 jonahwilliams@google.com [Impeller] Skip mask blur with 0 sigma. (flutter/engine#48457)
2023-11-28 jonahwilliams@google.com [Impeller] match sigma scaling to Skia scaling. (flutter/engine#48434)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

223f32e0

Roll Flutter Engine from d375d5b95d59 to fd3a33f8b239 (2 revisions) (#139163) · 95a8f000

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/d375d5b95d59...fd3a33f8b239

2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 8752700a2565 to f07025afd712 (1 revision) (flutter/engine#48462)
2023-11-28 30870216+gaaclarke@users.noreply.github.com [Impeller] implements incorporating the gaussian blur snapshot transform (flutter/engine#48426)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

95a8f000