- 11 Nov, 2023 4 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1c29ce15c528...e2e07eab35ec 2023-11-11 bdero@google.com [Flutter GPU] Add DeviceBuffer. (flutter/engine#47699) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/aa6753fdbb51...1c29ce15c528 2023-11-11 15619084+vashworth@users.noreply.github.com Only run tests on macOS 12 (flutter/engine#47933) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/00db306f6f7b...aa6753fdbb51 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 96ce4d6f433d to 7eaff63b1425 (1 revision) (flutter/engine#47932) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9d8a1125640d...00db306f6f7b 2023-11-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump minSdk to 19 for Android tests" (flutter/engine#47935) 2023-11-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 91c4a92a64ea to 370145bbbd4f (1 revision) (flutter/engine#47930) 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 2c43bf002b7f to 96ce4d6f433d (3 revisions) (flutter/engine#47931) 2023-11-10 flar@google.com [Impeller] implement Canvas::DrawLine to tesselate lines directly (flutter/engine#47846) 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from d06840545bff to 2c43bf002b7f (1 revision) (flutter/engine#47928) 2023-11-10 43091780+utzcoz@users.noreply.github.com Bump minSdk to 19 for Android tests (flutter/engine#47686) 2023-11-10 dnfield@google.com [Impeller] Reduce allocations for polyline generation (flutter/engine#47837) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 10 Nov, 2023 26 commits
-
-
Victoria Ashworth authored
There's an https://github.com/flutter/flutter/issues/138238 with mac_toolchain that makes Xcode installs flakey and an https://github.com/flutter/flutter/issues/138246 that makes Xcode installs more frequent on macOS 13, which is causing presubmit tests to fall frequently. In the meantime, we'll only have tests run on macOS 12.
-
Kristijan Žic authored
Fixes the #136996 Readresses the #54358 Before: ```sh [✓] VS Code (version unknown) • VS Code at /snap/code/current • Flutter extension version 3.74.0 ✗ Unable to determine VS Code version. ``` After: ```sh [✓] VS Code (version 1.83.1) • VS Code at /snap/code/current/usr/share/code • Flutter extension version 3.74.0 ``` *List which issues are fixed by this PR. You must list at least one issue.* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat -
Ross Llewallyn authored
This is a simple, common grammar issue. See here: https://en.wikipedia.org/wiki/Comprised_of
-
Chinmoy authored
This PR deprecates `onWillAccept` and `onAccept` over `onWillAcceptWithDetails` and `onAcceptWithDetails`. Fixes: #133347
-
Chris Bracken authored
As of Xcode 15 on macOS Sonoma, the following message is (repeatedly) output to stderr during builds (repros on non-Flutter apps). It is supppressed in xcode itself, but not when run from the command-line. ``` 2023-11-10 10:44:58.031 xcodebuild[61115:1017566] [MT] DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot11/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-22267/IDEFoundation/Provisioning/Capabilities Infrastructure/IDECapabilityQuerySelection.swift:103 Details: createItemModels creation requirements should not create capability item model for a capability item model that already exists. Function: createItemModels(for:itemModelSource:) Thread: <_NSMainThread: 0x6000027c0280>{number = 1, name = main} Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide. ``` This suppresses this message from stderr in our macOS build logs. Issue: https://github.com/flutter/flutter/issues/135277 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat -
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/275ddb296ec9...9d8a1125640d 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from c4af3caee55c to d06840545bff (1 revision) (flutter/engine#47926) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Kostia Sokolovskyi authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5c2e16c5a95a...275ddb296ec9 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 126c8faf6c36 to c4af3caee55c (4 revisions) (flutter/engine#47920) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/b69f54ee0358...a6821898bd5a 2023-11-09 engine-flutter-autoroll@skia.org Roll Flutter from 4b4a1feb to f6621502 (17 revisions) (flutter/packages#5361) 2023-11-09 32538273+ValentinVignal@users.noreply.github.com [go_router] Retain query parameter during refresh and first redirect (flutter/packages#5276) 2023-11-09 15619084+vashworth@users.noreply.github.com Use specific version of mac_toolchain (flutter/packages#5356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e5b75177ac8e...5c2e16c5a95a 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 384f047aa0b6 to 126c8faf6c36 (4 revisions) (flutter/engine#47916) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Elias Yishak authored
Related to tracker issue: - https://github.com/flutter/flutter/issues/128251 This event was only called from one file (`flutter_command.dart`). With the previous implementation, we actually sent 2 events, one for the result of the `commandPath` and another containing the `maxRss` value from `ProcessInfo`. I have consolidated this down to just one event and used a function to safely get the `maxRss` value, or return null when if there was an error getting that integer value
-
John McCutchan authored
Touch events were being ignored by Google Maps because we were always setting the event source to UNKNOWN. This PR maps our PointerDeviceKind to Android's InputDevice.SOURCE_* enums. Manually tested with Google Maps. https://github.com/flutter/flutter/issues/128925
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/77349dc8e27b...e5b75177ac8e 2023-11-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 33307e78db2b to 91c4a92a64ea (6 revisions) (flutter/engine#47915) 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 5df579e87784 to 384f047aa0b6 (4 revisions) (flutter/engine#47912) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a5eab0d281fe...77349dc8e27b 2023-11-10 43054281+camsim99@users.noreply.github.com [Android] Bump robolectric version to support unit testing on Android 34 (flutter/engine#47768) 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from ae6df7264c6e to 5df579e87784 (1 revision) (flutter/engine#47910) 2023-11-10 mdebbar@google.com [web] Move styling from FlutterViewEmbedder to StyleManager (flutter/engine#47489) 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from e23e328584a1 to ae6df7264c6e (1 revision) (flutter/engine#47907) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Elias Yishak authored
Fixes issues: - https://github.com/flutter/flutter/issues/138035 Similar to GA3, we will now record the host running the flutter tool, such as VSCode, stored in the `FLUTTER_HOST` env variable
-
Sam Rawlins authored
Fixes https://github.com/flutter/flutter/issues/138227. Work towards https://github.com/flutter/flutter/issues/82948 In https://github.com/dart-lang/sdk/commit/c033718da0502ed92609f8c6cee2f6a59ccc058e, the analyzer's support for `analysis_options_user.yaml` is dropped. So no lint is reported in this test, as expected. This PR changes the test to expect no lint, and also no write the edits that trigger the lint.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b020893cba29...a5eab0d281fe 2023-11-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 33307e78db2b to 5075ac874117 (3 revisions)" (flutter/engine#47909) 2023-11-10 15619084+vashworth@users.noreply.github.com Temporarily disable test UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays (flutter/engine#47883) 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 5075f1572bfe to e23e328584a1 (3 revisions) (flutter/engine#47900) 2023-11-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 33307e78db2b to 5075ac874117 (3 revisions) (flutter/engine#47899) 2023-11-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0pD5ceqf-e9y9NTNn... to 8sk2n2-NXJ-ceyc7T... (flutter/engine#47898) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 0pD5ceqf-e9y to 8sk2n2-NXJ-c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Dan Field authored
This seems like an old remnant that is now completely unnecessary.
-
Tirth authored
Adds `useRootNavigator` property to `PopupMenuButton` widget. Fixes #95425
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/de9c4d672ad7...b020893cba29 2023-11-10 58529443+srujzs@users.noreply.github.com Remove implements of JS types on @staticInterop classes (flutter/engine#47869) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e80af854bd3a...de9c4d672ad7 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 971e197ca81a to 5075f1572bfe (2 revisions) (flutter/engine#47885) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from 583c85e03fb0 to 971e197ca81a (1 revision) (flutter/engine#47879) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Nate Bosch authored
Closes #97595 The prior approach of manually diffing the entire log chain is less efficient, and only found the original branch point ignoring subsequent merges. The limitation forced PR workflows into rebasing and force pushing new history to get the branch point far enough for CI to pass. Use `git merge-base` to find the latest common commit with the main branch. Add an `allowFailure` argument to the `git` utility to use a more specific failure in the case of no shared history when this command will fail with a generic error. Use `^branch` with the `git log` commands to exclude shared history and more easily count the unique commits on each branch. Drop the `Commit` abstraction. Parse directly to timestamp or line counts.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d4a51fae094c...e80af854bd3a 2023-11-09 30870216+gaaclarke@users.noreply.github.com Expanded the performance lints (flutter/engine#47868) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
flutter-pub-roller-bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9a3494e31171...d4a51fae094c 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from 6ff0fdf79bfa to 583c85e03fb0 (6 revisions) (flutter/engine#47877) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Victoria Ashworth authored
Seems that bots recently upgraded to macOS 13 are missing certs (https://github.com/flutter/flutter/issues/138194). Temporarily move `Mac_build_test flutter_gallery__transition_perf_e2e_ios` to staging.
-
- 09 Nov, 2023 10 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/670e85f184d3...9a3494e31171 2023-11-09 jonahwilliams@google.com [Impeller] Remove unused/untested Path APIs. (flutter/engine#47841) 2023-11-09 athom@google.com Remove references to the runtime/third_party directory in the Dart SDK (flutter/engine#47853) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Camille Simon authored
Re-lands https://github.com/flutter/flutter/pull/137191. The fix for the issue causing that PR to be reverted was tested in this PR but ultimately landed separately in https://github.com/flutter/flutter/pull/138093.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0fae75f963e4...670e85f184d3 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from ff418c512205 to 6ff0fdf79bfa (2 revisions) (flutter/engine#47874) 2023-11-09 goderbauer@google.com Reland "Remove physical geometry" (flutter/engine#47872) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Renzo Olivares authored
This changes fixes text selection gestures on the search field when using `SearchAnchor`. Before this change text selection gestures did not work due to an `IgnorePointer` in the widget tree. This change: * Removes the `IgnorePointer` so the underlying `TextField` can receive pointer events. * Introduces `TextField.onTapAlwaysCalled` and `TextSelectionGestureDetector.onUserTapAlwaysCalled`, so a user provided on tap callback can be called on consecutive taps. This is so that the user provided on tap callback for `SearchAnchor/SearchBar` that was previously only handled by `InkWell` will still work if a tap occurs in the `TextField`s hit box. The `TextField`s default behavior is maintained outside of the context of `SearchAnchor/SearchBar`. Fixes https://github.com/flutter/flutter/issues/128332 and #134965
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ca30d7df7105...0fae75f963e4 2023-11-09 mdebbar@google.com [web] Refactor a11y announcements out of FlutterViewEmbedder (flutter/engine#47487) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from a58076ed871a to ff418c512205 (5 revisions) (flutter/engine#47871) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
hangyu authored
issue: https://github.com/flutter/flutter/issues/137438 Use case: I want to add action button is tooltip and thus want to disable tap to dismiss a tooltip. 
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/eb89b9440520...ca30d7df7105 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from 775da2d297de to a58076ed871a (3 revisions) (flutter/engine#47866) 2023-11-09 34871572+gmackall@users.noreply.github.com [Re-land] Upgrade Android SDK to 34 "UpsideDownCake" (flutter/engine#47839) 2023-11-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 6bd98dc2dffd to 33307e78db2b (1 revision) (flutter/engine#47865) 2023-11-09 15619084+vashworth@users.noreply.github.com Use specific version of mac_toolchain (flutter/engine#47835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Qun Cheng authored
Fixes #130687 and #132915 This PR is to add two properties: `viewOnChanged` and `viewOnSubmitted` to `SearchAnchor` and `SearchAnchor.bar` so we can control the search bar on the search view.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/35cad36b7ec5...eb89b9440520 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from df263765ebc8 to 775da2d297de (2 revisions) (flutter/engine#47861) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Reid Baker authored
Fixes #135402 Add fallback logic for a different format of java version output and handle no patch versions. Add tests for new logic output to prevent regressions.
-
