Commits · 445e02dd631aa9e9665e58d9fc4133950d199efd · abdullh.alsoleman / Front-End

07 Sep, 2023 17 commits

fix `--exit` flag in dev/devicelab/bin/run.dart (#134162) · 445e02dd

Andrew Kolos authored Sep 07, 2023

Fixes #134154 

This PR also changes the default value of the `--exit` flag from `true` to `false`. Effectively, this is not a change in behavior since `--exit` didn't previously work.

445e02dd

Roll Packages from e7d812cefce0 to 22d475491502 (9 revisions) (#134232) · ea351694

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/packages/compare/e7d812cefce0...22d475491502

2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from ff5b5b5fa6f3 to 2524052335ec (6 revisions) (flutter/packages#4866)
2023-09-07 maurits@vnbskm.nl [webview_flutter_platform_interface] Adds option to override console log (flutter/packages#4701)
2023-09-01 stuartmorgan@google.com [tools,pigeon] Update tooling to handle Windows build output changes (flutter/packages#4826)
2023-08-31 amuramoto@users.noreply.github.com [google_maps_flutter] Cloud-based map styling support (flutter/packages#3682)
2023-08-31 stuartmorgan@google.com [ci] Convert version presubmit check to LUCI (flutter/packages#4822)
2023-08-31 rajveer0malviya@gmail.com [url_launcher_android] Add support for Custom Tabs (flutter/packages#4739)
2023-08-31 tarrinneal@gmail.com [webview_flutter] update pigeon to 11 (flutter/packages#4821)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter (stable) from e1e47221e862 to ff5b5b5fa6f3 (1 revision) (flutter/packages#4823)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter from 1fe24956 to c175cf87 (30 revisions) (flutter/packages#4825)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea351694

Roll Flutter Engine from 71bea01d3abe to f0b718e28779 (2 revisions) (#134231) · 11ad759a

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/71bea01d3abe...f0b718e28779

2023-09-07 kjlubick@users.noreply.github.com Explicitly encode SkImages in SkPictures as PNG (flutter/engine#45511)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 9a41a83f96d7 to 16df0c27bc0e (3 revisions) (flutter/engine#45537)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

11ad759a

DropdownRoutePage should dispose the created ScrollController. (#133941) · 12e6ff2c
Polina Cherkasova authored Sep 07, 2023

12e6ff2c
Cover some test/widgets tests with leak tracking (#133803) · aca91df6
Kostia Sokolovskyi authored Sep 07, 2023

aca91df6
SearchDelegate should dispose resources. (#133948) · 0d198c7b
Polina Cherkasova authored Sep 07, 2023

0d198c7b

Fixed [NavigationRailDestination]'s label opacity while disabled not being... · 2867b31f

Matheus Kirchesch authored Sep 07, 2023

Fixed [NavigationRailDestination]'s label opacity while disabled not being coherent with the icon (#132345)

Fixing the opacity of the NavigationRailDestination widget label while
it is disabled, right now it doesn't get affected by the disabled
attribute, which doesn't match the icon that gets affected

* https://github.com/flutter/flutter/issues/132344

I believe this PR should be marked as [test-exempt]

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

2867b31f

Roll Flutter Engine from 558136a1ccbf to 71bea01d3abe (2 revisions) (#134216) · 6ddb3b04

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/558136a1ccbf...71bea01d3abe

2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 826f9f5d20b6 to 9a41a83f96d7 (2 revisions) (flutter/engine#45534)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from c99601816d84 to 826f9f5d20b6 (1 revision) (flutter/engine#45533)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6ddb3b04

Roll Flutter Engine from 5a45ecd24aa3 to 558136a1ccbf (1 revision) (#134206) · bbf5d11a

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/5a45ecd24aa3...558136a1ccbf

2023-09-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SCoDb2m_zQDLrMhwT... to N915IZbyx6MSrwwS-... (flutter/engine#45532)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SCoDb2m_zQDL to N915IZbyx6MS

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bbf5d11a

Roll Flutter Engine from d864ae68db3c to 5a45ecd24aa3 (1 revision) (#134201) · 3744050b

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/d864ae68db3c...5a45ecd24aa3

2023-09-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from hHwU6r12A0sy5Bq-0... to WbB3tmMXnuwJBAHoi... (flutter/engine#45529)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from hHwU6r12A0sy to WbB3tmMXnuwJ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3744050b

Fix `TabBar` doesn't use `labelStyle` & `unselectedLabelStyle` color (#133989) · f5355af4

Taha Tesser authored Sep 07, 2023

Fixes [TabBar labelStyle.color and unselectedLabelStyle.color does not take effect](https://github.com/flutter/flutter/issues/109484)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [TabBar].

const Color labelColor = Color(0xFFFF0000);
const Color unselectedLabelColor = Color(0x95FF0000);
const TextStyle labelStyle = TextStyle(
  color: Color(0xff0000ff),
  fontWeight: FontWeight.bold,
);
const TextStyle unselectedLabelStyle = TextStyle(
  color: Color(0x950000ff),
  fontStyle: FontStyle.italic,
);

void main() => runApp(const TabBarApp());

class TabBarApp extends StatelessWidget {
  const TabBarApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(useMaterial3: true),
      home: const TabBarExample(),
    );
  }
}

class TabBarExample extends StatelessWidget {
  const TabBarExample({super.key});

  @override
  Widget build(BuildContext context) {
    return DefaultTabController(
      initialIndex: 1,
      length: 3,
      child: Scaffold(
        appBar: AppBar(
          title: const Text('TabBar Sample'),
          bottom: const TabBar(
            // labelColor: labelColor,
            // unselectedLabelColor: unselectedLabelColor,
            labelStyle: labelStyle,
            unselectedLabelStyle: unselectedLabelStyle,
            tabs: <Widget>[
              Tab(
                icon: Icon(Icons.cloud_outlined),
                text: 'Cloudy',
              ),
              Tab(
                icon: Icon(Icons.beach_access_sharp),
                text: 'Sunny',
              ),
              Tab(
                icon: Icon(Icons.brightness_5_sharp),
                text: 'Rainy',
              ),
            ],
          ),
        ),
        body: const TabBarView(
          children: <Widget>[
            Center(
              child: Text("It's cloudy here"),
            ),
            Center(
              child: Text("It's rainy here"),
            ),
            Center(
              child: Text("It's sunny here"),
            ),
          ],
        ),
      ),
    );
  }
}
```

</details>

#### When `labelStyle` and `unselectedLabelStyle` are specified with a color.

### Before
![image](https://github.com/flutter/flutter/assets/48603081/4138f928-aa63-40bc-9d4e-4d2aeefe72c1)

### After

![image](https://github.com/flutter/flutter/assets/48603081/2ce552c5-3972-4b5d-9492-eb487764e58f)

f5355af4

Fix `DataTable`'s `headingTextStyle` & `dataTextStyle` are not merged with... · 75797a8a

Taha Tesser authored Sep 07, 2023

Fix `DataTable`'s `headingTextStyle` & `dataTextStyle` are not merged with default text style (#134138)

fixes [Inconsistent text color on DataTable in different platforms](https://github.com/flutter/flutter/issues/114470)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [DataTable].

void main() => runApp(const DataTableExampleApp());

class DataTableExampleApp extends StatelessWidget {
  const DataTableExampleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      themeMode: ThemeMode.dark,
      theme: ThemeData(),
      darkTheme: ThemeData.dark(),
      home: Scaffold(
        appBar: AppBar(title: const Text('DataTable Sample')),
        body: const DataTableExample(),
      ),
    );
  }
}

class DataTableExample extends StatelessWidget {
  const DataTableExample({super.key});

  @override
  Widget build(BuildContext context) {
    return DataTable(
      headingTextStyle: const TextStyle(),
      dataTextStyle: const TextStyle(),
      columns: const <DataColumn>[
        DataColumn(
          label: Expanded(
            child: Text(
              'Name',
              style: TextStyle(fontStyle: FontStyle.italic),
            ),
          ),
        ),
        DataColumn(
          label: Expanded(
            child: Text(
              'Age',
              style: TextStyle(fontStyle: FontStyle.italic),
            ),
          ),
        ),
        DataColumn(
          label: Expanded(
            child: Text(
              'Role',
              style: TextStyle(fontStyle: FontStyle.italic),
            ),
          ),
        ),
      ],
      rows: const <DataRow>[
        DataRow(
          cells: <DataCell>[
            DataCell(Text('Sarah')),
            DataCell(Text('19')),
            DataCell(Text('Student')),
          ],
        ),
        DataRow(
          cells: <DataCell>[
            DataCell(Text('Janine')),
            DataCell(Text('43')),
            DataCell(Text('Professor')),
          ],
        ),
        DataRow(
          cells: <DataCell>[
            DataCell(Text('William')),
            DataCell(Text('27')),
            DataCell(Text('Associate Professor')),
          ],
        ),
      ],
    );
  }
}

```

</details>

### Before

| Desktop | Mobile |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/19c3908d-6b6a-4408-9c6b-da83c8efaa4a"  /> | <img src="https://github.com/flutter/flutter/assets/48603081/efda08fb-05f9-437e-be5c-6b6861babe19" width="350"  /> |

### After

| Desktop | Mobile |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/6bd3433f-d61f-4f35-8a2a-f7539a74f93e" /> | <img src="https://github.com/flutter/flutter/assets/48603081/5123a79b-6c2a-4bea-9fbc-64ed3e599826" width="350" /> |

75797a8a

Roll Flutter Engine from 187c5b3c5f71 to d864ae68db3c (2 revisions) (#134199) · 3b0359a0

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/187c5b3c5f71...d864ae68db3c

2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 5b7a07a6356f to c99601816d84 (1 revision) (flutter/engine#45528)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 9e86d3f6239a to 5b7a07a6356f (1 revision) (flutter/engine#45527)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3b0359a0

Reland "Fix `Chip.shape`'s side is not used when provided in Material 3" (#133856) · ded8b8e3

Taha Tesser authored Sep 07, 2023

fixes [Chip border side color not working in Material3](https://github.com/flutter/flutter/issues/132922)
Relands https://github.com/flutter/flutter/pull/132941 with an updated fix and a regression test.

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Chips'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            const RawChip(
              shape: RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: BorderSide(color: Colors.red),
              label: Text('RawChip'),
            ),
            const Chip(
              shape: RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: BorderSide(color: Colors.red),
              label: Text('Chip'),
            ),
            ActionChip(
              shape: const RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: const BorderSide(color: Colors.red),
              label: const Text('ActionChip'),
              onPressed: () {},
            ),
            FilterChip(
              shape: const RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: const BorderSide(color: Colors.red),
              label: const Text('FilterChip'),
              onSelected: (value) {},
            ),
            ChoiceChip(
              shape: const RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: const BorderSide(color: Colors.red),
              label: const Text('ChoiceChip'),
              selected: false,
              onSelected: (value) {},
            ),
            InputChip(
              shape: const RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: const BorderSide(color: Colors.red),
              label: const Text('InputChip'),
              onSelected: (value) {},
            ),
          ],
        ),
      ),
    );
  }
}
```

</details>

<img src="https://github.com/flutter/flutter/assets/48603081/f713fd84-cf9a-4e52-8cdb-5faba63d8e91" height="450" /> <img src="https://github.com/flutter/flutter/assets/48603081/a142efc7-041e-4e6e-87cf-e6c4ebe735f3" height="450" />

<img src="https://github.com/flutter/flutter/assets/48603081/377df55b-499f-403f-96c5-0be0334795dc" height="450" /> <img src="https://github.com/flutter/flutter/assets/48603081/731a2752-7822-4605-8e9c-db0a71dd6f08" height="450" />

ded8b8e3

Roll Flutter Engine from 75437a3bd002 to 187c5b3c5f71 (1 revision) (#134193) · 83c24274

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/75437a3bd002...187c5b3c5f71

2023-09-07 bdero@google.com [Impeller] Gaussian blur: Remove lingering BlurStyle vertex data/uniforms. (flutter/engine#45524)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

83c24274

Manual roll Flutter Engine from 2c69d05dfafb to 75437a3bd002 (15 revisions) (#134188) · 14ced759

engine-flutter-autoroll authored Sep 07, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/2c69d05dfafb...75437a3bd002

2023-09-07 zanderso@users.noreply.github.com Revert "Enforce the rule of calling `FlutterView.Render`" (flutter/engine#45525)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 2b76d1113497 to 9e86d3f6239a (1 revision) (flutter/engine#45521)
2023-09-07 bdero@google.com [Impeller] Gaussian blur: Remove the current blur style implementation. (flutter/engine#45520)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 9c9757c5d17d to 2b76d1113497 (2 revisions) (flutter/engine#45518)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 0039caadd635 to 9c9757c5d17d (1 revision) (flutter/engine#45516)
2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 00daa451320c to 60b56591dee5 (1 revision) (flutter/engine#45517)
2023-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8dgICHnG28wNHzoz3... to SCoDb2m_zQDLrMhwT... (flutter/engine#45514)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from a274609c442c to 0039caadd635 (2 revisions) (flutter/engine#45513)
2023-09-06 stuartmorgan@google.com Add macOS support for plugin value publishing (flutter/engine#45502)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from e5ed4ffaaaa4 to a274609c442c (2 revisions) (flutter/engine#45510)
2023-09-06 zanderso@users.noreply.github.com Roll Fuchsia with license script fix (flutter/engine#45498)
2023-09-06 dkwingsmt@users.noreply.github.com Enforce the rule of calling `FlutterView.Render` (flutter/engine#45300)
2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 7b0bb0f6e785 to 00daa451320c (1 revision) (flutter/engine#45507)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 59e54ccf25a4 to e5ed4ffaaaa4 (4 revisions) (flutter/engine#45506)
2023-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from dFe-t1SosqZwU5lZR... to hHwU6r12A0sy5Bq-0... (flutter/engine#45505)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from z9uQ0mXwjKFQ to SCoDb2m_zQDL
fuchsia/sdk/core/mac-amd64 from dFe-t1SosqZw to hHwU6r12A0sy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14ced759

Revert "Roll Flutter Engine from 2c69d05dfafb to fa14d337449b (6 revisions)" (#134183) · e8ff2aed
Zachary Anderson authored Sep 07, 2023
```
Reverts flutter/flutter#134169

windows_startup_test is failing following the roll
```
e8ff2aed

06 Sep, 2023 23 commits

Bump actions/upload-artifact from 3.1.2 to 3.1.3 (#134173) · cf1968aa

dependabot[bot] authored Sep 06, 2023

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 3.1.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v3.1.3</h2>
<h2>What's Changed</h2>
<ul>
<li>chore(github): remove trailing whitespaces by <a href="https://github.com/ljmf00"><code>@âljmf00</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/313">actions/upload-artifact#313</a></li>
<li>Bump <code>@âactions/artifact</code> version to v1.1.2 by <a href="https://github.com/bethanyj28"><code>@âbethanyj28</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/436">actions/upload-artifact#436</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v3...v3.1.3">https://github.com/actions/upload-artifact/compare/v3...v3.1.3</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/upload-artifact/commit/a8a3f3ad30e3422c9c7b888a15615d19a852ae32"><code>a8a3f3a</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/436">#436</a> from bethanyj28/main</li>
<li><a href="https://github.com/actions/upload-artifact/commit/7b48769c030f7121ecb01c3558dd3cd8b9660a20"><code>7b48769</code></a> update dependency cache</li>
<li><a href="https://github.com/actions/upload-artifact/commit/66630398dfe3d04deb4c489ac54b9b468f071706"><code>6663039</code></a> update dist/index.js</li>
<li><a href="https://github.com/actions/upload-artifact/commit/55e76b779da56f582e27a6f7aff54c1e610551e5"><code>55e76b7</code></a> bump <code>@âactions/artifact</code> version</li>
<li><a href="https://github.com/actions/upload-artifact/commit/65d862660abb392b8c4a3d1195a2108db131dd05"><code>65d8626</code></a> chore(github): remove trailing whitespaces (<a href="https://redirect.github.com/actions/upload-artifact/issues/313">#313</a>)</li>
<li>See full diff in <a href="https://github.com/actions/upload-artifact/compare/0b7f8abb1508181956e8e162db84b466c27e18ce...a8a3f3ad30e3422c9c7b888a15615d19a852ae32">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=3.1.2&new-version=3.1.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

cf1968aa

Roll Flutter Engine from 2c69d05dfafb to fa14d337449b (6 revisions) (#134169) · f0394437

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/2c69d05dfafb...fa14d337449b

2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from e5ed4ffaaaa4 to a274609c442c (2 revisions) (flutter/engine#45510)
2023-09-06 zanderso@users.noreply.github.com Roll Fuchsia with license script fix (flutter/engine#45498)
2023-09-06 dkwingsmt@users.noreply.github.com Enforce the rule of calling `FlutterView.Render` (flutter/engine#45300)
2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 7b0bb0f6e785 to 00daa451320c (1 revision) (flutter/engine#45507)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 59e54ccf25a4 to e5ed4ffaaaa4 (4 revisions) (flutter/engine#45506)
2023-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from dFe-t1SosqZwU5lZR... to hHwU6r12A0sy5Bq-0... (flutter/engine#45505)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from z9uQ0mXwjKFQ to 8dgICHnG28wN
fuchsia/sdk/core/mac-amd64 from dFe-t1SosqZw to hHwU6r12A0sy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f0394437

DraggableScrollableActuator should dispose notifier. (#133917) · 1f0730e6
Polina Cherkasova authored Sep 06, 2023

1f0730e6

Roll Flutter Engine from b04c2a378302 to 2c69d05dfafb (3 revisions) (#134164) · 41ebf282

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/b04c2a378302...2c69d05dfafb

2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 1b8ab5382ff6 to 7b0bb0f6e785 (2 revisions) (flutter/engine#45503)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 487cd9240571 to 59e54ccf25a4 (1 revision) (flutter/engine#45504)
2023-09-06 zanderso@users.noreply.github.com Roll clang to 576b184d6e3b633f51b908b61ebd281d2ecbf66f (flutter/engine#45499)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

41ebf282

Clean the fixed TODOs. (#133859) · 420aa9f7

Polina Cherkasova authored Sep 06, 2023

https://github.com/flutter/flutter/issues/130354 is fixed, but the test still fails, so converted it back to 'testWidgets' to investigate later.

420aa9f7

Roll Flutter Engine from 839051596b1d to b04c2a378302 (7 revisions) (#134158) · 4184a1d2

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/839051596b1d...b04c2a378302

2023-09-06 nshahan@google.com Update deps on DDC build targets (flutter/engine#45404)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 99bcee22f87d to 487cd9240571 (1 revision) (flutter/engine#45500)
2023-09-06 30870216+gaaclarke@users.noreply.github.com Remove android API 26 bump for validation layers (flutter/engine#45468)
2023-09-06 zanderso@users.noreply.github.com Roll buildroot (flutter/engine#45480)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 4468ef79f3d7 to 99bcee22f87d (5 revisions) (flutter/engine#45495)
2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 55d3636b66e0 to 1b8ab5382ff6 (1 revision) (flutter/engine#45494)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 596a1f192faa to 4468ef79f3d7 (2 revisions) (flutter/engine#45493)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4184a1d2

[Windows Arm64] Also use Windows 11 for Devicelab tests (#134082) · d792c664

Loïc Sharma authored Sep 06, 2023

Currently, the Windows Arm64 tests try to run on Windows 10 devices.
However, [all Windows Arm64 devices use Windows
11](https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=cpu%3Aarm64&f=os%3AWindows-11&f=pool%3Aluci.flutter.staging&s=id)
which result in the Windows Arm64 tests not running. This updates the
configuration to accept both Windows 10 and 11 (ideally the tests would
run on both OSes).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

d792c664

Fix `subtitleTextStyle.color` isn't applied to the `ListTile.subtitle` in Material 2 (#133422) · cd9a257d

Burak İmdat authored Sep 06, 2023

The difference between header text style and subtitle text style and the reason why it doesn't work is the code difference below. If we make the subtitle text style the same as the title text style it will work

<details>
  <summary>Title Text Style</summary>
  
  ###  All Code
  
  ```dart
  TextStyle titleStyle = titleTextStyle
      ?? tileTheme.titleTextStyle
      ?? defaults.titleTextStyle!;
    final Color? titleColor = effectiveColor;
    titleStyle = titleStyle.copyWith(
      color: titleColor,
      fontSize: _isDenseLayout(theme, tileTheme) ? 13.0 : null,
    );
    final Widget titleText = AnimatedDefaultTextStyle(
      style: titleStyle,
      duration: kThemeChangeDuration,
      child: title ?? const SizedBox(),
    );
  ```
  
  ## Different Code Section
  
  ```dart
  final Color? titleColor = effectiveColor;
  ```
</details>

<details>
  <summary>Subtitle Text Style</summary>
  
  ## All Code
  
  ```dart
  subtitleStyle = subtitleTextStyle
        ?? tileTheme.subtitleTextStyle
        ?? defaults.subtitleTextStyle!;
      final Color? subtitleColor = effectiveColor
        ?? (theme.useMaterial3 ? null : theme.textTheme.bodySmall!.color);
      subtitleStyle = subtitleStyle.copyWith(
        color: subtitleColor,
        fontSize: _isDenseLayout(theme, tileTheme) ? 12.0 : null,
      );
      subtitleText = AnimatedDefaultTextStyle(
        style: subtitleStyle,
        duration: kThemeChangeDuration,
        child: subtitle!,
      );
  ```
  
  ## Different Code Section
  
  ```dart
  final Color? subtitleColor = effectiveColor
        ?? (theme.useMaterial3 ? null : theme.textTheme.bodySmall!.color);
  ```

### Description for code 
- The value `theme.textTheme.bodySmall!.color` is given because the `effectiveColor` value is `null` and the `theme.useMaterial3` value is `false`
</details>

<details>
  <summary>Problem solved code</summary>
  
  ## All Code
  
  ```dart
  subtitleStyle = subtitleTextStyle
        ?? tileTheme.subtitleTextStyle
        ?? defaults.subtitleTextStyle!;
      final Color? subtitleColor = effectiveColor;
      subtitleStyle = subtitleStyle.copyWith(
        color: subtitleColor,
        fontSize: _isDenseLayout(theme, tileTheme) ? 12.0 : null,
      );
      subtitleText = AnimatedDefaultTextStyle(
        style: subtitleStyle,
        duration: kThemeChangeDuration,
        child: subtitle!,
      );
  ```
</details>

<details>
<summary>Screenshot of the result after making the necessary change</summary>
<img src="https://github.com/flutter/flutter/assets/70351342/b552fd4c-fdcd-4bf5-b4ba-d6b2cfe527cc" width=250>
</details>

#133412

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

cd9a257d

Add `CheckedPopupMenuItem.onTap` callback (#134000) · b0e5a5ca
Tirth authored Sep 06, 2023
```
Adds parent prop `onTap` to CheckedPopupMenuItem.

Fixes #127800
```
b0e5a5ca
MinimumTextContrastGuideline should dispose image. (#133861) · ee0a15d4
Polina Cherkasova authored Sep 06, 2023

ee0a15d4
[flutter_tools] Fix "FormatException: Invalid date format" during version freshness check (#134088) · 195dca02
Christopher Fujino authored Sep 06, 2023
```
Fixes https://github.com/flutter/flutter/issues/134067
```
195dca02
Fix not disposed items in Cupertino app and route. (#134085) · 61a388a4
Polina Cherkasova authored Sep 06, 2023

61a388a4

Roll Flutter Engine from a5e7fa6bf81a to 839051596b1d (2 revisions) (#134140) · 99f5cf07

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/a5e7fa6bf81a...839051596b1d

2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from a74a98890cc1 to 596a1f192faa (1 revision) (flutter/engine#45492)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from d603af2045ce to a74a98890cc1 (2 revisions) (flutter/engine#45491)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

99f5cf07

_DropdownMenuState should dispose TextEditingController. (#133914) · 03b60ac7
Polina Cherkasova authored Sep 06, 2023

03b60ac7

Roll Flutter Engine from 5253a33096d1 to a5e7fa6bf81a (1 revision) (#134137) · 03fcfbef

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/5253a33096d1...a5e7fa6bf81a

2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 2cc5d8f0b0ef to d603af2045ce (1 revision) (flutter/engine#45490)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

03fcfbef

Roll Flutter Engine from c7fd088291e2 to 5253a33096d1 (1 revision) (#134135) · c97e7fd4

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/c7fd088291e2...5253a33096d1

2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 0d91e2410d0e to 2cc5d8f0b0ef (1 revision) (flutter/engine#45489)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c97e7fd4

Roll Flutter Engine from 3d9989f1e155 to c7fd088291e2 (1 revision) (#134132) · 90d6b0bf

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/3d9989f1e155...c7fd088291e2

2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 5116f54eca4f to 55d3636b66e0 (1 revision) (flutter/engine#45488)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90d6b0bf

Roll Flutter Engine from bace539bb654 to 3d9989f1e155 (3 revisions) (#134128) · 151e8b57

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/bace539bb654...3d9989f1e155

2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from d664543f3e6d to 5116f54eca4f (1 revision) (flutter/engine#45487)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from a7f50692638d to 0d91e2410d0e (1 revision) (flutter/engine#45485)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 619eef2d0d67 to a7f50692638d (1 revision) (flutter/engine#45483)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

151e8b57

Roll Flutter Engine from 9344685efbc3 to bace539bb654 (1 revision) (#134104) · 3e65d04c

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/9344685efbc3...bace539bb654

2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 72d57724bcb8 to 619eef2d0d67 (1 revision) (flutter/engine#45481)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3e65d04c

Roll Flutter Engine from 0c8c1647dcd0 to 9344685efbc3 (1 revision) (#134103) · 7b0b0e27

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/0c8c1647dcd0...9344685efbc3

2023-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from bHw1LzoikQJthLkTE... to dFe-t1SosqZwU5lZR... (flutter/engine#45479)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from bHw1LzoikQJt to dFe-t1SosqZw

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b0b0e27

Roll Flutter Engine from 0c663258fd09 to 0c8c1647dcd0 (1 revision) (#134100) · f4a6f69d

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/0c663258fd09...0c8c1647dcd0

2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 0ff71d5ecd25 to d664543f3e6d (1 revision) (flutter/engine#45477)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f4a6f69d

Roll Flutter Engine from 8bacc3b38707 to 0c663258fd09 (3 revisions) (#134096) · 1db39ddc

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/8bacc3b38707...0c663258fd09

2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 3a3a64670e08 to 72d57724bcb8 (1 revision) (flutter/engine#45476)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from ce2da423cb5d to 3a3a64670e08 (1 revision) (flutter/engine#45475)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 0a253625a76a to ce2da423cb5d (1 revision) (flutter/engine#45473)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1db39ddc

Roll Flutter Engine from 590349006d23 to 8bacc3b38707 (5 revisions) (#134089) · 70c35bb5

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/590349006d23...8bacc3b38707

2023-09-06 jonahwilliams@google.com [Impeller] construct text frames on UI thread. (flutter/engine#45418)
2023-09-06 jiahaog@users.noreply.github.com Add import for `<unordered_map>` to fix the g3 build (flutter/engine#45471)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from af473004622f to 0a253625a76a (2 revisions) (flutter/engine#45470)
2023-09-05 skia-flutter-autoroll@skia.org Roll Skia from 1019c10a2d38 to af473004622f (2 revisions) (flutter/engine#45469)
2023-09-05 zanderso@users.noreply.github.com Adds a comment on clang_arm64_apilevel26 toolchain usage (flutter/engine#45467)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

70c35bb5