Commits · 43ac23b4c7b4410b338788763f29034cf149cf5d · abdullh.alsoleman / Front-End

05 May, 2023 30 commits

targets/web.dart - fix typo (#126114) · 43ac23b4

Kevin Moore authored May 05, 2023

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

43ac23b4

Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (#126175) · a9053fbc

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/6b467df16e11...758cbadfac1f

2023-05-05 jason-simmons@users.noreply.github.com [Impeller] Do not free a Vulkan command buffer if its command pool has already been destroyed (flutter/engine#41761)
2023-05-05 dkwingsmt@users.noreply.github.com Remove single window assumption from SceneBuilder (flutter/engine#41559)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a9053fbc

add tests for dominant bottom sheet in scaffold (#124472) · d5df4586

Viren Khatri authored May 05, 2023

while debugging https://github.com/flutter/flutter/issues/123882 found out that below lines were untested. although they'll change due to the issue above, but the tests will remain.

https://github.com/flutter/flutter/blob/e0045d04f7057d91b1701a444f75f2f0458c1d1a/packages/flutter/lib/src/material/scaffold.dart#L3169-L3180

d5df4586

Added CupertinoDatepicker monthYear mode (flutter#93508) (#125603) · 37f348b0

Patrick Lindsay authored May 05, 2023

This PR adds a month and year mode to the CupertinoDatePicker. The monthYear mode is the date mode without the day of the month.
![monthYearMode](https://user-images.githubusercontent.com/98486346/234749274-794dce24-28c7-4f48-92ab-5ac46ec069d7.png)

This feature was added at the request of:
[Proposal] CupertinoDatePicker with month and year. #93508

One thing that I was unsure of was the use of the DatePickerDateOrder to determine the monthYear order. It could be considered a workaround since the DatePickerDateOrder is intended to order day, month, and year. This means that a developer could use the DatePickerDateOrder.dmy (day, month, year) or DatePickerDateOrder.mdy (month, day, year) to get the same result. 

At first I intended to add a DatePickerMonthYearOrder enum to the localizations, in addition to a new parameter for the CupertinoDatePicker for monthYearOrder, but I ended up reverting these changes (https://github.com/flutter/flutter/commit/1c61f1084e63fc4f6e394c3621a1ae626fd631a5) because I had not considered the effects of adding values to the localizations.

I decided it may be better to not add an additional parameter (monthYearOrder) that would go mostly unused. I am very open to feedback or ideas on this matter.

37f348b0

Add `Switch.trackOutlineWidth` property (#125848) · c1c2513a
Qun Cheng authored May 05, 2023

c1c2513a
Rename iosdeeplinksettings to iosuniversallinksettings (#126173) · 78ed142f
chunhtai authored May 05, 2023
```
as title
```
78ed142f

Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (#126174) · be0aa01b

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/f3efe11f4449...6b467df16e11

2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from 1a1c7db436e4 to d6149a13d696 (6 revisions) (flutter/engine#41779)
2023-05-05 godofredoc@google.com Replace legacy linux unopt with engine v2. (flutter/engine#41757)
2023-05-05 godofredoc@google.com Allow default out_dir for fuchsia symbols upload. (flutter/engine#41776)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

be0aa01b

improvement : removed required kotlin dependency (#125002) · 4d4b3cf2

Alberto Azinar authored May 05, 2023

This PR removed the non-necessary required Koltin dependency. This is because the Kotlin Gradle adds the dependency on the standard library automatically. 

Fixes #98212

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy]. *

4d4b3cf2

Fix incorrect assert hint in flutter.groovy (#125283) · dbcff31e

ChenRenJie authored May 05, 2023

When I include flutter in my exist android project by
`include_flutter.groovy`, it hint me:
```
Project :app doesn't exist. To custom the host app project name, set `org.gradle.project.flutter.hostAppProjectName=<project-name>` in gradle.properties.
```
But set `org.gradle.project.flutter.hostAppProjectName` has no effect,
acutally need to set `flutter.hostAppProjectName`.

This pr is to fix this incorrect hint.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

dbcff31e

Update .cirrus.yml (#126166) · 676be366

Drew Roen authored May 05, 2023

The previous key expires in 5 days: https://github.com/flutter/flutter/issues/126072

676be366

tool: replace top-level functions with enum properties (#126167) · f9d45513
Kevin Moore authored May 05, 2023

f9d45513

Use direct dart API from `dart:ui_web` rather than JS shim. (#123443) · 201f7311

Jackson Gardner authored May 05, 2023

This is based off (and dependent on) these changes in the web engine that expose web-specific APIs: https://github.com/flutter/engine/pull/40608

201f7311

Add sample code for SliverAppBar (#125785) · 042eaf6b

Istiak Ahmed authored May 05, 2023

This PR adds an another example for SliverAppBar, showing the use of stretch and onStretchTrigger

https://user-images.githubusercontent.com/68919043/235420973-2bfb9871-9e05-4d87-9538-941d43178c76.mp4

Fixes #125651 

### Adds sample code for SliverAppBar [stretch, onStretchTrigger]

This PR adds an another simple and easily understandable example code for SliverAppBar.

042eaf6b

Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (#126163) · f57d38f7

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/cef0e9d1a94f...f3efe11f4449

2023-05-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 07016e96b9ed to bb9f17a8f0c3 (1 revision) (flutter/engine#41773)
2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from d71ece9f9f1a to 1a1c7db436e4 (1 revision) (flutter/engine#41772)
2023-05-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from de2Eqw0IsOzTq15m3... to Z3O1yYOsNgkQ6b0o3... (flutter/engine#41771)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from de2Eqw0IsOzT to Z3O1yYOsNgkQ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f57d38f7

Add a ReorderableListView example with cards + cleanup existing tests (#126155) · de261546

Bruno Leroux authored May 05, 2023

## Description

This PR adds one `ReorderableListView` example to demonstrate how `proxyDecorator` can be used to animate cards elevation.

https://user-images.githubusercontent.com/840911/236468570-d2b33ab3-6b6d-4f8d-90de-778dcf1ad8ce.mp4

For motivation, see https://github.com/flutter/flutter/issues/124729#issuecomment-1521524190.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/124729

## Tests

Adds 1 tests.

This PR also moves some misplaced example tests from `examples/api/test/reorderable_list` to `examples/api/test/material/reorderable_list` (and replaces two existing ones).

de261546

Roll Packages from 6bd59cdb8fb5 to a0f8fd89af1a (4 revisions) (#126161) · e24de327

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/packages/compare/6bd59cdb8fb5...a0f8fd89af1a

2023-05-05 tarrinneal@gmail.com tree fix (flutter/packages#3910)
2023-05-05 tarrinneal@gmail.com manual roll and fix (flutter/packages#3903)
2023-05-04 stuartmorgan@google.com [file_selector] Add `getDirectoryPaths` (flutter/packages#3871)
2023-05-04 75943909+TheUltimateOptimist@users.noreply.github.com [go_router_builder] fixed typo in README (flutter/packages#3835)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e24de327

Bring back the failing build_test's (#126014) · 9de9a81b

Drew Roen authored May 05, 2023

https://github.com/flutter/flutter/issues/125897

The issue has been resolved, so bringing the tests out of bringup

9de9a81b

[web] Use plain platform views in benchmarks (#126080) · 28f30377
Mouad Debbar authored May 05, 2023
```
Removing the dependency between web benchmarks and `url_launcher`'s `Link` widget.
```
28f30377

Fix Material 3 tab indicator weight and position (#125883) · ad009fb7

Taha Tesser authored May 05, 2023

fixes https://github.com/flutter/flutter/issues/123112

### Description
1. Add proper M3 indicator height aka`IndictorWeight` from the M3 specs for the primary tab bar with label indicator size.
https://github.com/flutter/flutter/blob/db6074ade4e4fde664e6258d671faf356e1b6e85/dev/tools/gen_defaults/data/navigation_tab_primary.json#L9
(this was held due to `indicatorWeight` having a hard-coded value) 

and added a secondary tab bar indicator height.
2. Set a minimum value for the rounded indicator to maintain the indicator shape.
3. With proper indicator height, the rounded indicator position is also fixed.
4. Fix round indicator is shown for the primary tab bar with tab indicator size.
5. Above changes fix https://github.com/flutter/flutter/issues/123112.
6. Fix the `startOffset` const value from https://github.com/flutter/flutter/pull/125036  to match docs and move it to a variable.

ad009fb7

Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (#126150) · 9d9ad2d5

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/b0f53e7751ad...cef0e9d1a94f

2023-05-05 skia-flutter-autoroll@skia.org Roll Dart SDK from eff8f62a7bc7 to 07016e96b9ed (1 revision) (flutter/engine#41770)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9d9ad2d5

Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (#126148) · 5120a0df

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/6f26066144fb...b0f53e7751ad

2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from edc4ee2e286e to d71ece9f9f1a (2 revisions) (flutter/engine#41768)
2023-05-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m0-fwGyFnoDVAvxgk... to jbpFz7qSikrKiRanC... (flutter/engine#41769)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from m0-fwGyFnoDV to jbpFz7qSikrK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5120a0df

Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (#126141) · d3f2fc79

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/764991e046c6...6f26066144fb

2023-05-05 skia-flutter-autoroll@skia.org Roll Dart SDK from afeed9f8701e to eff8f62a7bc7 (2 revisions) (flutter/engine#41764)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d3f2fc79

Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (#126137) · 9ddba1be

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/e7cd29153aa9...764991e046c6

2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from bf4217c3f0da to edc4ee2e286e (1 revision) (flutter/engine#41763)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9ddba1be

Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (#126135) · 59c1ac41

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/a885ed472eea...e7cd29153aa9

2023-05-05 dkwingsmt@users.noreply.github.com [macOS] Change view ID's type to signed and a typedef (flutter/engine#41653)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

59c1ac41

Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (#126129) · 9b36fda9

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/c97a0deccbc1...a885ed472eea

2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from 6577130e14b6 to bf4217c3f0da (1 revision) (flutter/engine#41762)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9b36fda9

[NavigationDrawer] adds padding property in NavigationDrawer Widget (#123961) · 91a84ded

Tirth authored May 05, 2023

Adds `tilePadding` property to `NavigationDrawer` Widget.

Fixes: #121662

| Without adding `tilePadding` in NavigationDrawer | With `tilePadding: EdgeInsets.all(16)` in NavigationDrawer |
| --- | --- |
| ![photo_2023-04-02_15-03-56](https://user-images.githubusercontent.com/13456345/229344718-9070c0c0-9c71-4436-9953-d258367951e9.jpg) | ![photo_2023-04-02_15-04-00](https://user-images.githubusercontent.com/13456345/229344717-0768f9d5-6a55-4c2f-918e-53f2423bb959.jpg) |

91a84ded

Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (#126124) · 04e284a4

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/269ce2deebeb...c97a0deccbc1

2023-05-05 30322203+ksballetba@users.noreply.github.com Close connection on keyboard close (flutter/engine#41500)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

04e284a4

Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (#126115) · e9d486cd

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/4d5070672859...269ce2deebeb

2023-05-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SD8Q_B7eWZqLgqo0f... to de2Eqw0IsOzTq15m3... (flutter/engine#41755)
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 00693e987828 to 6577130e14b6 (1 revision) (flutter/engine#41752)
2023-05-04 jacksongardner@google.com Revert "Skwasm Font Loading" (flutter/engine#41750)
2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 95e133dbd3a6 to afeed9f8701e (1 revision) (flutter/engine#41749)
2023-05-04 magder@google.com Fix flaky FlutterChannelsTests, stop mocking `NSObject` (flutter/engine#41747)
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from a4828415b4af to 00693e987828 (6 revisions) (flutter/engine#41746)
2023-05-04 godofredoc@google.com Migrate linux unopt to engine_v2. (flutter/engine#41658)
2023-05-04 jonahwilliams@google.com [Impeller] check if path is Rect/RRect/Oval (flutter/engine#41744)
2023-05-04 lhkbob@gmail.com Add temporary staging GN arg for Skia roll (flutter/engine#41743)
2023-05-04 jason-simmons@users.noreply.github.com Roll buildroot to 05ec9f7124191c7ba354521f3ffd34b09af872e7 (flutter/engine#41736)
2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 7b56aac98a5a to 95e133dbd3a6 (1 revision) (flutter/engine#41741)
2023-05-04 dnfield@google.com Disable flaky tests on arm64 (flutter/engine#41740)
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 6950f56ad2ec to a4828415b4af (2 revisions) (flutter/engine#41737)
2023-05-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LIacrdFhuTuHnYh0B... to m0-fwGyFnoDVAvxgk... (flutter/engine#41738)
2023-05-04 jacksongardner@google.com Skwasm Font Loading (flutter/engine#41246)
2023-05-04 godofredoc@google.com Migrate linux_host_engine to engine v2. (flutter/engine#41715)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from LIacrdFhuTuH to m0-fwGyFnoDV
fuchsia/sdk/core/mac-amd64 from SD8Q_B7eWZqL to de2Eqw0IsOzT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e9d486cd

Minor fixes found while working on blankcanvas (#125751) · a11da307

Ian Hickson authored May 05, 2023

This PR contains a series of minor changes to address issues that I happened to run into:

 - Pretty-print errors triggered when handling events that are pending because of having locked event handling. Previously these were just dumped to the console.
 - Add more documentation for `debugPaintPadding`.
 - Add documentation to `Tween` saying how to implement it.
 - Slight formatting changes in the scrollbar code to align some expressions.
 - Since we convert ScrollMetricsNotifications to ScrollNotifications in various places, provide an explicit API to do this. This will make the behaviour consistent throughout, and makes the code easier to understand. Added a test for this.
 - Clarifications to some of the BindingBase and SchedulerBinding documentation.
 - Clarified some documentation in `flutter_test`'s `Finder` class.

a11da307

tool-web: use ProcessUtil.run to invoke child processes (#126109) · f22dd30c
Kevin Moore authored May 05, 2023
```
All invocations are logged on verbose
Better, more detailed exceptions are thrown on errors
A lot less boilerplate
```
f22dd30c

04 May, 2023 10 commits

Cleans up appbar imply leading logic (#125315) · 0b657236
chunhtai authored May 04, 2023
```
fixes https://github.com/flutter/flutter/issues/80256
```
0b657236
Adding vmservice to get iOS app settings (#123156) · b00f1c45
chunhtai authored May 04, 2023
```
fixes https://github.com/flutter/flutter/issues/120405
```
b00f1c45
tool-web-wasm: make wasm-opt an "option" instead of a "flag" (#126035) · 529b919f
Kevin Moore authored May 04, 2023
```
Allows controlling a broader set of variables than just on/off.

Also make wasm-opt "full" the default
```
529b919f
Define testWidgetsWithLeakTracking. (#125063) · 5a80f8d6
Polina Cherkasova authored May 04, 2023

5a80f8d6

Roll Packages from 407b7da0079e to 6bd59cdb8fb5 (5 revisions) (#126078) · fde717da

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/packages/compare/407b7da0079e...6bd59cdb8fb5

2023-05-04 41930132+hellohuanlin@users.noreply.github.com [pigeon][reland]enable treat warnings as errors for swift code in unit test (flutter/packages#3901)
2023-05-04 stuartmorgan@google.com [video_player] Fix Android lints (flutter/packages#3886)
2023-05-04 stuartmorgan@google.com [quick_actions] Fix Android lint issues (flutter/packages#3885)
2023-05-03 andrewjohncoutts@gmail.com [camera_platform_interface] [camera] [camera_android] Add NV21 as an image stream format (flutter/packages#3277)
2023-05-03 stuartmorgan@google.com Revert "[pigeon]enable treat warning as errors for swift code in unit test" (flutter/packages#3898)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fde717da

Provide default constraints for M3 dialogs (#120082) · 8ec5001a

Pierre-Louis authored May 04, 2023

This PR constrains M3 dialogs to 560dp max width and height.

This is not a breaking change per the breaking change policy.

Part of https://github.com/flutter/flutter/issues/118619

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

8ec5001a

Roll Flutter Engine from 31de1c79ad56 to 4d5070672859 (2 revisions) (#126067) · c2022aa5

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/31de1c79ad56...4d5070672859

2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 47da769ae13a to 7b56aac98a5a (1 revision) (flutter/engine#41731)
2023-05-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from LCajvqTauUudC-7RW... to SD8Q_B7eWZqLgqo0f... (flutter/engine#41730)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from LCajvqTauUud to SD8Q_B7eWZqL

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c2022aa5

Fix typo in README.md (#126053) · ce32282c
Yu authored May 04, 2023

ce32282c

Fix nullability of ClipRRect.borderRadius (#125878) · 4bf297ce

Michael Goderbauer authored May 04, 2023

The property was typed as nullable, but the code assumed its always non-null. This makes the property non-nullable as well.

Also refactors CupertinoListSection, which was flagged by the analyzer when borderRadius became non-nullable (no functional change, just cleaning up existing code to avoid the warning).

4bf297ce

Roll Flutter Engine from ee646f9dd4c0 to 31de1c79ad56 (1 revision) (#126060) · f53335bf

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/ee646f9dd4c0...31de1c79ad56

2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 02e4b3087869 to 6950f56ad2ec (1 revision) (flutter/engine#41729)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f53335bf