1. 01 Aug, 2019 1 commit
  2. 31 Jul, 2019 1 commit
  3. 13 Jul, 2019 1 commit
  4. 06 Jun, 2019 1 commit
  5. 04 Jun, 2019 1 commit
  6. 03 Jun, 2019 1 commit
  7. 31 May, 2019 1 commit
  8. 30 May, 2019 2 commits
    • Greg Spencer's avatar
      Fix onExit calling when the mouse is removed. (#33477) · 07aede4c
      Greg Spencer authored
      This PR solves two problems: currently, the onExit is called for a mouse pointer the moment the removal message is received, except that by the time it actually calls it, there is no _lastEvent for it in the mouse tracker (it's already been removed), resulting in an event being passed to the onExit that contains nulls for the position. Also, removePointer events don't actually get created with a position, although they easily could be, so that even the the _lastEvent in the mouse tracker were still populated, it would still give a null position and delta.
      
      This PR adds support for the position and delta in a PointerRemovedEvent, and populates them. In addition, when a remove event is received, it doesn't actually remove the pointer until the mouse position check that gets scheduled actually happens.
      07aede4c
    • Todd Volkert's avatar
      Fix/update several HTML links (#33539) · ca13add9
      Todd Volkert authored
      ca13add9
  9. 25 May, 2019 1 commit
    • Chris Bracken's avatar
      Americanise spellings (#33323) · 156b4220
      Chris Bracken authored
      Updates documentation and non-public API to use American spellings for
      consistency with the rest of the codebase.
      
      No changes to behaviour... other than how it's spelt.
      156b4220
  10. 20 May, 2019 1 commit
  11. 14 May, 2019 3 commits
  12. 10 May, 2019 1 commit
  13. 09 May, 2019 2 commits
    • Michael Goderbauer's avatar
    • Greg Spencer's avatar
      Fix nested listeners so that ancestor listeners can also receive enter/exit/move events. (#32350) · aeccd6a8
      Greg Spencer authored
      This changes Listener to trigger enter/move/exit in all Listeners below the pointer, not just the leaf region (the first region hit). This is because we need to allow listeners to be nested so that, say, a widget that handles changing color on hover, but also is wrapped in a Tooltip (that handles hover) can trigger both actions, not just one.
      
      To that end, I added a findAll to Layer, similar to the existing find method that was previously used. It returns an iterator over annotated layers which match the given data type.
      
      Since the findAll is implemented as returning an Iterable (and is sync*), I re-implemented the find routines as just returning the first result from findAll, since that should be just as efficient, and would then prevent duplication in the implementation.
      aeccd6a8
  14. 08 May, 2019 1 commit
    • Greg Spencer's avatar
      Fix RenderPointerListener so that callbacks aren't called at the wrong time. (#32142) · 23baae0e
      Greg Spencer authored
      I recently added some code to keep hover events from being propagated when a mouse wasn't attached. While that works, there are times when it can fire callbacks during the building of other components, since they can now be called from detach/attach. This is not ideal, since it will assert then. This changes the code so that it won't update the annotations during attach/detach, but also won't push the annotation layer unless a mouse is connected, achieving the same result as before, but with better semantics.
      
      The basic problem is that in the detach for RenderPointerListener, it would detach the annotation, which could cause onExit to be called on the annotation, since the widget was disappearing under the mouse, and thus needs to receive an onExit, but that onExit might be (and probably will be) calling setState, which marks the owning widget as needing to be built, sometimes when it already has been.
      
      The fix creates a new _ListenerElement that overrides activate and deactivate in order to tell the render object ahead of the detach that it might be detached, and so the onExit gets called before the detach instead of during it.
      
      In addition, I now avoid scheduling more than one check for mouse positions per frame.
      23baae0e
  15. 03 May, 2019 2 commits
    • Greg Spencer's avatar
      Re-land: Add support for Tooltip hover (#31699) · 11e0a725
      Greg Spencer authored
      This is a re-land of #31561, after fixing performance regressions.
      
      Added change listening to the MouseTracker so that the Listener and tooltip can react to whether or not a mouse is connected at all. Added a change check to make sure Listener only repaints when something changed.
      
      Fixes #22817
      11e0a725
    • Tong Mu's avatar
      Redo "Remove pressure customization from some pointer events" (#30874) · 7beb09e7
      Tong Mu authored
      * Revert "Revert "Remove pressure customization from some pointer events (#30414)" (#30873)"
      
      This reverts commit f34c2ef0.
      
      * Revert pressure removal of PointerUpEvent
      
      * Replace PR with an issue
      
      * Add tests for fromMouseEvent
      7beb09e7
  16. 01 May, 2019 2 commits
  17. 30 Apr, 2019 1 commit
    • Tong Mu's avatar
      Redo: Add buttons to gestures (#31819) · fea2c7d6
      Tong Mu authored
      * Revert "Revert "Add buttons to gestures (#30339)" (#31801)"
      
      This reverts commit 8fd7fa49.
      
      * Synthesise kPrimaryButton for unknown devices
      
      * Change TestPointer to a better API
      fea2c7d6
  18. 29 Apr, 2019 2 commits
  19. 22 Apr, 2019 1 commit
  20. 11 Apr, 2019 2 commits
  21. 10 Apr, 2019 2 commits
  22. 05 Apr, 2019 2 commits
  23. 04 Apr, 2019 2 commits
    • Tong Mu's avatar
      Touching the screen adds `0x01` to buttons (#30457) · 13101c1a
      Tong Mu authored
      * Add constants `kPrimaryButton`, `kTouchContact` and `kStylusContact`
      * PointerDownEvent and PointerMoveEvent will always set the 0x01 bit on buttons
      13101c1a
    • Tong Mu's avatar
      Fix edge cases of PointerEventConverter (#29998) · 423cf223
      Tong Mu authored
      * Fix: ui.PointerChange.remove might contain position change, but we used to expand it into a Cancel and Remove, neither of which allows position change. A Hover event is added, and a test is updated accordingly.
      * Fixed the issue where a PointerMoveEvent and a PointerCancelEvent do not receive the correct pressure.
      * Refactor the calculation of delta into deltaTo.
      423cf223
  24. 01 Apr, 2019 1 commit
  25. 27 Mar, 2019 1 commit
  26. 22 Mar, 2019 1 commit
  27. 20 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      some spaces formatting (#29452) · a6af4228
      Alexandre Ardhuin authored
      * some space formattings
      
      * always use blocks in if-else if a block is used
      
      * format spaces in for and while
      
      * allow multiline if conditions
      
      * fix missing space
      a6af4228
  28. 11 Mar, 2019 2 commits
    • Dwayne Slater's avatar
      Fix MouseTracker annotation leak (#28990) · b19df00c
      Dwayne Slater authored
      * Fix MouseTracker annotation leak
      
      Map's remove method is typed `remove(Object key)`, which can cause bugs.
      
      Modified the existing test to check if the annotation has been removed
      from MouseTracker.
      b19df00c
    • stuartmorgan's avatar
      Add support for scrollwheels (#22762) · 5922a40e
      stuartmorgan authored
      Adds support for discrete scroll events, such as those sent by a scroll wheel.
      
      Includes the plumbing to convert, dispatch, and handle these events, as well as
      Scrollable support for consuming them.
      5922a40e