Optimize gesture recognizer instantiation (#35979)

bec1b9a1 · Hey24sheep · Shi-Hao Hong · 13382f41 · bec1b9a1
Commit bec1b9a1 authored Jul 13, 2019 by Hey24sheep Committed by Shi-Hao Hong Jul 13, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 5 deletions

long_press.dart packages/flutter/lib/src/gestures/long_press.dart +6 -5

No files found.
--- a/packages/flutter/lib/src/gestures/long_press.dart
+++ b/packages/flutter/lib/src/gestures/long_press.dart
@@ -268,13 +268,14 @@ class LongPressGestureRecognizer extends PrimaryPointerGestureRecognizer {

  void _checkLongPressStart() {
    assert(_initialButtons == kPrimaryButton);
-    final LongPressStartDetails details = LongPressStartDetails(
-      globalPosition: _longPressOrigin.global,
-      localPosition: _longPressOrigin.local,
-    );
-    if (onLongPressStart != null)
+    if (onLongPressStart != null) {
+      final LongPressStartDetails details = LongPressStartDetails(
+        globalPosition: _longPressOrigin.global,
+        localPosition: _longPressOrigin.local,
+      );
      invokeCallback<void>('onLongPressStart',
        () => onLongPressStart(details));
+    }
    if (onLongPress != null)
      invokeCallback<void>('onLongPress', onLongPress);
  }