- 09 Apr, 2015 1 commit
-
-
Ojan Vafai authored
Text can only only inside paragraphs and inlines. This patch makes it so we stop putting such text nodes in the render tree at all if their parent is not a paragraph or an inline. This is the final step in making it so that we don't create anonymous renderers, which fixes a crash in the new custom layout code. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1077473002
-
- 07 Apr, 2015 2 commits
-
-
Eric Seidel authored
Just silly fixes needed for our 4 copies of our python run script. R=ianh@google.com Review URL: https://codereview.chromium.org/1064983003
-
Eric Seidel authored
Also fix button.dart to include ink_well.dart. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1058013003
-
- 06 Apr, 2015 1 commit
-
-
Ojan Vafai authored
-Make display:flex, flex-direction: column, flex-shrink: 1 the default. -Simplify StyleAdjuster::adjustStyleForAlignment to remove special cases we won't need as we make flex the default and remove absolute positioning. -Fix a bug this exposed in column flexboxes where we'd apply the wrong edge of border/padding/margin. -For now leave the default of align-items:stretch. The main change here is that iframe/img will do width:auto the same as blocks (i.e. the width of the parent). I think this is a good change, but we'll have to see how it feels in practice. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1061163002
-
- 01 Apr, 2015 1 commit
-
-
Hixie authored
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1043283003
-
- 27 Mar, 2015 1 commit
-
-
Adam Barth authored
TBR=ojan@chromium.org Review URL: https://codereview.chromium.org/1037163002
-
- 26 Mar, 2015 5 commits
-
-
Adam Barth authored
We're trying to clean up the //sky/examples directory to focus on mobile use cases for the fn framework. Terminal is both focused on desktop and uses the older custom-element framework. R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/1038813005
-
Adam Barth authored
1) Merge input example into widgets example 2) Move single-file, non-fn examples into a "raw" directory 3) Rename stocks-fn and widgets-fn to stocks and widgets R=ojan@chromium.org Review URL: https://codereview.chromium.org/1005393006
-
Adam Barth authored
It's not really an example of how to use Sky. It's a resource for benchmarking. TBR=raf@chromium.org Review URL: https://codereview.chromium.org/1030423002
-
Adam Barth authored
Flights is not longer a good example of something you can build wity Sky. Restore the flights-app-pixel test and move the assets needed for the test into the tests directory. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1034953003
-
Adam Barth authored
TBR=ojan@chromium.org Review URL: https://codereview.chromium.org/1038873005
-
- 25 Mar, 2015 4 commits
-
-
Adam Barth authored
When the StocksApp menu is showing, the user shouldn't be able to interact with the rest of the app. Instead, taps outside the menu should dismiss the menu. This CL makes that happen by adding a ModalOverlay on top of the app. We might want to do something fancier in the future using event delegation, but this works for now. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1031093002
-
Adam Barth authored
There's no reason for InkWell to take a |style| parameter anymore. Clients can simply use StyleNode instead. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1019443003
-
Adam Barth authored
This CL teaches PopupMenu how to animate out as well as in. Also, I've changed the PopupMenuItem animations to be driven from the PopupMenu itself, which makes it easier to run the animation in reverse when closing the menu. TBR=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1033913002
-
Adam Barth authored
This CL cleans up stock_app.dart to better separate concerns now that we have StyleNode. Also, this CL introduces IconButton, which will grow to include an ink effect in the future, and makes the background of the search bar white. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1007893005
-
- 24 Mar, 2015 3 commits
-
-
Adam Barth authored
Previously we would spend a lot of time during startup processing all 3k stocks in the data set. This CL breaks the data up into 100 stock chunks and loads them incrementally off the network. A future CL will switch to loading them on demand. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1038533002
-
Viet-Trung Luu authored
It's especially crappy since it doesn't actually do much/any error handling. Use: $ sky/tools/skydb start out/Debug \ 'sky/examples/terminal/index.sky?url=mojo:netcat?host=localhost%26port=80' (Note: We don't have a resolver yet, so the host either has to be "localhost" or an IPv4 address in the form N1.N2.N3.N4.) R=erg@chromium.org Review URL: https://codereview.chromium.org/1032743002
-
Viet-Trung Luu authored
TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/1031933002
-
- 23 Mar, 2015 4 commits
-
-
Adam Barth authored
This will let us form a wholistic picture of work done in the framework and in the engine. R=ojan@chromium.org, rafaelw@chromium.org Review URL: https://codereview.chromium.org/1028243003
-
Adam Barth authored
Build fix after recent Dart bindings refactoring. Now that these libraries are not included in the snapshot, we need to load them from the mojo package. R=zra@google.com TBR=zra@chromium.org Review URL: https://codereview.chromium.org/1029683002
-
Adam Barth authored
We were missing the ability to initialize one of the fields. TBR=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1027293003
-
Adam Barth authored
Instead of hard-coding the stock data in the Dart file, this CL moves the data to a JSON file and loads that file over the network. This change improves load time for the Stocks app from 3 seconds to 2 seconds. Also, this CL removes shake-to-reload from the Stocks app because that also slows down load time (due to the two module systems fighting each other). R=rafaelw@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/1021723005
-
- 20 Mar, 2015 6 commits
-
-
Eric Seidel authored
Also bumped package:sky's version in prep for publishing. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/1024243002
-
Eric Seidel authored
I'm not sure this is the final long-term solution, but works for now. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1022193002
-
Eric Seidel authored
TBR=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/1021933004
-
Rafael Weinstein authored
TBR=abarth BUG= Review URL: https://codereview.chromium.org/1024183002
-
Adam Barth authored
StockMenu was creating a container for the sole purpose of applying style to PopupMenu. Now we just use a StyleNode. Also, I've reverted the change to make box-sizing default to border-box. It turns out that CL wasn't effective because we didn't use the initialBoxSizing function to initialize box sizing. I've made us use initialBoxSizing but switch the default back to content-box because actually using border-box breaks a bunch of stuff. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1024083003
-
Adam Barth authored
This CL extracts a Scaffold component from StockApp. The Scaffold component lets you create an "app-like" layout with an action bar, a drawer, etc. R=ojan@chromium.org, rafaelw@chromium.org Review URL: https://codereview.chromium.org/1027813002
-
- 16 Mar, 2015 1 commit
-
-
Rafael Weinstein authored
This patch adds a new (non-Render) StyleNode which takes two arguments: A (content) node, which it wraps and a Style object. This allows for styles to be applied to Nodes which are constructed elsewhere (e.g. passed in as arguments). R=abarth@chromium.org Review URL: https://codereview.chromium.org/1027653002
-
- 19 Mar, 2015 3 commits
-
-
Adam Barth authored
This CL adds just enough custom painting to Sky to make sky/examples/painting/circle.sky draw a circle. Over time, we should be able to elaborate this system into something interesting and to make it actually work in a reasonable way. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1017593005
-
Adam Barth authored
1) Factors InkWell out of Material so that components can use an ink well without needing the shadow/level machinery. 2) Makes the ink effect move at a different velocity once the tap has actually occurred, converging with the spec. We don't have the right speeds yet, but at least we're approaching the right shape. 3) To support (2), added a primaryPointer attribute to GestureEvents to let authors coorelate gesturetapdown events with later gesturetap events. 4) To support (2), modernized SplashAnimation to used AnimatedValue and friends. 5) Added more constants to view-configuration.dart that match Android. I've also removed the cancelling of the ink effect on scroll. The proper way to do that is to notice that someone in the event chain is listening for scrollstart and delay the beginning of the ink effect for some period of time. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1019023003
-
Viet-Trung Luu authored
(Using the query string from the URL.) R=erg@chromium.org Review URL: https://codereview.chromium.org/1019323002
-
- 15 Mar, 2015 1 commit
-
-
Rafael Weinstein authored
This patch removes the mutable API to event handling (Nodes no longer have a events object with which to add listeners). Instead, a new (non-Render) Node is introduced: EventTarget. This node represents a location in the Effen tree which can handle events as they bubble. Note that this also changes the implementation to use event delegation (one set of listeners at the sky.document level) rather than direct listeners on leaf nodes. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1019633004
-
- 18 Mar, 2015 5 commits
-
-
Adam Barth authored
We're now doing all of the elements of the popup menu entrance animation from the material design spec, but our timing and curves might not be exactly right yet. I haven't started on the exit animation. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1017193004
-
Eric Seidel authored
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1022613002
-
Eric Seidel authored
Before this change Sky would hit 404s when trying to load examples from domokit.github.io. I also added a separate sky_home and updated the default url to point to sky_home instead of home. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1016143002
-
Adam Barth authored
This CL also refactors how animations work, particularly for the Drawer. I've renamed DrawerAnimation to DrawerController and switched it from being an Animation to having an Animation. I've also renamed Animation to AnimatedValue to capture the idea that the class actually presents the value being animated. Finally, I've factored AnimatedValueListener out of Drawer so that it can be used by PopupMenuItem as well. Finally, I've added a scheduleBuild convienence function to Component instead of having to call setState(() {}), which has come up a couple times. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1016093002
-
Adam Barth authored
We should probably move this menu into a view for an individual stock, but for now add it to the main stock screen. R=ojan@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/1008003007
-
- 17 Mar, 2015 2 commits
-
-
Adam Barth authored
1) Add a pubspec.yaml. 2) Move all the code into a 'lib' directory. 3) Move the stock widgets out of the app's library. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1011023003
-
Viet-Trung Luu authored
Ditto for terminal_client.mojom, previously in examples/echo_terminal. Fix the sky terminal example. R=erg@chromium.org Review URL: https://codereview.chromium.org/1013313002
-