- 14 Feb, 2020 2 commits
-
-
Dan Field authored
Track images available on screen
-
Taufiq Rahman authored
* Feature: allow minLines in SelectableText
-
- 13 Feb, 2020 3 commits
-
-
Gary Qian authored
-
Greg Spencer authored
This re-lands #49235 with the addition of includeSemantics flag on the Focus widget so that the FocusTraversalGroup can create a Focus widget without affecting the semantics tree. The FocusTraversalGroup uses the Focus widget to create a grouping of descendants for traversal, but doesn't actually participate in focus (canRequestFocus is always false), so we don't want it to add a Semantics widget in that case, since that can cause semantics changes. The canRequestFocus attribute can also be used when a widget is disabled, so we do sometimes want to include Semantics even if that is false, but not in the case where it is always false, as for FocusTraversalGroup. - Added a test to make sure that FocusTraversalGroup doesn't add any semantics information.
-
Greg Spencer authored
This fixes a problem when unfocusing focus nodes where the ancestor focus nodes and scopes don't receive notification that a child was unfocused. Fixes #43497
-
- 12 Feb, 2020 3 commits
-
-
chunhtai authored
-
Jacob Richman authored
-
Greg Spencer authored
This reverts commit 8ef5e2f0 because it breaks some semantics tests.
-
- 11 Feb, 2020 4 commits
-
-
LongCatIsLooong authored
-
Alexandre Ardhuin authored
-
Greg Spencer authored
This change adds a way to provide explicit focus order for a part of the widget tree. It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR. It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String. As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior. I was able to do this without breaking the API (AFAICT).
-
Gary Qian authored
-
- 10 Feb, 2020 5 commits
-
-
Mouad Debbar authored
-
Greg Spencer authored
This makes FocusManager a ChangeNotifier that notifies when the primaryFocus changes so that an app can track the current focus. Fixes #50501
-
Dan Field authored
-
Dan Field authored
-
liyuqian authored
-
- 08 Feb, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 07 Feb, 2020 2 commits
-
-
Alexandre Ardhuin authored
-
Dan Field authored
-
- 06 Feb, 2020 1 commit
-
-
Dan Field authored
-
- 05 Feb, 2020 2 commits
-
-
chunhtai authored
-
creativecreatorormaybenot authored
-
- 04 Feb, 2020 3 commits
-
-
Chris Bracken authored
This change broke some internal tests that set the text editing value to the same thing (the empty string) twice in a row. Note that in that case, the developer had subclassed EditableTextState and overridden the updateEditingValue method, which may or may not be relevant to the failure. This reverts commit 83d4d63a.
-
Jenn Magder authored
This reverts commit a1143d17.
-
- 03 Feb, 2020 1 commit
-
-
Remi Rousselet authored
-
- 01 Feb, 2020 2 commits
- 31 Jan, 2020 8 commits
-
-
Kate Lovett authored
-
Kate Lovett authored
-
Alexandre Ardhuin authored
-
Shi-Hao Hong authored
This reverts commit 46ccd086.
-
Dan Field authored
-
Gary Qian authored
-
Jonah Williams authored
This reverts commit 340b193f.
-
- 30 Jan, 2020 3 commits
-
-
chunhtai authored
-
Greg Spencer authored
This PR fixes #49647 by changing DiagnosticableMixin.toDiagnosticsNode and other things to accept DiagnosticableMixin instead of requiring Diagnosticable.
-
Dan Field authored
-