Commits · 3aca26edec28af39a4f854e690e3e7c89077d82a · abdullh.alsoleman / Front-End

25 Aug, 2023 4 commits

Roll Flutter Engine from 1382d6d79408 to 9bcefc74b772 (2 revisions) (#133305) · 3aca26ed

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/1382d6d79408...9bcefc74b772

2023-08-25 zanderso@users.noreply.github.com Revert ios cpu changes (flutter/engine#45095)
2023-08-25 30870216+gaaclarke@users.noreply.github.com [Impeller] Refactor: Create attachment descriptions without setting layouts (flutter/engine#45088)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3aca26ed

Allow passing verbose log from flutter daemon. (#132828) · 22a61b94
Lau Ching Jun authored Aug 25, 2023
```
It would be helpful for debugging if we can choose to also receive remote verbose logs.
```
22a61b94

Roll Flutter Engine from b8ec4da8866c to 1382d6d79408 (1 revision) (#133298) · 865b5b48

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/b8ec4da8866c...1382d6d79408

2023-08-25 flar@google.com Reland "Split DisplayListBuilder into
DlCanvas optimizer and DlOp recorder classes #44718"
(flutter/engine#45085)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

865b5b48

Roll Flutter Engine from 965501a25d92 to b8ec4da8866c (11 revisions) (#133296) · c8b9ae50

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/965501a25d92...b8ec4da8866c

2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 99a76ea8e1b2 to 1428f16fc0de (1 revision) (flutter/engine#45086)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 25fafff5b32c to 99a76ea8e1b2 (2 revisions) (flutter/engine#45083)
2023-08-24 jacksongardner@google.com Revert "Turn on the `skia_enable_optimize_size` flag to save a bit of binary size" (flutter/engine#45082)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from d7d56885a49b to 25fafff5b32c (1 revision) (flutter/engine#45081)
2023-08-24 dnfield@google.com [Impeller] Do not build scene unless 3d define is true (flutter/engine#45028)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 177e8477faf9 to d7d56885a49b (1 revision) (flutter/engine#45078)
2023-08-24 dkwingsmt@users.noreply.github.com Reland: [Rasterizer] Make resubmit information temporary (flutter/engine#45037)
2023-08-24 34871572+gmackall@users.noreply.github.com Add case checking to android sdk cipd upload script (flutter/engine#45063)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 007386294889 to 177e8477faf9 (1 revision) (flutter/engine#45076)
2023-08-24 jacksongardner@google.com Turn on the `skia_enable_optimize_size` flag to save a bit of binary size (flutter/engine#45029)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from b17ee34f3378 to 007386294889 (1 revision) (flutter/engine#45075)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c8b9ae50

24 Aug, 2023 16 commits

Bump actions/checkout from 3.5.3 to 3.6.0 (#133281) · d387f551

dependabot[bot] authored Aug 24, 2023

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v3.6.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Mark test scripts with Bash'isms to be run via Bash by <a href="https://github.com/dscho"><code>@âdscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1377">actions/checkout#1377</a></li>
<li>Add option to fetch tags even if fetch-depth &gt; 0 by <a href="https://github.com/RobertWieczoreck"><code>@âRobertWieczoreck</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/579">actions/checkout#579</a></li>
<li>Release 3.6.0 by <a href="https://github.com/luketomlinson"><code>@âluketomlinson</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1437">actions/checkout#1437</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/RobertWieczoreck"><code>@âRobertWieczoreck</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/579">actions/checkout#579</a></li>
<li><a href="https://github.com/luketomlinson"><code>@âluketomlinson</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1437">actions/checkout#1437</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3.5.3...v3.6.0">https://github.com/actions/checkout/compare/v3.5.3...v3.6.0</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/579">Add option to fetch tags even if fetch-depth &gt; 0</a></li>
</ul>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade <code>@âactions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1045">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942">Add GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967">Fix status badge</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1002">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1029">Update <code>@âactions/io</code> to 1.1.2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1039">Upgrading version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/939">Use <code>@âactions/core</code> <code>saveState</code> and <code>getState</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/922">Add <code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/770">Add input <code>set-safe-directory</code></a></li>
</ul>
<h2>v3.0.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/762">Fixed an issue where checkout failed to run in container jobs due to the new git setting <code>safe.directory</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/744">Bumped various npm package versions</a></li>
</ul>
<h2>v3.0.0</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/checkout/commit/f43a0e5ff2bd294095638e18286ca9a3d1956744"><code>f43a0e5</code></a> Release 3.6.0 (<a href="https://redirect.github.com/actions/checkout/issues/1437">#1437</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/7739b9ba2efcda9dde65ad1e3c2dbe65b41dfba7"><code>7739b9b</code></a> Add option to fetch tags even if fetch-depth &gt; 0 (<a href="https://redirect.github.com/actions/checkout/issues/579">#579</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/96f53100ba2a5449eb71d2e6604bbcd94b9449b5"><code>96f5310</code></a> Mark test scripts with Bash'isms to be run via Bash (<a href="https://redirect.github.com/actions/checkout/issues/1377">#1377</a>)</li>
<li>See full diff in <a href="https://github.com/actions/checkout/compare/c85c95e3d7251135ab7dc9ce3241c5835cc595a9...f43a0e5ff2bd294095638e18286ca9a3d1956744">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=3.5.3&new-version=3.6.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

d387f551

Update the tool to know about all our new platforms (#132423) · d6bf1447
Ian Hickson authored Aug 24, 2023
```
...and add a test so we remember to keep it in sync.
```
d6bf1447
l10n-related documentation improvements (#133114) · 5fa8de05
Ian Hickson authored Aug 24, 2023

5fa8de05

Add hover duration for `Inkwell` widget (#132176) · b2118918

Henry Riehl authored Aug 24, 2023

Adds a `hoverDuration` property to the `Inkwell` widget. This allows the user to customise how long the change in colour animates between the default colour and the hovered colour.

https://github.com/flutter/flutter/assets/73116038/2e7c5ccb-8651-4e08-8c7b-225cc005d594

Fixes #132170

b2118918

[web] benchmark the benchmark harness overhead (#132999) · cb72164a

Yegor authored Aug 24, 2023

Add benchmarks that measure the overhead of the benchmark harness itself. We want the overhead to be minimal. Also, these numbers are useful to judge the quality of real benchmarks. If a real benchmark's result is too close to the harness overhead, then it's likely not measuring enough of useful work.

cb72164a

Users of ChangeNotifier should dispatch event of object creation in constructor. (#133210) · afa37891
Polina Cherkasova authored Aug 24, 2023

afa37891

Bump activesupport from 6.1.7.3 to 6.1.7.6 in /dev/ci/mac (#133225) · 8175d693

dependabot[bot] authored Aug 24, 2023

Bumps [activesupport](https://github.com/rails/rails) from 6.1.7.3 to 6.1.7.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/rails/rails/releases">activesupport's releases</a>.</em></p>
<blockquote>
<h2>v6.1.7.6</h2>
<p>No changes between this and 6.1.7.5.  This release was just to fix file permissions in the previous release.</p>
<h2>6.1.7.5 Release</h2>
<h2>Active Support</h2>
<ul>
<li>
<p>Use a temporary file for storing unencrypted files while editing</p>
<p>[CVE-2023-38037]</p>
</li>
</ul>
<h2>Active Model</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Active Record</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Action View</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Action Pack</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Active Job</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Action Mailer</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Action Cable</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/rails/rails/commit/56bcc0abd3c9a6b09469e9428f6eea0dd77c2294"><code>56bcc0a</code></a> Preparing for 6.1.7.6 release</li>
<li><a href="https://github.com/rails/rails/commit/1f03e9dcbf75bf2a18f2b9a2212eff32d1a70612"><code>1f03e9d</code></a> Bumping version for new release</li>
<li><a href="https://github.com/rails/rails/commit/3a1b6150a9b7619fb6d020b61c3b8f8d493142b0"><code>3a1b615</code></a> Preparing for 6.1.7.5 release</li>
<li><a href="https://github.com/rails/rails/commit/c2af5781a972fcc5f39ef0a2915fca480f1aa186"><code>c2af578</code></a> bumping version / changelog</li>
<li><a href="https://github.com/rails/rails/commit/c85cc667ebfd3c270df37c7575d580ea6462e12f"><code>c85cc66</code></a> Use a temporary file for storing unencrypted files while editing</li>
<li><a href="https://github.com/rails/rails/commit/7d949d7c81d2ec3c6d21525ebb08c85f3f174b74"><code>7d949d7</code></a> Preparing for 6.1.7.4 release</li>
<li>See full diff in <a href="https://github.com/rails/rails/compare/v6.1.7.3...v6.1.7.6">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=activesupport&package-manager=bundler&previous-version=6.1.7.3&new-version=6.1.7.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/flutter/flutter/network/alerts).

</details>

8175d693

Remove `ImageProvider.load`, `DecoderCallback` and... · b4f4ece4

LongCatIsLooong authored Aug 24, 2023

Remove `ImageProvider.load`, `DecoderCallback` and `PaintingBinding.instantiateImageCodec` (#132679)

~The failing plugin tests should pass once
https://github.com/flutter/packages/pull/4725 lands and rolls into
flutter/flutter~

google tests are migrated.

Part of https://github.com/flutter/flutter/issues/133171

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

b4f4ece4

Roll Flutter Engine from aa98a9d2e86f to 965501a25d92 (24 revisions) (#133272) · 74ccd1d5

engine-flutter-autoroll authored Aug 24, 2023

https://github.com/flutter/engine/compare/aa98a9d2e86f...965501a25d92

2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 8b0fd320865e to b17ee34f3378 (1 revision) (flutter/engine#45073)
2023-08-24 zanderso@users.noreply.github.com Revert Dart SDK to 3.2.0-97.0.dev (flutter/engine#45072)
2023-08-24 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 87a5a26b25fc to bcad589d5d81 (4 revisions) (flutter/engine#45065)
2023-08-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from P8oeVw3whCGS6pCjL... to jkVyhV_xfb8Mv43xj... (flutter/engine#45068)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from e008ee76b890 to 8b0fd320865e (3 revisions) (flutter/engine#45067)
2023-08-24 whesse@google.com Remove package linter from DEPS (flutter/engine#45053)
2023-08-24 zanderso@users.noreply.github.com Revert "[Impeller] Add debug captures and inspector." (flutter/engine#45062)
2023-08-24 jonahwilliams@google.com [Impeller] Don't place vertex buffer bindings in the Binding map. (flutter/engine#45040)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 994d5e03fa1c to e008ee76b890 (1 revision) (flutter/engine#45061)
2023-08-24 jonahwilliams@google.com Revert "[Impeller] add trace events for VkRenderPass and VkFrameBuffeâ¦ (flutter/engine#45047)
2023-08-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from XoUnFqSvX9mhbXqBJ... to 0kEa4JczTMD0Xus08... (flutter/engine#45060)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 68700a1a2be9 to 994d5e03fa1c (1 revision) (flutter/engine#45059)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 13a050278b1a to 68700a1a2be9 (1 revision) (flutter/engine#45058)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 317f4c2ba2ca to 13a050278b1a (1 revision) (flutter/engine#45054)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 17c0f4b72fcd to 317f4c2ba2ca (1 revision) (flutter/engine#45051)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 82472773892d to 17c0f4b72fcd (1 revision) (flutter/engine#45050)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 02eecda395ba to 82472773892d (1 revision) (flutter/engine#45049)
2023-08-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from vJ6oaubpqgRM2nb1e... to P8oeVw3whCGS6pCjL... (flutter/engine#45046)
2023-08-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -HcyJtxGxUDcqX-jo... to XoUnFqSvX9mhbXqBJ... (flutter/engine#45044)
2023-08-24 skia-flutter-autoroll@skia.org Manual roll Dart SDK from ab417bc74bb1 to 87a5a26b25fc (4 revisions) (flutter/engine#45043)
2023-08-24 bdero@google.com [Impeller] Add debug captures and inspector. (flutter/engine#43764)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from e3ee267859a7 to 02eecda395ba (1 revision) (flutter/engine#45042)
2023-08-24 jason-simmons@users.noreply.github.com Remove a clang-tidy test that launches a full run of clang-tidy (flutter/engine#45033)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 9d4db3443527 to e3ee267859a7 (1 revision) (flutter/engine#45036)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from -HcyJtxGxUDc to 0kEa4JczTMD0
fuchsia/sdk/core/mac-amd64 from vJ6oaubpqgRM to jkVyhV_xfb8M

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

74ccd1d5

handle exceptions raised while searching for configured android studio (#133180) · e1967eca
Andrew Kolos authored Aug 24, 2023
```
Fixes #133055
```
e1967eca
Fix mac tool_integration_tests with Xcode 15 (#133217) · 12cf9de6
Christopher Fujino authored Aug 24, 2023
```
Fixes https://github.com/flutter/flutter/issues/132990
```
12cf9de6

Roll Packages from 3060b1aec99c to 383bffa3991d (3 revisions) (#133256) · 9632f821

engine-flutter-autoroll authored Aug 24, 2023

https://github.com/flutter/packages/compare/3060b1aec99c...383bffa3991d

2023-08-24 joonas.kerttula@codemate.com [google_maps_flutter] cloud-based map styling implementation (flutter/packages#4638)
2023-08-23 stuartmorgan@google.com [image_picker] Fix exception when canceling `pickMultipleMedia` on iOS (flutter/packages#4761)
2023-08-23 engine-flutter-autoroll@skia.org Roll Flutter from 54c98d74 to bd836cc6 (24 revisions) (flutter/packages#4760)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9632f821

Reverts "Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (#133224)" (#133255) · deeb811e

Zachary Anderson authored Aug 24, 2023

Reverts https://github.com/flutter/flutter/pull/133224
Reverting for failing wide gamut test https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20wide_gamut_ios/3186/overview

deeb811e

Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (#133224) · bede50cb

engine-flutter-autoroll authored Aug 24, 2023

https://github.com/flutter/engine/compare/aa98a9d2e86f...3b92bb6eda19

2023-08-24 bdero@google.com [Impeller] Add debug captures and inspector. (flutter/engine#43764)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from e3ee267859a7 to 02eecda395ba (1 revision) (flutter/engine#45042)
2023-08-24 jason-simmons@users.noreply.github.com Remove a clang-tidy test that launches a full run of clang-tidy (flutter/engine#45033)
2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 9d4db3443527 to e3ee267859a7 (1 revision) (flutter/engine#45036)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bede50cb

Roll Flutter Engine from 67e8b825cc91 to aa98a9d2e86f (4 revisions) (#133220) · b32cd68f

engine-flutter-autoroll authored Aug 24, 2023

https://github.com/flutter/engine/compare/67e8b825cc91...aa98a9d2e86f

2023-08-24 dnfield@google.com [Impeller] Fix stencil buffer format selection on Vulkan backend, add support for D24UnormS8Uint (flutter/engine#45025)
2023-08-24 jason-simmons@users.noreply.github.com Fix a clang-tidy error seen in the latest toolchain roll (flutter/engine#45039)
2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from a631fefdba37 to 9d4db3443527 (1 revision) (flutter/engine#45031)
2023-08-23 zanderso@users.noreply.github.com Roll clang with fix for ABI change (flutter/engine#44711)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b32cd68f

Roll Flutter Engine from 27d75f6221d2 to 67e8b825cc91 (1 revision) (#133214) · dc7fa473

engine-flutter-autoroll authored Aug 24, 2023

https://github.com/flutter/engine/compare/27d75f6221d2...67e8b825cc91

2023-08-23 jonahwilliams@google.com [Impeller] combine uniform metadata and buffer slots. (flutter/engine#45021)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dc7fa473

23 Aug, 2023 20 commits

Remove deprecated PlatformViewsService.synchronizeToNativeViewHierarchy (#133175) · 87c1a461
Kate Lovett authored Aug 23, 2023
```
Part of https://github.com/flutter/flutter/issues/133171
```
87c1a461

Roll Flutter Engine from 58dc868c26cb to 27d75f6221d2 (14 revisions) (#133211) · cfe41a64

engine-flutter-autoroll authored Aug 23, 2023

https://github.com/flutter/engine/compare/58dc868c26cb...27d75f6221d2

2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from 76898dad9fda to a631fefdba37 (2 revisions) (flutter/engine#45027)
2023-08-23 zanderso@users.noreply.github.com Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" (flutter/engine#45023)
2023-08-23 bdero@google.com [Impeller] Dat rvalue reference (fix engine head) (flutter/engine#45024)
2023-08-23 bdero@google.com Revert "Enable clang-tidy for pre-push (opt-out), exclude `performance-unnecessary-value-param`" (flutter/engine#45020)
2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from 4e42b51cfe27 to 76898dad9fda (1 revision) (flutter/engine#45019)
2023-08-23 bdero@google.com [Impeller] Add STB text backend. (flutter/engine#44887)
2023-08-23 reidbaker@google.com Followup to https://github.com/flutter/engine/pull/44982 (flutter/engine#45018)
2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from 5428f147e632 to 4e42b51cfe27 (4 revisions) (flutter/engine#45016)
2023-08-23 reidbaker@google.com Eliminate android test log spam (flutter/engine#44982)
2023-08-23 mdebbar@google.com [web] Remove some unused functions (flutter/engine#44505)
2023-08-23 lhkbob@gmail.com Use decal TileMode in blur image_filter_test.dart (flutter/engine#45004)
2023-08-23 ian@hixie.ch FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#44996)
2023-08-23 jonahwilliams@google.com [impeller] combine sampler and texture maps. (flutter/engine#44990)
2023-08-23 bdero@google.com [Impeller] Flutter GPU: Add HostBuffer. (flutter/engine#44696)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cfe41a64

Remove deprecated MaterialButtonWithIconMixin (#133173) · 8c69fd55
Kate Lovett authored Aug 23, 2023
```
Part of https://github.com/flutter/flutter/issues/133171
```
8c69fd55
Enable ChangeNotifier clients to dispatch event of object creation in constructor. (#133060) · 89907f6d
Polina Cherkasova authored Aug 23, 2023

89907f6d
Enable literal_only_boolean_expressions (#133186) · 382ceb57
Michael Goderbauer authored Aug 23, 2023
```
Blocking issue (https://github.com/dart-lang/linter/issues/453) for this lint has been resolved.
```
382ceb57

Add android analyzer commands for applinks (#131009) · 49306139

chunhtai authored Aug 23, 2023

Since applink validation tool is going to be a static tool, It won't have access to vmservices.

[flutter.dev/go/static-tooling-in-devtools](http://flutter.dev/go/static-tooling-in-devtools)

I remove the vm services and also update the deeplink task to also include path pattern and custom scheme
http://go/android-applink-apis (internal only)

49306139

Bump memory usage in gradle for platform views (#133155) · 6fd33879

Reid Baker authored Aug 23, 2023

fixes #133119 
Similar to https://github.com/flutter/flutter/issues/131006
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

6fd33879

[flutter_tools] Fix legacy version file not being ensured (#133097) · 9e59a68c

Christopher Fujino authored Aug 23, 2023

Fixes https://github.com/flutter/flutter/issues/133093

When I introduced the new, more robust version file `//flutter/bin/cache/version.json` in https://github.com/flutter/flutter/pull/124558, I changed `class FlutterVersion` into an abstract interface, implemented by `_FlutterVersionFromGit` (which is essentially the previous behavior) and `_FlutterVersionFromFile`, which merely reads the data it would have computed via git from `//flutter/bin/cache/version.json`.

While doing this, I made `_FlutterVersionFromGit.ensureVersionFile()` to be a no-op, since I assumed this would not be necessary since we already had a version file in the cache. However, this method was what was previously responsible for ensuring `//flutter/version` existed on disk. This means that if, for whatever reason, the user had `//flutter/bin/cache/flutter.version.json` present but NOT `//flutter/version`, the tool would have never created that file, and they would hit the tool crash seen in https://github.com/flutter/flutter/issues/133093.

This fixes the tool by ensuring `//flutter/version` exists regardless of if we're hydrating `FlutterVersion` from `//flutter/bin/cache/flutter.version.json` or not.

9e59a68c

Remove deprecated *TestValues from TestWindow (#131098) · ad78cf35

Michael Goderbauer authored Aug 23, 2023

Part of https://github.com/flutter/flutter/issues/133171.

Removes from `TestWindow`:
* `localeTestValue`
* `clearLocaleTestValue`
* `localesTestValue`
* `clearLocalesTestValue`
* `initialLifecycleStateTestValue`
* `alwaysUse24HourFormatTestValue`
* `clearAlwaysUse24HourTestValue`
* `brieflyShowPasswordTestValue`
* `defaultRouteNameTestValue`
* `clearDefaultRouteNameTestValue`
* `semanticsEnabledTestValue`
* `clearSemanticsEnabledTestValue`
* `accessibilityFeaturesTestValue`
* `clearAccessibilityFeaturesTestValue`

These properties have reached the end of their deprecation period.

ad78cf35

Roll Flutter Engine from ac352ba95f43 to 58dc868c26cb (2 revisions) (#133165) · 3cfaa34f

engine-flutter-autoroll authored Aug 23, 2023

https://github.com/flutter/engine/compare/ac352ba95f43...58dc868c26cb

2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from 2111e8126c08 to 5428f147e632 (2 revisions) (flutter/engine#45008)
2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DoQ8KUxSk-5EU6VQ1... to vJ6oaubpqgRM2nb1e... (flutter/engine#45005)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from DoQ8KUxSk-5E to vJ6oaubpqgRM

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3cfaa34f

[web] Remove unnecessary lint ignore (#133164) · fd155a34
Mouad Debbar authored Aug 23, 2023
```
This became unnecessary since https://github.com/flutter/flutter/pull/132087
```
fd155a34

Add `--experimental-wasm-type-reflection` and support newer emscripten builds. (#133084) · d8b1e81c

Jackson Gardner authored Aug 23, 2023

This makes two changes to prepare for incoming changes to skwasm in the web engine:
* We will (at least for now) be depending on the `WebAssembly.Function` constructor in `skwasm`, which is hidden behind the `--experimental-wasm-type-reflection` flag. We need to pass that when running skwasm benchmarks.
* We are going to be upgrading the skwasm build to a newer version of emscripten, which exposes the wasm exports via the `wasmExports` property instead of the `asm` property. Make sure to support either, if passed.

d8b1e81c

Roll Flutter Engine from 72a06427bd37 to ac352ba95f43 (2 revisions) (#133158) · 8ba40bb1

engine-flutter-autoroll authored Aug 23, 2023

https://github.com/flutter/engine/compare/72a06427bd37...ac352ba95f43

2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from d0c369eaa637 to 2111e8126c08 (1 revision) (flutter/engine#45002)
2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VSvpNFoFjqXIQTcs6... to -HcyJtxGxUDcqX-jo... (flutter/engine#44999)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from VSvpNFoFjqXI to -HcyJtxGxUDc

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8ba40bb1

Roll Packages from c730a90f2fcc to 3060b1aec99c (4 revisions) (#133149) · bd836cc6

engine-flutter-autoroll authored Aug 23, 2023

https://github.com/flutter/packages/compare/c730a90f2fcc...3060b1aec99c

2023-08-23 ian@hixie.ch [rfw] Support web (as JS) (flutter/packages#4650)
2023-08-22 84124091+opxdelwin@users.noreply.github.com [webview_flutter] Update sample code. (flutter/packages#4727)
2023-08-22 ctrysbita@outlook.com [flutter_adaptive_scaffold] Fix top padding for NavigationBar (flutter/packages#4661)
2023-08-22 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `ImageProvider` methods (flutter/packages#4725)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bd836cc6

Roll Flutter Engine from 7d56840865d2 to 72a06427bd37 (8 revisions) (#133139) · 575fd7ee

engine-flutter-autoroll authored Aug 23, 2023

https://github.com/flutter/engine/compare/7d56840865d2...72a06427bd37

2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from ee7404db8273 to d0c369eaa637 (1 revision) (flutter/engine#44997)
2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from d0d2b7042bb9 to ee7404db8273 (1 revision) (flutter/engine#44995)
2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from eac8f8ea2660 to d0d2b7042bb9 (1 revision) (flutter/engine#44994)
2023-08-23 zanderso@users.noreply.github.com Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" (flutter/engine#44993)
2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from aa208c8a2d60 to eac8f8ea2660 (1 revision) (flutter/engine#44992)
2023-08-23 dkwingsmt@users.noreply.github.com Move Rasterizer::Draw's discard_callback to Delegate (flutter/engine#44813)
2023-08-23 ian@hixie.ch FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#43750)
2023-08-23 ian@hixie.ch Make web tests start with an empty title (flutter/engine#43846)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

575fd7ee

Manual roll Flutter Engine from b190f9015049 to 7d56840865d2 (15 revisions) (#133106) · 4bbcb780

engine-flutter-autoroll authored Aug 23, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/b190f9015049...7d56840865d2

2023-08-23 zanderso@users.noreply.github.com Revert "Roll Dart SDK from
ab417bc74bb1 to c162b4979562 (1 revision)" (flutter/engine#44989)
2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
G25oJMO5jbUi-UN4F... to DoQ8KUxSk-5EU6VQ1... (flutter/engine#44988)
2023-08-23 zanderso@users.noreply.github.com Revert "Make `FontWeight`
an enum, Remove unused text classes" (flutter/engine#44987)
2023-08-23 skia-flutter-autoroll@skia.org Roll Dart SDK from
ab417bc74bb1 to c162b4979562 (1 revision) (flutter/engine#44986)
2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
kKI09su99b0AKs8b3... to VSvpNFoFjqXIQTcs6... (flutter/engine#44984)
2023-08-23 matanlurey@users.noreply.github.com Enable clang-tidy for
pre-push (opt-out), exclude `performance-unnecessary-value-param`
(flutter/engine#44936)
2023-08-22 john@johnmccutchan.com Restore old SurfaceTextureExternal
drawing code (flutter/engine#44979)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from d0918de21c1a to
aa208c8a2d60 (2 revisions) (flutter/engine#44981)
2023-08-22 jason-simmons@users.noreply.github.com Initialize the texture
destruction callback in the Metal embedder test harness
(flutter/engine#44973)
2023-08-22 matanlurey@users.noreply.github.com Further filter/clear
`<SkPaint>.setDither(true)`, this time in `DlSkPaintDispatchHelper`
(flutter/engine#44912)
2023-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from
3ebf0fedfceb to ab417bc74bb1 (1 revision) (flutter/engine#44977)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from bf6019be75ef to
d0918de21c1a (3 revisions) (flutter/engine#44975)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from c675298ddeda to
bf6019be75ef (3 revisions) (flutter/engine#44974)
2023-08-22 31859944+LongCatIsLooong@users.noreply.github.com Make
`FontWeight` an enum, Remove unused text classes (flutter/engine#44960)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 9f4b81aac175 to
c675298ddeda (2 revisions) (flutter/engine#44971)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from kKI09su99b0A to VSvpNFoFjqXI
  fuchsia/sdk/core/mac-amd64 from G25oJMO5jbUi to DoQ8KUxSk-5E

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4bbcb780

Reference AppLifecycleListener from widgets library (#132995) · 88290989
Ian Hickson authored Aug 23, 2023

88290989
Support disabling animations in the CLI (#132239) · 487bd690
Ian Hickson authored Aug 23, 2023

487bd690
Don't run on Samsung S10, shift to Pixel 7 Pro (#133085) · d8470f71
Zachary Anderson authored Aug 23, 2023

d8470f71
Add test to mark recording as leaking. (#133073) · 2afded61
Polina Cherkasova authored Aug 23, 2023

2afded61