1. 31 Aug, 2020 12 commits
    • Dan Field's avatar
      Remove assert about release mode (#64813) · 3aa0243a
      Dan Field authored
      b/150295238 has been resolved for a while now.
      3aa0243a
    • Casey Hillers's avatar
    • engine-flutter-autoroll's avatar
    • ekibun's avatar
      add different workload & add -products * to vswhere calls to check both Visual... · 719268b4
      ekibun authored
      add different workload & add -products * to vswhere calls to check both Visual Studio IDE and standalone Build Tools. (#64251)
      
      719268b4
    • James Clarke's avatar
    • engine-flutter-autoroll's avatar
    • Chris Bracken's avatar
      Prefer moreOrLessEquals over closeTo (#64915) · c0ea00ed
      Chris Bracken authored
      Flutter's `moreOrLessEquals` has a few advantages over `closeTo` from
      the `matcher` package:
      
         * It emits the epsilon value in the test result on failure.
         * It uses a named parameter for epsilon, which improves readability
           at the call site.
         * It has a reasonable default for epsilon in cases where something
           more specific isn't required.
      
      Using it also has the nice property that it aids in its own discovery
      when when people go looking for such functionality in new tests.
      
      This change also includes a couple unrelated whitespace formatting cleanups.
      c0ea00ed
    • Shi-Hao Hong's avatar
      [gen_l10n] Synthetic package generation by default (#62395) · fd22fc3e
      Shi-Hao Hong authored
      * synthetic packages by default in gen_l10n tool
      
      * Refactor default path for synthetic package
      
      * Remove unused import
      
      * Code cleanup
      
      * Further improvements to help text
      
      * Refactor synthetic package path
      
      * Remove newlines
      
      * Test cleanup
      
      * clean up logic in inputs and outputs list function
      
      * Update l10n.yaml usage
      
      * only add option if value is non-null
      
      * Update stocks app as proof of concept for synthetic package usage
      
      * Address nits
      
      * print pubspec contents
      
      * add print statements
      
      * Do not allow null value for useSyntheticPackage
      
      * +
      
      * +
      
      * +
      
      * +
      
      * Cleanup
      
      * Add test
      
      * Fix text
      
      * Dont parse pubspec directly
      
      * Test using context
      
      * WIP: generate synthetic packages on pub get -- needs tests
      
      * Allow null value
      
      * Update null handling
      
      * Refactor to properly handle null case
      
      * Fix yamlMap condition
      
      * Fix yaml node for real
      
      * WIP: struggling to write tests
      
      * WIP - take absolute path as an option
      
      * Add tests
      
      * Use environment project directory for synthetic package generation pathway
      
      * Fix typo
      
      * Improve help text
      
      * Update defaults
      
      * Remove unauthorized path import
      
      * Fix pathing issues at synthetic package generation
      
      * Fix typo in test
      
      * Use path.join so projectDir matches up based on OS
      
      * Fix Windows pathing in test
      
      * Remove unnecessary replaceApp code for projectDir.path
      
      * Use globals.fs.currentDirectory.path in resident_runner_test.dart
      
      * Fix merge conflict
      
      * Add test to ensure that synthetic package is generated on pub get
      
      * Fix resident_runner_test.dart tests
      
      * Fix tests
      
      * Use package:file instead of dart:io
      
      * WIP - exploration
      
      * Remove synthetic package use from stocks example
      
      * Update integration test to not use synthetic packages
      
      * Remove trailing whitespace
      
      * flutter pub get runs synth package generation
      
      * Remove more print statements
      
      * Add license header
      
      * WIP - minimally working pub.get
      
      * Use own MockBuildSystem
      
      * Modify test and implementation to be a little cleaner
      
      * Fix flutter pub get invocation
      
      * Use synthetic packages in stocks app
      
      * Revert "Use synthetic packages in stocks app"
      
      This reverts commit 45bf24903c3d4a2a5fd5481d7d6bc36c4a348703.
      
      * Add environment and buildSystem params to flutter test
      
      * Address code review feedback
      
      * +
      
      * Isolate codegen into its own API
      
      * Fix imports
      
      * Slight refactor
      
      * Add one more test for no l10n.yaml file
      
      * Remove unneeded mock class and import in pub_get_test.dart
      
      * More code review feedback
      
      * Remove unnecessary imports
      
      * Remove `return await`s that I missed
      
      * use arrow functions instead
      fd22fc3e
    • Chris Bracken's avatar
      Prefer moreOrLessEquals to closeTo (#64914) · c935a448
      Chris Bracken authored
      moreOrLessEquals is the preferred mechanism for checking that a value is
      within some error bound epsilon, with default value for epsilon of
      precisionErrorTolerance.
      
      This patch replaces instances of closeTo using precisionErrorTolerance.
      c935a448
    • engine-flutter-autoroll's avatar
    • Chris Bracken's avatar
      Match lerped values using moreOrLessEquals (#64908) · 8fa5c55e
      Chris Bracken authored
      Several of our tests make use of numbers without an exact floating point
      representation (frequently 0.x where x!=5) which, when scaled, also
      scale the error. The end result is that some of these tests currently
      implicitly rely on an implementation detail of floating point math and
      are sensitive to differences in the ~15th decimal place.
      
      This patch reduces the sensitivity of some of these tests, checking
      values using `moreOrLessEquals` from the flutter_test package
      rather than requiring en exact match.
      8fa5c55e
    • engine-flutter-autoroll's avatar
  2. 30 Aug, 2020 3 commits
  3. 29 Aug, 2020 7 commits
  4. 28 Aug, 2020 18 commits