1. 23 Aug, 2021 1 commit
  2. 09 Aug, 2021 1 commit
  3. 08 Jul, 2021 1 commit
  4. 22 Mar, 2021 1 commit
  5. 17 Dec, 2020 1 commit
  6. 09 Nov, 2020 1 commit
  7. 31 Oct, 2020 1 commit
  8. 12 Oct, 2020 1 commit
  9. 02 Oct, 2020 1 commit
    • Tong Mu's avatar
      Lazily compute PointerEvent's transformed positions (#63813) · 74fe6bff
      Tong Mu authored
      * PointerEvent.local* properties are calculated lazily; other properties are delegated to original.
      * Transformed PointerEvent becomes a subclass of its original class.
      * Unnamed constructors no longer accepts transform and origin.
      74fe6bff
  10. 08 Sep, 2020 1 commit
    • Jonah Williams's avatar
      [framework] make hit slop based on device pointer kind for drag/pan/scale gestures (#64267) · 29898812
      Jonah Williams authored
      Currently the framework uses fairly large "hit slop" values to disambiguate taps from drags/pans. This makes sense on touch devices where the interaction is not very precise, on mice however it can feel as if the UI is lagging. This is immediately noticeable on our infra dashboard, where it takes almost half of a grid square of drag before the actual drag kicks in.
      
      One potential solution is to always use smaller constants depending on whether the interaction is mouse or touch based. The only reasonable choice is to use the pointer device kind and not target platform - same platform can have different input sources. This requires exposing the pointer device kind in a few new places in several of the gesture detectors, and using the enum to compute the correct hit slop from an expanded set of constants.
      
      This almost works, however there are a few places (notably ListViews) which uses the touch hit slop as a default value in scroll physics. It does not seem like it will be easy to disambiguate a user provided scroll physics constant from the default and/or adjust it somehow - this might require significant changes to scroll physics which I have left out of this PR.
      
      This PR does not adjust:
      
      kTouchSlop used in scroll_physics.dart's minFlingDistance
      kTouchSlop used in PrimaryPointerGestureRecognizer/LongPressGestureRecognizer
      29898812
  11. 24 Aug, 2020 1 commit
  12. 20 Aug, 2020 1 commit
  13. 08 Aug, 2020 1 commit
  14. 06 Aug, 2020 1 commit
  15. 28 Jul, 2020 1 commit
  16. 14 Jul, 2020 1 commit
  17. 08 Jul, 2020 1 commit
  18. 07 Jul, 2020 3 commits
  19. 11 Jun, 2020 1 commit
  20. 01 May, 2020 1 commit
  21. 11 Mar, 2020 1 commit
    • Greg Spencer's avatar
      Convert Diagnosticable to a mixin (#51495) · 210f4d83
      Greg Spencer authored
      This converts Diagnosticable to be a mixin instead of an abstract class, so that it can be used to add diagnostics to classes which already have a base class.
      
      It leaves in place the DiagnosticableMixin mixin, since there are some plugins that are still using it, and removing it would mean that those plugins wouldn't work with master branch Flutter anymore. DiagnosticableMixin will be removed once this mixin version of Diagnosticable makes its way to the stable branch.
      210f4d83
  22. 21 Feb, 2020 1 commit
  23. 05 Dec, 2019 1 commit
    • Greg Spencer's avatar
      Normalizes all of the "See also" blocks in comments. (#46121) · c6fe7bb9
      Greg Spencer authored
      This normalizes all of the "See also" blocks in comments so that they conform in style.
      
      They all look like this now:
      
        /// See also:
        ///
        ///  * [MyFavoriteWidget], because it's cool.
        class Foo {}
      
      I removed some useless "See also" blocks, and added commentary to ones that were just "bare" references.
      
      This is my penance for adding so many bullets that are "-" instead of "*". :-)
      c6fe7bb9
  24. 03 Dec, 2019 1 commit
  25. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  26. 26 Nov, 2019 1 commit
  27. 22 Nov, 2019 1 commit
  28. 16 Nov, 2019 1 commit
  29. 26 Sep, 2019 1 commit
    • Kristin Ho's avatar
      Prevent PointerEnter[or Exit]Event from erasing event.down value (#40637) (#41332) · 034358e3
      Kristin Ho authored
      * MouseRegion documentation claimed that onEnter and onExit
        would track entry and exit regardless of whether the pointer was
        down or up
      * It did such, but when grabbing the value of `event.down` from
        the passed event, the value was always `false`
      * PointerEnterEvent and PointerExitEvent were overriding the value
        passed from PointerEvent in constructors, even if the value was true
        e.g. in invocations of .fromMouseEvent((PointerMoveEvent...))
      * This change now passes the value along to PointerEnter/ExitEvents
        while providing it a default of false, and updates documentation
      
      Fixes #40637
      034358e3
  30. 01 Aug, 2019 1 commit
  31. 31 May, 2019 1 commit
  32. 30 May, 2019 1 commit
    • Greg Spencer's avatar
      Fix onExit calling when the mouse is removed. (#33477) · 07aede4c
      Greg Spencer authored
      This PR solves two problems: currently, the onExit is called for a mouse pointer the moment the removal message is received, except that by the time it actually calls it, there is no _lastEvent for it in the mouse tracker (it's already been removed), resulting in an event being passed to the onExit that contains nulls for the position. Also, removePointer events don't actually get created with a position, although they easily could be, so that even the the _lastEvent in the mouse tracker were still populated, it would still give a null position and delta.
      
      This PR adds support for the position and delta in a PointerRemovedEvent, and populates them. In addition, when a remove event is received, it doesn't actually remove the pointer until the mouse position check that gets scheduled actually happens.
      07aede4c
  33. 20 May, 2019 1 commit
  34. 03 May, 2019 1 commit
  35. 01 May, 2019 1 commit
  36. 30 Apr, 2019 1 commit
    • Tong Mu's avatar
      Redo: Add buttons to gestures (#31819) · fea2c7d6
      Tong Mu authored
      * Revert "Revert "Add buttons to gestures (#30339)" (#31801)"
      
      This reverts commit 8fd7fa49.
      
      * Synthesise kPrimaryButton for unknown devices
      
      * Change TestPointer to a better API
      fea2c7d6
  37. 29 Apr, 2019 2 commits