1. 21 Mar, 2016 1 commit
    • Ian Hickson's avatar
      Refactor cassowary so it uses imports rather than parts. · 552896af
      Ian Hickson authored
      Also misc cleanup:
       - reorder members to be more consistent and fit the style guide
       - remove use of _Pair
       - made Variable.applyUpdate and Variable.owner public
       - added docs to Priority, tweaked the code a bit
       - added some docs to Result
       - removed the internal-error Result (replaced with asserts)
       - removed unused Results
       - made Result const
       - merged some files together since they had used privates a lot
      
      I'm sorry this is completely unreviewable. I did the move from `lib/*`
      to `lib/src/*` first, then did the `part`-to-`import` change, and then
      found out how many of the files involved privates, which I wasn't
      expecting. I can redo this as multiple commits if that would make it
      easier to review.
      552896af
  2. 14 Mar, 2016 1 commit
  3. 12 Mar, 2016 3 commits
  4. 11 Mar, 2016 1 commit
    • Ian Hickson's avatar
      Enable ALL THE LINTS · 1b9cd520
      Ian Hickson authored
      Well, all the easy ones, anyway.
      
      For some reason `// ignore:` isn't working for me so I've disabled
      lints that need that. Also disabled those that require a ton of work
      (which I'm doing, but not in this PR, to keep it reviewable).
      
      This adds:
      - avoid_init_to_null
      - library_names
      - package_api_docs
      - package_names
      - package_prefixed_library_names
      - prefer_is_not_empty
      - sort_constructors_first
      - sort_unnamed_constructors_first
      - unnecessary_getters_setters
      1b9cd520
  5. 01 Mar, 2016 1 commit
    • pq's avatar
      @override annotation cleanup. · 8574e442
      pq authored
      Added missing @override annotations (as per the `annotate_overrides` lint rule).
      8574e442
  6. 15 Feb, 2016 1 commit
    • Adam Barth's avatar
      Simplify the AutoLayout API · c7d71d8a
      Adam Barth authored
      This patch makes it easier to use the auto layout API:
      
      * We no longer use operator== because that requires an ugly cast by the
        API user.
      * Also, "leftEdge" is now just "left" for less verbosity.
      * AutoLayoutChild not implies its key from the AutoLayoutParam object.
      * We now correctly layout every child of a RenderAutoLayout object even
        if the solver doesn't flush any updates to that child.
      c7d71d8a
  7. 12 Nov, 2015 1 commit
    • Hixie's avatar
      flutter analyze command · a0227cab
      Hixie authored
      Other changes in this patch:
      - Make the 'flutter' tool say "Updating flutter tool..." when it calls
        pub get, to avoid confusion about what the pub get output is about.
      - Make the bash flutter tool call pub get when the revision has
        changed. (This was already happening on Windows.)
      - Fix a raft of bugs found by the analyzer.
      - Fix some style nits in various bits of code that happened to be near
        things the analyzer noticed.
      - Remove the logic in "flutter test" that would run "pub get", since
        upon further reflexion it was determined it didn't work anyway.
        We'll probably have to add better diagnostics here and say to run the
        updater script.
      - Remove the native velocity tracker script, since it was testing code
        that has since been removed.
      
      Notes on ignored warnings:
      - We ignore warnings in any packages that are not in the Flutter repo or
        in the author's current directory.
      - We ignore various irrelevant Strong Mode warnings. We still enable
        strong mode because even though it's not really relevant to our needs,
        it does (more or less accidentally) catch a few things that are
        helpful to us.
      - We allow CONSTANTS_LIKE_THIS, since we get some of those from other
        platforms that we are copying for sanity and consistency.
      - We allow one-member abstract classes since we have a number of them
        where it's perfectly reasonable.
      - We unfortunately still ignore warnings in mojom.dart autogenerated
        files. We should really fix those but that's a separate patch.
      - We verify the actual source file when we see the 'Name non-constant
        identifiers using lowerCamelCase.' lint, to allow one-letter variables
        that use capital letters (e.g. for physics expressions) and to allow
        multiple-underscore variable names.
      - We ignore all errors on lines that contain the following magic
        incantation and a "#" character:
          // analyzer doesn't like constructor tear-offs
      - For all remaining errors, if the line contains a comment of the form
          // analyzer says "..."
        ...then we ignore any errors that have that "..." string in them.
      a0227cab
  8. 08 Jul, 2015 1 commit
  9. 07 Jul, 2015 1 commit
  10. 25 Jun, 2015 2 commits
  11. 24 Jun, 2015 3 commits
  12. 22 Jun, 2015 6 commits