Commits · 2b42a47724d7e23698a3cacfe8533aea193edf89 · abdullh.alsoleman / Front-End

21 Aug, 2023 13 commits

Roll Flutter Engine from 0290d0bd79ee to 210f5a8aa245 (1 revision) (#132973) · 2b42a477

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/0290d0bd79ee...210f5a8aa245

2023-08-21 jonahwilliams@google.com [Impeller] Remove sync switch (flutter/engine#44885)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2b42a477

Docs on iOS's directional quote characters (#132869) · 8e95ee2e

Justin McCandless authored Aug 21, 2023

When you type a single or double quote character on the default iOS keyboard, it doesn't actually insert the usual `'` or `"`.  Instead, it inserts a directional version that tries to match with others.  This is very tricky when allow/deny-listing characters, so I've added a section about this to the docs.

Fixes https://github.com/flutter/flutter/issues/132232

8e95ee2e

Bump memory usage for flutter gallery (#132968) · 0c78dce5

Reid Baker authored Aug 21, 2023

Fixes https://github.com/flutter/flutter/issues/131006
Flakes related to out of memory in gradle when running tests.

Opted not to add enforcement for gradle.properties in https://github.com/flutter/flutter/blob/master/dev/bots/analyze.dart because the memory usage has been stable for 6 years and not every example needs more memory.

0c78dce5

When resized network image has error, all future unrelated images using the... · aeddab42

fzyzcjy authored Aug 21, 2023

When resized network image has error, all future unrelated images using the same url will fail, even if the network becomes OK (#127456)

Close #127265

The CI fails because of simple analyzer errors. Thus, I would like to hear your opinions first!

aeddab42

Roll Flutter Engine from a9b00783bc7c to 0290d0bd79ee (1 revision) (#132962) · 27dd111a

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/a9b00783bc7c...0290d0bd79ee

2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from 475f07f5ca14 to 7e5a3009a8d4 (1 revision) (flutter/engine#44900)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

27dd111a

Roll Packages from 4c16f3ef4033 to e26f3b9374d0 (5 revisions) (#132960) · e425b680

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/packages/compare/4c16f3ef4033...e26f3b9374d0

2023-08-21 raul.silveira@popcode.com.br [camera_android]: Fixes crash when record video on Android versions lower than 12 (flutter/packages#4635)
2023-08-19 engine-flutter-autoroll@skia.org Roll Flutter from 5a556f8e to 6f227c07 (11 revisions) (flutter/packages#4749)
2023-08-18 10687576+bparrishMines@users.noreply.github.com Update release action Flutter version to 3.13.0 (flutter/packages#4745)
2023-08-18 stuartmorgan@google.com [google_maps_flutter] Fix async handling in examples (flutter/packages#4729)
2023-08-18 engine-flutter-autoroll@skia.org Roll Flutter from 2502b51f to 5a556f8e (42 revisions) (flutter/packages#4743)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e425b680

Roll Flutter Engine from 14be26c91620 to a9b00783bc7c (2 revisions) (#132955) · 5e6d88d7

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/14be26c91620...a9b00783bc7c

2023-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from af7860c1b2a5 to 7dd53a3df4cf (1 revision) (flutter/engine#44898)
2023-08-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iQbvLoFBbhU8pkkqw... to lDn2QLh1I7rtNu01y... (flutter/engine#44895)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from iQbvLoFBbhU8 to lDn2QLh1I7rt

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5e6d88d7

Roll Flutter Engine from e2d9809d1af3 to 14be26c91620 (2 revisions) (#132946) · 3c0f7ca6

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/e2d9809d1af3...14be26c91620

2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from fca8fac08117 to 475f07f5ca14 (2 revisions) (flutter/engine#44896)
2023-08-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fiGH0e7wu87NiNtTr... to aXDvHIK6XMKTHieu_... (flutter/engine#44894)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from fiGH0e7wu87N to aXDvHIK6XMKT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3c0f7ca6

Roll Flutter Engine from 36ab259a61ed to e2d9809d1af3 (1 revision) (#132944) · 89e82958

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/36ab259a61ed...e2d9809d1af3

2023-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from c839eea7f0fa to af7860c1b2a5 (1 revision) (flutter/engine#44893)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

89e82958

Roll Flutter Engine from e7d745111795 to 36ab259a61ed (2 revisions) (#132937) · 77719265

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/e7d745111795...36ab259a61ed

2023-08-21 flar@google.com Split DisplayListBuilder into DlCanvas optimizer and DlOp recorder classes (flutter/engine#44718)
2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from d2369dac4a1d to fca8fac08117 (1 revision) (flutter/engine#44888)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

77719265

Roll Flutter Engine from 8c7ce6ddde0f to e7d745111795 (1 revision) (#132925) · c328d039

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/8c7ce6ddde0f...e7d745111795

2023-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 632c8cccd30c to c839eea7f0fa (1 revision) (flutter/engine#44886)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c328d039

Roll Flutter Engine from 394554bd1630 to 8c7ce6ddde0f (2 revisions) (#132921) · 45e464cb

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/394554bd1630...8c7ce6ddde0f

2023-08-20 skia-flutter-autoroll@skia.org Roll Skia from 4f6b9d08b6d1 to d2369dac4a1d (6 revisions) (flutter/engine#44883)
2023-08-20 bdero@google.com [Impeller] Fix clip management for DrawPicture. (flutter/engine#44835)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

45e464cb

Roll Flutter Engine from 2dcfb6cb7e49 to 394554bd1630 (4 revisions) (#132918) · 3b7831ac

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/2dcfb6cb7e49...394554bd1630

2023-08-20 chinmaygarde@google.com [Impeller] Document threading configuration with Vulkan. (flutter/engine#44874)
2023-08-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from onEHyyETXAMieDyfP... to fiGH0e7wu87NiNtTr... (flutter/engine#44875)
2023-08-20 skia-flutter-autoroll@skia.org Roll Dart SDK from a4908f67b63e to 632c8cccd30c (2 revisions) (flutter/engine#44872)
2023-08-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pSqQ556xmZp7S4np5... to iQbvLoFBbhU8pkkqw... (flutter/engine#44878)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from pSqQ556xmZp7 to iQbvLoFBbhU8
fuchsia/sdk/core/mac-amd64 from onEHyyETXAMi to fiGH0e7wu87N

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3b7831ac

20 Aug, 2023 1 commit

Roll Flutter Engine from f4bffdcf8536 to 2dcfb6cb7e49 (4 revisions) (#132914) · 4ac85071

engine-flutter-autoroll authored Aug 20, 2023

https://github.com/flutter/engine/compare/f4bffdcf8536...2dcfb6cb7e49

2023-08-20 skia-flutter-autoroll@skia.org Roll Skia from e9cf3f1740eb to 4f6b9d08b6d1 (2 revisions) (flutter/engine#44868)
2023-08-20 jonahwilliams@google.com Revert "Implementing TextScaler for nonlinear text scaling" (flutter/engine#44882)
2023-08-18 737941+loic-sharma@users.noreply.github.com [Embedder API] Add semantic string attributes (flutter/engine#44616)
2023-08-18 31859944+LongCatIsLooong@users.noreply.github.com Implementing TextScaler for nonlinear text scaling (flutter/engine#42062)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4ac85071

19 Aug, 2023 2 commits

Space character should be optional when tree shaking fonts (#132880) · 6f227c07
Jackson Gardner authored Aug 19, 2023
```
Addresses the other part of https://github.com/flutter/flutter/issues/132711
```
6f227c07

Roll Flutter Engine from 654d3a2c8494 to f4bffdcf8536 (5 revisions) (#132876) · 6d757046

engine-flutter-autoroll authored Aug 19, 2023

https://github.com/flutter/engine/compare/654d3a2c8494...f4bffdcf8536

2023-08-18 jacksongardner@google.com Allow optional codepoints to be expressed to the font subset generator. (flutter/engine#44864)
2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from 2ddec49abd5c to e9cf3f1740eb (3 revisions) (flutter/engine#44862)
2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from 2dd1ed0baa7d to 2ddec49abd5c (2 revisions) (flutter/engine#44860)
2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from cf37d99d844d to 2dd1ed0baa7d (1 revision) (flutter/engine#44859)
2023-08-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 8109103e041b to a4908f67b63e (2 revisions) (flutter/engine#44858)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6d757046

18 Aug, 2023 16 commits

SelectionArea on iOS should toggle the context menu when tapping on the... · 2ecb8866

Renzo Olivares authored Aug 18, 2023

SelectionArea on iOS should toggle the context menu when tapping on the previous selection (#132851)

https://github.com/flutter/flutter/assets/948037/210fdee4-d922-422b-a257-4ee586a3814f

Related: https://github.com/flutter/flutter/issues/129583

2ecb8866

Forward port API docs creation realm handling from prior script (#132867) · d5a162b7

Zachary Anderson authored Aug 18, 2023

It looks like the logic added here:


https://github.com/flutter/flutter/pull/131951/files#diff-297ee4cfe6d9bffc2fa1376918a50b8e4165ada4569575880c40811b6f749265R18

got dropped in the refactor here:

https://github.com/flutter/flutter/pull/132710

d5a162b7

Roll Flutter Engine from 72c4e61fdbfa to 654d3a2c8494 (3 revisions) (#132868) · 1bdef6fe

engine-flutter-autoroll authored Aug 18, 2023

https://github.com/flutter/engine/compare/72c4e61fdbfa...654d3a2c8494

2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from edf0c0ecc7b1 to cf37d99d844d (1 revision) (flutter/engine#44857)
2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from e3adabdd0511 to edf0c0ecc7b1 (3 revisions) (flutter/engine#44854)
2023-08-18 jason-simmons@users.noreply.github.com Flush pending graphics commands when the unref queue is drained on the IO thread (flutter/engine#44831)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1bdef6fe

Roll Flutter Engine from 83fdadaf12f0 to 72c4e61fdbfa (2 revisions) (#132861) · 58171f09

engine-flutter-autoroll authored Aug 18, 2023

https://github.com/flutter/engine/compare/83fdadaf12f0...72c4e61fdbfa

2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from 31baf15e8f2c to e3adabdd0511 (2 revisions) (flutter/engine#44851)
2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from c9294edc03b9 to 31baf15e8f2c (10 revisions) (flutter/engine#44850)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

58171f09

Updates app link gradle tasks and remove vm services (#131805) · 61242fa1

chunhtai authored Aug 18, 2023

1. Remove vm service registration
2. combine print<variant>ApplicationId and print<variant>AppLinkDomain into one task dump<variant>AppLinkSettings, which dump all the data in a json file

The deeplink validation tool will be a static app in devtool instead of regular app. A Static app doesn't require a running app; therefore, we can't call these API through vmservices. I decided to convert these API into flutter analyzer command, which will be done in a separate PR https://github.com/flutter/flutter/pull/131009.

The reason these print tasks are converted into file dumps is to reduce the amount of data encoding and decoding. Instead of passing data through stdout, the devtool can read the files generated by gradle tasks instead.

61242fa1

Roll Flutter Engine from 58f7d8ee3e2c to 83fdadaf12f0 (7 revisions) (#132857) · 6cefc2ea

engine-flutter-autoroll authored Aug 18, 2023

https://github.com/flutter/engine/compare/58f7d8ee3e2c...83fdadaf12f0

2023-08-18 zanderso@users.noreply.github.com Update Impeller
benchmarks.md with a Pixel 7 link (flutter/engine#44834)
2023-08-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
7xOzci7fempFgHNk9... to pSqQ556xmZp7S4np5... (flutter/engine#44846)
2023-08-18 skia-flutter-autoroll@skia.org Roll Dart SDK from
121fcbd8124c to 8109103e041b (1 revision) (flutter/engine#44844)
2023-08-18 jonahwilliams@google.com [Impeller] add trace events for
VkRenderPass and VkFrameBuffer creation. (flutter/engine#44837)
2023-08-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
Tnp43n_nAR2N0l_gY... to onEHyyETXAMieDyfP... (flutter/engine#44845)
2023-08-18 skia-flutter-autoroll@skia.org Roll Skia from 1e62a2d4c429 to
c9294edc03b9 (2 revisions) (flutter/engine#44843)
2023-08-18 leroux_bruno@yahoo.fr [Android] Expose channel buffer resize
and overflow calls (flutter/engine#44434)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 7xOzci7fempF to pSqQ556xmZp7
  fuchsia/sdk/core/mac-amd64 from Tnp43n_nAR2N to onEHyyETXAMi

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6cefc2ea

doc: add flag params (#132485) · 6875827f

Mustafa Ateş Uzun authored Aug 18, 2023

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

6875827f

Add a new MatrixTransition and refactor ScaleTransition and RotationT… (#131084) · 58019b34

gmilou authored Aug 18, 2023

â¦ransition to derive from it.

The MatrixTransition class uses a callback to handle any value => Matrix animation.

The alignment and filterQuality logic that was in ScaleTransition and RotationTransition is now factored in MatrixTransition.

The ScaleTransition.scale and RotationTransition.turns getters had to be kept because they're still referenced in https://github.com/flutter/packages/tree/main/packages/animations, and https://github.com/flutter/packages/flutter/test/. I plan to remove the references there, once this PR is generally available, and then remove the getters here.

A RotationTransition test was updated to use matrixMoreOrLessEquals because using Matrix4.rotationZ doesn't have the special cases Transform.Rotation had, and zeroes in matrix weren't exactly zeroes.

fixes #130946

58019b34

fixes l10n for CupertinoDatePicker in monthYear mode (#130934) · 1cfba262

Andrey Suvorov authored Aug 18, 2023

This PR fixes l10n issue when months names are being used in incorrect form in CupertinoDatePicker in CupertinoDatePickerMode.yearMonth (#130930).

The idea of this proposal is to add an optional parameter `standalone` for `CupertinoLocalizations.datePickerMonth` to be able to choose when to use months names in base form (intl DateSymbols.STANDALONEMONTHS) and when in day-dependent form (intl DateSymbols.MONTHS)

<details>
<summary>Before</summary>

<img width="366" alt="image" src="https://github.com/flutter/flutter/assets/32621121/1dd54fa7-6dd9-4053-889b-57134c145432">

<img width="387" alt="image" src="https://github.com/flutter/flutter/assets/32621121/c176070e-73e4-49d3-883b-ba31eca6d1d7">

</details>

<details>
<summary>After</summary>

<img width="369" alt="image" src="https://github.com/flutter/flutter/assets/32621121/255594f1-219d-4bd4-9b75-1012912f8ab0">

<img width="378" alt="image" src="https://github.com/flutter/flutter/assets/32621121/16bbb41f-3f62-4446-bf41-e27140b649a9">

</details>

1cfba262

Roll Packages from 3b602e77e69a to 4c16f3ef4033 (3 revisions) (#132848) · 5a556f8e

engine-flutter-autoroll authored Aug 18, 2023

https://github.com/flutter/packages/compare/3b602e77e69a...4c16f3ef4033

2023-08-17 katelovett@google.com [two_dimensional_scrollables] TableView (flutter/packages#4536)
2023-08-17 stuartmorgan@google.com [ci] Update minimums for 3.13 stable (flutter/packages#4731)
2023-08-17 10687576+bparrishMines@users.noreply.github.com Update stable version to efbf63d9c66b9f6ec30e9ad4611189aa80003d31 (flutter/packages#4730)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5a556f8e

Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR (#132803) · b52297da

Victoria Ashworth authored Aug 18, 2023

Starting in Xcode 15, when building macOS, DT_TOOLCHAIN_DIR cannot be used to evaluate LD_RUNPATH_SEARCH_PATHS or LIBRARY_SEARCH_PATHS. `xcodebuild` error message recommend using TOOLCHAIN_DIR instead.

Since Xcode 15 isn't in CI, I tested it in a one-off `led` test:
* [Pre-fix failure](https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/vashworth_google.com/04e485a0b152a0720f5e561266f7a6e4fb64fc76227fcacc95b67486ae2771e7/+/build.proto)
* [Post-fix success](https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/vashworth_google.com/d454a3e181e1a97692bdc1fcc197738fe04e4acf1cb20026fd040fd78513f3b0/+/build.proto)

Fixes https://github.com/flutter/flutter/issues/132755.

b52297da

[flutter_tools] Generate localizations on flutter pub get (#132172) · 312ef541

Tae Hyung Kim authored Aug 18, 2023

Currently, flutter pub get generates localizations if there exists an l10n.yaml file where synthetic-package is not false. However, for any user who needs to turn off synthetic-package, their localizations are not generated. This PR should make the behavior more consistent. (Also it seems good to make it so that running flutter pub get once resolves all the dependencies so that people can get to work without running flutter gen-l10n manually.)

Fixes https://github.com/flutter/flutter/issues/84979.

312ef541

Roll Flutter Engine from 866b43f656e4 to 58f7d8ee3e2c (1 revision) (#132820) · 633b1ce4

engine-flutter-autoroll authored Aug 18, 2023

https://github.com/flutter/engine/compare/866b43f656e4...58f7d8ee3e2c

2023-08-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7101eb7569ac to 121fcbd8124c (1 revision) (flutter/engine#44832)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

633b1ce4

Fix description in index.html / manifest.json getting double quoted (#131842) · 03664d0a

Navaron Bracke authored Aug 18, 2023

This PR adjusts the quoting of the project description not not apply twice in the index.html / manifest.json of web builds.

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/131834

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

03664d0a

Roll Flutter Engine from 5019d6da655c to 866b43f656e4 (8 revisions) (#132812) · a1e3b3da

engine-flutter-autoroll authored Aug 18, 2023

https://github.com/flutter/engine/compare/5019d6da655c...866b43f656e4

2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from 1bec2899ace8 to 1e62a2d4c429 (1 revision) (flutter/engine#44829)
2023-08-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 7e4e5796ee99 to 7101eb7569ac (2 revisions) (flutter/engine#44828)
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from e4be2cab442f to 1bec2899ace8 (1 revision) (flutter/engine#44826)
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from bfd45173e5e3 to e4be2cab442f (3 revisions) (flutter/engine#44824)
2023-08-17 gspencergoog@users.noreply.github.com Add Doxygen doc generation for iOS, macOS, Linux, Windows, and Impeller (flutter/engine#43915)
2023-08-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from VW7WAVPT3Cj5erlae... to Tnp43n_nAR2N0l_gY... (flutter/engine#44823)
2023-08-17 jason-simmons@users.noreply.github.com Fix FlutterInjectorTest assumptions about how the executor service assigns tasks to threads (flutter/engine#44775)
2023-08-17 john@johnmccutchan.com Reenable HardwareBuffer backed Android Platform Views on SDK >= 29 (flutter/engine#44790)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from VW7WAVPT3Cj5 to Tnp43n_nAR2N

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a1e3b3da

Fix the name of the local-engine-host flag in the warning message (#132808) · 579991cb
Jason Simmons authored Aug 18, 2023

579991cb

17 Aug, 2023 8 commits

Reland root predictive back (#132249) · f68d03f1

Justin McCandless authored Aug 17, 2023

Root predictive back (https://github.com/flutter/flutter/pull/120385) was reverted in https://github.com/flutter/flutter/pull/132167.  This PR is an attempt to reland it.

The reversion happened due to failed Google tests (b/295073110).

f68d03f1

Reland: "Reorganize and clarify API doc generator" (#132353) (#132710) · ced3e766

Greg Spencer authored Aug 17, 2023

## Description

This re-lands #132353 with some additional options for keeping around the staging directory, so that the recipe for publishing docs can give those options and have the staging directory left around for deploying to the website.

Reverted in #132613

## Related Issues
 - https://flutter-review.googlesource.com/c/recipes/+/49580

ced3e766

Allow date pickers to not have selected date (#132343) · d19fb632

Ian Hickson authored Aug 17, 2023

This enables our various date picker classes to have a null `initialDate`.

It also fixes the logic of some of the widgets which used to do something when you _changed_ the `initial*` parameters, which is wrong for `initial*` properties (they by definition should only impact the initial state) and wrong for properties in general (behaviour should not change based on whether the widget was built with a new value or not, that violates the reactive design principles).

Fixes https://github.com/flutter/flutter/issues/638.

d19fb632

[Framework] Add Share to selection controls (#132599) · 3f34b480

LouiseHsu authored Aug 17, 2023

In native iOS, users are able to select text and initiate a share menu, which provides several standard services, such as copy, sharing to social media, direct ability to send to various contacts through messaging apps, etc.

https://github.com/flutter/engine/assets/36148254/d0af7034-31fd-412e-8636-a06bbff54765

This PR is the framework portion of the changes that will allow Share to be implemented.
The corresponding merged engine PR is [here](https://github.com/flutter/engine/pull/44554)
This PR addresses https://github.com/flutter/flutter/issues/107578
More details are available in this [design doc](https://github.com/flutter/engine/pull/flutter.dev/go/add-missing-features-to-selection-controls)

3f34b480

Roll Packages from 9bf208f4beb6 to 3b602e77e69a (3 revisions) (#132784) · ac66bdb7

engine-flutter-autoroll authored Aug 17, 2023

https://github.com/flutter/packages/compare/9bf208f4beb6...3b602e77e69a

2023-08-16 ian@hixie.ch Add advice on code review for this repo (flutter/packages#4698)
2023-08-16 stuartmorgan@google.com [platform] Import the `platform` package (flutter/packages#4613)
2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter from f0e7c518 to 2502b51f (15 revisions) (flutter/packages#4722)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ac66bdb7

Roll Flutter Engine from 533670269c99 to 5019d6da655c (15 revisions) (#132797) · fb7baa9e

engine-flutter-autoroll authored Aug 17, 2023

https://github.com/flutter/engine/compare/533670269c99...5019d6da655c

2023-08-17 dkwingsmt@users.noreply.github.com Basic view management for engine classes (flutter/engine#42991)
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from d0d390f9310d to bfd45173e5e3 (5 revisions) (flutter/engine#44820)
2023-08-17 matanlurey@users.noreply.github.com Implement 2 suggested Clang Tidy fixes we don't look for yet. (flutter/engine#44816)
2023-08-17 louiseh0313@gmail.com Add share to selection controls (flutter/engine#44554)
2023-08-17 zanderso@users.noreply.github.com Adds new builders for partial clang-tidy checks. (flutter/engine#44811)
2023-08-17 41930132+hellohuanlin@users.noreply.github.com [ios][ios17]fix auto correction highlight on top left corner (flutter/engine#44779)
2023-08-17 109111084+yaakovschectman@users.noreply.github.com [Windows] Delay enabling app lifecycle states until requested (flutter/engine#44238)
2023-08-17 dkwingsmt@users.noreply.github.com Move `viewConfiguration` parsing from `PlatformDispatcher` to `_hooks` (flutter/engine#44787)
2023-08-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 92c32df13d31 to 7e4e5796ee99 (2 revisions) (flutter/engine#44810)
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from c4805a975ab3 to d0d390f9310d (2 revisions) (flutter/engine#44807)
2023-08-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cPncZK6z8HmuOmQr_... to 7xOzci7fempFgHNk9... (flutter/engine#44809)
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from efb5a5e0b78b to c4805a975ab3 (2 revisions) (flutter/engine#44795)
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from 11cb8cdd37c1 to efb5a5e0b78b (1 revision) (flutter/engine#44792)
2023-08-17 matanlurey@users.noreply.github.com Passthrough stderr results of clang_tidy when --enable-check-profile. (flutter/engine#44789)
2023-08-17 skia-flutter-autoroll@skia.org Roll Dart SDK from d6e1fca5dbdf to 92c32df13d31 (1 revision) (flutter/engine#44788)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from cPncZK6z8Hmu to 7xOzci7fempF

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fb7baa9e

Run gsutil with full python3 and full path. (#132805) · a70a852c
godofredoc authored Aug 17, 2023
```
This is to prevent failures when the gsutil.py is not executable.
```
a70a852c
Leaks fix. (#132778) · aa1bacb3
Polina Cherkasova authored Aug 17, 2023
```
Fixes https://github.com/flutter/flutter/issues/132769
```
aa1bacb3