Commits · 27635b4ce546dd52fbf2c417d160127dd0f601b2 · abdullh.alsoleman / Front-End

14 May, 2023 1 commit

Roll Flutter Engine from 96bd55349119 to fb703b1965cd (2 revisions) (#126758) · 27635b4c

engine-flutter-autoroll authored May 14, 2023

https://github.com/flutter/engine/compare/96bd55349119...fb703b1965cd

2023-05-14 flar@google.com add non-rendering operation culling to DisplayListBuilder (flutter/engine#41463)
2023-05-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from wxolyLvEWZ9IMOCU_... to hXcPXU_V5nVeGkEbt... (flutter/engine#42020)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from wxolyLvEWZ9I to hXcPXU_V5nVe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

27635b4c

13 May, 2023 9 commits

Roll Flutter Engine from 802ff626f498 to 96bd55349119 (2 revisions) (#126747) · f6b23f1d

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/802ff626f498...96bd55349119

2023-05-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 48d09a6216a8 to 005648f027a3 (1 revision) (flutter/engine#42017)
2023-05-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bddx8p5907poNnZTq... to mAQy_vMru3cTWSoBl... (flutter/engine#42016)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from bddx8p5907po to mAQy_vMru3cT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f6b23f1d

Roll Flutter Engine from d4f141f182d8 to 802ff626f498 (1 revision) (#126742) · d628f129

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/d4f141f182d8...802ff626f498

2023-05-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from oc2gdx4PWYT-K7XQ9... to wxolyLvEWZ9IMOCU_... (flutter/engine#42015)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from oc2gdx4PWYT- to wxolyLvEWZ9I

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d628f129

Roll Flutter Engine from 1745d441405e to d4f141f182d8 (1 revision) (#126741) · c6fd6258

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/1745d441405e...d4f141f182d8

2023-05-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 2a285d87f5d7 to 48d09a6216a8 (1 revision) (flutter/engine#42014)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c6fd6258

Roll Flutter Engine from 259daf6efd3e to 1745d441405e (1 revision) (#126737) · cba1dee3

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/259daf6efd3e...1745d441405e

2023-05-13 skia-flutter-autoroll@skia.org Roll Skia from 872787e7595c to 1c00432c2a85 (1 revision) (flutter/engine#42013)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cba1dee3

Roll Flutter Engine from eb5748199016 to 259daf6efd3e (2 revisions) (#126735) · 99dd10af

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/eb5748199016...259daf6efd3e

2023-05-13 leroux_bruno@yahoo.fr [macOS - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#41977)
2023-05-13 skia-flutter-autoroll@skia.org Roll Skia from cfdfc039b848 to 872787e7595c (1 revision) (flutter/engine#42010)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

99dd10af

Roll Flutter Engine from 36ced12f75af to eb5748199016 (1 revision) (#126730) · 7559454d

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/36ced12f75af...eb5748199016

2023-05-13 skia-flutter-autoroll@skia.org Roll Skia from 6a4e29cbd73b to cfdfc039b848 (2 revisions) (flutter/engine#42004)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7559454d

Fix crash from invalid ListWheelViewport assertion (#126539) · ae82f3cb
nt4f04uNd authored May 13, 2023
```
Fixes https://github.com/flutter/flutter/issues/126491
```
ae82f3cb

Roll Flutter Engine from 12e436d3aa7e to 36ced12f75af (1 revision) (#126726) · 3ef9bc5f

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/12e436d3aa7e...36ced12f75af

2023-05-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HMLNsG7w9sTDpW2Ge... to bddx8p5907poNnZTq... (flutter/engine#42003)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from HMLNsG7w9sTD to bddx8p5907po

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3ef9bc5f

Roll Flutter Engine from 502e1eb591d9 to 12e436d3aa7e (8 revisions) (#126725) · a1ddaa95

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/502e1eb591d9...12e436d3aa7e

2023-05-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rO5qs4MpN6WfJcu64... to oc2gdx4PWYT-K7XQ9... (flutter/engine#42000)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 64bdd87fadfe to 6a4e29cbd73b (2 revisions) (flutter/engine#41999)
2023-05-12 jason-simmons@users.noreply.github.com [Impeller] Remove a debug log from the Vulkan render pass (flutter/engine#41987)
2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 858f83d6d993 to 2a285d87f5d7 (2 revisions) (flutter/engine#41997)
2023-05-12 bdero@google.com [Impeller] Ignore the Z basis when scaling text (flutter/engine#41995)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 539fb10d7cfb to 64bdd87fadfe (18 revisions) (flutter/engine#41993)
2023-05-12 mdebbar@google.com [web] Cleaner output on LUCI (flutter/engine#41989)
2023-05-12 leroux_bruno@yahoo.fr [Web+Linux] Fix pressing Meta keys throws (flutter/engine#41694)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from rO5qs4MpN6Wf to oc2gdx4PWYT-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a1ddaa95

12 May, 2023 13 commits

Roll Flutter Engine from c784d6d4137d to 502e1eb591d9 (14 revisions) (#126714) · d5bb1a83

engine-flutter-autoroll authored May 12, 2023

https://github.com/flutter/engine/compare/c784d6d4137d...502e1eb591d9

2023-05-12 30870216+gaaclarke@users.noreply.github.com [Impeller] starts
running vulkan golden image tests with swiftshader
(flutter/engine#41958)
2023-05-12 mdebbar@google.com [web] Fix crash on old versions of Chrome
(Intl.Segmenter missing) (flutter/engine#41986)
2023-05-12 godofredoc@google.com Move clang tidy v2 build to prod.
(flutter/engine#41985)
2023-05-12 godofredoc@google.com Reland "Move linux_license to engine
v2."" (flutter/engine#41983)
2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from
6cd6e54f280d to 858f83d6d993 (2 revisions) (flutter/engine#41980)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 0b929ada9cc6 to
539fb10d7cfb (2 revisions) (flutter/engine#41979)
2023-05-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
MjcKzcsqMDkuRKopu... to rO5qs4MpN6WfJcu64... (flutter/engine#41975)
2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from
4028c7d8b87c to 6cd6e54f280d (1 revision) (flutter/engine#41974)
2023-05-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
lf8VcONMWlne4oa3H... to HMLNsG7w9sTDpW2Ge... (flutter/engine#41973)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 208a07f71701 to
0b929ada9cc6 (2 revisions) (flutter/engine#41971)
2023-05-12 dnfield@google.com [Impeller] [Android] Refactor the Android
context/surface implementation to work more like Skia.
(flutter/engine#41059)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from ccec5093ca38 to
208a07f71701 (1 revision) (flutter/engine#41970)
2023-05-12 jonahwilliams@google.com [Impeller] Dont synthesize fake
index buffer if none was provided to VBB (flutter/engine#41969)
2023-05-12 dnfield@google.com [Impeller] Make index buffer optional
(flutter/engine#41962)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from lf8VcONMWlne to HMLNsG7w9sTD
  fuchsia/sdk/core/mac-amd64 from MjcKzcsqMDku to rO5qs4MpN6Wf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d5bb1a83

Add namespace to Android plugin templates (#126354) · aa230140

stuartmorgan authored May 12, 2023

Adds the `namespace` property necessary for AGP 8 compatibility to the plugin templates, with the conditional logic to ensure that it doesn't break AGP <4.2, so that new plugins will be maximally compatible.

Part of https://github.com/flutter/flutter/issues/125181

aa230140

Roll Packages from 0167d834e937 to 6328cfbd2a46 (2 revisions) (#126442) · 9c72f5a7

engine-flutter-autoroll authored May 12, 2023

https://github.com/flutter/packages/compare/0167d834e937...6328cfbd2a46

2023-05-10 43640732+dancamdev@users.noreply.github.com
[go_router_builder] Adds name parameter to TypedGoRoute and supports its
generation. (flutter/packages#3665)
2023-05-10 stuartmorgan@google.com [various] Remove iOS 9 references
(flutter/packages#3948)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c72f5a7

Fix focus behavior and provided thumb and focus color aren't applied to... · 96dae5e1

Taha Tesser authored May 12, 2023

Fix focus behavior and provided thumb and focus color aren't applied to Cupertino variant of `Switch.adaptive` (#126688)

fixes https://github.com/flutter/flutter/issues/126637
fixes https://github.com/flutter/flutter/issues/126669

##  ~~To be merged after https://github.com/flutter/flutter/pull/126684~~

### Description

1.  Fix the Cupertino variant of `Switch.adaptive` requires two tab key presses to focus.
2.  Fix `thumbColor` & `focusColor` aren't applied.

### Before
Requires two tab presses to focus. and `thumbColor` & `focusColor` aren't applied.

https://github.com/flutter/flutter/assets/48603081/24635551-0794-443f-8320-32fdaa5de57a

### After
Single tab key to focus (no additional focus node) and `thumbColor` & `focusColor` are applied.

https://github.com/flutter/flutter/assets/48603081/9bf42fd8-c7e0-475a-b933-192a94650b0c

96dae5e1

[Docs] Fix Typo (#126660) · 482d5671
杨加康 authored May 12, 2023

482d5671

Manual roll Flutter Engine from ef5c349f04d8 to c784d6d4137d (#126680) · 6e9c0db2

Jason Simmons authored May 12, 2023

https://github.com/flutter/engine/compare/ef5c349f04d8...c784d6d4137d

2023-05-12
[skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org)
Roll Dart SDK from 7ad028c26344 to 4028c7d8b87c (8 revisions)
(https://github.com/flutter/engine/pull/41967)

Requires some update for changes to the Dart analyzer

fixes https://github.com/flutter/flutter/issues/126683

6e9c0db2

Add `FocusNode`, `onFocusChange`, and `autofocus` to `CupertinoSwitch` (#126684) · b9e3aef2

Taha Tesser authored May 12, 2023

fixes https://github.com/flutter/flutter/issues/126679 

### Description
Control cupertino widgets like `CupertinoCheckbox` and `CupertinoRadio` have `focusNode` and `autofocus`, while these are missing in `CupertinoSwitch`.

This is blocking https://github.com/flutter/flutter/issues/126637 
(`switch.dart` currently maintains its focus node for `CupertinoSwitch` when using `Switch.adaptive` which causes a bug)

b9e3aef2

Hide the context menu on tap down (#126295) · 6ffcc9e5
Justin McCandless authored May 12, 2023
```
Desktop text selection toolbar no longer flashes before closing.
```
6ffcc9e5

Fix `showDatePicker` in input mode throws an `ArgumentError` (#126525) · 15a7e073

Taha Tesser authored May 12, 2023

fixes https://github.com/flutter/flutter/issues/126397

The `parseCompactDate` method in `material_localizations.dart` with long text throws an argument error before the date picker could handle it to show a validation error while the date picker is on autovalidate.

This PR adds `try/catch` in the `parseCompactDate` to return null on the argument error.

15a7e073

Increase test timeout for analyzer_benchmark to 60 minutes (#126586) · 468512e0
Zachary Anderson authored May 12, 2023
```
Fixes https://github.com/flutter/flutter/issues/126451
```
468512e0

Fix TextSpan gc regression (#126382) · 4eefced8

LongCatIsLooong authored May 12, 2023

`for (final InlineSpan child in children ?? const <InlineSpan>[])` bad

Fixes https://github.com/flutter/flutter/issues/126337

4eefced8

Roll Flutter Engine from 748ef964b993 to ef5c349f04d8 (1 revision) (#126624) · 5e459380

engine-flutter-autoroll authored May 12, 2023

https://github.com/flutter/engine/compare/748ef964b993...ef5c349f04d8

2023-05-11 leroux_bruno@yahoo.fr [Linux - TextInput] Do not add new line for send action (flutter/engine#41895)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5e459380

Roll Flutter Engine from f38f46f66e9a to 748ef964b993 (13 revisions) (#126622) · 43b2b658

engine-flutter-autoroll authored May 12, 2023

https://github.com/flutter/engine/compare/f38f46f66e9a...748ef964b993

2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from aed81125e6bc to ccec5093ca38 (10 revisions) (flutter/engine#41963)
2023-05-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 2tQjI0g3aDmjHAtMw... to MjcKzcsqMDkuRKopu... (flutter/engine#41960)
2023-05-11 smartercallum@gmail.com iPhone floating cursor selection (flutter/engine#36643)
2023-05-11 vashworth@google.com Update README.md (flutter/engine#41953)
2023-05-11 skia-flutter-autoroll@skia.org Roll Clang from 5344d8e10bb7 to 6d667d4b261e (flutter/engine#41949)
2023-05-11 kjlubick@users.noreply.github.com Use moved SkImage procs (flutter/engine#41947)
2023-05-11 msgh@selfisekai.rocks allow supplying custom gn args in gn wrapper (flutter/engine#41794)
2023-05-11 68549184+Mayb3Nots@users.noreply.github.com fix: platform_dispatcher documentation typo (flutter/engine#41739)
2023-05-11 lhkbob@gmail.com Remove GN staging flag for save layer bounds (flutter/engine#41940)
2023-05-11 flar@google.com switch MockTexture off of MockCanvas calls (flutter/engine#41906)
2023-05-11 gspencergoog@users.noreply.github.com [Android] Lifecycle defaults to focused instead of unfocused (flutter/engine#41875)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from ccf73af6ca91 to aed81125e6bc (9 revisions) (flutter/engine#41946)
2023-05-11 godofredoc@google.com Clobber caches in licenses test. (flutter/engine#41942)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 2tQjI0g3aDmj to MjcKzcsqMDku

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

43b2b658

11 May, 2023 11 commits

Add dimensions to release builds. (#126117) · fa117aad

godofredoc authored May 11, 2023

Release builds running in dart internal require the dimensions to be set explicitly at the target level in ci.yaml.

Bug: https://github.com/flutter/flutter/issues/126116

fa117aad

Revert "[tool] Move Java functions to their own file" (#126569) · 5b2f658f

Andrew Kolos authored May 11, 2023

Reverts flutter/flutter#126086.

This PR changed the interfaces of some classes, namely `AndroidSdk`, and deleted a global.

These classes had custom overrides in g3 that were not updated with a g3fix, so this PR has broken tests. See https://b.corp.google.com/issues/281945232 (non-public link)

5b2f658f

Manual roll Flutter Engine from a0925f158198 to f38f46f66e9a (8 revisions) (#126554) · 37fe1e9d

engine-flutter-autoroll authored May 11, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/a0925f158198...f38f46f66e9a

2023-05-11 whesse@google.com Add pkg:protobuf as a dependency for
testing/dart (flutter/engine#41938)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from 0c979da775be to
ccf73af6ca91 (1 revision) (flutter/engine#41937)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from a12a999cbd09 to
0c979da775be (1 revision) (flutter/engine#41935)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from 9cbc2c578e10 to
a12a999cbd09 (2 revisions) (flutter/engine#41933)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from 1a29bd9a0147 to
9cbc2c578e10 (10 revisions) (flutter/engine#41932)
2023-05-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
a3rrULFaXlwS8mfjW... to 2tQjI0g3aDmjHAtMw... (flutter/engine#41931)
2023-05-11 jacksongardner@google.com Return fonts in a deterministic
order. (flutter/engine#41907)
2023-05-11 58529443+srujzs@users.noreply.github.com Turn @staticInterop
tear-off into closure (flutter/engine#41885)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from a3rrULFaXlwS to 2tQjI0g3aDmj

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

37fe1e9d

Add `cpu: x86` dimension and xcode dependency for Mac_build_test targets (#126482) · a7a1ddfb

keyonghan authored May 11, 2023

This is a follow up of https://github.com/flutter/flutter/pull/111164.

My local LED was based on `cpu: x86` dimension and `xcode` dependency. But these are missed in the above PR, which caused test failure: https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_build_test%20flutter_gallery__transition_perf_e2e_ios/19/overview

a7a1ddfb

Make dpr available during Scrollable disposal (#126535) · dc3d6603

Michael Goderbauer authored May 11, 2023

Fixes https://github.com/flutter/flutter/issues/126454.

In certain situations (see linked bug) the Scrollable needs access to the DPR of the View it is drawn into during disposal. Since inherited widget lookups are not allowed during disposal, we cannot look up the DPR dynamically in these situations. Instead, we have to cache the DPR when lookups are still allowed.

dc3d6603

Fix `MultiChildLayoutDelegate.hasChild` doc (#126433) · 12659f2a

Taha Tesser authored May 11, 2023

fixes https://github.com/flutter/flutter/issues/115898

`hasChild` checks `_idToChild` map.  `_idToChild` is not assigned until `_callPerformLayout` is called.
So `hasChild` shouldn't be called in `getSize`.

https://github.com/flutter/flutter/blob/df789c9e76098e82f80f2c5de8b5560f360afa40/packages/flutter/lib/src/rendering/custom_layout.dart#L400-L404

Updated docs and example class names.

12659f2a

Sync lints (#126316) · 42d9a2b3

Michael Goderbauer authored May 11, 2023

Sync lints with https://github.com/dart-lang/linter/blob/master/example/all.yaml and enable `implicit_reopen` and `type_literal_in_constant_pattern` (which have no violations). Also contains some clean-up work towards enabling `matching_super_parameters`, which is not quite ready yet due to its handling of "private" arguments.

42d9a2b3

[tool] Move Java functions to their own file (#126086) · 0a63cd70

Andrew Kolos authored May 11, 2023

This is the first step in unifying Java-finding logic across the tool. If curious, see #126029 for an example of what all the changes will probably entail.

Moves java-related functionality like `AndroidSdk.findJavaHome` to a new class, `Java`.

See tracking issue https://github.com/flutter/flutter/issues/126126 for more.

0a63cd70

Roll Flutter Engine from ef771f95e928 to a0925f158198 (1 revision) (#126486) · a308666d

engine-flutter-autoroll authored May 11, 2023

https://github.com/flutter/engine/compare/ef771f95e928...a0925f158198

2023-05-10 mdebbar@google.com [web] Expose PlatformLocation and HashUrlStrategy through ui_web (flutter/engine#41163)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a308666d

Roll Flutter Engine from de6e130f77fc to ef771f95e928 (3 revisions) (#126481) · 224c8b92

engine-flutter-autoroll authored May 11, 2023

https://github.com/flutter/engine/compare/de6e130f77fc...ef771f95e928

2023-05-10 chris@bracken.jp [macos] Disable background colour tests (flutter/engine#41904)
2023-05-10 yjbanov@google.com [web] generalize focusability in semantics (flutter/engine#41831)
2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 32f4cfc2460b to 1a29bd9a0147 (12 revisions) (flutter/engine#41905)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

224c8b92

Reorder `materialStateProperty` defaults (#125905) · 4e7e4512

Qun Cheng authored May 11, 2023

Fixes #122250. This PR is to make sure all the MaterialStateProperty defaults are able to correctly resolve different states. 
* When a widget is pressed, it is also hovered, so we need to put the `MaterialState.pressed` check before `MaterialState.hovered`. 
* When a widget is focused, the widget should still be able to be hovered, so we should check `MaterialState.hovered` before `MaterialState.focused`.
* There are also cases like in _InputDecoratorDefaultsM3, the `MaterialState.disabled` should be checked before `MaterialState.error`.

 the order should be disabled, (error), pressed, hovered, focused.

4e7e4512

10 May, 2023 6 commits

Roll Flutter Engine from 406b3546a2ac to de6e130f77fc (2 revisions) (#126472) · a48cc240

engine-flutter-autoroll authored May 10, 2023

https://github.com/flutter/engine/compare/406b3546a2ac...de6e130f77fc

2023-05-10 godofredoc@google.com Revert "Move linux_license to engine v2." (flutter/engine#41903)
2023-05-10 41930132+hellohuanlin@users.noreply.github.com [backdrop_filter]Avoid relying on internal class details (flutter/engine#41873)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a48cc240

✨ Add `strokeAlign` to `CircularProgressIndicator` and `RefreshProgressIndicator` (#125945) · d01d8aee
Alex Li authored May 10, 2023

d01d8aee

Roll Flutter Engine from 10ac36c52f08 to 406b3546a2ac (13 revisions) (#126468) · a3257ca5

engine-flutter-autoroll authored May 10, 2023

https://github.com/flutter/engine/compare/10ac36c52f08...406b3546a2ac

2023-05-10 mdebbar@google.com [web] Re-enable history tests on Safari
(flutter/engine#41901)
2023-05-10 flar@google.com switch from MockCanvas to DisplayListBuilder
in layer unit tests (flutter/engine#41889)
2023-05-10 zanderso@users.noreply.github.com Revert "Move linux fuchsia
engine v2 build to prod." (flutter/engine#41902)
2023-05-10 godofredoc@google.com Migrate mac host clang tidy to engine
v2. (flutter/engine#41824)
2023-05-10 jonahwilliams@google.com [Impeller] delete special handling
of RRect. (flutter/engine#41872)
2023-05-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... (flutter/engine#41898)
2023-05-10 109111084+yaakovschectman@users.noreply.github.com Only
register top level window message listener upon registering service
binding (flutter/engine#41733)
2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 8c936fb9ba8e to
32f4cfc2460b (27 revisions) (flutter/engine#41891)
2023-05-10 yjbanov@google.com [web] dialog a11y fixes
(flutter/engine#41681)
2023-05-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
2cf089614e1c to 7ad028c26344 (2 revisions) (flutter/engine#41882)
2023-05-10 jonahwilliams@google.com [Impeller] Increase minimum size of
alpha glyph atlas. (flutter/engine#41880)
2023-05-10 jonahwilliams@google.com [Impeller] Use separate atlases and
shaders for color and alpha (flutter/engine#41780)
2023-05-10 godofredoc@google.com Move linux fuchsia engine v2 build to
prod. (flutter/engine#41865)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JiOACcaGrDph to a3rrULFaXlwS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a3257ca5

Manual roll Flutter Engine from 10ac36c52f08 to 892f88d2513f (11 revisions) (#126455) · ce3b4f88

engine-flutter-autoroll authored May 10, 2023

Manual roll requested by aaclarke@google.com

Cannot build log URL because revision "892f88d2513f" is invalid: Luci
builds of "Linux Fuchsia FEMU" for
892f88d2513f4a60ebd6d1496c4ac272e53c55ba was STARTED

2023-05-10 zanderso@users.noreply.github.com Revert "Move linux fuchsia
engine v2 build to prod." (flutter/engine#41902)
2023-05-10 godofredoc@google.com Migrate mac host clang tidy to engine
v2. (flutter/engine#41824)
2023-05-10 jonahwilliams@google.com [Impeller] delete special handling
of RRect. (flutter/engine#41872)
2023-05-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... (flutter/engine#41898)
2023-05-10 109111084+yaakovschectman@users.noreply.github.com Only
register top level window message listener upon registering service
binding (flutter/engine#41733)
2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 8c936fb9ba8e to
32f4cfc2460b (27 revisions) (flutter/engine#41891)
2023-05-10 yjbanov@google.com [web] dialog a11y fixes
(flutter/engine#41681)
2023-05-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
2cf089614e1c to 7ad028c26344 (2 revisions) (flutter/engine#41882)
2023-05-10 jonahwilliams@google.com [Impeller] Increase minimum size of
alpha glyph atlas. (flutter/engine#41880)
2023-05-10 jonahwilliams@google.com [Impeller] Use separate atlases and
shaders for color and alpha (flutter/engine#41780)
2023-05-10 godofredoc@google.com Move linux fuchsia engine v2 build to
prod. (flutter/engine#41865)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JiOACcaGrDph to a3rrULFaXlwS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce3b4f88

tool/web: correctly log all options to web wasm compile (#126379) · 1b831a2c
Kevin Moore authored May 10, 2023
```
Filtering on 'true' omitted non-bool values
```
1b831a2c

Manual roll Flutter Engine from 78f41a8f2f06 to 10ac36c52f08 (6 revisions) (#126445) · 01ac99aa

engine-flutter-autoroll authored May 10, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/78f41a8f2f06...10ac36c52f08

2023-05-09 jacksongardner@google.com Implement text rendering in Skwasm
(flutter/engine#41832)
2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
leCRDVJ8szOS2LsPV... to lf8VcONMWlne4oa3H... (flutter/engine#41876)
2023-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller]
started cleaning up pools when devices are deleted
(flutter/engine#41857)
2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
c4JvQUEOBHgtRdNPc... to JiOACcaGrDphuHIql... (flutter/engine#41874)
2023-05-09 godofredoc@google.com Move linux_license to engine v2.
(flutter/engine#41863)
2023-05-09 godofredoc@google.com Replace Windows Unopt with the engine
v2 version. (flutter/engine#41861)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from leCRDVJ8szOS to lf8VcONMWlne
  fuchsia/sdk/core/mac-amd64 from c4JvQUEOBHgt to JiOACcaGrDph

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

01ac99aa