Commits · 258382c5949ecc354c46591198a599953079865d · abdullh.alsoleman / Front-End

19 Jul, 2023 19 commits

Add menu dismiss localization (#128613) · 258382c5

Greg Spencer authored Jul 19, 2023

## Description

Modifies the semantic label for popup and context menus to be "Dismiss menu" instead of just "Dismiss".

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/118994

## Tests
 - Updated tests

258382c5

Add implementation advice to debugTypicalAncestorWidgetClass (#130530) · 07cdf37c
Ian Hickson authored Jul 19, 2023
```
Fixes https://github.com/flutter/flutter/issues/56500
```
07cdf37c

Roll Flutter Engine from 6ea54eee0592 to 0af285219809 (4 revisions) (#130939) · 6cabe736

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/6ea54eee0592...0af285219809

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 650c980daa72 to 30d458aea0b9 (1 revision) (flutter/engine#43825)
2023-07-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Iqf3gYJ8Vkq8k8l3O... to 7kGBjmX-zBXcg1svE... (flutter/engine#43823)
2023-07-19 flar@google.com fix handling of clipped rendering inside a layer that applies a filter (flutter/engine#43787)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 8d19d04472e1 to 650c980daa72 (6 revisions) (flutter/engine#43821)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Iqf3gYJ8Vkq8 to 7kGBjmX-zBXc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6cabe736

Add support for M3 motion (#129942) · 0830a362

Pierre-Louis authored Jul 19, 2023

## Description

This adds support for M3 easing and duration tokens.

This PR includes these changes:
* Generation of duration and easing constants, in `Durations` and
`Easing`, respectively (`Curves` is already taken in the `animation`
library)
* Add 3 Dart fixes

Once this is merged, I'll migrate packages/plugins/customers and then
uncomment the deprecation notices for the 3 M2 curves, all of which have
1:1 replacements.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/116525

## Tests
 - Added Dart fix tests

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

0830a362

Roll Flutter Engine from 2fab8ab5ff7f to 6ea54eee0592 (2 revisions) (#130929) · b54e83e4

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/2fab8ab5ff7f...6ea54eee0592

2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from a013e7bf089e to 936824d49aa7 (1 revision) (flutter/engine#43820)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from a352521a3a7c to 8d19d04472e1 (1 revision) (flutter/engine#43818)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b54e83e4

Roll Flutter Engine from 4b274b5c2c3a to 2fab8ab5ff7f (2 revisions) (#130920) · 8d3a5cf1

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/4b274b5c2c3a...2fab8ab5ff7f

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 4728980564b1 to a352521a3a7c (3 revisions) (flutter/engine#43816)
2023-07-19 bdero@google.com [Impeller] Disable color attachment on clip pipelines for Metal & Vulkan. (flutter/engine#43781)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8d3a5cf1

Roll Flutter Engine from 9645d8e27b59 to 4b274b5c2c3a (3 revisions) (#130903) · ffa59533

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/9645d8e27b59...4b274b5c2c3a

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 16475d7aa315 to 4728980564b1 (1 revision) (flutter/engine#43815)
2023-07-19 jason-simmons@users.noreply.github.com Apply the offset to the child bounds of an ImageFilterLayer with no filter (flutter/engine#43783)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 1f175b7a2155 to 16475d7aa315 (1 revision) (flutter/engine#43812)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ffa59533

Fix contradictory advice in "detach" docs; cut redundancy in "attach" (#130688) · f0039119

Greg Price authored Jul 19, 2023

Fixes #115525.

On [AbstractNode.detach] and its two progeny [RenderNode.detach]
and [Layer.detach], the docs said both to call the inherited method
before detaching children, and to end by doing so.  The former
advice is what's enforced by an assertion in the base implementation,
so cut out the other.

The corresponding [attach] methods redundantly said twice to
call the inherited method first, so cut the redundancy.
Leave in place the version more recently added (in #76021), because
that PR shows the old version must have been easy to overlook.

f0039119

Roll Flutter Engine from 076bd7b81d9c to 9645d8e27b59 (1 revision) (#130895) · ef43463c

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/076bd7b81d9c...9645d8e27b59

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from e9409b832799 to 1f175b7a2155 (1 revision) (flutter/engine#43811)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ef43463c

Roll Packages from 3e8b8130cda3 to 209db219ad73 (8 revisions) (#130894) · 56619889

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/packages/compare/3e8b8130cda3...209db219ad73

2023-07-19 reidbaker@google.com [tooling] mark infra steps as infra steps in yaml files (flutter/packages#4473)
2023-07-19 engine-flutter-autoroll@skia.org Manual roll Flutter from f842ed91 to 6f09064e (11 revisions) (flutter/packages#4518)
2023-07-19 stuartmorgan@google.com [ci] Enable new sharding (flutter/packages#4515)
2023-07-19 stuartmorgan@google.com [flutter_markdown] Change the way tests get screen size (flutter/packages#4514)
2023-07-18 stuartmorgan@google.com [ci] Roll Flutter to f842ed91 (flutter/packages#4513)
2023-07-18 stuartmorgan@google.com [image_picker] Update Android example (flutter/packages#4504)
2023-07-18 43054281+camsim99@users.noreply.github.com [camerax] Fixes relistening to `onStreamedFrameAvailable`'s stream behavior (flutter/packages#4511)
2023-07-18 43054281+camsim99@users.noreply.github.com [various] Deletes deprecated splash screen meta-data element (flutter/packages#4501)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

56619889

Mark Windows_android channels_integration_test_win flaky (#130893) · 3b0b670d
Zachary Anderson authored Jul 19, 2023
```
For https://github.com/flutter/flutter/issues/130732
```
3b0b670d

Roll Flutter Engine from eb2285205f25 to 076bd7b81d9c (2 revisions) (#130891) · 305c36f3

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/eb2285205f25...076bd7b81d9c

2023-07-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZABO4Om1vToxhI394... to -SNz0augjLKFVsUWn... (flutter/engine#43810)
2023-07-19 kjlubick@users.noreply.github.com Update legacy call to SkImage::makeSubset (flutter/engine#43786)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZABO4Om1vTox to -SNz0augjLKF

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

305c36f3

Roll Flutter Engine from 09389b16d684 to eb2285205f25 (3 revisions) (#130879) · d07e8aec

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/09389b16d684...eb2285205f25

2023-07-19 skia-flutter-autoroll@skia.org Roll ANGLE from 255dec886475 to 4dcaad2a894d (1 revision) (flutter/engine#43809)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from c03050eb2b65 to e9409b832799 (1 revision) (flutter/engine#43808)
2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 9f5e86b4c108 to a013e7bf089e (1 revision) (flutter/engine#43805)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d07e8aec

Roll Flutter Engine from 0293a7cb7887 to 09389b16d684 (5 revisions) (#130867) · 37ed50ac

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/0293a7cb7887...09389b16d684

2023-07-19 skia-flutter-autoroll@skia.org Roll ANGLE from b32d661389a6 to 255dec886475 (1 revision) (flutter/engine#43804)
2023-07-19 jason-simmons@users.noreply.github.com Fix the rules for determining whether a blur image filter is valid (flutter/engine#43791)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 035b12a03918 to c03050eb2b65 (1 revision) (flutter/engine#43802)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 9062ca6a691c to 035b12a03918 (3 revisions) (flutter/engine#43801)
2023-07-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SCshjyIlymHWD9W4D... to Iqf3gYJ8Vkq8k8l3O... (flutter/engine#43800)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from SCshjyIlymHW to Iqf3gYJ8Vkq8

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

37ed50ac

Move TapAndDragGestureRecognizer code under gestures (#119508) · e4e9dde4
Tomasz Gucio authored Jul 19, 2023

e4e9dde4

Roll Flutter Engine from 29de67c7d009 to 0293a7cb7887 (1 revision) (#130858) · 3213588c

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/29de67c7d009...0293a7cb7887

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from caf0d191bd07 to 9062ca6a691c (1 revision) (flutter/engine#43799)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3213588c

Roll Flutter Engine from 39d60be72ffb to 29de67c7d009 (4 revisions) (#130855) · a417a699

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/39d60be72ffb...29de67c7d009

2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from c184cac2d22f to 9f5e86b4c108 (1 revision) (flutter/engine#43798)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from d1d2b623799e to caf0d191bd07 (1 revision) (flutter/engine#43797)
2023-07-19 skia-flutter-autoroll@skia.org Roll ANGLE from 6eea5ff4db82 to b32d661389a6 (1 revision) (flutter/engine#43796)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 280fb8391187 to d1d2b623799e (1 revision) (flutter/engine#43795)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a417a699

Roll Flutter Engine from b3bfc744bb61 to 39d60be72ffb (1 revision) (#130847) · 33d174d7

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/b3bfc744bb61...39d60be72ffb

2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from ec95774043ec to c184cac2d22f (1 revision) (flutter/engine#43794)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

33d174d7

Roll Flutter Engine from adf6142f6738 to b3bfc744bb61 (7 revisions) (#130843) · 504c68ae

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/adf6142f6738...b3bfc744bb61

2023-07-18 zanderso@users.noreply.github.com Increase engine v2 orchestrator timeouts (flutter/engine#43788)
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from dcc56df202cc to 280fb8391187 (1 revision) (flutter/engine#43793)
2023-07-18 zanderso@users.noreply.github.com Remove obsolete legacy engine builds from staging (flutter/engine#43790)
2023-07-18 skia-flutter-autoroll@skia.org Roll ANGLE from 52fe3116ead9 to 6eea5ff4db82 (1 revision) (flutter/engine#43789)
2023-07-18 bdero@google.com [Impeller] Fix GL_NUM_EXTENSIONS check for desktop GL (flutter/engine#43785)
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 9a0f6d82a6f5 to dcc56df202cc (1 revision) (flutter/engine#43784)
2023-07-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ixKM7wyMrqmPDaQ11... to ZABO4Om1vToxhI394... (flutter/engine#43782)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ixKM7wyMrqmP to ZABO4Om1vTox

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

504c68ae

18 Jul, 2023 21 commits

Update app_builder_test.dart for M3 (#130794) · a4af12f4

Bruno Leroux authored Jul 18, 2023

This PR updates unit tests from app_builder_test.dart for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

In this particular case, I choose to make the tests Material-agnostic by removing the color theming which was not meaningful to what is tested here.

a4af12f4

Catch errors in loadStructuredData (#130748) · d2110922
Ian Hickson authored Jul 18, 2023
```
Fixes https://github.com/flutter/flutter/issues/42390
```
d2110922
Fix super tiny space formatting (hope we have auto formatter in the future) (#127479) · 2d753a62
fzyzcjy authored Jul 18, 2023
```
Just fix a space... I do hope we can have the auto formatter enabled in the future!
```
2d753a62

Roll Flutter Engine from 71bbecee3010 to adf6142f6738 (2 revisions) (#130831) · 0084347e

engine-flutter-autoroll authored Jul 18, 2023

https://github.com/flutter/engine/compare/71bbecee3010...adf6142f6738

2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 0adae44dd9cd to 9a0f6d82a6f5 (1 revision) (flutter/engine#43780)
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 4e518e65fea0 to 0adae44dd9cd (6 revisions) (flutter/engine#43779)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0084347e

Update SnackBar tests for M2/M3 (#130717) · e29f2b98

Bruno Leroux authored Jul 18, 2023

This PR updates unit tests for `SnackBar` to have M2 and M3 versions.

More info in https://github.com/flutter/flutter/issues/127064

e29f2b98

Roll pub packages (#130821) · edcaa335
flutter-pub-roller-bot authored Jul 18, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
edcaa335

Relax syntax for gen-l10n (#130736) · c6b93b2d

Tae Hyung Kim authored Jul 18, 2023

To preserve backward compatibility with the old parser which would
ignore syntax errors, this PR introduces a way to treat the special
characters `{` and `}` in the following way:
1. If we encounter a `{` which searching for a string token and this `{`
is not followed by a valid placeholder, then we treat the `{` as a
string and continue lexing for strings.
2. If we encounter a `}` while not within some expression (i.e.
placeholders, arguments, plurals, or selects), then we treat the `}` as
a string and continue lexing for strings.

This makes it so that
```
"helloWorld": "{ } { placeholder }",
"@@helloWorld": {
  "placeholders": {
    "placeholder" {}
  }
}
```
treats the `{ }` as a string while `{ placeholder } ` is treated as a
placeholder.

Fixes https://github.com/flutter/flutter/issues/122404.

c6b93b2d

Roll Flutter Engine from 45851af55bd6 to 71bbecee3010 (7 revisions) (#130820) · bb798e2a

engine-flutter-autoroll authored Jul 18, 2023

https://github.com/flutter/engine/compare/45851af55bd6...71bbecee3010

2023-07-18 mdebbar@google.com [web] sync => isSync , scuba => golden (flutter/engine#43699)
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 219ca2581ab2 to 4e518e65fea0 (2 revisions) (flutter/engine#43777)
2023-07-18 skia-flutter-autoroll@skia.org Roll ANGLE from 113f847be69f to 52fe3116ead9 (146 revisions) (flutter/engine#43776)
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from b7103fe086c1 to 219ca2581ab2 (1 revision) (flutter/engine#43774)
2023-07-18 chillers@google.com [ci.yaml] Skip windows arm on releases (flutter/engine#43771)
2023-07-18 gspencergoog@users.noreply.github.com Check FlutterAppDelegate selector support before calling (flutter/engine#43425)
2023-07-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from _CIP-1iUTmGCbCDZ5... to SCshjyIlymHWD9W4D... (flutter/engine#43773)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from _CIP-1iUTmGC to SCshjyIlymHW

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bb798e2a

Roll pub packages (#130608) · 60425b3c
flutter-pub-roller-bot authored Jul 18, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
60425b3c

Roll Flutter Engine from 831da7e9dc3b to 45851af55bd6 (2 revisions) (#130814) · 8fa71cbb

engine-flutter-autoroll authored Jul 18, 2023

https://github.com/flutter/engine/compare/831da7e9dc3b...45851af55bd6

2023-07-18 zanderso@users.noreply.github.com Reset Dart VM optimization level to 2 (flutter/engine#43770)
2023-07-18 jonahwilliams@google.com [Impeller] Avoid inserting additional save layers based on clip configuration. (flutter/engine#43759)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8fa71cbb

[Android] Deletes deprecated splash screen meta-data element (#130744) · b42879a9

Camille Simon authored Jul 18, 2023

Deletes deprecated splash screen meta-data element.

This is no longer needed to present a splash screen in a Flutter application, but will be removed soon. See [go/flutter-splash-screen-migration](http://go/flutter-splash-screen-migration) for more information.

Part of https://github.com/flutter/flutter/issues/105173.

b42879a9

Updated `ThemeData.useMaterial3` API doc, default is `true` (#130764) · 433f9356
Hans Muller authored Jul 18, 2023
```
Fixes https://github.com/flutter/flutter/issues/130761
```
433f9356

[labeler] Mark sync-labels as empty (#130642) · ab14a5c3

Casey Hillers authored Jul 18, 2023

https://github.com/flutter/flutter/issues/128440

Recommendation from https://github.com/actions/labeler/issues/112#issuecomment-1136485391

ab14a5c3

Roll Flutter Engine from c27658cc5ade to 831da7e9dc3b (2 revisions) (#130810) · fc2626a7

engine-flutter-autoroll authored Jul 18, 2023

https://github.com/flutter/engine/compare/c27658cc5ade...831da7e9dc3b

2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from b33cc7da1e23 to b7103fe086c1 (1 revision) (flutter/engine#43769)
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 8d3e00a1f25f to b33cc7da1e23 (1 revision) (flutter/engine#43768)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fc2626a7

Roll Packages from 6889cca8ba78 to 3e8b8130cda3 (9 revisions) (#130802) · 94179a8e

engine-flutter-autoroll authored Jul 18, 2023

https://github.com/flutter/packages/compare/6889cca8ba78...3e8b8130cda3

2023-07-18 jkbturek@gmail.com [video_player] Fix iOS crash with multiple players (flutter/packages#4202)
2023-07-17 stuartmorgan@google.com [pigeon] Enable Android emulator tests in CI (flutter/packages#4484)
2023-07-17 defuncart@gmail.com [video_player] Add optional web options [Platform interface] (flutter/packages#4433)
2023-07-17 rexios@rexios.dev [google_maps_flutter_platform_interface] Platform interface changes for #3258 (flutter/packages#4478)
2023-07-17 yan.outside@gmail.com [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826)
2023-07-17 43054281+camsim99@users.noreply.github.com [camerax] Add flash configuration for image capture (flutter/packages#3800)
2023-07-17 stuartmorgan@google.com Remove `equatable` and `xml` allowances (flutter/packages#4489)
2023-07-17 stuartmorgan@google.com [ci] Switch Linux platform tests to LUCI (flutter/packages#4479)
2023-07-17 stuartmorgan@google.com [ci] Adjust bot configurations (flutter/packages#4485)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

94179a8e

Update `AppBar` and `AppBarTheme` tests for M2/M3 (#130790) · b460d491

Taha Tesser authored Jul 18, 2023

Updated unit tests for `AppBar` and `AppBarTheme` to have M2 and M3 versions.

More info in https://github.com/flutter/flutter/issues/127064

b460d491

Update app tests for M3 (#130792) · 86385dce

Bruno Leroux authored Jul 18, 2023

This PR updates unit tests from `app_test.dart` for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

The diff is somewhat misleading because third test in the original code is now the fourth in the updated one, but because they were very similar git diff does not reflect this swap.

And also, first test is M2 only and last one M3 only.

86385dce

Add lint check to make sure samples are linked and have tests (#130523) · 8b768de1

Greg Spencer authored Jul 18, 2023

## Description

This adds a checker that will check all of the API docs examples to make sure that they are linked from at least one source file in the packages.

It also checks to make sure that all of the examples have an associated test. Since there are a large number that don't have tests at the moment, there is also a large exception list that can be burned down (burn down list is in https://github.com/flutter/flutter/issues/130459).

Because there are missing links currently, this PR will only pass after https://github.com/flutter/flutter/pull/130521 is merged.

## Related Issues

- https://github.com/flutter/flutter/issues/129956
- https://github.com/flutter/flutter/issues/130459

## Tests

- Added test for the checker.

8b768de1

Roll Flutter Engine from aaec42812a1f to c27658cc5ade (2 revisions) (#130799) · 3b0b8348

engine-flutter-autoroll authored Jul 18, 2023

https://github.com/flutter/engine/compare/aaec42812a1f...c27658cc5ade

2023-07-18 skia-flutter-autoroll@skia.org Roll Dart SDK from b83a63e0181a to ec95774043ec (1 revision) (flutter/engine#43767)
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from a4df72ba04bb to 8d3e00a1f25f (1 revision) (flutter/engine#43766)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3b0b8348

Extract common functionality of iOS platformviews into superclasses (#128716) · 203ef6f7

yaakovschectman authored Jul 18, 2023

Move most functionality of `UiKitView` and its supporting classes into
superclasses named `DarwinPlatformView`, etc., and create trivial or
near-trivial subclasses with the same names as the old classes.

I am currently awaiting approval for a macOS workstation that would
allow me to run the iOS/macOS tests and make sure all existing
functionality is preserved by this refactor. I can ensure that tests
will pass, but doing so may need to wait for a while.

Addresses [Add
AppKitView](https://github.com/flutter/flutter/issues/128519)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Chris Bracken <chris@bracken.jp>

203ef6f7

Roll Flutter Engine from 88be39be7b07 to aaec42812a1f (1 revision) (#130787) · beb245c7

engine-flutter-autoroll authored Jul 18, 2023

https://github.com/flutter/engine/compare/88be39be7b07...aaec42812a1f

2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 31be5646930b to a4df72ba04bb (1 revision) (flutter/engine#43763)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

beb245c7