- 24 Apr, 2017 1 commit
-
-
Adam Barth authored
This patch introduces the notion of a keyboard token, which generalizes the logic in EditableText for distinguishing between gaining focus by default and gaining focus because of an explicit use action. Fixes #7985
-
- 23 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
* more widget const constructors * prefer const constructors * address review comments
-
- 21 Apr, 2017 3 commits
-
-
xster authored
-
Alexandre Ardhuin authored
* make @immutable const * fix build
-
Alexandre Ardhuin authored
-
- 20 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 19 Apr, 2017 2 commits
-
-
Chinmay Garde authored
* Remove FadeTransition from _MountainViewFadeTransition. * Update tests.
-
Adam Barth authored
Turns out we have many immutable classes. Fixes #6892
-
- 18 Apr, 2017 3 commits
-
-
Hans Muller authored
-
Hans Muller authored
-
xster authored
* Make Cupertino page transition elevation animated too * Rename and change physical model to a decorated box * Tests * Add a comment * still need to handle null in the tween somewhere * nits * Tweens evaluate to the actual begin/end instances. Let them be non-null * Rename no decoration to none
-
- 14 Apr, 2017 2 commits
-
-
Hans Muller authored
-
Hans Muller authored
-
- 13 Apr, 2017 3 commits
-
-
Hans Muller authored
* Scaffold appBar is-a PreferredSizeWidget, etc * Updated * Updated per review feedback
-
Chris Bracken authored
Tests that updates to selection base/offset editing state is updated on controller updates. Tests TextEditingValue.clear() clears text.
-
Ian Hickson authored
I can't figure out if this is genius or a giant hack. This lets you use DefaultTextStyle.merge and IconTheme.merge without specifying a BuildContext. It automatically merges in at the appropriate place in the tree using a Builder widget.
-
- 12 Apr, 2017 4 commits
-
-
Hans Muller authored
-
Hans Muller authored
-
Ian Hickson authored
* Manually fix every use of Point.x and Point.y Some of these were moved to dx/dy, but not all. * Manually convert uses of the old gradient API * Remove old reference to Point. * Mechanical changes I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g' git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g' git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g' git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g' git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g' git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g' git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g' git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g' git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g' git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g' git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g' git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g' git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g' git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g' git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g' git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g' * Mechanical changes - dartdocs I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g' git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g' * Further improvements and a test * Fix minor errors from rebasing... * Roll engine
-
Ian Hickson authored
* Fix tests to use Ahem, and helpful changes around that - Fix fonts that had metric-specific behaviours. - LiveTestWidgetsFlutterBinding.allowAllFrames has been renamed to LiveTestWidgetsFlutterBinding.framePolicy. - LiveTestWidgetsFlutterBinding now defaults to using a frame policy that pumps slightly more frames, to animate the pointer crosshairs. - Added "flutter run --use-test-fonts" to enable Ahem on devices. - Changed how idle() works to be more effective in live mode. - Display the test name in live mode (unless ahem fonts are enabled). - Added a toString to TextSelectionPoint. - Style nit fixes. * Roll engine to get Ahem changes. * Update tests for dartdoc changes. * Fix flutter_tools tests
-
- 11 Apr, 2017 1 commit
-
-
xster authored
Rename State.config to State.widget Rename State.didUpdateConfig to State.didUpdateWidget Renamed all State subclasses' local variables named config to something else
-
- 10 Apr, 2017 2 commits
- 07 Apr, 2017 3 commits
-
-
Ian Hickson authored
Aggressively apply the const lint.
-
Chris Bracken authored
enterText() now includes a call to idle().
-
Chris Bracken authored
Fixes a bug where tapping in the text under edit moved the cursor but did not push the updated selection to the engine. Adds a test for caret position updates.
-
- 06 Apr, 2017 2 commits
-
-
Adam Barth authored
Fixes #9246
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/pull/8643 Fixes https://github.com/flutter/flutter/issues/8804 by adding a test to verify that Material elevation changes animate. Also tweak some dartdocs, add some trailing commas, improve some toString output, make the inkwell test agnostic to the PhysicalModel logic, and move the material buttons test to the material test directory.
-
- 05 Apr, 2017 2 commits
-
-
Ian Hickson authored
Add some commentary around DefaultTabController.initialIndex. Fix typo (nuull) in TabBar. Make some asserts more detailed.
-
Ian Hickson authored
-
- 04 Apr, 2017 5 commits
-
-
Jason Simmons authored
Fixes https://github.com/flutter/flutter/issues/9186
-
Jason Simmons authored
-
xster authored
* Just realized the creation order is the other way around * Works * Revert previous partial solution * Change pumpAndSettle to pump for gestures
-
Adam Barth authored
The underlying issue was fixed by the new focus system. Fixes #1523
-
Adam Barth authored
We should always use the maxWidth from the incomming constraints to size the text inside the editable because the EditableText itself always expands to fill its width. Also, make sure InputDecoration always expands horizontially (even when there's no icon) for consistency. Fixes #9149
-
- 03 Apr, 2017 3 commits
-
-
Hans Muller authored
-
xster authored
* Moved stuff around yet * Fix depedencies * Add more dartdoc comments to packages * Remove Cupertino dependency on material * Removed mountain_view package and added page transition test * Fix analyze warnings * Remove commented code * Partial solution. Still need to stop the animation on the previous page for modal * Some review notes * Move the cupertino back gesture controller’s lifecycle management back to its parent * Reviews * Add background color * Directional curves, full screen transition * Don’t perform the exit animation if the incoming page is a dialog * It works! * Test structures * Add a bunch of more tests and fix the gallery * One more comment * Review notes * final controller * Use that sweet sweet `is!` keyword * Play golf, because I’m bitter that there’s no nullable `as` or something in dart * Remove a space * Review notes * Remove the last deprecated test
-
xster authored
* Moved stuff around yet * Fix depedencies * Add more dartdoc comments to packages * Remove Cupertino dependency on material * Removed mountain_view package and added page transition test * Fix analyze warnings * Remove commented code * Some review notes * Move the cupertino back gesture controller’s lifecycle management back to its parent * Reviews * Add background color * final controller * Review notes
-
- 02 Apr, 2017 2 commits
-
-
Adam Barth authored
Also, fix an issue where hint text wasn't visible when the InputDecoration was collapsed. Fixes #8541
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/9031 Also some updates to mock_canvas that were needed to do this.
-