- 04 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 01 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 14 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 06 Sep, 2018 1 commit
-
-
Chris Bracken authored
--preview-dart-2 is no longer necessary as it is now the default for the standalone Dart VM.
-
- 30 Aug, 2018 2 commits
-
-
Alexander Aprelev authored
Normalize file path to non-Windows so string path comparison works.
-
Alexander Aprelev authored
* Split analysis steps out of dev/bots/test.dart into dev/bots/analyze.dart. This allows to run analysis step with command line arguments that are only applicable to flutter analyze(like --dart-sdk, needed for dart-flutter-engine head-head-head bot). * Add forgotten dev/bots/analyze.dart * Refactor common code from analyze.dart and test.dart into run_command.dart * Remove comments, add header
-
- 28 Aug, 2018 2 commits
-
-
Ian Hickson authored
-
Danny Tuppeny authored
-
- 24 Aug, 2018 1 commit
-
-
Greg Spencer authored
This adds ".pub-cache" to the list of directories to ignore when checking for dependence upon dart:test, since when people install a downloadable package, their pub cache is in the flutter directory. Also, I centralized the ANSI "red line" so that they would all use the same final string.
-
- 23 Aug, 2018 2 commits
-
-
Danny Tuppeny authored
* Start logger in startProgress to avoid assertion failure There are lots of places that create a Status() and all but two of them call ..start() immediately. This is one of the places that doesn't, which causes an assertion failure when running with --enable-asserts and the other is in the same file (I suspect it's also incorrect, but possibly it's never used - I'll look at that separately when I can trace some code that calls it). Fixes #20812. * Enable asserts for tools tests * Fix lint * Rename enableAsserts -> enableFlutterToolAsserts To make it clearer that it only enables asserts for flutter_tools when set.
-
Jonah Williams authored
Create flutter_driver infra for testing the Android AccessibilityNodeInfo generated by Flutter (#19700)
-
- 20 Aug, 2018 1 commit
-
-
Ian Hickson authored
* `flutter analyze` cleanup * Make `--dartdocs` work in all modes. * Make `analyze-sample-code.dart` more resilient. * Add a test for `analyze-sample-code.dart`. * Minor cleanup in related code and files. * Apply review comments * Fix tests
-
- 18 Aug, 2018 1 commit
-
-
Ian Hickson authored
* Fixes resulting from audit of issues links I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link. * Update run_test.dart skip this test again since it failed on linux and macos bots
-
- 17 Aug, 2018 1 commit
-
-
Ian Hickson authored
All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`. I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests. While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others. Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
-
- 15 Aug, 2018 1 commit
-
-
Ian Hickson authored
* Upgrade everything except matcher. * Roll matcher (and test) * Adjust tests that depend on flutter:test directly to depend on a shim * Require use of package:test shim and remove other references to package:test
-
- 12 Aug, 2018 1 commit
-
-
Greg Spencer authored
This changes the flutter tool to just try 10 times before giving up when running "flutter upgrade". Infinite retries can hang bots, and really don't provide a lot of help: if we've failed to upgrade for for nearly a minute, trying every five seconds, then something is just not responding. Also, changed the bot default warning level to "normal" from "all", because the solver messages are VERY verbose: several megs of output for doing packages get on Flutter. "normal" will give warnings, user messages and errors, which should be sufficient to diagnose problems on the bots without spamming the log. I removed the retrying for building the snapshot on flutter.bat because we don't do that on the other platforms, and because I can't imagine how running it again would give a different answer. I also fixed a problem in the whitespace detection when no files matched the type of file that it is looking for, and removed the code that waits until failure to print the logs on setup, since reducing the log output made a huge difference.
-
- 07 Aug, 2018 1 commit
-
-
Greg Spencer authored
This removes the final traces of Travis and Appveyor from the Flutter tree. I've updated the documentation and fixed a couple of places where scripts look for Travis, and eliminated the dart tools runningOnTravis function (which was unused anyhow). There are places in the flutter script that used to look for the environment variable TRAVIS. We actually do want to continue to detect that we're running on Travis there, since in the plugins repo we still use Travis (for the moment). In any case, it's OK, because the CI environment variable is set on all of the CI bots (Cirrus, Travis, and Appveyor). FastLane doesn't have a setup_cirrus equivalent to setup_travis, but it actually doesn't matter there either, since it doesn't do Travis-specific things, and it also looks for the CI environment variable.
-
- 06 Aug, 2018 1 commit
-
-
Devon Carew authored
* move where the mega_gallery benchmark code is generated by default * generate into a temporary diectory
-
- 02 Aug, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 01 Aug, 2018 1 commit
-
-
Greg Spencer authored
I switched to just checking for spaces and tabs, since otherwise it expresses a preference for line endings that I think should be taken care of at the git level (and I think they are). I also fixed a bug where I was looking for ".yml" instead of "*.yml" files, and clarified an output message.
-
- 27 Jul, 2018 1 commit
-
-
Todd Volkert authored
It was causing problems rolling Flutter into Fuchsia
-
- 25 Jul, 2018 1 commit
-
-
Greg Spencer authored
Our Cirrus Windows tests were not really working: they reported success even when failing. This should fix several problems with the Cirrus Windows tests.
-
- 23 Jul, 2018 2 commits
-
-
Greg Spencer authored
The trailing whitespace detector wasn't handling file deletes very well (at all, really). This filters the set of files grepped to only include files that exist. Also, clarified the failure message to make it more obvious what the failure is when the grep finds results.
-
Alexandre Ardhuin authored
* re-enable lint unnecessary_const * remove trailling whitespaces * remove unnecessary const (after merge)
-
- 20 Jul, 2018 2 commits
-
-
Greg Spencer authored
-
Greg Spencer authored
Checks only changed source files (C++, Dart, Java, ObjC) for trailing whitespace.
-
- 16 Jul, 2018 2 commits
-
-
Ian Hickson authored
This reverts commit cc1cf13e.
-
Alexandre Ardhuin authored
-
- 26 Jun, 2018 1 commit
-
-
Ian Hickson authored
-
- 13 Jun, 2018 1 commit
-
-
Chris Bracken authored
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb24. (#18362) This reverts commit 3daebd05. (#18316)
-
- 11 Jun, 2018 2 commits
-
-
Ian Hickson authored
This should reduce the number of flakes without actually increasing the timeout, so we'll still find out quickly if a test is hanging. The numbers here might need tweaking. Maybe the default two seconds is too short for CI bots.
-
Greg Spencer authored
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax. Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml. No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
-
- 08 Jun, 2018 3 commits
-
-
Chris Bracken authored
* It's time to #deleteDart1 (#18293) Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1 benchmarks. All commands now run in Dart 1 mode only. Eliminates --preview-dart-2 / --no-preview-dart-2 support. * Fix indentation, remove no longer necessary .toList() * Only push udpated kernel if >0 invalidated srcs
-
Chris Bracken authored
Several benchmarks started failing during kernel compile: 1. Timeouts: * commands_test * hot_mode_dev_cycle__benchmark * run_machine_concurrent_hot_reload * service_extensions_test 2. Kernel compiler crash: * hot_mode_dev_cycle_linux__benchmark * routing_test 3. Unexpected termination: * hot_mode_dev_cycle_win__benchmark This reverts commit ed63e708.
-
Chris Bracken authored
Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1 benchmarks. All commands now run in Dart 1 mode only. Eliminates --preview-dart-2 / --no-preview-dart-2 support.
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 04 Jun, 2018 1 commit
-
-
Ian Hickson authored
Now that we have thousands of tests, it doesn't make sense to display a separate line for each test. The result is just megabytes of logs that you have to scrub through to find error messages.
-
- 30 May, 2018 2 commits
-
-
Greg Spencer authored
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041) This reverts commit 32586020.
-
Greg Spencer authored
Fixes #18028 Just changes typedef declarations, no logic changes.
-