1. 04 Oct, 2018 1 commit
  2. 01 Oct, 2018 1 commit
  3. 14 Sep, 2018 1 commit
  4. 12 Sep, 2018 1 commit
  5. 06 Sep, 2018 1 commit
  6. 30 Aug, 2018 2 commits
  7. 28 Aug, 2018 2 commits
  8. 24 Aug, 2018 1 commit
    • Greg Spencer's avatar
      Ignore pub-cache when analyzing (#20925) · 977da4fb
      Greg Spencer authored
      This adds ".pub-cache" to the list of directories to ignore when checking for dependence upon dart:test, since when people install a downloadable package, their pub cache is in the flutter directory.
      
      Also, I centralized the ANSI "red line" so that they would all use the same final string.
      977da4fb
  9. 23 Aug, 2018 2 commits
    • Danny Tuppeny's avatar
      Start logger in startProgress to avoid assertion failure (#20814) · dc5a5c18
      Danny Tuppeny authored
      * Start logger in startProgress to avoid assertion failure
      
      There are lots of places that create a Status() and all but two of them call ..start() immediately. This is one of the places that doesn't, which causes an assertion failure when running with --enable-asserts and the other is in the same file (I suspect it's also incorrect, but possibly it's never used - I'll look at that separately when I can trace some code that calls it).
      
      Fixes #20812.
      
      * Enable asserts for tools tests
      
      * Fix lint
      
      * Rename enableAsserts -> enableFlutterToolAsserts
      
      To make it clearer that it only enables asserts for flutter_tools when set.
      dc5a5c18
    • Jonah Williams's avatar
      Create flutter_driver infra for testing the Android AccessibilityNodeInfo... · 99b38295
      Jonah Williams authored
      Create flutter_driver infra for testing the Android AccessibilityNodeInfo generated by Flutter (#19700)
      
      99b38295
  10. 20 Aug, 2018 1 commit
    • Ian Hickson's avatar
      `flutter analyze` cleanup (#20490) · ad1eaff4
      Ian Hickson authored
      * `flutter analyze` cleanup
      
      * Make `--dartdocs` work in all modes.
      * Make `analyze-sample-code.dart` more resilient.
      * Add a test for `analyze-sample-code.dart`.
      * Minor cleanup in related code and files.
      
      * Apply review comments
      
      * Fix tests
      ad1eaff4
  11. 18 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Fixes resulting from audit of issues links (#20772) · 8c79f40d
      Ian Hickson authored
      * Fixes resulting from audit of issues links
      
      I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.
      
      * Update run_test.dart
      
      skip this test again since it failed on linux and macos bots
      8c79f40d
  12. 17 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Clean up usage of temporary directories (#20682) · 3dec6a69
      Ian Hickson authored
      All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`.
      
      I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests.
      
      While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others.
      
      Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
      3dec6a69
  13. 15 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Shim package:test to avoid matcher issues (#20602) · 686d8f8a
      Ian Hickson authored
      * Upgrade everything except matcher.
      * Roll matcher (and test)
      * Adjust tests that depend on flutter:test directly to depend on a shim
      * Require use of package:test shim and remove other references to package:test
      686d8f8a
  14. 12 Aug, 2018 1 commit
    • Greg Spencer's avatar
      Switch from infinite retries on upgrade to 10 retries. (#20450) · 01d64444
      Greg Spencer authored
      This changes the flutter tool to just try 10 times before giving up when running "flutter upgrade". Infinite retries can hang bots, and really don't provide a lot of help: if we've failed to upgrade for for nearly a minute, trying every five seconds, then something is just not responding.
      
      Also, changed the bot default warning level to "normal" from "all", because the solver messages are VERY verbose: several megs of output for doing packages get on Flutter. "normal" will give warnings, user messages and errors, which should be sufficient to diagnose problems on the bots without spamming the log.
      
      I removed the retrying for building the snapshot on flutter.bat because we don't do that on the other platforms, and because I can't imagine how running it again would give a different answer.
      
      I also fixed a problem in the whitespace detection when no files matched the type of file that it is looking for, and removed the code that waits until failure to print the logs on setup, since reducing the log output made a huge difference.
      01d64444
  15. 07 Aug, 2018 1 commit
    • Greg Spencer's avatar
      Remove Travis configuration from flutter/flutter (#20288) · e60087a1
      Greg Spencer authored
      This removes the final traces of Travis and Appveyor from the Flutter tree.
      
      I've updated the documentation and fixed a couple of places where scripts look for Travis, and eliminated the dart tools runningOnTravis function (which was unused anyhow).
      
      There are places in the flutter script that used to look for the environment variable TRAVIS. We actually do want to continue to detect that we're running on Travis there, since in the plugins repo we still use Travis (for the moment). In any case, it's OK, because the CI environment variable is set on all of the CI bots (Cirrus, Travis, and Appveyor).
      
      FastLane doesn't have a setup_cirrus equivalent to setup_travis, but it actually doesn't matter there either, since it doesn't do Travis-specific things, and it also looks for the CI environment variable.
      e60087a1
  16. 06 Aug, 2018 1 commit
  17. 02 Aug, 2018 1 commit
  18. 01 Aug, 2018 1 commit
    • Greg Spencer's avatar
      Fix the whitespace check. (#20059) · 2a66fd34
      Greg Spencer authored
      I switched to just checking for spaces and tabs, since otherwise it expresses a preference for line endings that I think should be taken care of at the git level (and I think they are).
      
      I also fixed a bug where I was looking for ".yml" instead of "*.yml" files, and clarified an output message.
      2a66fd34
  19. 27 Jul, 2018 1 commit
  20. 25 Jul, 2018 1 commit
  21. 23 Jul, 2018 2 commits
  22. 20 Jul, 2018 2 commits
  23. 16 Jul, 2018 2 commits
  24. 26 Jun, 2018 1 commit
  25. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  26. 11 Jun, 2018 2 commits
    • Ian Hickson's avatar
      More flexible timeout logic in flutter_test (#18256) · dac2ebf0
      Ian Hickson authored
      This should reduce the number of flakes without actually increasing
      the timeout, so we'll still find out quickly if a test is hanging.
      
      The numbers here might need tweaking. Maybe the default two seconds is
      too short for CI bots.
      dac2ebf0
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  27. 08 Jun, 2018 3 commits
    • Chris Bracken's avatar
      It's time to #deleteDart1 (again) (#18316) · 3daebd05
      Chris Bracken authored
      * It's time to #deleteDart1 (#18293)
      
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      
      * Fix indentation, remove no longer necessary .toList()
      
      * Only push udpated kernel if >0 invalidated srcs
      3daebd05
    • Chris Bracken's avatar
      Revert "It's time to #deleteDart1 (#18293)" (#18313) · 9495df4b
      Chris Bracken authored
      Several benchmarks started failing during kernel compile:
      1. Timeouts:
         * commands_test
         * hot_mode_dev_cycle__benchmark
         * run_machine_concurrent_hot_reload
         * service_extensions_test
      
      2. Kernel compiler crash:
         * hot_mode_dev_cycle_linux__benchmark
         * routing_test
      
      3. Unexpected termination:
         * hot_mode_dev_cycle_win__benchmark
      
      This reverts commit ed63e708.
      9495df4b
    • Chris Bracken's avatar
      It's time to #deleteDart1 (#18293) · ed63e708
      Chris Bracken authored
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      ed63e708
  28. 05 Jun, 2018 1 commit
  29. 04 Jun, 2018 1 commit
    • Ian Hickson's avatar
      Be less verbose in the logs. (#17401) · e3427550
      Ian Hickson authored
      Now that we have thousands of tests, it doesn't make sense to display a separate line for each test. The result is just megabytes of logs that you have to scrub through to find error messages.
      e3427550
  30. 30 May, 2018 2 commits