1. 23 Aug, 2019 1 commit
    • Greg Spencer's avatar
      Normalize assert checking of clipBehavior (#38568) · 365f577c
      Greg Spencer authored
      I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary.
      
      This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
      365f577c
  2. 28 Jul, 2019 1 commit
  3. 16 Jul, 2019 1 commit
  4. 12 Jul, 2019 2 commits
    • Kate Lovett's avatar
      Revert "Part 1: Skia Gold Testing (#33688)" (#36094) · 8809f698
      Kate Lovett authored
      This reverts commit eb0b1790.
      Skia Gold post-submit test were failing due to the service account not being found on Cirrus.
      8809f698
    • Kate Lovett's avatar
      Part 1: Skia Gold Testing (#33688) · eb0b1790
      Kate Lovett authored
      * Fresh PR for Gold integration.
      
      * Nits
      
      * WIP
      
      * Artifacts from merge
      
      * Changed some platform dependencies for web, added library prefix notation for Skia Gold test names.
      
      * Updating for CI implementation
      
      * Write out service account
      
      * Writing to skip out
      
      * WIP
      
      * ++
      
      * Fixing depot tools deps
      
      * Windows depot_tools
      
      * Fixing setup scripts
      
      * ++
      
      * depot tools
      
      * ++
      
      * WIP
      
      * Tracing depot_tools clone
      
      * WIP
      
      * ++
      
      * analyzer
      
      * WIP
      
      * chrome typo
      
      * copy artifact
      
      * Working on tests
      
      * Code cleanup
      
      * ++
      
      * Code cleanup, updated tests
      
      * ++ review feedback
      
      * Review
      
      * Analyzer
      
      * Review feedback
      
      * Nits from review
      
      * PRogress
      
      * ++
      
      * Fixing tests
      
      * ++
      
      * Testing repo route
      
      * Just needing documention around new structures.
      
      * cleanup
      
      * Analyzer
      
      * Documentation updates
      
      * Documentation updates
      
      * Cirrus updates
      
      * cirrus nit
      
      * Review feedback
      
      * Review feedback
      
      * Fixing skip comparator
      
      * Fix base directory for Skia Gold case
      
      * ++
      
      * Feedback
      
      * ++
      
      * Fixed uri assertion
      
      * Made GoldensClient abstract, altered SkiaGoldClient constructor
      
      * Analyzer
      eb0b1790
  5. 18 Jun, 2019 1 commit
  6. 13 Jun, 2019 1 commit
  7. 03 Jun, 2019 3 commits
  8. 10 May, 2019 1 commit
  9. 25 Apr, 2019 1 commit
  10. 24 Apr, 2019 1 commit
  11. 14 Mar, 2019 1 commit
  12. 12 Mar, 2019 1 commit
  13. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  14. 21 Feb, 2019 1 commit
  15. 01 Feb, 2019 1 commit
  16. 30 Jan, 2019 1 commit
    • rami-a's avatar
      Add Material/Card borderOnForeground flag to allow border to be painted behind... · 327e3eff
      rami-a authored
      Add Material/Card borderOnForeground flag to allow border to be painted behind the child widget (#27297)
      
      In certain situations, a developer may require the border of a Material to be painted behind its child. For example a Card widget that has a full width image across the top half. In that scenario, the image should ideally be painted above the border with regards to z-position.
      
      This change exposes a flag on Material widget to achieve this behavior. Additionally, the same flag is exposed on Card widget to allow the Card widget to pass this down to its Material.
      
      I added a couple golden tests to verify this new behavior. Goldens are here:
      https://github.com/flutter/goldens/commit/46a3d26acbb1b0d72b6b02c30f03b9dbda7d5bdf
      327e3eff
  17. 08 Jan, 2019 1 commit
  18. 23 Dec, 2018 1 commit
  19. 12 Sep, 2018 1 commit
  20. 24 Aug, 2018 1 commit
  21. 15 Aug, 2018 1 commit
  22. 09 Aug, 2018 1 commit
  23. 02 Aug, 2018 1 commit
  24. 27 Jul, 2018 1 commit
  25. 23 Jul, 2018 1 commit
  26. 16 Jul, 2018 2 commits
  27. 05 Jun, 2018 1 commit
  28. 07 Feb, 2018 3 commits
  29. 01 Feb, 2018 1 commit
    • amirh's avatar
      Use RRects instead of Paths when possible in Material. (#14404) · d9ef7df9
      amirh authored
      0672055a changed the Material widget to
      always use Paths for representing the outline.
      These paths are later used for clipping and drawing a shadow.
      This changed introduced a performance regression, see:
      https://github.com/flutter/flutter/issues/14403
      
      We did not expect a path that is a rounded rectangle to be less
      performant than a rounded rectangle, as Skia should be able to tell the
      path is just a rounded rectangle.
      Until we find a solution for this regression, we keep using RRect when
      we can represent the shape with it.
      d9ef7df9
  30. 31 Jan, 2018 1 commit
    • amirh's avatar
      Support arbitrary shaped Material. (#14367) · 0672055a
      amirh authored
      For backward compatibility we keep supporting specifying the shape as a
      combination of MaterialType and borderRadius, and we just use that as a
      default when shapeBorder is null.
      
      To cleanup the implementation if shapeBorder was not specified we just
      translate the specified shape to a shapeBorder internally.
      I benchmarked paint, layout and hit testing, with the specialized shape
      clippers vs. the equivalent path clippers and did not see any
      significant performance difference.
      
      For testing, I extended the clippers/physicalShape matchers to match either the
      specialized shape or the equivalent shape.
      0672055a
  31. 30 Jan, 2018 1 commit
  32. 08 Nov, 2017 1 commit
  33. 07 Nov, 2017 1 commit
    • Sebastiano Poggi's avatar
      Surface elevation shadow colour on Material (#12881) · dfd1ffa7
      Sebastiano Poggi authored
      * Surface shadowColor from RenderPhysicalModel to Material
      
      * Fix typo in material_test
      
      * Add nullability info to documentation
      
      * Add support for animating elevation shadow color
      
      * Add shadowColor to Material's debugFillProperties()
      
      * Add missing default value for elevation in Material debugFillProperties()
      
      * Add missing non-null asserts for animate flags in AnimatedPhysicalModel
      
      * Add test for shadow color animating smoothly
      dfd1ffa7
  34. 05 Sep, 2017 1 commit