- 23 Aug, 2019 1 commit
-
-
Greg Spencer authored
I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary. This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
-
- 28 Jul, 2019 1 commit
-
-
Kate Lovett authored
-
- 16 Jul, 2019 1 commit
-
-
Darren Austin authored
Added support for a semi-transparent white overlay color for `Material` widgets to indicate their elevation in a dart theme. A new `ThemeData.applyElevationOverlayColor` flag was added to control this behavior, which is off by default for backwards compatibility reasons.
-
- 12 Jul, 2019 2 commits
-
-
Kate Lovett authored
This reverts commit eb0b1790. Skia Gold post-submit test were failing due to the service account not being found on Cirrus.
-
Kate Lovett authored
* Fresh PR for Gold integration. * Nits * WIP * Artifacts from merge * Changed some platform dependencies for web, added library prefix notation for Skia Gold test names. * Updating for CI implementation * Write out service account * Writing to skip out * WIP * ++ * Fixing depot tools deps * Windows depot_tools * Fixing setup scripts * ++ * depot tools * ++ * WIP * Tracing depot_tools clone * WIP * ++ * analyzer * WIP * chrome typo * copy artifact * Working on tests * Code cleanup * ++ * Code cleanup, updated tests * ++ review feedback * Review * Analyzer * Review feedback * Nits from review * PRogress * ++ * Fixing tests * ++ * Testing repo route * Just needing documention around new structures. * cleanup * Analyzer * Documentation updates * Documentation updates * Cirrus updates * cirrus nit * Review feedback * Review feedback * Fixing skip comparator * Fix base directory for Skia Gold case * ++ * Feedback * ++ * Fixed uri assertion * Made GoldensClient abstract, altered SkiaGoldClient constructor * Analyzer
-
- 18 Jun, 2019 1 commit
-
-
Kate Lovett authored
* Splitting golden file versioning out as an argument of matchesGoldenFile * Fixing description implementation. * Removing unused imports * Removing unused import * Review feedback
-
- 13 Jun, 2019 1 commit
-
-
Jonah Williams authored
-
- 03 Jun, 2019 3 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
This reverts commit d92b3b40.
-
Jonah Williams authored
-
- 10 May, 2019 1 commit
-
-
Kate Lovett authored
Revert "Merge branch 'master' into master" This reverts commit e3a03c04, reversing changes made to 64749826.
-
- 25 Apr, 2019 1 commit
-
-
Kate Lovett authored
-
- 24 Apr, 2019 1 commit
-
-
Kate Lovett authored
-
- 14 Mar, 2019 1 commit
-
- 12 Mar, 2019 1 commit
-
-
Dan Field authored
* Always composite PhysicalModels * Update tests to check layer tree instead of canvas for Physical shadows
-
- 01 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
* add trailing commas on list/map/parameters * add trailing commas on Invocation with nb of arg>1 * add commas for widget containing widgets * add trailing commas if instantiation contains trailing comma * revert bad change
-
- 21 Feb, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 01 Feb, 2019 1 commit
-
-
Hans Muller authored
-
- 30 Jan, 2019 1 commit
-
-
rami-a authored
Add Material/Card borderOnForeground flag to allow border to be painted behind the child widget (#27297) In certain situations, a developer may require the border of a Material to be painted behind its child. For example a Card widget that has a full width image across the top half. In that scenario, the image should ideally be painted above the border with regards to z-position. This change exposes a flag on Material widget to achieve this behavior. Additionally, the same flag is exposed on Card widget to allow the Card widget to pass this down to its Material. I added a couple golden tests to verify this new behavior. Goldens are here: https://github.com/flutter/goldens/commit/46a3d26acbb1b0d72b6b02c30f03b9dbda7d5bdf
-
- 08 Jan, 2019 1 commit
-
-
Mehmet Fidanboylu authored
-
- 23 Dec, 2018 1 commit
-
-
Ian Hickson authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 24 Aug, 2018 1 commit
-
-
liyuqian authored
This reverts commit 8de0e15e and updates the goldens versoin. This requires https://github.com/flutter/flutter/pull/20751 to land first.
-
- 15 Aug, 2018 1 commit
-
-
Jonah Williams authored
-
- 09 Aug, 2018 1 commit
-
-
liyuqian authored
This fixes https://github.com/flutter/flutter/issues/18057
-
- 02 Aug, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Jul, 2018 1 commit
-
-
Todd Volkert authored
It was causing problems rolling Flutter into Fuchsia
-
- 23 Jul, 2018 1 commit
-
-
Alexandre Ardhuin authored
* re-enable lint unnecessary_const * remove trailling whitespaces * remove unnecessary const (after merge)
-
- 16 Jul, 2018 2 commits
-
-
Ian Hickson authored
This reverts commit cc1cf13e.
-
Alexandre Ardhuin authored
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Feb, 2018 3 commits
-
-
amirh authored
-
Amir Hardon authored
This is done to keep in place the workaround we have for rectangular material where PhysicalModel skips the saveLayer call.
-
Amir Hardon authored
This reverts commit d9ef7df9.
-
- 01 Feb, 2018 1 commit
-
-
amirh authored
0672055a changed the Material widget to always use Paths for representing the outline. These paths are later used for clipping and drawing a shadow. This changed introduced a performance regression, see: https://github.com/flutter/flutter/issues/14403 We did not expect a path that is a rounded rectangle to be less performant than a rounded rectangle, as Skia should be able to tell the path is just a rounded rectangle. Until we find a solution for this regression, we keep using RRect when we can represent the shape with it.
-
- 31 Jan, 2018 1 commit
-
-
amirh authored
For backward compatibility we keep supporting specifying the shape as a combination of MaterialType and borderRadius, and we just use that as a default when shapeBorder is null. To cleanup the implementation if shapeBorder was not specified we just translate the specified shape to a shapeBorder internally. I benchmarked paint, layout and hit testing, with the specialized shape clippers vs. the equivalent path clippers and did not see any significant performance difference. For testing, I extended the clippers/physicalShape matchers to match either the specialized shape or the equivalent shape.
-
- 30 Jan, 2018 1 commit
-
-
amirh authored
-
- 08 Nov, 2017 1 commit
-
-
Yegor authored
-
- 07 Nov, 2017 1 commit
-
-
Sebastiano Poggi authored
* Surface shadowColor from RenderPhysicalModel to Material * Fix typo in material_test * Add nullability info to documentation * Add support for animating elevation shadow color * Add shadowColor to Material's debugFillProperties() * Add missing default value for elevation in Material debugFillProperties() * Add missing non-null asserts for animate flags in AnimatedPhysicalModel * Add test for shadow color animating smoothly
-
- 05 Sep, 2017 1 commit
-
-
Adam Barth authored
Fixes #11855
-