Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
8c59c524
Commit
8c59c524
authored
Apr 24, 2019
by
Kate Lovett
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Swapping out matchesGoldenFile for matchesSkiaGoldFile for framework tests.
parent
beebd5c4
Changes
13
Hide whitespace changes
Inline
Side-by-side
Showing
13 changed files
with
70 additions
and
43 deletions
+70
-43
nav_bar_test.dart
packages/flutter/test/cupertino/nav_bar_test.dart
+6
-4
segmented_control_test.dart
packages/flutter/test/cupertino/segmented_control_test.dart
+9
-4
bottom_app_bar_test.dart
packages/flutter/test/material/bottom_app_bar_test.dart
+7
-3
bottom_app_bar_theme_test.dart
...ages/flutter/test/material/bottom_app_bar_theme_test.dart
+3
-2
bottom_navigation_bar_test.dart
...ges/flutter/test/material/bottom_navigation_bar_test.dart
+3
-2
card_theme_test.dart
packages/flutter/test/material/card_theme_test.dart
+3
-2
dialog_theme_test.dart
packages/flutter/test/material/dialog_theme_test.dart
+3
-2
dropdown_test.dart
packages/flutter/test/material/dropdown_test.dart
+6
-4
floating_action_button_test.dart
...es/flutter/test/material/floating_action_button_test.dart
+3
-2
input_decorator_test.dart
packages/flutter/test/material/input_decorator_test.dart
+6
-4
material_test.dart
packages/flutter/test/material/material_test.dart
+6
-4
radio_test.dart
packages/flutter/test/material/radio_test.dart
+3
-2
tab_bar_theme_test.dart
packages/flutter/test/material/tab_bar_theme_test.dart
+12
-8
No files found.
packages/flutter/test/cupertino/nav_bar_test.dart
View file @
8c59c524
...
...
@@ -801,12 +801,13 @@ void main() {
await
expectLater
(
find
.
byType
(
RepaintBoundary
).
last
,
matchesGoldenFile
(
'nav_bar_test.standard_title.1.png'
),
//matchesGoldenFile('nav_bar_test.standard_title.1.png'),
matchesSkiaGoldFile
(
'nav_bar_test.standard_title.png'
),
);
},
// TODO(xster): remove once https://github.com/flutter/flutter/issues/17483
// is fixed.
skip:
!
Platform
.
isLinux
,
//
skip: !Platform.isLinux,
);
testWidgets
(
...
...
@@ -835,12 +836,13 @@ void main() {
await
expectLater
(
find
.
byType
(
RepaintBoundary
).
last
,
matchesGoldenFile
(
'nav_bar_test.large_title.1.png'
),
// matchesGoldenFile('nav_bar_test.large_title.1.png'),
matchesSkiaGoldFile
(
'nav_bar_test.large_title.png'
),
);
},
// TODO(xster): remove once https://github.com/flutter/flutter/issues/17483
// is fixed.
skip:
!
Platform
.
isLinux
,
//
skip: !Platform.isLinux,
);
...
...
packages/flutter/test/cupertino/segmented_control_test.dart
View file @
8c59c524
...
...
@@ -1327,9 +1327,11 @@ void main() {
await
expectLater
(
find
.
byType
(
RepaintBoundary
),
matchesGoldenFile
(
'segmented_control_test.0.0.png'
),
// matchesGoldenFile('segmented_control_test.0.0.png'),
matchesSkiaGoldFile
(
'segmented_control_test.0.png'
),
);
},
skip:
!
Platform
.
isLinux
);
},
//skip: !Platform.isLinux
);
testWidgets
(
'Golden Test Pressed State'
,
(
WidgetTester
tester
)
async
{
final
Map
<
int
,
Widget
>
children
=
<
int
,
Widget
>{};
...
...
@@ -1365,7 +1367,10 @@ void main() {
await
expectLater
(
find
.
byType
(
RepaintBoundary
),
matchesGoldenFile
(
'segmented_control_test.1.0.png'
),
// matchesGoldenFile('segmented_control_test.1.0.png'),
matchesSkiaGoldFile
(
'segmented_control_test.1.png'
),
);
},
skip:
!
Platform
.
isLinux
);
},
// skip: !Platform.isLinux
);
}
packages/flutter/test/material/bottom_app_bar_test.dart
View file @
8c59c524
...
...
@@ -73,15 +73,19 @@ void main() {
await
pump
(
FloatingActionButtonLocation
.
endDocked
);
await
expectLater
(
find
.
byKey
(
key
),
matchesGoldenFile
(
'bottom_app_bar.custom_shape.1.png'
),
// matchesGoldenFile('bottom_app_bar.custom_shape.1.png'),
matchesSkiaGoldFile
(
'bottom_app_bar.custom_shape.1.png'
),
);
await
pump
(
FloatingActionButtonLocation
.
centerDocked
);
await
tester
.
pumpAndSettle
();
await
expectLater
(
find
.
byKey
(
key
),
matchesGoldenFile
(
'bottom_app_bar.custom_shape.2.png'
),
// matchesGoldenFile('bottom_app_bar.custom_shape.2.png'),
matchesSkiaGoldFile
(
'bottom_app_bar.custom_shape.2.png'
),
);
},
skip:
!
Platform
.
isLinux
);
},
// skip: !Platform.isLinux
);
testWidgets
(
'color defaults to Theme.bottomAppBarColor'
,
(
WidgetTester
tester
)
async
{
await
tester
.
pumpWidget
(
...
...
packages/flutter/test/material/bottom_app_bar_theme_test.dart
View file @
8c59c524
...
...
@@ -82,8 +82,9 @@ void main() {
await
expectLater
(
find
.
byKey
(
_painterKey
),
matchesGoldenFile
(
'bottom_app_bar_theme.custom_shape.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'bottom_app_bar_theme.custom_shape.png'
),
//matchesGoldenFile('bottom_app_bar_theme.custom_shape.png'),
//skip: !Platform.isLinux,
);
});
...
...
packages/flutter/test/material/bottom_navigation_bar_test.dart
View file @
8c59c524
...
...
@@ -1148,8 +1148,9 @@ void main() {
await
tester
.
pump
(
const
Duration
(
milliseconds:
30
));
await
expectLater
(
find
.
byType
(
BottomNavigationBar
),
matchesGoldenFile
(
'bottom_navigation_bar.shifting_transition.2.
$pump
.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'bottom_navigation_bar.shifting_transition.
$pump
.png'
),
// matchesGoldenFile('bottom_navigation_bar.shifting_transition.2.$pump.png'),
// skip: !Platform.isLinux,
);
}
});
...
...
packages/flutter/test/material/card_theme_test.dart
View file @
8c59c524
...
...
@@ -139,8 +139,9 @@ void main() {
await
expectLater
(
find
.
byKey
(
painterKey
),
matchesGoldenFile
(
'card_theme.custom_shape.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'card_theme.custom_shape.png'
),
// matchesGoldenFile('card_theme.custom_shape.png'),
// skip: !Platform.isLinux,
);
});
}
...
...
packages/flutter/test/material/dialog_theme_test.dart
View file @
8c59c524
...
...
@@ -132,8 +132,9 @@ void main() {
await
expectLater
(
find
.
byKey
(
_painterKey
),
matchesGoldenFile
(
'dialog_theme.dialog_with_custom_border.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'dialog_theme.dialog_with_custom_border.png'
),
// matchesGoldenFile('dialog_theme.dialog_with_custom_border.png'),
// skip: !Platform.isLinux,
);
});
...
...
packages/flutter/test/material/dropdown_test.dart
View file @
8c59c524
...
...
@@ -141,8 +141,9 @@ void main() {
assert
(
tester
.
renderObject
(
buttonFinder
).
attached
);
await
expectLater
(
find
.
ancestor
(
of:
buttonFinder
,
matching:
find
.
byType
(
RepaintBoundary
)).
first
,
matchesGoldenFile
(
'dropdown_test.default.0.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'dropdown_test.default.png'
),
// matchesGoldenFile('dropdown_test.default.0.png'),
// skip: !Platform.isLinux,
);
});
...
...
@@ -154,8 +155,9 @@ void main() {
assert
(
tester
.
renderObject
(
buttonFinder
).
attached
);
await
expectLater
(
find
.
ancestor
(
of:
buttonFinder
,
matching:
find
.
byType
(
RepaintBoundary
)).
first
,
matchesGoldenFile
(
'dropdown_test.expanded.0.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'dropdown_test.expanded.png'
),
// matchesGoldenFile('dropdown_test.expanded.0.png'),
// skip: !Platform.isLinux,
);
});
...
...
packages/flutter/test/material/floating_action_button_test.dart
View file @
8c59c524
...
...
@@ -681,8 +681,9 @@ void main() {
await
tester
.
pump
(
const
Duration
(
milliseconds:
1000
));
await
expectLater
(
find
.
byKey
(
key
),
matchesGoldenFile
(
'floating_action_button_test.clip.2.png'
),
// .clip.1.png is obsolete and can be removed
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'floating_action_button_test.clip.png'
),
// matchesGoldenFile('floating_action_button_test.clip.2.png'), // .clip.1.png is obsolete and can be removed
// skip: !Platform.isLinux,
);
});
...
...
packages/flutter/test/material/input_decorator_test.dart
View file @
8c59c524
...
...
@@ -2020,15 +2020,17 @@ void main() {
await
tester
.
pumpWidget
(
buildFrame
(
TextDirection
.
ltr
));
await
expectLater
(
find
.
byType
(
InputDecorator
),
matchesGoldenFile
(
'input_decorator.outline_icon_label.ltr.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'input_decorator.outline_icon_label.ltr.png'
),
// matchesGoldenFile('input_decorator.outline_icon_label.ltr.png'),
// skip: !Platform.isLinux,
);
await
tester
.
pumpWidget
(
buildFrame
(
TextDirection
.
rtl
));
await
expectLater
(
find
.
byType
(
InputDecorator
),
matchesGoldenFile
(
'input_decorator.outline_icon_label.rtl.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'input_decorator.outline_icon_label.rtl.png'
),
// matchesGoldenFile('input_decorator.outline_icon_label.rtl.png'),
// skip: !Platform.isLinux,
);
},
skip:
!
Platform
.
isLinux
,
...
...
packages/flutter/test/material/material_test.dart
View file @
8c59c524
...
...
@@ -618,8 +618,9 @@ void main() {
await
expectLater
(
find
.
byKey
(
painterKey
),
matchesGoldenFile
(
'material.border_paint_above.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'material.border_paint_above.png'
),
// matchesGoldenFile('material.border_paint_above.png'),
// skip: !Platform.isLinux,
);
});
...
...
@@ -659,8 +660,9 @@ void main() {
await
expectLater
(
find
.
byKey
(
painterKey
),
matchesGoldenFile
(
'material.border_paint_below.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'material.border_paint_below.png'
),
// matchesGoldenFile('material.border_paint_below.png'),
// skip: !Platform.isLinux,
);
});
});
...
...
packages/flutter/test/material/radio_test.dart
View file @
8c59c524
...
...
@@ -277,8 +277,9 @@ void main() {
await
tester
.
pumpAndSettle
();
await
expectLater
(
find
.
byKey
(
painterKey
),
matchesGoldenFile
(
'radio.ink_ripple.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'radio.ink_ripple.png'
),
// matchesGoldenFile('radio.ink_ripple.png'),
// skip: !Platform.isLinux,
);
});
}
...
...
packages/flutter/test/material/tab_bar_theme_test.dart
View file @
8c59c524
...
...
@@ -269,8 +269,9 @@ void main() {
await
expectLater
(
find
.
byKey
(
_painterKey
),
matchesGoldenFile
(
'tab_bar_theme.tab_indicator_size_tab.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'tab_bar_theme.tab_indicator_size_tab.png'
),
// matchesGoldenFile('tab_bar_theme.tab_indicator_size_tab.png'),
// skip: !Platform.isLinux,
);
});
...
...
@@ -281,8 +282,9 @@ void main() {
await
expectLater
(
find
.
byKey
(
_painterKey
),
matchesGoldenFile
(
'tab_bar_theme.tab_indicator_size_label.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'tab_bar_theme.tab_indicator_size_label.png'
),
// matchesGoldenFile('tab_bar_theme.tab_indicator_size_label.png'),
// skip: !Platform.isLinux,
);
});
...
...
@@ -298,8 +300,9 @@ void main() {
await
expectLater
(
find
.
byKey
(
_painterKey
),
matchesGoldenFile
(
'tab_bar_theme.custom_tab_indicator.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'tab_bar_theme.custom_tab_indicator.png'
),
// matchesGoldenFile('tab_bar_theme.custom_tab_indicator.png'),
// skip: !Platform.isLinux,
);
});
...
...
@@ -315,8 +318,9 @@ void main() {
await
expectLater
(
find
.
byKey
(
_painterKey
),
matchesGoldenFile
(
'tab_bar_theme.beveled_rect_indicator.png'
),
skip:
!
Platform
.
isLinux
,
matchesSkiaGoldFile
(
'tab_bar_theme.beveled_rect_indicator.png'
),
// matchesGoldenFile('tab_bar_theme.beveled_rect_indicator.png'),
// skip: !Platform.isLinux,
);
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment