- 25 Aug, 2020 1 commit
-
-
Greg Spencer authored
-
- 21 Aug, 2020 2 commits
-
-
LongCatIsLooong authored
Reland "Prevent material switch from recreating its render object when it becomes disabled (#61398)", reverted in #64062 (#64354)
-
LongCatIsLooong authored
Revert "Prevent material switch from recreating its render object when it becomes disabled (#61398)" (#64062)
-
- 17 Aug, 2020 1 commit
-
-
LongCatIsLooong authored
-
- 29 Jul, 2020 2 commits
-
-
Michael Goderbauer authored
-
Michael Goderbauer authored
-
- 28 Jul, 2020 1 commit
-
-
Darren Austin authored
Updated references to the old button classes to the new ones in comments and documentation for classes in the widgets, services and rendering libraries. (#62099)
-
- 23 Jul, 2020 2 commits
-
-
Todd Volkert authored
-
Todd Volkert authored
The boolean value as to whether the action was found and enabled is less useful than just returning the result of invoking the action itself.
-
- 18 Jun, 2020 1 commit
-
-
Darren Austin authored
-
- 11 Jun, 2020 2 commits
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
Darren Austin authored
-
- 29 May, 2020 1 commit
-
-
Greg Spencer authored
This makes the callback arguments to FocusableActionDetector optional, if you (for instance) only want to define shortcuts and actions and a focus node for something.
-
- 28 May, 2020 1 commit
-
-
Tong Mu authored
* Adds default cursor and/or mouseCursor property to a number of widgets. * Adds `MaterialStateMouseCurrsor`.
-
- 27 May, 2020 1 commit
-
-
Greg Spencer authored
This adds a new navigationMode to the MediaQueryData that indicates how focusable controls should behave under different navigation modes, currently with two modes: NavigationMode.traditional, and NavigationMode.directional. It may seem like focusing a disabled control is not desirable, but this is useful for user interfaces that use DPAD navigation because if a control gets disabled, losing focus is disruptive to the user, and it is difficult to control where the focus will end up unless it is done explicitly.
-
- 21 Apr, 2020 1 commit
-
-
Greg Spencer authored
-
- 07 Apr, 2020 1 commit
-
-
Greg Spencer authored
This updates the Action API in accordance with the design doc for the changes: flutter.dev/go/actions-and-shortcuts-design-revision Fixes #53276
-
- 11 Mar, 2020 1 commit
-
-
Greg Spencer authored
This converts Diagnosticable to be a mixin instead of an abstract class, so that it can be used to add diagnostics to classes which already have a base class. It leaves in place the DiagnosticableMixin mixin, since there are some plugins that are still using it, and removing it would mean that those plugins wouldn't work with master branch Flutter anymore. DiagnosticableMixin will be removed once this mixin version of Diagnosticable makes its way to the stable branch.
-
- 20 Feb, 2020 1 commit
-
-
Greg Spencer authored
-
- 11 Feb, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 10 Feb, 2020 1 commit
-
-
Greg Spencer authored
This PR modifies the existing API docs samples to use DartPad so that all of the samples are now interactive apps on the API docs site. It also removes the restriction for the max width of the description area so that the dartpad region can expand horizontally. I updated the first paragraph on the API docs to indicate that Flutter is more than just mobile now (same text as the README.md at the top level). I modified a few of the examples so that they looked nicer, and fit better on the page. I added the sample description text above each DartPad instance, since that often defines the context of the example. I removed animations and images when they were redundant with the sample content. There were a few that made sense to keep, so I did.
-
- 08 Jan, 2020 1 commit
-
-
Greg Spencer authored
-
- 05 Dec, 2019 2 commits
-
-
Greg Spencer authored
This normalizes all of the "See also" blocks in comments so that they conform in style. They all look like this now: /// See also: /// /// * [MyFavoriteWidget], because it's cool. class Foo {} I removed some useless "See also" blocks, and added commentary to ones that were just "bare" references. This is my penance for adding so many bullets that are "-" instead of "*". :-)
-
Greg Spencer authored
This adds actions and shortcuts arguments to WidgetsApp (and MaterialApp and CupertinoApp) to allow developers to override the default mappings on an application, and to allow for a more complex definition of the default mappings. I've stopped using SelectAction here, in favor of using ActivateAction for all activations, but haven't removed it, to avoid a breaking change, and to allow a common base class for these types of actions. This is because some platforms use the same mapping (web) for both kinds of activations (both select and activate).
-
- 04 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
* implicit-casts:false in flutter/lib/src/widgets * address review comments * address review comment
-
- 02 Dec, 2019 1 commit
-
-
Tong Mu authored
This PR rewrites MouseTracker's lifecycle, so that mouse callbacks are all triggered in post frame, instead of the current one where some are triggered during the build phase. This PR also changes the onExit callback to MouseRegion, RenderMouseRegion, and MouseTrackerAnnotation, so that it is no longer triggered on dispose.
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 22 Nov, 2019 1 commit
-
-
Alexandre Ardhuin authored
* make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic * make BuildContext.inheritFromWidgetOfExactType generic * make BuildContext.ancestorInheritedElementForWidgetOfExactType generic * make BuildContext.ancestorWidgetOfExactType generic * fix snippet * bump scoped_model on temp version * update names * Revert "bump scoped_model on temp version" This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0. * address review comments * fix ci * address review comments * repeat the deprecation notice * fix uppercase * use of recommanded deprecation syntax * address review comment
-
- 20 Nov, 2019 1 commit
-
-
Greg Spencer authored
Before this change, it was possible to move the focus onto a control that was no longer in the view using focus traversal. This changes that, so that when a control is focused, it makes sure that if it is the child of a scrollable, that the scrollable attempts to keep it in view. If it is already in view, then nothing scrolls. When asked to move in a direction, the focus traversal code tries to find a control to move to inside the scrollable first, and then looks for things outside of the scrollable only once the scrollable has reached its limit in that direction.
-
- 19 Nov, 2019 1 commit
-
-
Greg Spencer authored
This adds a FocusableActionDetector, a widget which combines the functionality of Actions, Shortcuts, MouseRegion and a Focus widget to create a detector that defines actions and key bindings, and will notify that the focus or hover highlights should be shown or not. This widget can be used to give a control the required detection modes for focus and hover handling on desktop and web platforms. I replaced a bunch of similar code in many of our widgets with this widget, and found that pretty much any control that wants to be focusable wants all of these features as well: focus highlights, hover highlights, and actions to activate it. Also eliminated an extra _hasFocus variable in FocusState that wasn't being used.
-
- 01 Nov, 2019 1 commit
-
-
Greg Spencer authored
This adds accessors for WidgetsBinding.instance.focusManager and WidgetsBinding.instance.focusManager.primaryFocus so that they can be more easily found in IDEs and accessed. This adds a top level getter for WidgetsBinding.instance.focusManager.primaryFocus called primaryFocus, and a static accessor FocusManager.instance that returns WidgetsBinding.instance.focusManager.
-
- 30 Oct, 2019 1 commit
-
-
Greg Spencer authored
This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43213), with fixes for the web tests that weren't enabled in the master that it was synced to when I first landed it.
-
- 28 Oct, 2019 2 commits
-
-
Greg Spencer authored
Revert "Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43384)" (#43647) This reverts commit 8017f63b, since it breaks web tests.
-
Greg Spencer authored
This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43213) No changes from original, except for finding the right RenderBox in dev/integration_tests/android_semantics_testing/test_driver/main_test.dart.
-
- 23 Oct, 2019 2 commits
-
-
Jonah Williams authored
Revert "Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43213)" (#43367) This reverts commit 90006720.
-
Greg Spencer authored
In order to enable keyboard navigation to more controls, I've added focus nodes to switches, checkboxes, and radio buttons. In addition, this change enables mouse hover over these controls. - Added tests for focus, hover, and shortcut activation for Checkbox, Radio, and Switch.
-
- 10 Oct, 2019 1 commit
-
-
Greg Spencer authored
This attempts to reland #40186 and #41220, that were reverted in #41945. The main modifications from the original PRs are that I predefine the shortcuts and actions maps instead of defining them inline in the build function, and I use a new mapEquals to do a deep comparison so that we don't rebuild modified things if the contents of the map haven't changed. I also eliminated an operator== and hashCode that were defined on the Actions widget, since widgets shouldn't have those. (it's too bad though: I get an 85% speedup if we leave this in! Too bad it prevents rebuilding of the children...) Fixes #40101
-
- 04 Oct, 2019 1 commit
-
-
Greg Spencer authored
-
- 02 Oct, 2019 1 commit
-
-
Greg Spencer authored
Adds an ActivateAction to controls that use InkWell. Make InkWell host the Focus for those controls, and add the top level binding to the ENTER key. This will make it possible to trigger a button using the enter key, and to get an ink response when the button is triggered. This is a breaking change because it moves the Focus widget into the InkWell. If you have a component that uses the InkWell directly and you used to wrap that InkWell in a Focus widget to give it its notion of focus, it will now not look for that Focus ancestor for its focus state anymore. In order to control focus on the InkWell, you need to give it a FocusNode directly, via the new focusNode parameter. This should not affect users of widgets like OutlineButton or FloatingActionButton and the like, since those have been modified in this PR.
-
- 28 Sep, 2019 1 commit
-
-
Greg Spencer authored
This re-lands #41417 with a slight change that will hopefully not tickle the analyzer as it did before. The last time I tried to land this, the analyzer succeeded for the analyze step in Cirrus, and locally, but failed in an integration test.
-