Commits · 23d3b1e4a56391c91ee5fca2622efff5349651a0 · abdullh.alsoleman / Front-End

17 Oct, 2023 31 commits

Roll Flutter Engine from f9f937e51080 to e57b5bac4244 (3 revisions) (#136768) · 23d3b1e4

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/f9f937e51080...e57b5bac4244

2023-10-17 jason-simmons@users.noreply.github.com Workaround for a clang-tidy warning in CPUSpeedTracker (flutter/engine#47024)
2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from a9caf3c19792 to b524e0af7d3a (1 revision) (flutter/engine#47017)
2023-10-17 jason-simmons@users.noreply.github.com Manual roll of Clang from 576b184d6e3b to 00396e6a1a0b (flutter/engine#46980)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

23d3b1e4

clean up `--dart-define-from-file` option tests (#135980) · cdc40b52

Andrew Kolos authored Oct 17, 2023

Fixes https://github.com/flutter/flutter/issues/134279.

Changes:
* Moves all tests of `--dart-define-from-file` behavior from `build_bundle_test.dart` and `assemble_test.dart` to `flutter_command_test.dart`.
* Deletes a duplicate test of malformed JSON detection behavior.
* Renames the `useDartDefineFromFileOption` method of `FlutterCommand` to `_usesDartDefineFromFileOption`. This 1) makes the name more consistent with the other `uses*Option` methods and 2) hides the method since it is not used outside of the file.
* Renames several tests to better articulate what is under test and what the expected result is.
* Adds a test for the case where a `.env` file with a malformed line is provided to `--dart-define-from-file`.

cdc40b52

GoldenFileComparators should dispose created Image objects. (#136716) · 22f593e5
Kostia Sokolovskyi authored Oct 17, 2023

22f593e5

make integration_test_driver_extended.dart support writeResponseData--(done) (#128382) · 3d1d4532

LinChen authored Oct 17, 2023

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*
- https://github.com/flutter/flutter/issues/128381

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

3d1d4532

Bump actions/checkout from 3.6.0 to 4.1.1 (#136762) · 380520d4

dependabot[bot] authored Oct 17, 2023

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.1.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.1.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Update CODEOWNERS to Launch team by <a href="https://github.com/joshmgross"><code>@âjoshmgross</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1510">actions/checkout#1510</a></li>
<li>Correct link to GitHub Docs by <a href="https://github.com/peterbe"><code>@âpeterbe</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1511">actions/checkout#1511</a></li>
<li>Link to release page from what's new section by <a href="https://github.com/cory-miller"><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1514">actions/checkout#1514</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/joshmgross"><code>@âjoshmgross</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1510">actions/checkout#1510</a></li>
<li><a href="https://github.com/peterbe"><code>@âpeterbe</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1511">actions/checkout#1511</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4...v4.1.1">https://github.com/actions/checkout/compare/v4...v4.1.1</a></p>
<h2>v4.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update README.md for V4 by <a href="https://github.com/sivapalan"><code>@âsivapalan</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1452">actions/checkout#1452</a></li>
<li>Add support for partial checkout filters by <a href="https://github.com/finleygn"><code>@âfinleygn</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1396">actions/checkout#1396</a></li>
<li>Prepare 4.1.0 release by <a href="https://github.com/cory-miller"><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1496">actions/checkout#1496</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/sivapalan"><code>@âsivapalan</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1452">actions/checkout#1452</a></li>
<li><a href="https://github.com/finleygn"><code>@âfinleygn</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1396">actions/checkout#1396</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.0.0...v4.1.0">https://github.com/actions/checkout/compare/v4.0.0...v4.1.0</a></p>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update default runtime to node20 by <a href="https://github.com/takost"><code>@âtakost</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1436">actions/checkout#1436</a></li>
<li>Support fetching without the --progress option by <a href="https://github.com/simonbaird"><code>@âsimonbaird</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1067">actions/checkout#1067</a></li>
<li>Release 4.0.0 by <a href="https://github.com/takost"><code>@âtakost</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1447">actions/checkout#1447</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/takost"><code>@âtakost</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1436">actions/checkout#1436</a></li>
<li><a href="https://github.com/simonbaird"><code>@âsimonbaird</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1067">actions/checkout#1067</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v4.0.0">https://github.com/actions/checkout/compare/v3...v4.0.0</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396">Add support for partial checkout filters</a></li>
</ul>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436">Update to node20</a></li>
</ul>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/579">Add option to fetch tags even if fetch-depth &gt; 0</a></li>
</ul>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade <code>@âactions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1045">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942">Add GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967">Fix status badge</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1002">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1029">Update <code>@âactions/io</code> to 1.1.2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1039">Upgrading version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/939">Use <code>@âactions/core</code> <code>saveState</code> and <code>getState</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/922">Add <code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/checkout/commit/b4ffde65f46336ab88eb53be808477a3936bae11"><code>b4ffde6</code></a> Link to release page from what's new section (<a href="https://redirect.github.com/actions/checkout/issues/1514">#1514</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/8530928916aaef40f59e6f221989ccb31f5759e7"><code>8530928</code></a> Correct link to GitHub Docs (<a href="https://redirect.github.com/actions/checkout/issues/1511">#1511</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/7cdaf2fbc075e6f3b9ca94cfd6cec5adc8a75622"><code>7cdaf2f</code></a> Update CODEOWNERS to Launch team (<a href="https://redirect.github.com/actions/checkout/issues/1510">#1510</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/8ade135a41bc03ea155e62e844d188df1ea18608"><code>8ade135</code></a> Prepare 4.1.0 release (<a href="https://redirect.github.com/actions/checkout/issues/1496">#1496</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/c533a0a4cfc4962971818edcfac47a2899e69799"><code>c533a0a</code></a> Add support for partial checkout filters (<a href="https://redirect.github.com/actions/checkout/issues/1396">#1396</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/72f2cec99f417b1a1c5e2e88945068983b7965f9"><code>72f2cec</code></a> Update README.md for V4 (<a href="https://redirect.github.com/actions/checkout/issues/1452">#1452</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/3df4ab11eba7bda6032a0b82a6bb43b11571feac"><code>3df4ab1</code></a> Release 4.0.0 (<a href="https://redirect.github.com/actions/checkout/issues/1447">#1447</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/8b5e8b768746b50394015010d25e690bfab9dfbc"><code>8b5e8b7</code></a> Support fetching without the --progress option (<a href="https://redirect.github.com/actions/checkout/issues/1067">#1067</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/97a652b80035363df47baee5031ec8670b8878ac"><code>97a652b</code></a> Update default runtime to node20 (<a href="https://redirect.github.com/actions/checkout/issues/1436">#1436</a>)</li>
<li>See full diff in <a href="https://github.com/actions/checkout/compare/f43a0e5ff2bd294095638e18286ca9a3d1956744...b4ffde65f46336ab88eb53be808477a3936bae11">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=3.6.0&new-version=4.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

380520d4

Roll Flutter Engine from 289f29b1ad00 to f9f937e51080 (1 revision) (#136755) · cdb2304c

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/289f29b1ad00...f9f937e51080

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from 1a332d2b35d9 to a9caf3c19792 (1 revision) (flutter/engine#47013)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cdb2304c

Roll Flutter Engine from 659e68a097b5 to 289f29b1ad00 (1 revision) (#136752) · 9fd8217a

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/659e68a097b5...289f29b1ad00

2023-10-17 31859944+LongCatIsLooong@users.noreply.github.com Don't respond to the `insertionPointColor` selector on iOS 17+ (flutter/engine#46373)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9fd8217a

Support --web-header option for flutter run (#136297) · 48eee14f

Aran Donohue authored Oct 17, 2023

Adds support for a new --web-header option to flutter run.

Creates a workaround for https://github.com/flutter/flutter/issues/127902

This PR allows adding additional headers for the flutter run web server. This is useful to add headers like Cross-Origin-Embedder-Policy and Cross-Origin-Opener-Policy without the use of a proxy server. These headers are required enable advanced web features. This approach provides flexibility to the developer to make use of the feature as they see fit and is backward-compatible. One tradeoff is that it increases the surface area to support for future changes to the flutter web server.

https://github.com/flutter/flutter/issues/127902 is not fully addressed by this change. The solution for that task will be more opinionated. This PR creates a general-purpose workaround for anyone who needs a solution sooner while the bigger solution is developed.

48eee14f

Add Android 14 physical devices to firebase tests (#136736) · b136ddc6

Gray Mackall authored Oct 17, 2023

I've been keeping an eye on the device list, and android 14 devices recently became available. For reviewing purposes (and anyone who comes across this in the future), you can check the available devices here at the third option without needing a firebase login:
https://firebase.google.com/docs/test-lab/android/available-testing-devices

The "shiba" device is high capacity. There are no api 34 virtual devices yet.

b136ddc6

Roll Flutter Engine from 62a90a91cee3 to 659e68a097b5 (3 revisions) (#136746) · 8536be52

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/62a90a91cee3...659e68a097b5

2023-10-17 zanderso@users.noreply.github.com Shift some engine DEPS from github to mirrors (flutter/engine#46633)
2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from 8b3f2ef48a90 to 1a332d2b35d9 (1 revision) (flutter/engine#47009)
2023-10-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 2418bda7a457 to 99ce477503f8 (1 revision) (flutter/engine#47008)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8536be52

Reverts "Skip injecting Bonjour settings when port publication is disabled" (#136750) · 54c0a350

auto-submit[bot] authored Oct 17, 2023

Reverts flutter/flutter#136562
Initiated by: vashworth
This change reverts the following previous change:
Original Description:
Some of our tests in CI are triggering the `NSLocalNetworkUsageDescription` dialog when they're not supposed to (https://github.com/flutter/flutter/issues/129836) since it's disabled via flags (`--no-publish-port` for flutter/flutter and `--disable-vm-service-publication` for flutter/engine).

Normally, we inject `NSLocalNetworkUsageDescription` (and other bonjour settings) to the Info.plist during the project build for debug and profile mode since by default they will publish the VM Service port over mDNS.

To help diagnose the issue, though, this PR changes it so that we don't inject `NSLocalNetworkUsageDescription` (and other bonjour settings) when port publication is disabled since it shouldn't be needed. Hopefully, this will give us better error messages or cause the app to crash and end the test early (rather than timeout after 30 minutes).

54c0a350

Revert "[SingleChildScrollView] Correct the offset pixels if it is out of... · 0cc2eff2
Kate Lovett authored Oct 17, 2023
```
Revert "[SingleChildScrollView] Correct the offset pixels if it is out of range during layout" (#136744)
```
0cc2eff2

Skip injecting Bonjour settings when port publication is disabled (#136562) · 0383d8ba

Victoria Ashworth authored Oct 17, 2023

Some of our tests in CI are triggering the `NSLocalNetworkUsageDescription` dialog when they're not supposed to (https://github.com/flutter/flutter/issues/129836) since it's disabled via flags (`--no-publish-port` for flutter/flutter and `--disable-vm-service-publication` for flutter/engine).

0383d8ba

Roll Flutter Engine from 3ecbe924a598 to 62a90a91cee3 (2 revisions) (#136739) · 24a762b7

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/3ecbe924a598...62a90a91cee3

2023-10-17 30870216+gaaclarke@users.noreply.github.com [Impeller] added trace statements for colorsources (flutter/engine#47007)
2023-10-17 chinmaygarde@google.com Move the secondary build tree into the engine. (flutter/engine#46989)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

24a762b7

Roll Flutter Engine from 0a4d8b99a95b to 3ecbe924a598 (3 revisions) (#136732) · 5227d006

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/0a4d8b99a95b...3ecbe924a598

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from d937d10a0ba9 to 8b3f2ef48a90 (3 revisions) (flutter/engine#47005)
2023-10-17 jacksongardner@google.com Include symbol maps in CanvasKit and Skwasm builds. (flutter/engine#46973)
2023-10-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Y9mDBoH4BSC6pWFXV... to VtEx0R7lepGAvwAMU... (flutter/engine#47004)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Y9mDBoH4BSC6 to VtEx0R7lepGA

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5227d006

Reenable NexusLowRes API 29 (#136686) · d42b4bb5

Ricardo Amador authored Oct 17, 2023

Reenable the NexusLowRes API version 29 tests. 

*List which issues are fixed by this PR. You must list at least one issue.*
fixes https://buganizer.corp.google.com/issues/302753598
fixes flutter/flutter#135784

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

d42b4bb5

Reenable the nexus 6p tests (#136689) · c76761ea

Ricardo Amador authored Oct 17, 2023

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

c76761ea

Removed TBD translations for optional remainingTextFieldCharacterCounZero message (#136684) · 6eea6e27
Hans Muller authored Oct 17, 2023
```
Fixes https://github.com/flutter/flutter/issues/136090
```
6eea6e27

Roll Flutter Engine from 86f685c87e06 to 0a4d8b99a95b (2 revisions) (#136727) · 7cfd3d47

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/86f685c87e06...0a4d8b99a95b

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from f7e15ba449f7 to d937d10a0ba9 (7 revisions) (flutter/engine#47003)
2023-10-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gJiEzqLWUvPVgoq8b... to E0Ui7KmD3u5JSKEk5... (flutter/engine#47000)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from gJiEzqLWUvPV to E0Ui7KmD3u5J

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7cfd3d47

Roll Flutter Engine from 793fb7d85690 to 86f685c87e06 (1 revision) (#136725) · b0e56a39

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/793fb7d85690...86f685c87e06

2023-10-17 15619084+vashworth@users.noreply.github.com Only run web mac tests on macOS 12 (flutter/engine#46965)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b0e56a39

Roll Packages from 872d6d26c48b to d4390624a624 (4 revisions) (#136724) · 5739397e

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/packages/compare/872d6d26c48b...d4390624a624

2023-10-17 ditman@gmail.com [gis_web] Adds FedCM toggle. (flutter/packages#5123)
2023-10-17 tarrinneal@gmail.com [quick_actions] Convert android to pigeon (flutter/packages#5099)
2023-10-16 70025277+Nitin-Poojary@users.noreply.github.com [flutter_image] added example app (flutter/packages#4353)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter from b00216b3 to afc39160 (12 revisions) (flutter/packages#5156)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5739397e

Roll Flutter Engine from 9c744ad5433a to 793fb7d85690 (1 revision) (#136721) · 13dc8a3c

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/9c744ad5433a...793fb7d85690

2023-10-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 82c073d657eb to 2418bda7a457 (1 revision) (flutter/engine#46997)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

13dc8a3c

Roll Flutter Engine from 7d47532bb56f to 9c744ad5433a (1 revision) (#136719) · f2365f9d

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/7d47532bb56f...9c744ad5433a

2023-10-17 kjlubick@users.noreply.github.com Replace use of SkFont::refTypefaceOrDefault() (flutter/engine#46969)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f2365f9d

Roll Flutter Engine from ace31a8eaea4 to 7d47532bb56f (1 revision) (#136717) · 387f75e3

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/ace31a8eaea4...7d47532bb56f

2023-10-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 7d0a805e4ee1 to 82c073d657eb (1 revision) (flutter/engine#46995)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

387f75e3

Roll Flutter Engine from 077494a09872 to ace31a8eaea4 (1 revision) (#136713) · ecdaee82

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/077494a09872...ace31a8eaea4

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from c30529427b7d to f7e15ba449f7 (1 revision) (flutter/engine#46994)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ecdaee82

Roll Flutter Engine from 8be0b5398d41 to 077494a09872 (1 revision) (#136712) · 619a5b39

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/8be0b5398d41...077494a09872

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from 31310feb67dc to c30529427b7d (2 revisions) (flutter/engine#46992)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

619a5b39

Roll Flutter Engine from 90bbe8ee4ac3 to 8be0b5398d41 (1 revision) (#136705) · c960cd5d

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/90bbe8ee4ac3...8be0b5398d41

2023-10-17 skia-flutter-autoroll@skia.org Roll Dart SDK from f3e1cd38e8b0 to 7d0a805e4ee1 (2 revisions) (flutter/engine#46991)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c960cd5d

Roll Flutter Engine from 6855e78a1aac to 90bbe8ee4ac3 (1 revision) (#136700) · d8c25396

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/6855e78a1aac...90bbe8ee4ac3

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from 205b728a8623 to 31310feb67dc (2 revisions) (flutter/engine#46990)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d8c25396

Roll Flutter Engine from 2159fdb8461d to 6855e78a1aac (1 revision) (#136697) · f69e45c4

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/2159fdb8461d...6855e78a1aac

2023-10-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from bMDZdOFfPiVkjIdiv... to gJiEzqLWUvPVgoq8b... (flutter/engine#46985)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from bMDZdOFfPiVk to gJiEzqLWUvPV

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f69e45c4

Roll Flutter Engine from 2d55e29dfa79 to 2159fdb8461d (8 revisions) (#136695) · 6074ff5e

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/2d55e29dfa79...2159fdb8461d

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from 751358929d1f to 205b728a8623 (1 revision) (flutter/engine#46982)
2023-10-17 jason-simmons@users.noreply.github.com Revert "Fix `Platform.script` for flutter_tester" (flutter/engine#46981)
2023-10-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 12f6559bd6ed to f3e1cd38e8b0 (1 revision) (flutter/engine#46977)
2023-10-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 6E-cSq679DjzBMcqY... to Y9mDBoH4BSC6pWFXV... (flutter/engine#46974)
2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 8919fecf15c1 to 751358929d1f (4 revisions) (flutter/engine#46972)
2023-10-16 jonahwilliams@google.com [Impeller] GPUTracer for Metal. (flutter/engine#46846)
2023-10-16 dnfield@google.com Fix `Platform.script` for flutter_tester (flutter/engine#46911)
2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 85c8dca08cbe to 8919fecf15c1 (1 revision) (flutter/engine#46966)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 6E-cSq679Djz to Y9mDBoH4BSC6

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6074ff5e

Add docs to SchedulerBinding (#136433) · 4f6c2ccc
Todd Volkert authored Oct 17, 2023
```
Add documentation that I went looking for and didn't find :-)
```
4f6c2ccc

16 Oct, 2023 9 commits

Roll Flutter Engine from 83224dcd662e to 2d55e29dfa79 (3 revisions) (#136675) · 0acd1f21

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/83224dcd662e...2d55e29dfa79

2023-10-16 matej.knopp@gmail.com [macOS] FlutterMutatorView should clip to bounds (flutter/engine#46463)
2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 0e5207fb4971 to 85c8dca08cbe (1 revision) (flutter/engine#46964)
2023-10-16 john@johnmccutchan.com Allow Image backed platform view rendering target on Android >= 29 again (flutter/engine#46958)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0acd1f21

Roll Flutter Engine from c24f30343cf6 to 83224dcd662e (1 revision) (#136671) · 1dd49a8f

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/c24f30343cf6...83224dcd662e

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 68de6e352585 to 0e5207fb4971 (1 revision) (flutter/engine#46960)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1dd49a8f

Do not hold on to stale canvas reference in _RenderSegmentedButton (#136658) · 2df7244f

Dan Field authored Oct 16, 2023

Fixes https://github.com/flutter/flutter/issues/135747

Before this change, the render object was storing the `context.canvas` and using it after painting children. If those children were composited (e.g. because of an `Opacity` layer), the canvas it stored was disposed and not valid for use anymore.

2df7244f

Avoid use of Platform.script in isolates_test.dart (#136669) · c03dac9a

Dan Field authored Oct 16, 2023

Avoid using string replacement on a bogus string to get the relative directory of this test.

https://github.com/flutter/engine/pull/46911 will fix the behavior of Platform.script so it actually has the file being executed, but that will not be the file the test author wrote, it will be `listener.dart.dill` generated by tool code and running in a temp directory for this particular test.

We may want to come up with a more robust way of providing the test for framework test users, but we should do so in a way that will not limit the ability to run multiple tests in a single process if that offers performance benefits.

c03dac9a

Roll Flutter Engine from ca8cf6bc256d to c24f30343cf6 (3 revisions) (#136665) · b1d9642b

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/ca8cf6bc256d...c24f30343cf6

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 675f088b9ac4 to 68de6e352585 (1 revision) (flutter/engine#46956)
2023-10-16 30870216+gaaclarke@users.noreply.github.com [Impeller] implements a retry mechanism for dart:ui/Image.toByteData. (flutter/engine#46840)
2023-10-16 jason-simmons@users.noreply.github.com [Impeller] Adjust clip coverage operations to handle per-pass clip stacks (flutter/engine#46912)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b1d9642b

update analytics in generate api docs site to use new UA4 (#136497) · 4dcd1598
Christopher Fujino authored Oct 16, 2023
```
Change the analytics instance that the generated api.flutter.dev and master-api.flutter.dev use.
```
4dcd1598

Roll Flutter Engine from 64734a266683 to ca8cf6bc256d (2 revisions) (#136662) · bb7f0b23

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/64734a266683...ca8cf6bc256d

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 2db9c220ba00 to 675f088b9ac4 (2 revisions) (flutter/engine#46954)
2023-10-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 64a485bb79bd to 12f6559bd6ed (1 revision) (flutter/engine#46953)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bb7f0b23

Roll Flutter Engine from 850de4ce0e75 to 64734a266683 (2 revisions) (#136659) · 06c1b1ec

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/850de4ce0e75...64734a266683

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 44a0f98aa71a to 2db9c220ba00 (1 revision) (flutter/engine#46949)
2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from c03c9a02f6ef to 44a0f98aa71a (1 revision) (flutter/engine#46947)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

06c1b1ec

Fix prefer_mixin TODOs (#136480) · d564d39f

Michael Goderbauer authored Oct 16, 2023

Fixes https://github.com/flutter/flutter/issues/123172
Fixes https://github.com/dart-lang/sdk/issues/51813

In combination with https://github.com/flutter/flutter/pull/136418.

d564d39f