- 17 Jul, 2023 1 commit
-
-
Michael Goderbauer authored
This change enables Flutter to generate multiple Scenes to be rendered into separate FlutterViews from a single widget tree. Each Scene is described by a separate render tree, which are all associated with the single widget tree. This PR implements the framework-side mechanisms to describe the content to be rendered into multiple views. Separate engine-side changes are necessary to provide these views to the framework and to draw the framework-generated Scene into them. ## Summary of changes The details of this change are described in [flutter.dev/go/multiple-views](https://flutter.dev/go/multiple-views). Below is a high-level summary organized by layers. ### Rendering layer changes * The `RendererBinding` no longer owns a single `renderView`. In fact, it doesn't OWN any `RenderView`s at all anymore. Instead, it offers an API (`addRenderView`/`removeRenderView`) to add and remove `RenderView`s that then will be MANAGED by the binding. The `RenderView` itself is now owned by a higher-level abstraction (e.g. the `RawView` Element of the widgets layer, see below), who is also in charge of adding it to the binding. When added, the binding will interact with the `RenderView` to produce a frame (e.g. by calling `compositeFrame` on it) and to perform hit tests for incoming pointer events. Multiple `RenderView`s can be added to the binding (typically one per `FlutterView`) to produce multiple Scenes. * Instead of owning a single `pipelineOwner`, the `RendererBinding` now owns the root of the `PipelineOwner` tree (exposed as `rootPipelineOwner` on the binding). Each `PipelineOwner` in that tree (except for the root) typically manages its own render tree typically rooted in one of the `RenderView`s mentioned in the previous bullet. During frame production, the binding will instruct each `PipelineOwner` of that tree to flush layout, paint, semantics etc. A higher-level abstraction (e.g. the widgets layer, see below) is in charge of adding `PipelineOwner`s to this tree. * Backwards compatibility: The old `renderView` and `pipelineOwner` properties of the `RendererBinding` are retained, but marked as deprecated. Care has been taken to keep their original behavior for the deprecation period, i.e. if you just call `runApp`, the render tree bootstrapped by this call is rooted in the deprecated `RendererBinding.renderView` and managed by the deprecated `RendererBinding.pipelineOwner`. ### Widgets layer changes * The `WidgetsBinding` no longer attaches the widget tree to an existing render tree. Instead, it bootstraps a stand-alone widget tree that is not backed by a render tree. For this, `RenderObjectToWidgetAdapter` has been replaced by `RootWidget`. * Multiple render trees can be bootstrapped and attached to the widget tree with the help of the `View` widget, which internally is backed by a `RawView` widget. Configured with a `FlutterView` to render into, the `RawView` creates a new `PipelineOwner` and a new `RenderView` for the new render tree. It adds the new `RenderView` to the `RendererBinding` and its `PipelineOwner` to the pipeline owner tree. * The `View` widget can only appear in certain well-defined locations in the widget tree since it bootstraps a new render tree and does not insert a `RenderObject` into an ancestor. However, almost all Elements expect that their children insert `RenderObject`s, otherwise they will not function properly. To produce a good error message when the `View` widget is used in an illegal location, the `debugMustInsertRenderObjectIntoSlot` method has been added to Element, where a child can ask whether a given slot must insert a RenderObject into its ancestor or not. In practice, the `View` widget can be used as a child of the `RootWidget`, inside the `view` slot of the `ViewAnchor` (see below) and inside a `ViewCollection` (see below). In those locations, the `View` widget may be wrapped in other non-RenderObjectWidgets (e.g. InheritedWidgets). * The new `ViewAnchor` can be used to create a side-view inside a parent `View`. The `child` of the `ViewAnchor` widget renders into the parent `View` as usual, but the `view` slot can take on another `View` widget, which has access to all inherited widgets above the `ViewAnchor`. Metaphorically speaking, the view is anchored to the location of the `ViewAnchor` in the widget tree. * The new `ViewCollection` widget allows for multiple sibling views as it takes a list of `View`s as children. It can be used in all the places that accept a `View` widget. ## Google3 As of July 5, 2023 this change passed a TAP global presubmit (TGP) in google3: tap/OCL:544707016:BASE:545809771:1688597935864:e43dd651 ## Note to reviewers This change is big (sorry). I suggest focusing the initial review on the changes inside of `packages/flutter` first. The majority of the changes describe above are implemented in (listed in suggested review order): * `rendering/binding.dart` * `widgets/binding.dart` * `widgets/view.dart` * `widgets/framework.dart` All other changes included in the PR are basically the fallout of what's implemented in those files. Also note that a lot of the lines added in this PR are documentation and tests. I am also very happy to walk reviewers through the code in person or via video call, if that is helpful. I appreciate any feedback. ## Feedback to address before submitting ("TODO")
-
- 15 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove last few references to window singleton
-
- 19 Sep, 2022 1 commit
-
-
fzyzcjy authored
-
- 28 Jul, 2022 1 commit
-
-
Dan Field authored
-
- 30 Mar, 2022 1 commit
-
-
Emmanuel Garcia authored
-
- 29 Mar, 2022 2 commits
-
-
Zachary Anderson authored
This reverts commit 61c30eed.
-
Emmanuel Garcia authored
-
- 24 Mar, 2022 1 commit
-
-
Emmanuel Garcia authored
This reverts commit d92fedcc.
-
- 17 Mar, 2022 1 commit
-
-
Emmanuel Garcia authored
-
- 16 Mar, 2022 2 commits
-
-
Zachary Anderson authored
This reverts commit 509ddfda.
-
Emmanuel Garcia authored
-
- 03 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 22 Feb, 2022 1 commit
-
-
Emmanuel Garcia authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 05 Aug, 2021 1 commit
-
-
Darren Austin authored
-
- 01 Jul, 2021 1 commit
-
-
Ahmed Ashour authored
-
- 11 Jun, 2021 1 commit
-
-
xubaolin authored
-
- 23 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 11 Feb, 2021 1 commit
-
-
Sam Rawlins authored
-
- 27 Jan, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Oct, 2020 1 commit
-
-
Kate Lovett authored
-
- 05 Oct, 2020 1 commit
-
-
Tong Mu authored
-
- 20 Aug, 2020 1 commit
-
-
Tong Mu authored
* Redesigns the interface between MouseTracker and RendererBinding&RenderView. * Simplifies the structure of RenderMouseRegion. * Extracts the common utility code between mouse_tracker_test and mouse_tracker_cursor_test.
-
- 29 Jul, 2020 1 commit
-
-
Tong Mu authored
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 16 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 05 Dec, 2019 1 commit
-
-
Chris Bracken authored
This adds support to PlatformViewLayer for handling hover events. Prior to this, PlatformViewLayers only supported events forwarded by the gesture recognizers associated with the PlatformViewRenderBox. Hover events don't participate in gesture recognition and as such are dropped in GestureBinding. That said, hover event processing in platform views is expected for desktop and other platforms with hover event support. This adds support for passing an optional MouseTrackerAnnotation to PlatformViewLayer. PlatformViewRenderBox populates this with a mouse tracker annotation that forwards hover events to PlatformViewController.dispatchPointerEvent() for handling by users.
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 15 Oct, 2019 1 commit
-
-
Yegor authored
-
- 27 Sep, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 06 Aug, 2019 1 commit
-
-
Chris Yang authored
-
- 02 Aug, 2019 1 commit
-
-
Chris Yang authored
* painting and semantics * more comments * fixing ci * review fixes * add assert for id * rename custom layer factory to layer builder * review updates * partial review fixes * some doc updates * more doc updates * only expose getter for id in PlatformViewController * doc updates/removing all the references * remove extra * more doc updates * some doc updates * more doc fixes * review fixes
-