Unverified Commit 225a43d9 authored by Darren Austin's avatar Darren Austin Committed by GitHub

Updated skipped tests for rendering directory. (#87700)

parent ec86605a
...@@ -24,7 +24,7 @@ void main() { ...@@ -24,7 +24,7 @@ void main() {
binding.handleDrawFrame(); binding.handleDrawFrame();
await expectLater(completer.future, completes); await expectLater(completer.future, completes);
}, skip: !kIsWeb); }, skip: !kIsWeb); // [intended] the test is only makes sense on the web.
} }
class TestRenderBinding extends BindingBase class TestRenderBinding extends BindingBase
......
...@@ -189,7 +189,7 @@ Future<void> main() async { ...@@ -189,7 +189,7 @@ Future<void> main() async {
image.dispose(); image.dispose();
expect(image.debugGetOpenHandleStackTraces()!.length, 0); expect(image.debugGetOpenHandleStackTraces()!.length, 0);
}, skip: kIsWeb); // Web doesn't track open image handles. }, skip: kIsWeb); // https://github.com/flutter/flutter/issues/87442
test('RenderImage does not dispose its image if setting the same image twice', () async { test('RenderImage does not dispose its image if setting the same image twice', () async {
final ui.Image image = await createTestImage(width: 10, height: 10, cache: false); final ui.Image image = await createTestImage(width: 10, height: 10, cache: false);
...@@ -206,7 +206,7 @@ Future<void> main() async { ...@@ -206,7 +206,7 @@ Future<void> main() async {
image.dispose(); image.dispose();
expect(image.debugGetOpenHandleStackTraces()!.length, 0); expect(image.debugGetOpenHandleStackTraces()!.length, 0);
}, skip: kIsWeb); // Web doesn't track open image handles. }, skip: kIsWeb); // https://github.com/flutter/flutter/issues/87442
test('Render image disposes its image when it is disposed', () async { test('Render image disposes its image when it is disposed', () async {
final ui.Image image = await createTestImage(width: 10, height: 10, cache: false); final ui.Image image = await createTestImage(width: 10, height: 10, cache: false);
...@@ -221,5 +221,5 @@ Future<void> main() async { ...@@ -221,5 +221,5 @@ Future<void> main() async {
image.dispose(); image.dispose();
expect(image.debugGetOpenHandleStackTraces()!.length, 0); expect(image.debugGetOpenHandleStackTraces()!.length, 0);
}, skip: kIsWeb); // Web doesn't track open image handles. }, skip: kIsWeb); // https://github.com/flutter/flutter/issues/87442
} }
...@@ -434,7 +434,7 @@ void main() { ...@@ -434,7 +434,7 @@ void main() {
// Ensure we can render the same scene again after rendering an interior // Ensure we can render the same scene again after rendering an interior
// layer. // layer.
parent.buildScene(SceneBuilder()); parent.buildScene(SceneBuilder());
}, skip: isBrowser); // TODO(yjbanov): `toImage` doesn't work on the Web: https://github.com/flutter/flutter/issues/42767 }, skip: isBrowser); // TODO(yjbanov): `toImage` doesn't work on the Web: https://github.com/flutter/flutter/issues/49857
test('PictureLayer does not let you call dispose unless refcount is 0', () { test('PictureLayer does not let you call dispose unless refcount is 0', () {
PictureLayer layer = PictureLayer(Rect.zero); PictureLayer layer = PictureLayer(Rect.zero);
......
...@@ -118,7 +118,7 @@ void main() { ...@@ -118,7 +118,7 @@ void main() {
final TextPosition positionBelow = paragraph.getPositionForOffset(const Offset(5.0, 20.0)); final TextPosition positionBelow = paragraph.getPositionForOffset(const Offset(5.0, 20.0));
expect(positionBelow.offset, greaterThan(position40.offset)); expect(positionBelow.offset, greaterThan(position40.offset));
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/61015 });
test('getBoxesForSelection control test', () { test('getBoxesForSelection control test', () {
final RenderParagraph paragraph = RenderParagraph( final RenderParagraph paragraph = RenderParagraph(
...@@ -184,7 +184,7 @@ void main() { ...@@ -184,7 +184,7 @@ void main() {
expect(boxes[2], const TextBox.fromLTRBD(0.0, 10.0, 130.0, 20.0, TextDirection.ltr)); expect(boxes[2], const TextBox.fromLTRBD(0.0, 10.0, 130.0, 20.0, TextDirection.ltr));
// 'fifth': // 'fifth':
expect(boxes[3], const TextBox.fromLTRBD(0.0, 20.0, 50.0, 30.0, TextDirection.ltr)); expect(boxes[3], const TextBox.fromLTRBD(0.0, 20.0, 50.0, 30.0, TextDirection.ltr));
}, skip: !isLinux); // mac typography values can differ }, skip: !isLinux); // mac typography values can differ https://github.com/flutter/flutter/issues/12357
test('getBoxesForSelection test with boxHeightStyle and boxWidthStyle set to max', () { test('getBoxesForSelection test with boxHeightStyle and boxWidthStyle set to max', () {
final RenderParagraph paragraph = RenderParagraph( final RenderParagraph paragraph = RenderParagraph(
...@@ -243,7 +243,7 @@ void main() { ...@@ -243,7 +243,7 @@ void main() {
final TextRange range85 = paragraph.getWordBoundary(const TextPosition(offset: 75)); final TextRange range85 = paragraph.getWordBoundary(const TextPosition(offset: 75));
expect(range85.textInside(_kText), equals("Queen's")); expect(range85.textInside(_kText), equals("Queen's"));
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/61017 });
test('overflow test', () { test('overflow test', () {
final RenderParagraph paragraph = RenderParagraph( final RenderParagraph paragraph = RenderParagraph(
...@@ -439,7 +439,7 @@ void main() { ...@@ -439,7 +439,7 @@ void main() {
expect(boxes[2].toRect().height, moreOrLessEquals(26.0, epsilon: 0.0001)); expect(boxes[2].toRect().height, moreOrLessEquals(26.0, epsilon: 0.0001));
expect(boxes[3].toRect().width, anyOf(14.0, 13.0)); expect(boxes[3].toRect().width, anyOf(14.0, 13.0));
expect(boxes[3].toRect().height, moreOrLessEquals(13.0, epsilon: 0.0001)); expect(boxes[3].toRect().height, moreOrLessEquals(13.0, epsilon: 0.0001));
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/61016 });
test('toStringDeep', () { test('toStringDeep', () {
final RenderParagraph paragraph = RenderParagraph( final RenderParagraph paragraph = RenderParagraph(
...@@ -605,7 +605,7 @@ void main() { ...@@ -605,7 +605,7 @@ void main() {
// intrinsicHeight = singleLineHeight * textScaleFactor * two lines. // intrinsicHeight = singleLineHeight * textScaleFactor * two lines.
expect(maxIntrinsicHeight, singleLineHeight * 2.0 * 2); expect(maxIntrinsicHeight, singleLineHeight * 2.0 * 2);
expect(maxIntrinsicHeight, minIntrinsicHeight); expect(maxIntrinsicHeight, minIntrinsicHeight);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/61020 });
test('can compute IntrinsicWidth for widget span', () { test('can compute IntrinsicWidth for widget span', () {
// Regression test for https://github.com/flutter/flutter/issues/59316 // Regression test for https://github.com/flutter/flutter/issues/59316
...@@ -648,7 +648,7 @@ void main() { ...@@ -648,7 +648,7 @@ void main() {
final double maxIntrinsicWidth = paragraph.computeMaxIntrinsicWidth(fixedHeight); final double maxIntrinsicWidth = paragraph.computeMaxIntrinsicWidth(fixedHeight);
// maxIntrinsicWidth = widthForOneLine * textScaleFactor // maxIntrinsicWidth = widthForOneLine * textScaleFactor
expect(maxIntrinsicWidth, widthForOneLine * 2.0); expect(maxIntrinsicWidth, widthForOneLine * 2.0);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/61020 });
test('inline widgets multiline test', () { test('inline widgets multiline test', () {
const TextSpan text = TextSpan( const TextSpan text = TextSpan(
...@@ -714,7 +714,7 @@ void main() { ...@@ -714,7 +714,7 @@ void main() {
layout(paragraph); layout(paragraph);
paragraph.assembleSemanticsNode(SemanticsNode(), SemanticsConfiguration(), <SemanticsNode>[]); paragraph.assembleSemanticsNode(SemanticsNode(), SemanticsConfiguration(), <SemanticsNode>[]);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/61020 });
test('Asserts on unsupported gesture recognizer', () { test('Asserts on unsupported gesture recognizer', () {
final RenderParagraph paragraph = RenderParagraph( final RenderParagraph paragraph = RenderParagraph(
...@@ -733,7 +733,7 @@ void main() { ...@@ -733,7 +733,7 @@ void main() {
expect(e.message, 'MultiTapGestureRecognizer is not supported.'); expect(e.message, 'MultiTapGestureRecognizer is not supported.');
} }
expect(failed, true); expect(failed, true);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/61020 });
test('assembleSemanticsNode handles text spans that do not yield selection boxes', () { test('assembleSemanticsNode handles text spans that do not yield selection boxes', () {
final RenderParagraph paragraph = RenderParagraphWithEmptySelectionBoxList( final RenderParagraph paragraph = RenderParagraphWithEmptySelectionBoxList(
...@@ -750,7 +750,7 @@ void main() { ...@@ -750,7 +750,7 @@ void main() {
final SemanticsNode node = SemanticsNode(); final SemanticsNode node = SemanticsNode();
paragraph.assembleSemanticsNode(node, SemanticsConfiguration(), <SemanticsNode>[]); paragraph.assembleSemanticsNode(node, SemanticsConfiguration(), <SemanticsNode>[]);
expect(node.childrenCount, 2); expect(node.childrenCount, 2);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/61020 });
test('assembleSemanticsNode handles empty WidgetSpans that do not yield selection boxes', () { test('assembleSemanticsNode handles empty WidgetSpans that do not yield selection boxes', () {
final TextSpan text = TextSpan(text: '', children: <InlineSpan>[ final TextSpan text = TextSpan(text: '', children: <InlineSpan>[
......
...@@ -99,7 +99,7 @@ void main() { ...@@ -99,7 +99,7 @@ void main() {
expect(fakePlatformViewController.dispatchedPointerEvents, isNotEmpty); expect(fakePlatformViewController.dispatchedPointerEvents, isNotEmpty);
}); });
}, skip: isBrowser); // TODO(yjbanov): fails on Web with obscured stack trace: https://github.com/flutter/flutter/issues/42770 });
// Regression test for https://github.com/flutter/flutter/issues/69431 // Regression test for https://github.com/flutter/flutter/issues/69431
test('multi-finger touch test', () { test('multi-finger touch test', () {
......
...@@ -262,7 +262,7 @@ void main() { ...@@ -262,7 +262,7 @@ void main() {
expect(getPixel(20, 20), equals(0x00000080)); expect(getPixel(20, 20), equals(0x00000080));
expect(getPixel(image.width - 1, 0), equals(0x00000000)); expect(getPixel(image.width - 1, 0), equals(0x00000000));
expect(getPixel(image.width - 1, 20), equals(0xffffffff)); expect(getPixel(image.width - 1, 20), equals(0xffffffff));
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/42767 }, skip: isBrowser); // https://github.com/flutter/flutter/issues/49857
test('RenderOpacity does not composite if it is transparent', () { test('RenderOpacity does not composite if it is transparent', () {
final RenderOpacity renderOpacity = RenderOpacity( final RenderOpacity renderOpacity = RenderOpacity(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment