- 02 Feb, 2023 1 commit
-
-
Andrew Kolos authored
* add asset manifest bin loading and asset manifest api * use new api for image resolution * remove upfront smc data casting * fix typecasting issue * remove unused import * fix tests * lints * lints * fix import * revert image resolution changes * Update image_resolution_test.dart * Update decode_and_parse_asset_manifest.dart * make targetDevicePixelRatio optional * Update packages/flutter/lib/src/services/asset_manifest.dart Co-authored-by:
Jonah Williams <jonahwilliams@google.com> * Update packages/flutter/lib/src/services/asset_manifest.dart Co-authored-by:
Jonah Williams <jonahwilliams@google.com> * fix immutable not being imported * return List in AssetManifest methods, fix annotation import * simplify onError callback * make AssetManifest methods abstract instead of throwing UnimplementedError * simplify AssetVariant.key docstring * tweak _AssetManifestBin docstring * make AssetManifest and AssetVariant doc strings more specific * use List.of instead of List.from for type-safety * adjust import * change _AssetManifestBin comment from doc comment to normal comment * revert to callback function for onError in loadStructuredBinaryData * add more to the docstring of AssetManifest.listAssets and AssetVariant.key * add tests for CachingAssetBundle caching behavior * add simple test to ensure loadStructuredBinaryData correctly calls load * Update asset_manifest.dart * update docstring for AssetManifest.getAssetVariants * rename getAssetVariants, have it include main asset * rename isMainAsset field of AssetMetadata to main * (slightly) shorten name of describeAssetAndVariants * rename describeAssetVariants back to getAssetVariants * add tests for TestAssetBundle * nits * fix typo in docstring * remove no longer necessary non-null asserts * update gallery and google_fonts versions --------- Co-authored-by:
Jonah Williams <jonahwilliams@google.com>
-
- 01 Feb, 2023 2 commits
-
-
Ian Hickson authored
-
Kevin Chisholm authored
* update console link * update test to include new console link
-
- 31 Jan, 2023 4 commits
-
-
Hans Muller authored
-
Michael Goderbauer authored
-
Chris Bracken authored
* Reland: [macos] add flavor options to tool commands Adds --flavor option to flutter run and flutter build. Running against preexisting devicelab flavor tests for feature parity between macOS, iOS, and Android. This relands #118421 by alex-wallen which was reverted in #118858 due to the following test failures: The bail-out with "Host and target are the same. Nothing to install." added in `packages/flutter_tools/lib/src/commands/install.dart` triggered failures in the following tests, which unconditionally attempt to install the built app, which is unsupported on desktop since the host and target are the same: * https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout * https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout * https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout Fixes #64088 * Partial revert: eliminate install check on desktop The original flavour support patch included a check that triggered a failure when flutter install is run on desktop OSes. This was intentional, since the host and target devices are the same and installation is unnecessary to launch the app on currently-supported desktop OSes. Note that Windows UWP apps *do* require installation to run, and we used to have an install command for those apps, though UWP is no longer supported. Since that part of the change was orthogonal to flavour support itself, I'm reverting that component of the change and we can deal with it separately if so desired.
-
Michael Goderbauer authored
-
- 30 Jan, 2023 3 commits
-
-
Camille Simon authored
* Add exported tag * Undo testing changes
-
Flutter GitHub Bot authored
-
Flutter GitHub Bot authored
-
- 27 Jan, 2023 2 commits
-
-
Michael Goderbauer authored
-
Danny Tuppeny authored
-
- 26 Jan, 2023 3 commits
-
-
Christopher Fujino authored
This reverts commit 2b8f2d05.
-
Andrew Kolos authored
* add asset manifest bin loading and asset manifest api * use new api for image resolution * remove upfront smc data casting * fix typecasting issue * remove unused import * fix tests * lints * lints * fix import * revert image resolution changes * Update image_resolution_test.dart * Update decode_and_parse_asset_manifest.dart * make targetDevicePixelRatio optional * Update packages/flutter/lib/src/services/asset_manifest.dart Co-authored-by:
Jonah Williams <jonahwilliams@google.com> * Update packages/flutter/lib/src/services/asset_manifest.dart Co-authored-by:
Jonah Williams <jonahwilliams@google.com> * fix immutable not being imported * return List in AssetManifest methods, fix annotation import * simplify onError callback * make AssetManifest methods abstract instead of throwing UnimplementedError * simplify AssetVariant.key docstring * tweak _AssetManifestBin docstring * make AssetManifest and AssetVariant doc strings more specific * use List.of instead of List.from for type-safety * adjust import * change _AssetManifestBin comment from doc comment to normal comment * revert to callback function for onError in loadStructuredBinaryData * add more to the docstring of AssetManifest.listAssets and AssetVariant.key * add tests for CachingAssetBundle caching behavior * add simple test to ensure loadStructuredBinaryData correctly calls load * Update asset_manifest.dart * update docstring for AssetManifest.getAssetVariants * rename getAssetVariants, have it include main asset * rename isMainAsset field of AssetMetadata to main * (slightly) shorten name of describeAssetAndVariants * rename describeAssetVariants back to getAssetVariants * add tests for TestAssetBundle * nits * fix typo in docstring * remove no longer necessary non-null asserts Co-authored-by:
Jonah Williams <jonahwilliams@google.com>
-
Todd Volkert authored
This updates the framework to provide higher level wrappers around ui.instantiateImageCodecWithSize(). Functionally, this doesn't change anything (other than deprecating the older loadBuffer() method in favor of loadImage()), but it sets the stage for a simpler change that will allow us to provide a more flexible way to load sized images. #118543
-
- 25 Jan, 2023 1 commit
-
-
Flutter GitHub Bot authored
-
- 24 Jan, 2023 3 commits
-
-
yaakovschectman authored
* Create template file test * Add to .ci.yaml * Add to TESTOWNERS * Organize test script * Push license to top of file * Equals sign * Utilize path.join * Expand error message Co-authored-by:
Loïc Sharma <737941+loic-sharma@users.noreply.github.com> * Fix missing newline string * Move template file test to analyze.dart * Fix newline * Var name * Fix extension length * Use ignore-list for filenames * Update dev/bots/analyze.dart Co-authored-by:
Loïc Sharma <737941+loic-sharma@users.noreply.github.com> * Indentation Co-authored-by:
Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
-
stuartmorgan authored
* Add Windows unit tests to plugin template Adds an example native unit test to the plugin template for Windows, matching the format we use for our 1P plugin example app unit tests. Once these have been added for all platforms+languages, they will be documented on a new plugin development page to explain their use. Since we don't appear to be running our current plugin e2e tests for Windows, this adds a new configuration to run them. I haven't `led`-tested this, so it may not work, but this will give a starting point for getting them running. Part of https://github.com/flutter/flutter/issues/82458 * Minor fix * Add test owner * Fix typo * Fix test feature flag
-
Christopher Fujino authored
* roll pub deps and remove archive, crypto, typed_data from allow-list * un-comment code
-
- 23 Jan, 2023 1 commit
-
-
yaakovschectman authored
-
- 21 Jan, 2023 3 commits
-
-
Michael Goderbauer authored
-
Michael Goderbauer authored
-
Jenn Magder authored
* Remove macOS impeller benchmarks * TESTOWNERS
-
- 20 Jan, 2023 5 commits
-
-
Michael Goderbauer authored
-
Michael Goderbauer authored
-
Michael Goderbauer authored
* Remove unnecessary null checks in dev/benchmarks * empty
-
Michael Goderbauer authored
* Remove unnecessary null checks in dev/conductor * review
-
Jenn Magder authored
This reverts commit 73096fd9.
-
- 19 Jan, 2023 7 commits
-
-
Alex Wallen authored
* Add new macos target configured for flavors * Rename Free App copy-Info.plist to Free App Info.plist * Remove bogus entitlements * Remove Generated.xcconfig * Audit project.pbxproj * Remove unused configs * share one info.plist * Modify scheme so that paid app works * Codesign automatic * Pipe flavor as scheme into xcodebuild * Ignore incoming flavor string * pipe flavor for flutter run to work * Add devicelab tests * Error if host and target device are same for flutter install desktop * Avoid bang (!) by promoting a local. Co-authored-by:
Jenn Magder <magder@google.com> * Add supportsInstall property * Override in test classes * Add install test on macOS * Refactor application_package and add tests for package directory Co-authored-by:
a-wallen <stephenwallen@google.com> Co-authored-by:
Jenn Magder <magder@google.com>
-
David Landeros authored
* [Flutter_tools] Ensure service worker starts caching assets since the first launch * [flutter_tools] add comment to give some context on self.clients.claim() * [flutter_tools] add comment to give some context on self.clients.claim()
-
Alex Wallen authored
* Add new task runner for impeller enabled complex layout test * Add new target in .ci.yaml * Claim ownership of complex_layout_scroll_perf_impeller_macos__timeline_summary * Task runner for non-impeller enabled scroll test * Add test target for non impeller complex layout scroll * claim ownership of the last target * mark as bringup Co-authored-by:
a-wallen <stephenwallen@google.com>
-
Mitchell Goodwin authored
* Add focus detector to CupertinoSwitch * Add comment * Remove whitespace * Add focusColor constructor to CupertinoSwitch * Remove whitespace * Add color type * Remove gap in border * Adjust color and line thickness
-
Danny Tuppeny authored
Update test expectations from application/javascript -> text/javascript `package:mime` now uses `text/javascript` and not `application/javascript`. See https://github.com/dart-lang/mime/pull/76. See https://datatracker.ietf.org/doc/html/rfc9239. > This document defines equivalent processing requirements for the various script media types. The most widely supported media type in use is `text/javascript`; all others are considered historical and obsolete aliases of `text/javascript`.
-
Alex Wallen authored
* Add gems as a dep - fails without * Add missing entitlements to run app on macos Co-authored-by:
a-wallen <stephenwallen@google.com>
-
Jenn Magder authored
-
- 18 Jan, 2023 3 commits
-
-
dependabot[bot] authored
Bumps [activesupport](https://github.com/rails/rails) from 6.1.5 to 6.1.7.1. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.0.4.1/activesupport/CHANGELOG.md) - [Commits](https://github.com/rails/rails/compare/v6.1.5...v6.1.7.1) --- updated-dependencies: - dependency-name: activesupport dependency-type: indirect ... Signed-off-by:
dependabot[bot] <support@github.com> Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Alex Wallen authored
* Add new task runner for animated_complex_opacity_perf_impeller e2e_summary on macos * Register new target for macos e2e_summary task * Claim ownership in TESTOWNERS * Add task runner for animated complex opacity without impeller * Register new target in .ci.yaml for non-impeller test * Claim ownership of non-impeller task Co-authored-by:
a-wallen <stephenwallen@google.com>
-
Alex Wallen authored
Co-authored-by:
Jenn Magder <magder@google.com> Co-authored-by:
a-wallen <stephenwallen@google.com>
-
- 17 Jan, 2023 2 commits
-
-
Ricardo Amador authored
* Testing whether emulator is possible. * Adding changes to see if emulator can be used from recipe. * adding emulator support. * Add the emulator flag for testing. * Using string for boolean since it cannot be parsed in properties * Checking to see if these changes are being used. * Updated bool back to string * Remove trailing whitespace from file.
-
Darren Austin authored
-