Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
70cecf6c
Unverified
Commit
70cecf6c
authored
Jan 21, 2023
by
Michael Goderbauer
Committed by
GitHub
Jan 21, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unnecessary null checks in dev/*_tests (#118844)
parent
25843bdb
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
6 additions
and
11 deletions
+6
-11
main_test.dart
...ests/android_semantics_testing/test_driver/main_test.dart
+1
-1
android_platform_view.dart
...tests/hybrid_android_views/lib/android_platform_view.dart
+1
-1
url_strategy_integration.dart
...s/web_e2e_tests/test_driver/url_strategy_integration.dart
+1
-1
actions.dart
dev/manual_tests/lib/actions.dart
+1
-4
density.dart
dev/manual_tests/lib/density.dart
+1
-3
raw_keyboard.dart
dev/manual_tests/lib/raw_keyboard.dart
+1
-1
No files found.
dev/integration_tests/android_semantics_testing/test_driver/main_test.dart
View file @
70cecf6c
...
...
@@ -20,7 +20,7 @@ const List<AndroidSemanticsAction> ignoredAccessibilityFocusActions = <AndroidSe
];
String
adbPath
(
)
{
final
String
androidHome
=
io
.
Platform
.
environment
[
'ANDROID_HOME'
]
??
io
.
Platform
.
environment
[
'ANDROID_SDK_ROOT'
]!
;
final
String
?
androidHome
=
io
.
Platform
.
environment
[
'ANDROID_HOME'
]
??
io
.
Platform
.
environment
[
'ANDROID_SDK_ROOT'
]
;
if
(
androidHome
==
null
)
{
return
'adb'
;
}
else
{
...
...
dev/integration_tests/hybrid_android_views/lib/android_platform_view.dart
View file @
70cecf6c
...
...
@@ -19,7 +19,7 @@ class AndroidPlatformView extends StatelessWidget {
this
.
onPlatformViewCreated
,
this
.
useHybridComposition
=
false
,
required
this
.
viewType
,
})
:
assert
(
viewType
!=
null
)
;
});
/// The unique identifier for the view type to be embedded by this widget.
///
...
...
dev/integration_tests/web_e2e_tests/test_driver/url_strategy_integration.dart
View file @
70cecf6c
...
...
@@ -99,7 +99,7 @@ class TestUrlStrategy extends UrlStrategy {
@override
void
replaceState
(
dynamic
state
,
String
title
,
String
url
)
{
assert
(
withinAppHistory
);
if
(
url
==
null
||
url
==
''
)
{
if
(
url
==
''
)
{
url
=
currentEntry
.
url
;
}
currentEntry
=
TestHistoryEntry
(
state
,
title
,
url
);
...
...
dev/manual_tests/lib/actions.dart
View file @
70cecf6c
...
...
@@ -48,8 +48,6 @@ class Memento extends Object with Diagnosticable {
void
debugFillProperties
(
DiagnosticPropertiesBuilder
properties
)
{
super
.
debugFillProperties
(
properties
);
properties
.
add
(
StringProperty
(
'name'
,
name
));
properties
.
add
(
FlagProperty
(
'undo'
,
value:
undo
!=
null
,
ifTrue:
'undo'
));
properties
.
add
(
FlagProperty
(
'redo'
,
value:
redo
!=
null
,
ifTrue:
'redo'
));
}
}
...
...
@@ -63,8 +61,7 @@ class UndoableActionDispatcher extends ActionDispatcher implements Listenable {
/// The [maxUndoLevels] argument must not be null.
UndoableActionDispatcher
({
int
maxUndoLevels
=
_defaultMaxUndoLevels
,
})
:
assert
(
maxUndoLevels
!=
null
),
_maxUndoLevels
=
maxUndoLevels
;
})
:
_maxUndoLevels
=
maxUndoLevels
;
// A stack of actions that have been performed. The most recent action
// performed is at the end of the list.
...
...
dev/manual_tests/lib/density.dart
View file @
70cecf6c
...
...
@@ -365,9 +365,7 @@ class _OptionsState extends State<Options> {
}
class
_ControlTile
extends
StatelessWidget
{
const
_ControlTile
({
required
this
.
label
,
required
this
.
child
})
:
assert
(
label
!=
null
),
assert
(
child
!=
null
);
const
_ControlTile
({
required
this
.
label
,
required
this
.
child
});
final
String
label
;
final
Widget
child
;
...
...
dev/manual_tests/lib/raw_keyboard.dart
View file @
70cecf6c
...
...
@@ -43,7 +43,7 @@ class _HardwareKeyDemoState extends State<RawKeyboardDemo> {
return
KeyEventResult
.
ignored
;
}
String
_asHex
(
int
value
)
=>
value
!=
null
?
'0x
${value.toRadixString(16)}
'
:
'null
'
;
String
_asHex
(
int
value
)
=>
'0x
${value.toRadixString(16)}
'
;
String
_getEnumName
(
dynamic
enumItem
)
{
final
String
name
=
'
$enumItem
'
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment