- 24 Jan, 2024 1 commit
-
-
Jesús S Guerrero authored
Revert "[web] - Fix broken `TextField` in semantics mode when it's a sibling of `Navigator`" (#142129) Reverts flutter/flutter#138446 b/322136071
-
- 22 Jan, 2024 1 commit
-
-
Hassan Toor authored
When a `TextField` is rendered before a `Navigator`, it breaks in semantics mode. This is because the framework generates the incorrect semantics tree (excludes the TextField) and when that tree gets sent to the engine, we don't get the signal to create the corresponding `<input>` element. This happens for a few reasons: * `ModalBarrier` uses `BlockSemantics` to drop the semantics of routes beneath the current route in `Navigator` * `ModalBarrier` mistakenly recognizes the widget outside of the `Navigator` to be its sibling * So we end up dropping the semantics node of the `TextField` rendered before it. The fix is to let `Navigator` generate a semantics node so that `ModalBarrier` doesn't mistakenly think widgets outside of `Navigator` are its siblings. `Navigator` doesn't currently do this, which causes all the nodes generated from its widget subtree to be directly attached to the parent semantics node above `Navigator` - since this is also the parent of `TextField`, it considers them siblings. Fixes https://github.com/flutter/flutter/issues/129324
-
- 20 Jan, 2024 1 commit
-
-
LongCatIsLooong authored
Remove more `textScaleFactor` references from flutter/flutter. - Some changes are related to label scaling: the padding EdgeInsets values of some chip subclasses scale linearly between predetermined "max" padding values and "min" padding values. Before they scale with the `textScaleFactor` scalar, now they scale with the font size and are still capped at the original "max" and "min" values. - The rest of them are tests or size heuristics that depend on `textScaleFactor`, these are replaced by an effective text scale factor computed using a default font size (which is determined in a pretty random fashion, but it will only make a difference on Android 14+). No API changes in this batch. There are still some references left that I intend to remove in a different batch that would introduce API changes.
-
- 03 Jan, 2024 1 commit
-
-
Jack Gibbons authored
Pass key into _BottomNavigationTile Adding a optional key parameter to BottomNavigationBarItem to be passed through to _BottomNavigationTile. This will allow easier testing in some scenarios, and fix the splash appearing on the wrong tile. https://github.com/flutter/flutter/issues/139615 https://github.com/flutter/flutter/issues/34833
-
- 15 Dec, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 14 Dec, 2023 1 commit
-
-
Shashi authored
This PR wraps the `label` with `IntrinsicWidth` and then `Flexible` which allows DefaulTextStyle `TextOverflow.ellipsis` to work. Wrapping `label` directly with `Flexible` brings more space between `icon` and `label`. `IntrinsicWidth` fixes this by giving reasonable width. Fixes #112163
-
- 04 Dec, 2023 1 commit
-
-
Bruno Leroux authored
This PR removes the call to `InkSparkle.constantTurbulenceSeedSplashFactory` which was introduced in https://github.com/flutter/flutter/pull/137998. This is now obsolete since https://github.com/flutter/flutter/pull/138757 was merged and InkSparkle randomness is no more active in tests.
-
- 20 Nov, 2023 1 commit
-
-
Bruno Leroux authored
This is a reland of https://github.com/flutter/flutter/pull/136624 which was reverted because one new M3 golden test failed. The failure was related to the ink sparkle animation. Ink sparkle is the M3 default animation, it does not play well with golden because it introduces an element of randomness. One way to avoid this randomness is to use the `InkSparkle.constantTurbulenceSeedSplashFactory`. This PR has two commits: - the first one is the original PR (https://github.com/flutter/flutter/pull/136624). - the second one updates the failing test using `InkSparkle.constantTurbulenceSeedSplashFactory`.
-
- 06 Nov, 2023 2 commits
-
-
auto-submit[bot] authored
Reverts flutter/flutter#136624 Initiated by: HansMuller This change reverts the following previous change: Original Description: This PR updates `BottomNavigationBar` unit tests for M3 migration. More info in https://github.com/flutter/flutter/issues/127064 It was somewhat complex because existing tests relied on a lot of magic numbers.
-
Bruno Leroux authored
This PR updates `BottomNavigationBar` unit tests for M3 migration. More info in https://github.com/flutter/flutter/issues/127064 It was somewhat complex because existing tests relied on a lot of magic numbers.
-
- 14 Aug, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 07 Aug, 2023 1 commit
-
-
Kate Lovett authored
Fixes https://github.com/flutter/flutter/issues/59413 This relocates `mock_canvas.dart` and `recording_canvas.dart` from `flutter/test/rendering` to `flutter_test`. The testing functionality afforded by mock_canvas should be available to everyone, not just the framework. :) mock_canvas.dart needed a bit of cleanup - things like formatting and super parameters.
-
- 22 Jul, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 13 Jun, 2023 1 commit
-
-
Qun Cheng authored
Updates most of the unit tests in the packages/flutter/test/material folder so that they'll pass if ThemeData.useMaterial3 defaults to true. All of the tests have wired useMaterial3 to false and will need to be updated with a M3 version. related to #127064
-
- 20 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 21 Dec, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 17 Oct, 2022 1 commit
-
-
luckysmg authored
-
- 27 Sep, 2022 1 commit
-
-
Jonah Williams authored
-
- 20 Sep, 2022 1 commit
-
-
Zlati Pehlivanov authored
-
- 21 Jul, 2022 1 commit
-
-
Bruno Leroux authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `material` * include test/material * add back removed comments
-
- 20 May, 2022 1 commit
-
-
Tong Mu authored
-
- 28 Apr, 2022 1 commit
-
-
Kate Lovett authored
-
- 27 Apr, 2022 1 commit
-
-
Taha Tesser authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 21 Jan, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 15 Nov, 2021 1 commit
-
-
Kate Lovett authored
-
- 16 Oct, 2021 1 commit
-
-
Kate Lovett authored
-
- 14 Oct, 2021 1 commit
-
-
Kate Lovett authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 30 Aug, 2021 1 commit
-
-
Kate Lovett authored
-
- 29 Jul, 2021 1 commit
-
-
Hans Muller authored
-
- 15 Jul, 2021 1 commit
-
- 14 Jul, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 31de052e.
-
Ian Hickson authored
-
- 13 Jul, 2021 2 commits
-
-
Ian Hickson authored
This reverts commit e2490f29.
-
Ian Hickson authored
-