1. 17 Oct, 2016 6 commits
    • Adam Barth's avatar
      Improve error message for createState type errors (#6339) · 1d6fa089
      Adam Barth authored
      Fixes #6209
      1d6fa089
    • Adam Barth's avatar
      Add custom clipping to ClipRRect (#6346) · 8b16c025
      Adam Barth authored
      Fixes #773
      8b16c025
    • Phil Quitslund's avatar
      Bump to Dart SDK `1.20.1` stable (#6357) · 32037579
      Phil Quitslund authored
      32037579
    • Adam Barth's avatar
      Tap above LongPressDraggable should work (#6348) · 61240fe8
      Adam Barth authored
      Previously, we were nulling out the ArenaEntry in MultiDragPointerState
      too early, which was prevent MultiDragPointerState from rejecting the
      gesture in `dispose` if we hadn't accepted by the time the pointer went
      up. Now we properly reject the gesture, which causes the tap gesture to
      win during `sweep` in the arena.
      
      Also, add a bunch of docs and annotations based on information I learned
      while studying this issue. Finally, rename a private member of tap
      recognizer to a name that would have confused me less in my
      investigation.
      
      Fixes #1186
      61240fe8
    • Adam Barth's avatar
      Fix DropdownButton regression (#6353) · 6399a3af
      Adam Barth authored
      When I changed how routes complete their futures, I broke the Dropdown
      button because it was still waiting for its own Completer to complete
      instead of using the Future returned by push. This patch fixes that
      issue.
      
      I've also removed the previous behavior of the DropdownButton forwarding
      its text style to its route. The mechansim that we were using doesn't
      work properly in all cases. For example, if the DropdownButton is a
      child of a LayoutBuilder, then the route will have already built by the
      time the DropdownButton gets a chance to forward its text style, causing
      an assert in setState.
      
      Finally, I've tweaked PopupMenuButton to work the same way as
      DropdownButton in a couple corner cases (e.g., not calling the changed
      callback if the button was removed from the tree before the menu
      completed its Future).
      
      Fixes #6352
      6399a3af
    • Adam Barth's avatar
      Fix typo in TableRow.toString (#6354) · e81e06a6
      Adam Barth authored
      Fixes #6351
      e81e06a6
  2. 16 Oct, 2016 3 commits
  3. 15 Oct, 2016 5 commits
  4. 14 Oct, 2016 11 commits
  5. 13 Oct, 2016 14 commits
  6. 12 Oct, 2016 1 commit
    • Chris Bracken's avatar
      Improve doctor reporting for iOS toolchain (#6289) · 38840776
      Chris Bracken authored
      Previously, overall status was reported as good if Xcode and homebrew
      were installed, even if there were issues with either of the tools. We
      now report partial status if we detect issues with either installation.
      38840776