Commits · 1c90ed8b64d9ed8ce2431afad8bc6e6d9acc4556 · abdullh.alsoleman / Front-End

25 Oct, 2023 17 commits

Fix structure of pkg:integration_test (#137283) · 1c90ed8b

Michael Goderbauer authored Oct 25, 2023

The private _ libraries should not be advertised as importable. Moving them to the src directory.

I noticed this while browsing our dart docs. This should remove the underscore entries.

![image](https://github.com/flutter/flutter/assets/1227763/41511efe-4eb8-487a-9758-ccde1720e05a)

Replaces https://github.com/flutter/flutter/pull/137197.

1c90ed8b

Ensure Xcode project is setup to start debugger (#136977) · 5dd2a4e0

Victoria Ashworth authored Oct 25, 2023

Some users have their Xcode settings set to not debug (see example here https://github.com/flutter/flutter/issues/136197#issuecomment-1766834195). This will cause the [engine check for a debugger](https://github.com/flutter/engine/blob/22ce5c6a45e2898b4ce348c514b5fa42ca25bc88/runtime/ptrace_check.cc#L56-L71) to fail, which will cause an error and cause the app to crash.

This PR parses the scheme file to ensure the scheme is set to start a debugger and warn the user if it's not.

Fixes https://github.com/flutter/flutter/issues/136197.

5dd2a4e0

Marks Windows build_tests_6_6 to be unflaky (#137216) · 9366170e

Flutter GitHub Bot authored Oct 25, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_6_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_6_6%22).
This test can be marked as unflaky.

9366170e

Remove gem and docker files. (#137200) · c391315c

godofredoc authored Oct 25, 2023

Gem files were used to install cocoapods which now is being provisioned as part of the ruby cipd package.

This is also deleting the docker file used for Cirrus testing.

Bug: https://github.com/flutter/flutter/issues/136377

c391315c

Reverts "[gallery] Reland roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda" (#137264) · bfc4c502

auto-submit[bot] authored Oct 25, 2023

Reverts flutter/flutter#137199
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Reverts flutter/flutter#133095

Dependencies have been fixed, hopefully : https://github.com/flutter/flutter/issues/133096#event-10761117209

bfc4c502

[gallery] Reland roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda (#137199) · aaf7184a

Jonah Williams authored Oct 25, 2023

Reverts flutter/flutter#133095

Dependencies have been fixed, hopefully : https://github.com/flutter/flutter/issues/133096#event-10761117209

aaf7184a

Roll Packages from 2faf992a0589 to f751ffb7d3cf (11 revisions) (#137254) · de93f026

engine-flutter-autoroll authored Oct 25, 2023

https://github.com/flutter/packages/compare/2faf992a0589...f751ffb7d3cf

2023-10-25 stuartmorgan@google.com [ci] Enable legacy Android emulator tests (flutter/packages#5190)
2023-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.0 to 2.3.1 (flutter/packages#5209)
2023-10-25 godofredoc@google.com Replace gems dependency with ruby. (flutter/packages#5219)
2023-10-25 godofredoc@google.com Update the ftl hardware version. (flutter/packages#5224)
2023-10-25 737941+loic-sharma@users.noreply.github.com [ci] Disable Windows Arm64 stable CI (flutter/packages#5217)
2023-10-24 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Only set `limitsNavigationsToAppBoundDomains` when it is set to true (flutter/packages#5137)
2023-10-24 stuartmorgan@google.com [url_launcher] Add an `inAppBrowserView` mode (flutter/packages#5155)
2023-10-24 43054281+camsim99@users.noreply.github.com [Android] Introduces API 34 emulators for subset of tests (flutter/packages#5105)
2023-10-24 stuartmorgan@google.com [url_launcher] Add an `inAppBrowserView` mode in implementations (flutter/packages#5211)
2023-10-24 stuartmorgan@google.com [ci] Fix legacy Android task names (flutter/packages#5191)
2023-10-24 reidbaker@google.com Update annotations deps to 1.7 (flutter/packages#4935)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

de93f026

Marks Windows build_tests_3_6 to be unflaky (#137214) · cd2c08ee

Flutter GitHub Bot authored Oct 25, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_3_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_3_6%22).
This test can be marked as unflaky.

cd2c08ee

Marks Windows build_tests_5_6 to be unflaky (#137215) · 7db948cf

Flutter GitHub Bot authored Oct 25, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_5_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_5_6%22).
This test can be marked as unflaky.

7db948cf

Marks Windows build_tests_2_6 to be unflaky (#137213) · 1001a0a3

Flutter GitHub Bot authored Oct 25, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_2_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_2_6%22).
This test can be marked as unflaky.

1001a0a3

Revert "Update `OutlinedButton` tests for Material 3 (#136809)" (#137242) · d0fe9f20

Taha Tesser authored Oct 25, 2023

This reverts commit d36a8433
(https://github.com/flutter/flutter/pull/136809)

This fails even tho golden files were approved and `golden test` pending
was cleared and green and `autosubmit` successfully merged the PR.


```console
02:42 +4618 ~5: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/outlined_button_test.dart: Material3 - OutlinedButton, OutlinedButton.icon defaults
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following SkiaException was thrown while running async test code:
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/flutter are triaged
in pre-submit during code review for the given PR.

Visit https://flutter-gold.skia.org/ to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter

Debug information for Gold --------------------------------
stdout: Given image with hash 37275e74c51f98d7abd7f301c5c94ac1 for test
material.outlined_button.ink_sparkle.default
Expectation for test: 531f5fa74908d2e6db2b8fd86a6b8662 (positive)
Expectation for test: 683e368ff51d947a3d63c2a5f4568cf6 (positive)
Expectation for test: 749241ff0fa21595b2c6cb551fd40b68 (positive)
Expectation for test: aaf9ac1328614d6c9f4540308bc86f62 (positive)
Expectation for test: b31a50440c7dd31b10cacd9e7b5c6b86 (positive)
Expectation for test: c0a7c8c625b69ddc695a770f28abd403 (positive)
Expectation for test: f1f66ce931c2ef33ebcb699a637025a6 (positive)
Expectation for test: 2d32e34efc1d7ca4cd12965402fb76ff (positive)
Untriaged or negative image:
https://flutter-gold.skia.org/detail?grouping=name%3Dmaterial.outlined_button.ink_sparkle.default%26source_type%3Dflutter&digest=37275e74c51f98d7abd7f301c5c94ac1


stderr: Test: material.outlined_button.ink_sparkle.default FAIL


result-state.json: No result file found.

When the exception was thrown, this was the stack:
#0      SkiaGoldClient.imgtestAdd (package:flutter_goldens_client/skia_client.dart:243:7)
<asynchronous suspension>
#1      MatchesGoldenFile.matchAsync.<anonymous closure> (package:flutter_test/src/_matchers_io.dart:118:32)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from dart:async)

The exception was caught asynchronously.
════════════════════════════════════════════════════════════════════════════════════════════════════
02:42 +4618 ~5 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_anchor_test.dart: Menu functions keyboard directional traversal works
02:42 +4618 ~5 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/outlined_button_test.dart: Material3 - OutlinedButton, OutlinedButton.icon defaults [E]
  Test failed. See exception logs above.
  The test description was: Material3 - OutlinedButton, OutlinedButton.icon defaults
  
02:42 +4619 ~5 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_anchor_test.dart: Menu functions keyboard directional traversal works
```

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

d0fe9f20

Update `OutlinedButton` tests for Material 3 (#136809) · d36a8433

Taha Tesser authored Oct 25, 2023

Updated unit tests for `CircleOutlinedButton` to have M2 and M3 versions.

More info in #127064

This also gets rid of unnecessary `fromSwatch` usage (part of https://github.com/flutter/flutter/issues/132584 documentation and test cleanup)

d36a8433

Let `OverflowBox` be shrink-wrappable (#129095) · 6df6c897

fzyzcjy authored Oct 25, 2023

Close https://github.com/flutter/flutter/issues/129094

I have demonstrated how this PR fixes the problem using tests in #129094. I will further add tests in this PR if the PR looks roughly acceptable :)

6df6c897

Add dependency on leak_tracker to flutter_test. (#137069) · dcbb2de0

Polina Cherkasova authored Oct 25, 2023

Contributes to: https://github.com/flutter/flutter/issues/135856

This PR also adds transitive dependency on web_socket_channel, crypto, typed_data. `web_socket_channel` is needed to request retaining path for not GCed objects from VM Service. Two others are needed to serve web_socket_channel.

The dependency on leak_tracker is pinned:
https://github.com/flutter/flutter/blob/aea562114c4d8c220c9079e82d89a7da4164409f/packages/flutter_tools/lib/src/commands/update_packages.dart#L40

dcbb2de0

fix SliverReorderableLists item wrong offset (#136828) · 25c5bf06

yim authored Oct 25, 2023

This PR fixes the issue of items being created at the wrong position during dragging.

Fixes #135819

25c5bf06

Remove `bringup: true` from realm_checker and remove the redundant tool test. (#137186) · 4afdfca2
Jackson Gardner authored Oct 25, 2023
```
Now that the realm checker is no longer in bringup, we can remove the tool test that checks for the empty realm file.
```
4afdfca2
Revert "Fix Gradle lockfiles." (#137198) · ebc67643
Qun Cheng authored Oct 25, 2023
```
Reverts flutter/flutter#137190
```
ebc67643

24 Oct, 2023 23 commits

Fix Gradle lockfiles. (#137190) · ccbe221b
Polina Cherkasova authored Oct 24, 2023

ccbe221b
Fix Typos (#137173) · ad448db6
Tirth authored Oct 24, 2023
```
Fix Small Typos.
```
ad448db6

Roll Flutter Engine from d6a48e9963df to 6e09ee14e244 (1 revision) (#137185) · 996dcf93

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/d6a48e9963df...6e09ee14e244

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from f78663386a10 to bc90585b0dd4 (4 revisions) (flutter/engine#47275)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

996dcf93

Roll Flutter Engine from 602b5131ee4d to d6a48e9963df (6 revisions) (#137180) · 6f6c8369

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/602b5131ee4d...d6a48e9963df

2023-10-24 jonahwilliams@google.com [Impeller] Allocate exact descriptor count, populate in one go. (flutter/engine#47200)
2023-10-24 47866232+chunhtai@users.noreply.github.com [Impeller] Curve components in stroke path use start directions as their initial offsets (flutter/engine#46203)
2023-10-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from OUWiWfUxyMyDOlEfA... to YqSO1OByhoexFJSCr... (flutter/engine#47273)
2023-10-24 matanlurey@users.noreply.github.com [Impeller] Enable MSAA for OpenGLES: Take 2. (flutter/engine#47030)
2023-10-24 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 901e92d10627 to 360370ff93b0 (3 revisions) (flutter/engine#47271)
2023-10-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 901e92d10627 to 360370ff93b0 (3 revisions) (flutter/engine#47269)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from OUWiWfUxyMyD to YqSO1OByhoex

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6f6c8369

TextField - allow to customize cursor color in error state (#136121) · 7cd6fd43

lirantzairi authored Oct 24, 2023

The color of the TextField's cursor in error state is the same as the error text color by default. However we should be allowed to customize it

Fixes #135580

7cd6fd43

[macOS] Refactor macOS build/codesize analysis (#137164) · c15ff682

Chris Bracken authored Oct 24, 2023

Extracts out _shouldWriteCodeSizeAnalysis and _writeCodeSizeAnalysis from the main buildMacOS function.

No tets changes sine this is a simple restructuring for readability and does not change any tool logic.

c15ff682

Roll Flutter Engine from dc00de7dacf4 to 602b5131ee4d (1 revision) (#137174) · 8f6c1e35

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/dc00de7dacf4...602b5131ee4d

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 43ba2a70f6a6 to f78663386a10 (3 revisions) (flutter/engine#47268)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8f6c1e35

Check the realm file in its own shard. (#137160) · cdd1ae99

Jackson Gardner authored Oct 24, 2023

This way, it is easier to differentiate between a real failure in the tools tests vs. just the realm check that blocks the merge.

cdd1ae99

Roll Flutter Engine from 1890bd7dc412 to dc00de7dacf4 (1 revision) (#137172) · f98b557e

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/1890bd7dc412...dc00de7dacf4

2023-10-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 7Cq6zmNZ_1UTJoQUE... to tqukMrdJ6j-845-57... (flutter/engine#47266)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 7Cq6zmNZ_1UT to tqukMrdJ6j-8

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f98b557e

Roll Flutter Engine from ca7ef01c99c6 to 1890bd7dc412 (2 revisions) (#137158) · ac83d58f

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/ca7ef01c99c6...1890bd7dc412

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 4f9a1a464eb1 to 43ba2a70f6a6 (3 revisions) (flutter/engine#47263)
2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 86df55671e1d to 4f9a1a464eb1 (1 revision) (flutter/engine#47262)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ac83d58f

Migrate mac builds to ruby dep. (#136929) · 69d0ca60

godofredoc authored Oct 24, 2023

The ruby dependency has been automated to include cocoapods.

Bug: https://github.com/flutter/flutter/issues/136377

69d0ca60

Roll Packages from 4bf51144c295 to 2faf992a0589 (7 revisions) (#137154) · 88643f90

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/packages/compare/4bf51144c295...2faf992a0589

2023-10-23 34871572+gmackall@users.noreply.github.com Change firebase device tests from Android api 30 to 33 (flutter/packages#5185)
2023-10-23 stuartmorgan@google.com [url_launcher] Add an `inAppBrowserView` mode (flutter/packages#5205)
2023-10-23 737941+loic-sharma@users.noreply.github.com [ci] Remove device_type property from Windows Arm64 properties (flutter/packages#5193)
2023-10-23 ditman@gmail.com [url_launcher_web] Disallows launching "javascript:" URLs. (flutter/packages#5180)
2023-10-23 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.6.0 to 1.6.1 in /packages/local_auth/local_auth_android/android (flutter/packages#4600)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter from 823e0835 to 5e8b5f4e (13 revisions) (flutter/packages#5208)
2023-10-23 stuartmorgan@google.com [tool] Add optional swift-format support (flutter/packages#5204)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88643f90

Roll Flutter Engine from 7224835bb65f to ca7ef01c99c6 (1 revision) (#137153) · 664915f3

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/7224835bb65f...ca7ef01c99c6

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from fb6e09449f71 to 86df55671e1d (1 revision) (flutter/engine#47261)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

664915f3

fix some typos (#137144) · c5e71b3e

cui fliter authored Oct 24, 2023

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

fix some typos

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

c5e71b3e

Roll Flutter Engine from 8f7488e0b4b5 to 7224835bb65f (1 revision) (#137150) · 4dd48905

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/8f7488e0b4b5...7224835bb65f

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 70978e42479c to fb6e09449f71 (1 revision) (flutter/engine#47260)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4dd48905

Roll Flutter Engine from d58895093d0a to 8f7488e0b4b5 (3 revisions) (#137135) · 5effaf34

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/d58895093d0a...8f7488e0b4b5

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from b3923b715c50 to 70978e42479c (1 revision) (flutter/engine#47257)
2023-10-24 chinmaygarde@google.com Update fml::ThreadPriority enum to match style guide. (flutter/engine#47255)
2023-10-24 jonahwilliams@google.com [Impeller] Adjustments to SubmitKHR and queries. (flutter/engine#47249)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5effaf34

Roll Flutter Engine from 2a8471f188cd to d58895093d0a (4 revisions) (#137130) · e6bf3ffc

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/2a8471f188cd...d58895093d0a

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 82f665328e96 to b3923b715c50 (1 revision) (flutter/engine#47256)
2023-10-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from a3CcHQHJIAEr-O2R0... to OUWiWfUxyMyDOlEfA... (flutter/engine#47254)
2023-10-24 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.0 to 2.3.1 (flutter/engine#47252)
2023-10-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.0 to 4.1.1 (flutter/engine#47253)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from a3CcHQHJIAEr to OUWiWfUxyMyD

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e6bf3ffc

Roll Flutter Engine from 71600d89aa3f to 2a8471f188cd (2 revisions) (#137129) · dc78bf66

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/71600d89aa3f...2a8471f188cd

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 8632561c828a to 82f665328e96 (1 revision) (flutter/engine#47251)
2023-10-24 chinmaygarde@google.com [Impeller] Update shader pipeline image with a chart. (flutter/engine#47250)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dc78bf66

Roll Flutter Engine from 3dd197dcf9e5 to 71600d89aa3f (1 revision) (#137127) · 6e02e40a

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/3dd197dcf9e5...71600d89aa3f

2023-10-24 chinmaygarde@google.com [Impeller] Rename blobcat to shader_archive(r). (flutter/engine#47247)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6e02e40a

Roll Flutter Engine from bdbd1058858b to 3dd197dcf9e5 (2 revisions) (#137125) · 62b6414c

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/bdbd1058858b...3dd197dcf9e5

2023-10-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uW96BsI9g7PF2on-4... to 7Cq6zmNZ_1UTJoQUE... (flutter/engine#47245)
2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 6711d27055e8 to 8632561c828a (1 revision) (flutter/engine#47246)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uW96BsI9g7PF to 7Cq6zmNZ_1UT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

62b6414c

Roll Flutter Engine from 0ef5caa91c40 to bdbd1058858b (1 revision) (#137119) · e4eecba7

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/0ef5caa91c40...bdbd1058858b

2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from fd557c42e44c to 6711d27055e8 (1 revision) (flutter/engine#47244)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e4eecba7

Reverts "Use `coverage.collect`'s `coverableLineCache` param to speed up coverage" (#137121) · 8df62188

auto-submit[bot] authored Oct 24, 2023

Reverts flutter/flutter#136851
Initiated by: CaseyHillers
This change reverts the following previous change:
Original Description:
One of the reasons gathering coverage information is expensive is that we have to force compile every function in the libraries we're interested in. Without this, functions that haven't been invoked (so haven't been compiled) won't have any line number information, so the coverage tool doesn't know which lines to add to the list of misses. In flutter's case, the test infra spawns many VMs, and each of these needs to recompile all those libraries.

To fix this, we need a way of skipping force compilation for libraries we've already seen in previous tests, without losing the information about which lines in each library are coverable. So I [added](https://github.com/dart-lang/coverage/pull/466) the `coverableLineCache` to `coverage.collect` in package:coverage v1.7.0. This cache starts out empty, but fills up with lists of all the lines that are coverable for every library as coverage is gathered. package:coverage can then tell the VM not to force compile any libraries in this cache (using `getSourceReport`'s `librariesAlreadyCompiled` param). So the first test suite will still have to compile everything, but subsequent test suites will be much faster.

This speeds up coverage collection significantly, for large test suites:

| Running flutter/packages/flutter tests... | Time | Overhead |
| --- | --- | --- |
| without coverage | 8:53 | - |
| with coverage | 20:25 | 130% |
| with `coverableLineCache` | 12:21 | 40% |

Bug: https://github.com/flutter/flutter/issues/100751

8df62188

Roll Flutter Engine from dd6a6531e816 to 0ef5caa91c40 (1 revision) (#137114) · d1884e7b

engine-flutter-autoroll authored Oct 24, 2023

https://github.com/flutter/engine/compare/dd6a6531e816...0ef5caa91c40

2023-10-23 dkwingsmt@users.noreply.github.com Reland 2: Multiview Pipeline (flutter/engine#47239)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d1884e7b