1. 26 Feb, 2024 1 commit
    • Nate's avatar
      Implementing `switch` expressions in `rendering/` (#143812) · 60d28ad9
      Nate authored
      This pull request is part of the effort to solve issue #136139.
      
      The previous [`switch` expressions PR](https://github.com/flutter/flutter/pull/143496) was comprised of many simple changes throughout `flutter/lib/src/`, but due to some more in-depth refactoring in `flutter/lib/src/rendering/`, I decided to submit the changes to this directory as a separate pull request.
      
      There was really just one function that I changed significantly; I'll add a comment for explanation.
      60d28ad9
  2. 20 Jun, 2023 1 commit
    • Tae Hyung Kim's avatar
      DecoratedSliver (#127823) · 541fdd60
      Tae Hyung Kim authored
      This is a second attempt to merge #107269. Currently I've fixed two of the issues:
      1. Fixed horizontal scrollview by using a switch statement to consider vertical/horizontal case.
      2. Fixed issue of `paintExtent` not being the right extent for painting. Rather using a `scrollExtent` for the main axis length of the decoration box and painting it offsetted by the `scrollOffset`.
      3. If the sliver child has inifinite scrollExtent, then we only draw the decoration down to the bottom of the `cacheExtent`. The developer is expected to ensure that the border does not creep up above the cache area.
      
      This PR includes a test that checks that the correct rectangle is drawn at a certain scrollOffset for both the horizontal and vertical case which should be sufficient for checking that `SliverDecoration` works properly now.
      
      Fixes https://github.com/flutter/flutter/issues/107498.
      541fdd60